| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
render :html escapes the argument if not provided as html safe.
|
| |
|
| |
|
| |
|
|
|
|
| |
Lacks some proper creds to the homies who went the... distance ;)
|
| |
|
|
|
|
|
|
|
|
| |
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
|
|
|
|
| |
Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| |
|
| |
|
|
|
| |
The main goal is to improve readability, but as a side effect this commit makes the method a bit faster.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some translations of rails guides has their own documents.yaml, for example
Japanese:
https://github.com/yasslab/railsguides.jp/blob/japanese/guides/source/documents.yaml
Traditional Chinese:
https://github.com/docrails-tw/guides/blob/master/rails_guides/helpers.rb#L21,L27
https://github.com/docrails-tw/guides/blob/master/source/documents_zh-TW.yaml
The [Translating Rails Guides](https://github.com/rails/docrails/wiki/translating-rails-guides) says
> Copy the contents of guides/source into your own language directory and translate them.
So that sounds ok to copy guides/source/documents.yaml into language
specific directly and translating them like other markdown files.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calculating -------------------------------------
each_char 924.000 i/100ms
each_codepoint 1.381k i/100ms
-------------------------------------------------
each_char 9.320k (¡Þ 5.1%) i/s - 47.124k
each_codepoint 13.857k (¡Þ 3.6%) i/s - 70.431k
Comparison:
each_codepoint: 13857.4 i/s
each_char: 9319.5 i/s - 1.49x slower
The full report can be found here:
https://gist.github.com/yuki24/a80988f35aceac76f1d5
|
| |
|
|
|
|
| |
Bug was discovered and discussed in #18395.
|
|
|
|
| |
- Changed `IN` to `ON` in all note sentences in guides.
|
|
|
|
|
|
| |
To highlight ERB snippets, both `erb` and `html+erb` are used as a
language passed to the code block. However, only the former will be
correctly highlighted.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This could use in any translation because it's not limited to `[^a-z0-9]`.
Verify after this change, all guides still have same anchors.
[Robin Dupret & Juanito Fatas]
|
|
|
|
|
|
| |
This reverts commit 699babe.
Also change the upgrading_ruby_on_rails link back to original in 4_2_release_notes.
|
|
|
|
| |
[skip ci]
|
| |
|
| |
|
|
|
|
|
|
|
| |
This version fixes an API breakage between 3.0 and 3.1 ; the header
method's arity should not have changed.
[ci skip]
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resolve the following error when running `bundle exec rake guides:generate:html`:
```
/Users/senny/.rbenv/versions/2.0.0-p353/bin/ruby rails_guides.rb
Generating 2_2_release_notes.md as 2_2_release_notes.html
/Users/senny/Projects/rails/guides/rails_guides/helpers.rb:17:in `documents_by_section': uninitialized constant RailsGuides::Helpers::YAML (ActionView::Template::Error)
from /Users/senny/Projects/rails/guides/rails_guides/helpers.rb:32:in `docs_for_menu'
from /Users/senny/Projects/rails/guides/source/layout.html.erb:56:in `block in ___sers_senny__rojects_rails_guides_source_layout_html_erb___3094858039481335962_70118647133480'
from /Users/senny/Projects/rails/guides/source/layout.html.erb:54:in `each'
from /Users/senny/Projects/rails/guides/source/layout.html.erb:54:in `___sers_senny__rojects_rails_guides_source_layout_html_erb___3094858039481335962_70118647133480'
from /Users/senny/Projects/rails/actionview/lib/action_view/template.rb:143:in `block in render'
from /Users/senny/Projects/rails/activesupport/lib/active_support/notifications.rb:161:in `instrument'
from /Users/senny/Projects/rails/actionview/lib/action_view/template.rb:337:in `instrument'
from /Users/senny/Projects/rails/actionview/lib/action_view/template.rb:141:in `render'
from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/template_renderer.rb:61:in `render_with_layout'
from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/template_renderer.rb:47:in `render_template'
from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/template_renderer.rb:17:in `render'
from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/renderer.rb:42:in `render_template'
from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/renderer.rb:23:in `render'
from /Users/senny/Projects/rails/actionview/lib/action_view/helpers/rendering_helper.rb:24:in `render'
from /Users/senny/Projects/rails/guides/rails_guides/markdown.rb:160:in `render_page'
from /Users/senny/Projects/rails/guides/rails_guides/markdown.rb:25:in `render'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:205:in `block in generate_guide'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:195:in `open'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:195:in `generate_guide'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:144:in `block in generate_guides'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:142:in `each'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:142:in `generate_guides'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:97:in `generate'
from rails_guides.rb:63:in `<main>'
rake aborted!
Command failed with status (1): [/Users/senny/.rbenv/versions/2.0.0-p353/bi...]
/Users/senny/Projects/rails/guides/Rakefile:11:in `block (3 levels) in <top (required)>'
Tasks: TOP => guides:generate:html
(See full trace by running task with --trace)
```
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Kindle ebook generation with working section navigation
|
| | |
|
|/
|
|
|
|
|
|
|
|
| |
Shelling out was there for authors convenience, but we are
rather going to have the tag or SHA1 always in RAILS_VERSION
and if the environment variable is blank, then just use
"local" as a reminder that you are just working locally.
The docs server has been updated to set the long SHA1 in
RAILS_VERSION when generating edge guides.
|
|
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit abf8de85519141496a6773310964ec03f6106f3f.
We should take a deeper look to those cases flat_map doesn't do deep
flattening.
irb(main):002:0> [[[1,3], [1,2]]].map{|i| i}.flatten
=> [1, 3, 1, 2]
irb(main):003:0> [[[1,3], [1,2]]].flat_map{|i| i}
=> [[1, 3], [1, 2]]
|
| |
|
| |
|