aboutsummaryrefslogtreecommitdiffstats
path: root/guides/bug_report_templates
Commit message (Collapse)AuthorAgeFilesLines
* Deprecate secret_token, long since usurped by secret_key_base.Kasper Timm Hansen2017-09-282-2/+0
| | | | | | | | | | See the changelog entry. Remove `secrets.secret_token` from the bug report templates, since we don't accept bug reports for Rails versions that don't support a `secret_key_base`. [ claudiob & Kasper Timm Hansen ]
* Add newlines before/after the `git_source` in bug report templatesRyuta Kamizono2017-09-2711-0/+22
| | | | [ci skip]
* Change :github git source for bug report templatesbogdanvlviv2017-09-2711-0/+11
| | | | | | | :github source uses `git://` url by default, `https://` is recommended. See http://bundler.io/v1.15/guides/git.html#security We do the same in our `Gemfile` and templates.
* Use frozen string literal in guides/Koichi ITO2017-08-1311-0/+22
|
* Require arel master in the benchmark templateSean Griffin2017-07-251-0/+1
| | | | Pointing at Rails master generally requires pointing at Arel master
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-0211-11/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-0111-0/+11
|
* Do not use private API in bug report templatesyuuji.yaginuma2017-06-222-8/+4
| | | | | | | | `ActiveRecord::Migrator` is private API. https://github.com/rails/rails/blob/bb9d6eb094f29bb94ef1f26aa44f145f17b973fe/activerecord/lib/active_record/migration.rb#L977 Therefore, it is not good to use it in bug report templates. Instead, should use the public API `ActiveRecord::Migration#migrate`.
* Define path with __dir__bogdanvlviv2017-05-232-2/+2
| | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f
* Update the Gem Bug Report Templates to 5.1.0Alex Kitchens2017-05-015-5/+5
| | | | 5.1.0 has been released, and the gem templates can reflect that now.
* Update bug report templatesMatthew Draper2017-03-225-5/+5
|
* Start Rails 5.2 developmentMatthew Draper2017-03-225-0/+5
|
* Use released arelyuuji.yaginuma2017-02-261-1/+0
| | | | Follow up to ea9566f6cd1b4d3f0d8a5f03283b49423b89044d
* Use released arelRafael Mendonça França2017-02-215-5/+0
|
* Bump bug report template versions to 5.0.1Daniel Martin2017-01-265-5/+5
|
* Remove deprecated support to passing a column to #quoteRafael Mendonça França2016-12-296-0/+6
|
* Add more rubocop rules about whitespacesRafael Mendonça França2016-10-293-4/+4
|
* Introduce a benchmark template [ci skip]Godfrey Chan2016-10-151-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This replaces boilerplate in the “benchmark your code” section of the contributors’ guide with an executable template. I also amended the text to encourage best practices and codified it in the template. For now this is only good for relatively self-contained changes that can be inlined into a simple script. In the future, this can be expanded to cover how to measure the difference between two commits. The output looks like this: ``` ==================================== Empty ===================================== Warming up -------------------------------------- blank? 225.963k i/100ms fast_blank? 238.147k i/100ms Calculating ------------------------------------- blank? 8.825M (± 6.4%) i/s - 44.063M in 5.014824s fast_blank? 9.311M (± 6.3%) i/s - 46.439M in 5.009153s Comparison: fast_blank?: 9310694.8 i/s blank?: 8824801.7 i/s - same-ish: difference falls within error ================================= Single Space ================================= Warming up -------------------------------------- blank? 56.581k i/100ms fast_blank? 232.774k i/100ms Calculating ------------------------------------- blank? 813.985k (±16.7%) i/s - 4.017M in 5.076576s fast_blank? 9.547M (± 5.2%) i/s - 47.719M in 5.013204s Comparison: fast_blank?: 9547414.0 i/s blank?: 813985.0 i/s - 11.73x slower ================================== Two Spaces ================================== Warming up -------------------------------------- blank? 58.265k i/100ms fast_blank? 244.056k i/100ms Calculating ------------------------------------- blank? 823.343k (±16.2%) i/s - 4.020M in 5.014213s fast_blank? 9.484M (± 4.9%) i/s - 47.347M in 5.005339s Comparison: fast_blank?: 9484021.6 i/s blank?: 823343.1 i/s - 11.52x slower =============================== Mixed Whitspaces =============================== Warming up -------------------------------------- blank? 53.919k i/100ms fast_blank? 237.103k i/100ms Calculating ------------------------------------- blank? 763.435k (±16.8%) i/s - 3.720M in 5.018029s fast_blank? 9.672M (± 5.8%) i/s - 48.369M in 5.019356s Comparison: fast_blank?: 9672467.2 i/s blank?: 763435.4 i/s - 12.67x slower =============================== Very Long String =============================== Warming up -------------------------------------- blank? 34.037k i/100ms fast_blank? 240.366k i/100ms Calculating ------------------------------------- blank? 409.731k (± 8.9%) i/s - 2.042M in 5.028235s fast_blank? 9.794M (± 4.3%) i/s - 49.035M in 5.016328s Comparison: fast_blank?: 9794225.2 i/s blank?: 409731.4 i/s - 23.90x slower ```
* bug report template for migrations (#26488)Girish Sonawane2016-09-152-0/+129
| | | * added bug report template for migrations
* fix class name typoyuuji.yaginuma2016-09-022-4/+4
|
* Added bug report templates for Active JobPrathamesh Sonpatki2016-09-022-0/+63
|
* remove unnessary `session_store` settingyuuji.yaginuma2016-08-201-1/+0
| | | | | Since e5a6f7ee9e951dbe0e4e9ea2c0743b4dfb135c57, by default the session store will be set to cookie store with application name as session key.
* applies new string literal convention in guidesXavier Noria2016-08-066-57/+57
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Bump version for master bug report templatesJon Moss2016-07-053-3/+3
|
* Update Ruby report templatesRafael Mendonça França2016-05-103-3/+3
|
* Remove extra space [ci skip]Jon Moss2016-05-051-2/+2
|
* Remove github gems from the master bug report templatesRafael Mendonça França2016-02-183-15/+0
| | | | | All gems are released now so we don't need to ask the github repository for these gems anymore.
* remove backward compatibility code for Minitest 4yuuji.yaginuma2016-01-301-3/+0
| | | | | The master branch is required Ruby 2.2.2+, for the Ruby 2.2 is bundled Minitest 5.4.3, I think backward compatibility code for Minitest 4 is unnecessary.
* Fix: make Travis CI happy about guides againclaudiob2015-09-013-0/+9
| | | | | | | | Tests on Rails [are currently failing](https://travis-ci.org/rails/rails/jobs/78255666). The reason is the dependency of Rails master from gems that are currently on GitHub (not on RubyGems) and should be explicitly referenced in the Guides test files.
* argh!!!Aaron Patterson2015-08-203-0/+3
|
* Replaced render :text with render :plain in AC gem bug report templatePrathamesh Sonpatki2015-07-181-1/+1
| | | | | - Followup of https://github.com/rails/rails/pull/20929. [ci skip]
* use `plain` option instead of deprecated `text` optionyuuji.yaginuma2015-07-181-1/+1
| | | | this will silence deprecation warnings
* Output an error message and raise an error if bundler 1.10.x is not ↵akihiro172015-06-066-6/+36
| | | | installed when reporting bugs
* Add the bug report templates to the Travis CI buildRoque Pinel2015-06-054-9/+24
| | | | | | | | | | | | The bug report templates are now executed from the `ci/travis.rb` when `GEM` contains `guides`. I started by creating a `test` task in `guides/Rakefile` to handle this, but since inline `gemfile` must not be executed with `bundle exec`, that rake task would not be consistent with others. So I went back by executing them directly from `Build`. Use inline Gemfile dependency when reporting gem bugs
* Use inline Gemfile dependency when reporting bugsRoque Pinel2015-06-033-33/+18
| | | | | With Bundler `1.10.3`, it is possible to list the gems inline without the need to create a `Gemfile` if none is found in the current directory.
* Add a "generic" bug report templateGodfrey Chan2015-04-192-0/+41
| | | | | This template gives contributors a starting point to use when reporting bugs that does not involve Active Record or Action Pack.
* load "rack/test" before "action_controller/railtie" in bug report templates ↵yuuji.yaginuma2015-02-051-1/+1
| | | | [ci skip]
* Use force: true options for creating tables in bug templatesPrathamesh Sonpatki2015-01-192-4/+4
| | | | | | | - Generally we have to run the bug templates multiple times to get them right and it always complains because the posts and comments tables already exist due to earlier runs. - Using force: true will eliminate this issue.
* Update bug report templates to use version 4.2.0 instead of 5.0.0 [ci skip]Prathamesh Sonpatki2015-01-042-2/+2
| | | | | | | | - Right now master is 5.0.0. Latest gem release is 4.2.0 for which we are accepting bug reports. So lets use it in bug report templates. - 5.0.0 is not installable as it's not available on Rubygems yet. So the gem bug templates are not usable without editing the version. Using 4.2.0 will make them usable again.
* Using Rails 5.0 in bug report templates [ci skip]Lucas Caton2015-01-022-2/+2
|
* Remove rack and i18n master from bug report tempaltes [ci skip]Rafael Mendonça França2014-12-192-4/+0
|
* `secret_token` is now saved in `Rails.application.secrets.secret_token`Benjamin Fleischer2014-11-022-4/+4
| | | | | | | | | | | | | | | | | | | | | | - `secrets.secret_token` is now used in all places `config.secret_token` was - `secrets.secret_token`, when not present in `config/secrets.yml`, now falls back to the value of `config.secret_token` - when `secrets.secret_token` is set, it over-writes `config.secret_token` so they are the same (for backwards-compatibility) - Update docs to reference app.secrets in all places - Remove references to `config.secret_token`, `config.secret_key_base` - Warn that missing secret_key_base is deprecated - Add tests for secret_token, key_generator, and message_verifier - the legacy key generator is used with the message verifier when secrets.secret_key_base is blank and secret_token is set - app.key_generator raises when neither secrets.secret_key_base nor secret_token are set - app.env_config raises when neither secrets.secret_key_base nor secret_token are set - Add changelog Run focused tests via ruby -w -Itest test/application/configuration_test.rb -n '/secret_|key_/'
* [ci skip]Add i18n master to the Gemfileyuuji.yaginuma2014-07-242-0/+2
|
* [Bug report templates] Added rack master to the GemfileAbdelkader Boudih2014-07-122-0/+2
|
* Add arel to the controller templateAbdelkader Boudih2014-07-031-0/+1
|
* Revert "Don't rely on Arel master in bug report template [ci skip]"Godfrey Chan2014-04-271-0/+1
| | | | | | This reverts commit fd6d7835. We are back on arel master, see b395265f.
* Don't rely on Arel master in bug report template [ci skip]Robin Dupret2014-04-191-1/+0
| | | | | | We should rely instead on the version supported by Active Record Closes #14809
* Ensure backward compatibility between Minitest 5 and 4Robin Dupret2013-12-272-1/+7
| | | | | | | | Define Minitest::Test in case we are running the gist under Minitest 4 and avoid relying on MiniTest::Unit::TestCase to avoid displaying warning on version five. [ci skip]
* Minitest::Unit::TestCase is Minitest::Test [ci skip]Arun Agrawal2013-12-262-2/+2
|
* Change all `MiniTest` to `Minitest` since, `MiniTest` namespace has been ↵Vipul A M2013-12-182-2/+2
| | | | | | renamed to `Minitest` Ref: https://github.com/seattlerb/minitest/blob/master/History.txt
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 01:13:55 +0000