| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
albertoalmagro/use-assert-not-instead-of-refute"
This reverts commit ab5d5c95ec51c63d58d7e75694af748f165e2228, reversing
changes made to ef4f5ef69b5a50c897bbb17f6b36b729dff12e6c.
|
|
|
|
|
|
|
|
| |
As mentioned in the contributing to Ruby on Rails guides,
we should prefer `assert_not` instead of `refute`. And the
best place to start giving example are our bug report templates..
See: https://github.com/rails/rails/blame/master/guides/source/contributing_to_ruby_on_rails.md#L256
|
|
|
|
|
|
|
|
|
|
| |
Given that Bundler 1.10 was released back in 2015, we can assume
that people are at least on this version or a higher one so there
is no need to ask people to upgrade.
Also, given that Rails 5.0 supports Ruby 2.2+ and given that this
version come with Minitest 5.4.3 bundled, we don't need to ensure
backward compatibility with Minitest 4.
|
|
|
|
| |
This reverts commit b106242f52272c4a5ced7a0e9d1dcb1b50542501.
|
|
|
|
| |
Related to 2e0fe5928f0d08f85b4796c85bd0b39f6be09079
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have already specified to install `bundler` 1.15.4 in `.travis.yml`.
https://github.com/rails/rails/blob/master/.travis.yml#L31..L32
However, `bundler` 1.16.0 may be used in the test.
https://travis-ci.org/rails/rails/jobs/296582467#L2208
The test failed due to this influence.
In order to avoid this, specifying `bundler` version in bug report
templates.
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
| |
:github source uses `git://` url by default, `https://` is recommended.
See http://bundler.io/v1.15/guides/git.html#security
We do the same in our `Gemfile` and templates.
|
| |
|
|
|
|
|
| |
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
|
|
|
|
| |
All gems are released now so we don't need to ask the github repository
for these gems anymore.
|
|
|
|
|
| |
The master branch is required Ruby 2.2.2+, for the Ruby 2.2 is bundled Minitest 5.4.3,
I think backward compatibility code for Minitest 4 is unnecessary.
|
|
|
|
|
|
|
|
| |
Tests on Rails [are currently failing](https://travis-ci.org/rails/rails/jobs/78255666).
The reason is the dependency of Rails master from gems that are currently on
GitHub (not on RubyGems) and should be explicitly referenced in the Guides
test files.
|
| |
|
|
|
|
| |
installed when reporting bugs
|
|
|
|
|
| |
With Bundler `1.10.3`, it is possible to list the gems inline without the
need to create a `Gemfile` if none is found in the current directory.
|
|
This template gives contributors a starting point to use when reporting bugs
that does not involve Active Record or Action Pack.
|