aboutsummaryrefslogtreecommitdiffstats
path: root/guides/bug_report_templates/action_controller_master.rb
Commit message (Collapse)AuthorAgeFilesLines
* Specify `hosts` in bug report template.yuuji.yaginuma2018-12-251-0/+1
| | | | | | | | | | | | | | | | | | | Host authentication introduced by #33145 allows only "0.0.0.0/0", "::/0" and "localhost" in the development environment. https://github.com/rails/rails/blob/4298df00ae6219b9b5b7c40f281d4fa4d66f4383/railties/lib/rails/application/configuration.rb#L33 But `rack-test` use `example.org` for default host. https://github.com/rack-test/rack-test/blob/6c07bf53adf4a4082e206561f5b9b43142fdc821/lib/rack/test.rb#L13 Therefore, if `hosts` is not specified, host authentication rejects the request. In Travis CI, this problem does not occur because `test` is specified by default in `RAILS_ENV` and `RACK_ENV`. https://docs.travis-ci.com/user/environment-variables/#default-environment-variables If user actually use it, env may not always be specified. Explicitly specify hosts in the file so that it works in any environment.
* Update bug report templatesRobin Dupret2018-10-281-6/+1
| | | | | | | | | | Given that Bundler 1.10 was released back in 2015, we can assume that people are at least on this version or a higher one so there is no need to ask people to upgrade. Also, given that Rails 5.0 supports Ruby 2.2+ and given that this version come with Minitest 5.4.3 bundled, we don't need to ensure backward compatibility with Minitest 4.
* Revert "Specify bundler version in template files"SHIBATA Hiroshi2017-12-221-2/+0
| | | | This reverts commit b106242f52272c4a5ced7a0e9d1dcb1b50542501.
* Use released arelyuuji.yaginuma2017-11-151-1/+0
| | | | Related to 2e0fe5928f0d08f85b4796c85bd0b39f6be09079
* Specify bundler version in template filesyuuji.yaginuma2017-11-031-0/+2
| | | | | | | | | | | | We have already specified to install `bundler` 1.15.4 in `.travis.yml`. https://github.com/rails/rails/blob/master/.travis.yml#L31..L32 However, `bundler` 1.16.0 may be used in the test. https://travis-ci.org/rails/rails/jobs/296582467#L2208 The test failed due to this influence. In order to avoid this, specifying `bundler` version in bug report templates.
* Deprecate secret_token, long since usurped by secret_key_base.Kasper Timm Hansen2017-09-281-1/+0
| | | | | | | | | | See the changelog entry. Remove `secrets.secret_token` from the bug report templates, since we don't accept bug reports for Rails versions that don't support a `secret_key_base`. [ claudiob & Kasper Timm Hansen ]
* Add newlines before/after the `git_source` in bug report templatesRyuta Kamizono2017-09-271-0/+2
| | | | [ci skip]
* Change :github git source for bug report templatesbogdanvlviv2017-09-271-0/+1
| | | | | | | :github source uses `git://` url by default, `https://` is recommended. See http://bundler.io/v1.15/guides/git.html#security We do the same in our `Gemfile` and templates.
* Use frozen string literal in guides/Koichi ITO2017-08-131-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Define path with __dir__bogdanvlviv2017-05-231-1/+1
| | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f
* Start Rails 5.2 developmentMatthew Draper2017-03-221-0/+1
|
* Use released arelyuuji.yaginuma2017-02-261-1/+0
| | | | Follow up to ea9566f6cd1b4d3f0d8a5f03283b49423b89044d
* Remove deprecated support to passing a column to #quoteRafael Mendonça França2016-12-291-0/+1
|
* remove unnessary `session_store` settingyuuji.yaginuma2016-08-201-1/+0
| | | | | Since e5a6f7ee9e951dbe0e4e9ea2c0743b4dfb135c57, by default the session store will be set to cookie store with application name as session key.
* applies new string literal convention in guidesXavier Noria2016-08-061-13/+13
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Remove github gems from the master bug report templatesRafael Mendonça França2016-02-181-5/+0
| | | | | All gems are released now so we don't need to ask the github repository for these gems anymore.
* Fix: make Travis CI happy about guides againclaudiob2015-09-011-0/+3
| | | | | | | | Tests on Rails [are currently failing](https://travis-ci.org/rails/rails/jobs/78255666). The reason is the dependency of Rails master from gems that are currently on GitHub (not on RubyGems) and should be explicitly referenced in the Guides test files.
* argh!!!Aaron Patterson2015-08-201-0/+1
|
* use `plain` option instead of deprecated `text` optionyuuji.yaginuma2015-07-181-1/+1
| | | | this will silence deprecation warnings
* Output an error message and raise an error if bundler 1.10.x is not ↵akihiro172015-06-061-1/+6
| | | | installed when reporting bugs
* Add the bug report templates to the Travis CI buildRoque Pinel2015-06-051-1/+0
| | | | | | | | | | | | The bug report templates are now executed from the `ci/travis.rb` when `GEM` contains `guides`. I started by creating a `test` task in `guides/Rakefile` to handle this, but since inline `gemfile` must not be executed with `bundle exec`, that rake task would not be consistent with others. So I went back by executing them directly from `Build`. Use inline Gemfile dependency when reporting gem bugs
* Use inline Gemfile dependency when reporting bugsRoque Pinel2015-06-031-11/+6
| | | | | With Bundler `1.10.3`, it is possible to list the gems inline without the need to create a `Gemfile` if none is found in the current directory.
* Remove rack and i18n master from bug report tempaltes [ci skip]Rafael Mendonça França2014-12-191-2/+0
|
* `secret_token` is now saved in `Rails.application.secrets.secret_token`Benjamin Fleischer2014-11-021-2/+2
| | | | | | | | | | | | | | | | | | | | | | - `secrets.secret_token` is now used in all places `config.secret_token` was - `secrets.secret_token`, when not present in `config/secrets.yml`, now falls back to the value of `config.secret_token` - when `secrets.secret_token` is set, it over-writes `config.secret_token` so they are the same (for backwards-compatibility) - Update docs to reference app.secrets in all places - Remove references to `config.secret_token`, `config.secret_key_base` - Warn that missing secret_key_base is deprecated - Add tests for secret_token, key_generator, and message_verifier - the legacy key generator is used with the message verifier when secrets.secret_key_base is blank and secret_token is set - app.key_generator raises when neither secrets.secret_key_base nor secret_token are set - app.env_config raises when neither secrets.secret_key_base nor secret_token are set - Add changelog Run focused tests via ruby -w -Itest test/application/configuration_test.rb -n '/secret_|key_/'
* [ci skip]Add i18n master to the Gemfileyuuji.yaginuma2014-07-241-0/+1
|
* [Bug report templates] Added rack master to the GemfileAbdelkader Boudih2014-07-121-0/+1
|
* Add arel to the controller templateAbdelkader Boudih2014-07-031-0/+1
|
* Include URL helpers in TestController in bug report templatesRoman Kushnir2013-11-111-0/+2
| | | | | | [ci skip] Fixes #12848.
* remove warnings on ruby trunklaurocaetano2013-11-011-2/+2
|
* Added bug report template for ActionControllerPaul Nikitochkin2013-08-211-0/+51
[ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 23:41:22 +0000