| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit updates the Missing Template image in the Getting Started
Guide.
The new image displays the current error message. Additionally:
- New image is a PNG file, whereas the current image is in fact a misnamed JPEG.
- New image is smaller.
Before:
```
$ file --mime -b template_is_missing_articles_new.png
image/jpeg; charset=binary
$ du -h template_is_missing_articles_new.png
464K template_is_missing_articles_new.png
```
After:
```
$ file --mime -b template_is_missing_articles_new.png
image/png; charset=binary
$ du -h template_is_missing_articles_new.png
28K template_is_missing_articles_new.png
```
[ci-skip]
|
|
|
|
| |
* adding rtl css main file and logic to use
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous version wasn’t matching the Rails Guides logo source file
listed at https://github.com/rails/homepage/blob/master/materials/rails_guides_logo.psd
somehow. It was also a GIF when an 8-bit PNG results in a smaller file (2KB vs 4KB) which
should be just as widely compatible with browsers.
And that’s just for the 1x version. I added a new 2x version for “retina” or high-density
displays and a CSS @media query to progressively enhance with this high density
version of the logo. I’ve ensured that this query is supported across browsers by
using vendor-specific versions when necessary. See:
https://caniuse.com/#feat=css-media-resolution
[ci skip]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This notably allows us to tile each category without pushing the page down vertically
as much as we previously did on any viewport wider than mobile sizes.
It also means we can fit more guides which will become useful in the future since
we have several new guides in the work.
Finally the new layout allows three clearly distinct columns to emerge:
- Start Here and Rails basics: Models, Views, Controllers, Other Components
- Digging Deeper, Extending Rails, Contributing, Maintenance
- Release Notes
Having Release Notes shoot back up to the top of the third column is great
because that makes finding the latest released version and its associated
release notes much easier without having to scroll down a bunch.
[ci skip]
|
|\
| |
| | |
Use Turbolinks in Rails guides
|
| | |
|
| |
| |
| |
| | |
Fix a layout issue in the rails guides, where the navigation covers the main text,
if the page is between 800 and 960 pixels wide. (issue #33406)
|
| | |
|
|/
|
|
|
|
| |
* Update 'rails_welcome.png' to reflect a more diverse population
* Cleanup 'rails_welcome.png'
|
|
|
|
|
| |
* Remove `$` prefix from all variables (`$` prefix means jQuery object)
* Old browsers doesn't support forEach. So use for instead of forEach.
|
|
|
|
|
| |
* Rewrite with Vanilla JS
* Confirmed with Chrome, Safari, Firefox
|
|\
| |
| | |
Improve css in guide
|
| |
| |
| |
| |
| |
| |
| |
| | |
* .clearfix is overridden.
* .clear is not currently used.
* #extraCol is not currently used.
* table th, table td are overridden. Merged them.
* Removed needless comment lines which are added on #6475
|
| |
| |
| |
| | |
Note that tab_yellow.gif exists, that is the one being used.
|
|/
|
|
| |
The credits page is gone after #32429, these images are now orphan.
|
| |
|
| |
|
| |
|
|
|
|
| |
instead of ApplicationRecord in images
|
| |
|
|
|
|
| |
Minor fix to #28662
|
|
|
|
| |
[ci skip]
|
|
|
|
| |
To allow easy linking at all levels and not just from index
|
|\
| |
| | |
Fix a wrong permission
|
| | |
|
|\ \
| | |
| | | |
Selectively add `li ul, li ol { margin:0 1.5em; }` to subColl as needed
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Chapters column, instead of leaking to other lists.
Before:
https://monosnap.com/file/CNIMXcqv3HuRrObTNYWYFis8I3G8PT
After:
https://monosnap.com/file/0IyEKEy9hcRCIx82etR8ikinCo3vNb
Chapters column remains as is: http://take.ms/M0BkF
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes #25744 by slightly increasing the margin in code syntax
highlights. With a margin of 0, it was cutting off underscores in Linux
browesers, so I slightly increased it to 0.5px.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Build Syntax Highlighter based on https://github.com/syntaxhighlighter/syntaxhighlighter/wiki/Building and use theme generated by fxn.
- This also bundles these brushes in the file itself- ruby,css,xml,sql,javascript,plain. Generation command used:
gulp build --compat --brushes=javascript,ruby,xml,sql,plain --theme=/Path/To/RailsSource/rails/guides/assets/stylesheets/syntaxhighlighter/shThemeRailsGuides.css
- rm all old js and css files
- Moved over how JS configuration is created for Syntax Highlighter
- Fixed layout for all imports
- Fixes bug with old copy paste, generating wrong space character on webkit https://github.com/syntaxhighlighter/syntaxhighlighter/blob/7caa9632e7fe470d944fc06b4db7d35352ebaa36/src/dom.js#L227
Fixes #25655
|
|/ /
| |
| |
| |
| |
| | |
- Rails 5 will return 204 No Content by default for controller actions
which do not have a template or do not specify how to render.
- The "Getting started" guide needs to be updated for this.
|
| | |
|
| |
| |
| |
| |
| |
| | |
Change background-color value to transparent, which is the default value of background-color.
[ci skip]
|
| |
| |
| |
| | |
As requested by David in 23233.
|
| |
| |
| |
| |
| |
| | |
changed from 755 to 644.
I executed `chmod -x guides/assets/javascripts/responsive-tables.js`.
[ci skip]
|
| |
| |
| |
| |
| | |
- Add new logo for guides header
[ci skip]
|
| |
| |
| | |
fixes #21500
|
|/
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change all of anchor text in the nav links to `Back` and `Edit`
Use `Edit | Back` on pages that use both links to conform to what
scaffolding generates.
Use consistent anchor text throughout the guide.
Change all of anchor text in the nav links to `Back` and `Edit`
Use `Edit | Back` on pages that use both links to conform to what
scaffolding generates.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 65a2977 added a `pre-wrap` style for white spaces on `.note`
paragraphs. However, this is first inconsistent as other notes like
warnings don't have this style applied. Furthermore, it seems to be
unneeded for mobile devices.
Also revert changes made in #18147 since they aren't needed anymore.
Cross-refs #18138.
[ci skip]
|
|
|
|
|
|
|
|
|
|
|
|
| |
/cc @chancancode @robin850
configuration reference: http://alexgorbatchev.com/SyntaxHighlighter/manual/configuration/
Related issues:
* https://github.com/vmg/redcarpet/issues/334
* https://github.com/docrails-tw/guides/issues/62
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We noticed the rails gem increased in size between the beta and rc
versions, and the reason is that some guides images were updated but not
properly optimized, and one image changed from png to jpg, way bigger.
Converting the jpg image back to png, and using ImageOptim to optimize
all the images for web view, improves the situation [ci skip].
---
In current master/4-1-stable:
508K guides/assets/images/getting_started/
In v4.1.0.beta1:
268K guides/assets/images/getting_started/
In 4-0-stable
328K guides/assets/images/getting_started/
After the patch:
260K guides/assets/images/getting_started/
|
|
|
|
|
|
|
|
| |
- Used Article model instead of Post as it may confuse with 'post'
requests
- Tried to wrap the guide to 80 chars lines as much as possible.
- Removed unused image
- Fixes #13764
|
|
|
|
| |
More to come.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had written the original guide for "A Guide to Testing Rails
Applications". The current documents maintains the same structure and
examples I had drafted albeit with some minor changes to keep up with
newer version of Rails.
Older version which had credits included:
http://guides.rubyonrails.org/v2.3.11/testing.html
Github lifo/docrails History:
https://github.com/rails/rails/commits/ff359af86505b4d317b7467e7f79aa2ef2c5e795/railties/doc/guides/source/testing_rails_applications.txt
|
|\
| |
| | |
Improve guides js
|
| |
| |
| |
| |
| |
| |
| | |
* Stop using unnecessary global variable
* Use function defined by jQuery for simplicity
* Fix event listner for "more info button" to handle
event on resize browser
|
| |
| |
| |
| |
| | |
dropdown menu on guides page (which appear on small windows)
[ci skip]
|