aboutsummaryrefslogtreecommitdiffstats
path: root/ci
Commit message (Collapse)AuthorAgeFilesLines
* Bump RuboCop to 0.58.2Koichi ITO2018-07-267-275/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ## Summary RuboCop 0.58.2 was released. https://github.com/rubocop-hq/rubocop/releases/tag/v0.58.2 And rubocop-0-58 channel is available in Code Climate. https://github.com/codeclimate/codeclimate/releases/tag/v0.76.0 https://github.com/codeclimate/codeclimate/commit/38f21f0 In addition, the following changes are made in this PR. - Replace Custom cops with Rails cops - Add jaro_winkler gem to Gemfile.lock ### Replace Custom cops with Rails cops These are compatible replacements. - Replace `CustomCops/AssertNot` cop with `Rails/AssertNot` cop. - Replace `CustomCops/RefuteNot` cop with `Rails/RefuteMethods` cop. With this replacement, it was decided to use cop of RuboCop itself. It removes the code related to CustomCops accordingly. ### Add jaro_winkler gem to Gemfile.lock Since RuboCop 0.57.0 depends on jaro_winkler gem, it has been added to Gemfile.lock.
* Fix `CustomCops/AssertNot` to allow it to have failure messageRyuta Kamizono2018-05-131-1/+1
| | | | Follow up of #32605.
* Add RuboCop for `assert_not` over `assert !`Daniel Colson2018-04-195-10/+96
| | | | | | | | | | | | | | | We added `assert_not` in f75addd "to replace warty 'assert !foo'". fa8d35b agrees that it is warty, and so do I. This custom Rubocop rule turns the wart into a violation. As with my last custom cop, https://github.com/rails/rails/pull/32441, I want to make sure this looks right on code climate before pushing another commit to autocorrect everything. @toshimaru I just noticed https://github.com/toshimaru/rubocop-rails/pull/26 Is there a better way to add these custom cops, or were you saying we shouldn't have custom cops at all?
* Add custom RuboCop for `assert_not` over `refute`Daniel Colson2018-04-035-0/+189
| | | | | | | | | | | | | | | | | | | | | | | Since at least cf4afc4 we have preferred `assert_not` methods over `refute` methods. I have seen plenty of comments in PRs about this, and we have tried to fix it a few times (5294ad8, e45f176, 8910f12, 41f50be, d4cfd54, 48a183e, and 211adb4), but the `refute` methods keep sneaking back in. This custom RuboCop will take care of enforcing this preference, so we don't have to think about it again. I suspect there are other similar stylistic preferences that could be solved with some custom RuboCops, so I will definitely keep my eyes open. `assert_not` over `assert !` might be a good candidate, for example. I wasn't totally sure if `ci/custom_cops` was the best place to put this, but nothing else seemed quite right. At one point I had it set up as a gem, but I think custom cops like this would have limited value in another context. I want to see how code climate handles the new cops before autocorrecting the existing violations. If things go as expected, I will push another commit with those corrections.
* Only run isolated tests on the latest stable ruby: that's now 2.5Matthew Draper2018-01-251-1/+1
|
* Fix ActionView UJS buildeileencodes2018-01-181-0/+1
| | | | | | | | | | The UJS build has been failing with Chrome failed to start. This commit fixes it by adding the option `--no-sandbox`. Travis removed the sanbox option which is why Chrome crashes. Ref https://github.com/travis-ci/travis-ci/issues/8836 Example failure: https://travis-ci.org/rails/rails/jobs/330396750
* Fix typos and add a few suggestionsFatos Morina2017-11-281-1/+1
|
* Keep rubocop happy with the new Selenium runnerMatthew Draper2017-10-281-4/+6
|
* Count assertions instead of tests in reportGuillermo Iguaran2017-10-191-1/+1
|
* PhantomJS is abandoned, replace it with Selenium/Chrome headlessGuillermo Iguaran2017-10-192-149/+13
|
* Use frozen string literal in ci/Koichi ITO2017-08-131-0/+2
|
* Run Active Storage tests in CI (#30144)George Claghorn2017-08-101-0/+2
|
* Use File::NULL instead of "/dev/null"Kazuhiro NISHIYAMA2017-07-311-1/+1
|
* Create `rails@localhost` user on travis ciRyuta Kamizono2017-07-191-0/+4
| | | | | | | Looks like that latest CI failure is due to missing `rails@localhost`. Creating the user may solve the issue. https://travis-ci.org/rails/rails/jobs/254996063#L831
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Skip isolated test runs on older rubiesMatthew Draper2017-03-231-0/+1
|
* Test rails-ujs in our travis matrixRafael Mendonça França2017-02-222-1/+157
|
* Move and rename system testseileencodes2017-02-201-1/+0
| | | | | | | | | | * Move system tests back into Action Pack * Rename `ActionSystemTest` to `ActionDispatch::SystemTestCase` * Remove private base module and only make file for public `SystemTestCase` class, name private module `SystemTesting` * Rename `ActionSystemTestCase` to `ApplicationSystemTestCase` * Update corresponding documentation and guides * Delete old `ActionSystemTest` files
* Turn system testing into it's own gem and renameeileencodes2017-02-201-1/+1
| | | | | | | | | | Renames `Rails::SystemTestCase` to `ActionSystemTest` and moves it to a gem under the Rails name. We need to name the class `ActionSystemTestCase` because the gem expects a module but tests themselves expect a class. Adds MIT-LICENSE, CHANGELOG, and README for the future.
* Add more rubocop rules about whitespacesRafael Mendonça França2016-10-291-1/+1
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-2/+2
|
* modernizes hash syntax in the rest of the projectXavier Noria2016-08-061-1/+1
|
* applies new string literal convention in ciXavier Noria2016-08-061-38/+38
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* CI: run Action Cable browser tests in Sauce LabsJon Moss2016-05-251-0/+1
| | | | | | | | Allow failures until test runs are consistently stable, not hanging. Closes #24943. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* Minor comment language correction.Anubhav Saxena2016-05-241-2/+2
|
* Fix some typos in comments.Joe Rafaniello2016-05-041-1/+1
| | | | [ci skip]
* Remove commented out code in `ci/travis.rb` [ci skip]Ryuta Kamizono2016-02-041-14/+0
|
* Use an appropriate rebuild task on Travisyui-knk2015-12-221-1/+8
| | | | | | Use `db:mysql:rebuild` when testing mysql2, `db:postgresql:rebuild` when testing postgresql and no rebuild task when testing others.
* Do not run action cable tests in isolationRafael Mendonça França2015-12-141-0/+1
| | | | We don't have isolation tests for it yet.
* Add Action Cable tests to travis matrixRafael Mendonça França2015-12-141-0/+1
|
* Partially revert 14b20ceGodfrey Chan2015-11-271-2/+8
| | | | | The failure have returned, so disabling the tests again. (The upgrade is fine to keep.)
* Upgrade to listen 3.0.5, re-enable testsGodfrey Chan2015-11-261-8/+2
| | | | | | | | | | In listen 3.0.4 and below, the `#stop` method on the notification backends are a no-op, meaning that we are leaking them per test. This ended up triggering another bug in Ruby that causes our builds to fail randomly on CI. listen bug: https://github.com/guard/listen/issues/353 ruby bug: https://bugs.ruby-lang.org/issues/11744
* Only run listen tests in isolation, for nowGodfrey Chan2015-11-261-1/+16
| | | | | | There is a known issue with the listen tests that casuses files to be incorrectly GC'ed even when they are still in-use. The current is to only run them in isolation to avoid randomly failing our test suite.
* Add the bug report templates to the Travis CI buildRoque Pinel2015-06-051-8/+24
| | | | | | | | | | | | The bug report templates are now executed from the `ci/travis.rb` when `GEM` contains `guides`. I started by creating a `test` task in `guides/Rakefile` to handle this, but since inline `gemfile` must not be executed with `bundle exec`, that rake task would not be consistent with others. So I went back by executing them directly from `Build`. Use inline Gemfile dependency when reporting gem bugs
* Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-291-1/+1
|
* Skip isolated tests for PRsMatthew Draper2014-09-201-0/+1
| | | | | They're valuable, but the types of errors they catch are fairly rare: we can address them post-merge when they show up.
* ActiveJob Integration TestsCristian Bica2014-09-111-1/+12
|
* Added ActiveJob configuration for travisCristian Bica2014-08-141-1/+2
|
* Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi]Arun Agrawal2014-05-161-1/+1
|
* Revert "Merge pull request #14940 from arunagw/hbakhtiyor-test-db-namespaces-ar"Yves Senn2014-05-031-1/+1
| | | | | This reverts commit fe9859600824268ff614cb3eb48b62c7165a1fbd, reversing changes made to add9560643ef79830febf47fa1228752d1df3502.
* Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi]Arun Agrawal2014-05-031-1/+1
|
* Add ActionView to CIŁukasz Strzałkowski2013-06-201-1/+2
|
* Fix copy table index test; Change == to ! on false in travis.rbVipul A M2013-03-211-2/+2
|
* remove duplicate build runs in travis. These extra runs were used toGrace Liu2012-07-241-3/+0
| | | | test identity map and not fully removed when the feature was removed.
* Remove IdentityMapCarlos Antonio da Silva2012-03-131-8/+1
|
* Remove Active Resource source files from the repositoryPrem Sichanugrist2012-03-131-1/+0
| | | | | | | | | | Dear Active Resource, It's not that I hate you or anything, but you didn't get much attention lately. There're so many alternatives out there, and I think people have made their choice to use them than you. I think it's time for you to have a big rest, peacefully in this Git repository. I will miss you, @sikachu.
* fixed a typo in a message when there is no failuresin a buildSergey Parizhskiy2011-11-281-1/+1
|
* Remove cruise filesSantiago Pastorino2011-07-265-415/+0
|
* Added a .travis.yml config and travis specific ci script.Josh Kalderimis2011-07-151-0/+142
| | | | | | | | Don't install ruby-debug if running the test suite on Travis, linecache19 is the main offender, very very slow. And do not install pg if Travis is bundling the gems, pg will be setup on Travis soon.