aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Find query_source_location using lazy EnumeratorJohn Hawthorn2019-04-151-1/+5
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This way, we only need to filter the backtrace up to the first non-noise stack frame. This also updates noise to be able to deal with being passed a lazy enum. We don't need this anywhere, but it seemed better for this to be consistent.
* | | | Redis fetch without names returns {}David Verhasselt2019-04-122-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When trying to call mget in Redis without any parameters, a Redis error is thrown. To avoid this, we circumvent Redis entirely when there are no key names given.
* | | | Auto-correct `Style/RedundantBegin` cop offencesRyuta Kamizono2019-04-121-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is newly added at 7b6b10542d5dac2b50f2578143dc5d70120d1146. ``` % be rubocop -a Inspecting 2781 files ...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................. Offenses: activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:12:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:12:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:12:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:13:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. Rails.autoloaders.main.reload ^^^^ activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:16:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end. activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:16:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. 2781 files inspected, 6 offenses detected, 6 offenses corrected ```
* | | | improves the reloading disabled error messageXavier Noria2019-04-112-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original message from Zeitwerk is "can't reload, please call loader.enable_reloading before setup (Zeitwerk::Error)", which is not very informative for Rails programmers. Rails should err with a message worded in terms of its interface.
* | | | depend on Zeitwerk 2.1.0Xavier Noria2019-04-094-14/+20
| | | |
* | | | depend on Zeitwerk 2Xavier Noria2019-04-073-4/+11
|/ / /
* | | Merge pull request #35691 from ↵Rafael França2019-04-042-6/+78
|\ \ \ | | | | | | | | | | | | | | | | sushantmittal/add_deattach_from_in_active_support_subscriber Adds 'detach_from' to 'ActiveSupport::Subscriber' to detach a subscriber from a namespace.
| * | | Added 'detach_from' to 'ActiveSupport::Subscriber' to detach a subscriber ↵sushant2019-04-042-6/+78
| | | | | | | | | | | | | | | | from a namespace.
* | | | Output junit format test reportFumiaki MATSUSHIMA2019-04-041-0/+2
| | | |
* | | | Merge pull request #35771 from timoschilling/hash-speed-improvementsRafael França2019-04-022-4/+7
|\ \ \ \ | | | | | | | | | | Hash / HashWithIndifferentAccess speed improvements
| * | | | Speed improvement for HashWithIndifferentAccess#values_atTimo Schilling2019-04-021-2/+2
| | | | |
| * | | | Speed improvement for HashWithIndifferentAccess#fetch_valuesTimo Schilling2019-04-021-1/+1
| | | | |
| * | | | Speed improvement for HashWithIndifferentAccess#exceptTimo Schilling2019-04-011-0/+3
| | | | |
| * | | | Speed improvement for Hash#exceptTimo Schilling2019-03-291-1/+1
| | | | |
* | | | | Follow up tweaks b89a3e7e638a50c648a17d09c48b49b707e1d90d [ci skip]Ryuta Kamizono2019-03-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * use backticks instead of `+` * and more (e.g. missed replacing `Array#excluding` and `Enumerable#excluding` in b89a3e7e638a50c648a17d09c48b49b707e1d90d)
* | | | | Tweaks CHANGELOGs and docs [ci skip]Ryuta Kamizono2019-03-312-19/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * add leading `#` before `=>` since hash rocket is valid Ruby code * add backticks * remove trailing spaces * and more
* | | | | fixes eager loading edge case in :zeitwerk modeXavier Noria2019-03-303-7/+27
|/ / / /
* | | | Merge pull request #34405 from shugo/safe_buffer_backref_fixMatthew Draper2019-03-282-2/+55
|\ \ \ \ | | | | | | | | | | sub, sub!, gsub, and gsub! should set back references
| * | | | Eliminate a thread local variable as suggested by nobuShugo Maeda2019-02-141-8/+1
| | | | |
| * | | | Remove trailing spaceShugo Maeda2018-11-081-1/+1
| | | | |
| * | | | Add a commented code example of what will be producedShugo Maeda2018-11-081-22/+22
| | | | |
| * | | | sub, sub!, gsub, and gsub! should set back referencesShugo Maeda2018-11-082-2/+62
| | | | |
* | | | | Fix bug in Range comparisons when comparing to excluded-end RangeOwen Stephens2019-03-283-14/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: ```ruby (1..10).cover?(1...11) => false ``` After: ```ruby (1..10).cover?(1...11) => true ``` See https://git.io/fjTtz for the commit against Ruby core that added support for Range arguments, with similar handling of this case.
* | | | | Don't encode in secure_compare for speedupBart de Water2019-03-261-1/+1
| | | | | | | | | | | | | | | | | | | | Hex encoding is base 16 which makes the original input twice as big. With this change less time need to be spent in fixed_length_secure_compare.
* | | | | bumps Zeitwerk and BootsnapXavier Noria2019-03-261-1/+1
| | | | |
* | | | | Use weak references in descendants trackerEdgars Beigarts2019-03-263-4/+64
| | | | | | | | | | | | | | | | | | | | It allows anonymous subclasses to be garbage collected.
* | | | | Depend on Zeitwerk 1.4.2Xavier Noria2019-03-231-1/+1
| | | | |
* | | | | Fix AS CHANGELOG typoAli Ibrahim2019-03-221-1/+1
| | | | |
* | | | | Update CHANGELOG and docsAli Ibrahim2019-03-222-3/+11
| | | | | | | | | | | | | | | | | | | | with change to ActiveSupport::Notifications::Instrumenter#instrument
* | | | | Update AS::Notifications::Instrumenter#instrumentAli Ibrahim2019-03-222-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | * Update #instrument to make passing a block optional. This will let users leverage #instrument for messaging in addition to instrumentation.
* | | | | depend on Zeitwerk 1.4.0Xavier Noria2019-03-192-2/+6
| | | | |
* | | | | Fix Time#advance to work with dates before 1001-03-07Andrew White2019-03-183-2/+17
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #10634 the behavior of Time#advance was changed to maintain a proleptic gregorian calendar for dates before calendar reform. However it didn't full address dates a long time before calendar reform and they gradually drift away from the proleptic calendar the further you go back in time. Fix this by always converting the date to gregorian before calling advance which sets the reform date to -infinity.
* | | | Merge pull request #35634 from sharang-d/update-parameterize-docsRyuta Kamizono2019-03-162-6/+10
|\ \ \ \ | | | | | | | | | | Update docs for 'parameterize()' [ci skip]
| * | | | Update docs for 'parameterize()' [ci skip]Sharang Dashputre2019-03-162-6/+10
| | | | |
* | | | | Engines are reloaded in Zeitwerk mode [closes #35618]Xavier Noria2019-03-152-2/+5
|/ / / /
* | | | Match evented checker behavior on dir with no extsJohn Hawthorn2019-03-152-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When FileUpdateChecker is passed a directory and given an empty array of extensions to match on, it will match any extension. Previously, EventedFileUpdateChecker would never match any files when given an empty array. This commit makes it EventedFileUpdateChecker match FileUpdateChecker, and watch all extensions when given an empty array.
* | | | bumps ZeitwerkXavier Noria2019-03-141-1/+1
| | | |
* | | | support slice assignment on SafeBufferRichard Monette2019-03-132-2/+38
| | | |
* | | | Merge tag 'v6.0.0.beta3'eileencodes2019-03-132-1/+6
|\ \ \ \ | | | | | | | | | | | | | | | v6.0.0.beta3 release
| * | | | Prep releaseeileencodes2019-03-112-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update RAILS_VERSION * Bundle * rake update_versions * rake changelog:header
* | | | | Fix typo s/ActiveSupport::Timezone/ActiveSupport::TimeZone/ [ci skip]Ryuta Kamizono2019-03-131-1/+1
| | | | |
* | | | | Merge pull request #35577 from sharang-d/typo-opt-outVipul A M2019-03-123-13/+13
|\ \ \ \ \ | | | | | | | | | | | | Change wording of some instances of 'opt out' [ci skip]
| * | | | | Change wording of some instances of 'opt out' [ci skip]Sharang Dashputre2019-03-123-13/+13
| | | | | |
* | | | | | Merge pull request #35575 from sharang-d/changelog-for-parameterizeRyuta Kamizono2019-03-121-1/+13
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | Add changelog entry for transliterate/parameterize accepting `locale` [ci skip]
| * | | | | Add changelog entry for transliterate/parameterize accepting `locale` [ci skip]Sharang Dashputre2019-03-121-0/+10
| | | | | |
* | | | | | bump Zeitwerk to 1.3.3Xavier Noria2019-03-111-1/+1
|/ / / / /
* | | | | Fix bug with parametrize when `locale` is passedSharang Dashputre2019-03-124-1/+19
| | | | | | | | | | | | | | | | | | | | Also add tests for parametrize and transliterate
* | | | | Add locale option to parameterizeKaan Ozkan2019-03-112-10/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Parameterize is triggering I18n#transliterate. This method already accepts a locale. It would be cleaner if similar to other string inflection methods #parameterize also accepted 'locale' as a parameter.
* | | | | Merge pull request #35121 from utilum/warning_tried_to_create_proc_without_blockKasper Timm Hansen2019-03-101-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Ruby 2.7 warning: creating a Proc without a block
| * | | | | Ruby 2.7 warning: creating a Proc without a blockutilum2019-02-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As of [Revision 66772]( https://bugs.ruby-lang.org/projects/ruby-trunk/repository/trunk/revisions/66772) `Proc.new` without giving a block emits `warning: tried to create Proc object without a block`. This commit fixes cases where Rails test suit tickles this warning. See CI logs: https://travis-ci.org/rails/rails/jobs/487205819#L1161-L1190 https://travis-ci.org/rails/rails/jobs/487205821#L1154-1159 https://travis-ci.org/rails/rails/jobs/487205821#L1160-L1169 https://travis-ci.org/rails/rails/jobs/487205821#L1189 https://travis-ci.org/rails/rails/jobs/487254404#L1307-L1416 https://travis-ci.org/rails/rails/jobs/487254405#L1174-L1191