| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
These methods are not random so they should not belings to SecureRandom
module.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
This output isn't used anywhere for assertions so we can simply remove
it. The introducing commit was f238d495.
|
|
|
|
|
|
| |
A minor version breakage due to a rewrite of the callbacks code now
requires an explicit block to be passed to #set_callback. This amends
the documentation.
|
| |
|
|
|
| |
This has changed since around 2b1500d6
|
| |
|
|
|
|
| |
(This is a manual merge of #9102)
|
|
|
|
|
|
|
| |
Previously this method always returns `.0` in the fractional part. This commit
changes it to preserve the fractional seconds instead.
Fixes #15994.
|
|
|
|
|
| |
Didn't get a chance to convert existing code, I'll skim through the code
base to make use of this later this afternoon.
|
| |
|
|
|
|
| |
[ci skip]
|
|\
| |
| |
| | |
Always instrument ActiveSupport::Cache
|
| |
| |
| |
| |
| |
| |
| |
| | |
The current approach is broken because it uses a thread local value
which means on multi-threaded environments it has to be turned on
per thread. Secondly, ActiveSupport::Notifications does not
instrument items when there are not subscribers so this flag is
unnecessary.
|
| |
| |
| | |
In some cases run_callbacks will return nil. I'm attempting to update the documentation for the method to clarify.
|
|\ \
| |/
|/| |
Make the apply_inflections method case-sensitive
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since d3071db1, the apply_inflections method check if the downcased
version of a string is contained inside the "whitelist" of uncountable
words. However, if the word is composed of capital letters, it won't be
matched in the list while it should.
We can't simply revert to the previous behavior as there is a
performance concern (benchmarked over /usr/share/dict/words):
Before d3071db1 135.610000 0.290000 135.900000 (137.807081)
Since d3071db1 22.170000 0.020000 22.190000 ( 22.530005)
With the patch 22.060000 0.020000 22.080000 ( 22.125771)
Benchmarked with http://git.io/aFnWig
This way, the solution is to put the down-case version of words inside
the @uncountables array.
|
| |
| |
| |
| |
| |
| |
| | |
These methods shouldn't be added to `SecureRandom`, as they are neither secure nor random. The more appropriate place for this seems to be `Digest`, so we should move them there. (Pull request welcomed!)
Marking this `:nodoc:` for now, so we don't accidentally ship it as public API.
See https://github.com/rails/rails/pull/15306/files#r13055862 for details.
|
|\ \
| |/
|/| |
Make the isolated tests run on JRuby
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As there is no forking on JRuby, we need to spawn sub-processes to make
the tests run in isolation.
Previously, we were defining globally env variables and running the test
file through backticks and delete these variables once the test ran.
Now, we simply rely on IO.popen as this is cross-platform and the env
variables are available during the child-process execution only so there
are no race conditions.
[Ben Browning & Robin Dupret]
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Ruby's original behaviour is that :
* It only returns a const name, not a qualified aname
* It returns a symbol, not a string
|
| | |
|
|\ \
| | |
| | | |
Use with_parse_json_times helper in tests.
|
| |/ |
|
|/ |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
zuhao/refactor_activesupport_time_zone_test_helpers
Extract out with_env_tz helper method.
|
| |
| |
| |
| |
| | |
It’s used at so many places that extracting it out into a helper file
is worth doing.
|
| | |
|
| | |
|
|/ |
|
| |
|
|\
| |
| | |
Add test cases for Hash#asset_valid_keys
|
| | |
|
| |
| |
| |
| |
| | |
Clean up I18n stored translations after test
continuation with #15714
|
|\ \
| |/
|/| |
Add missing test cases for #assert_no_difference
|
| | |
|
|\ \
| | |
| | | |
[ci skip] BigDecimal#duplicable? returns false in 1.9.x
|
| |/ |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
require `to_param`"
Revert "No need to require to_param, it is already required in to_query.rb"
This reverts commits ccdd97662e1fb00c23c90d59f65c091904959561
and d697ee14264a90a39cdbe87857656d8b314ac9b7.
Reason by @jeremy: These requires are not for implementation dependency.
They ensure that requiring array conversions provides to_query, to_param,
and other array conversion behaviors.
The fact that to_query is implemented in terms of to_param is just a
coincidence. If to_query removed its to_param require, then someone
requiring array conversions would no longer have to_param available.
This change removes these intentional dependencies on to_param in favor
of implementation side effects—an undesirable move that's susceptible to
regression.
|
|
|
|
| |
`to_param`
|
| |
|