aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* deprecate `halt_callback_chains_on_return_false` instead of ↵yuuji.yaginuma2017-02-083-16/+7
| | | | | | | | | | | | | | `halt_and_display_warning_on_return_false` `halt_and_display_warning_on_return_false` is not a public API and application is using `halt_callback_chains_on_return_false`. https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults.rb.tt#L29 https://github.com/rails/rails/blob/5-0-stable/activesupport/lib/active_support.rb#L86..L88 Therefore, deprecate messages should be issued for `halt_callback_chains_on_return_false` instead of `halt_and_display_warning_on_return_false`.
* Remove unused code now that the deprecated file was removedRafael Mendonça França2017-02-071-2/+1
|
* Deprecate halt_and_display_warning_on_return_falseRafael Mendonça França2017-02-072-5/+16
|
* Remove deprecated behavior that halts callbacks when the return is falseRafael Mendonça França2017-02-073-52/+6
|
* Document that string in if and unless option of callbacks are deprecatedRafael Mendonça França2017-02-071-4/+4
|
* Improve the exception message to direct people to all the possible valuesRafael Mendonça França2017-02-071-1/+2
|
* Merge pull request #27608 from ↵Rafael França2017-02-073-58/+68
|\ | | | | | | | | kamipo/remove_deprecated_passing_string_to_define_callback Remove deprecated passing string to define callback
| * Deprecate passing string to `:if` and `:unless` conditional options on ↵Ryuta Kamizono2017-02-043-4/+38
| | | | | | | | `set_callback` and `skip_callback`
| * Remove deprecated passing string to define callbackRyuta Kamizono2017-02-043-55/+31
| | | | | | | | And raise `ArgumentError` when passing string to define callback.
* | Merge pull request #27919 from bf4/correct_spellingArthur Nogueira Neves2017-02-065-6/+6
|\ \ | | | | | | Correct spelling
| * | Correct spellingBenjamin Fleischer2017-02-055-6/+6
| | | | | | | | | | | | | | | | | | | | | ``` go get -u github.com/client9/misspell/cmd/misspell misspell -w -error -source=text . ```
* | | Add tests for `blank?`kenta-s2017-02-063-0/+12
|/ /
* / Docs: Correction: Module::DelegationErrorJared Beck2017-02-031-7/+9
|/ | | | | | | | | | | | | | | | When the delegation target is nil and the allow_nil option is not in use, a Module::DelegationError is raised. class C delegate :a, to: :b def b nil end end C.new.a # => Module::DelegationError: C#a delegated to b.a, but b is nil [ci skip]
* explicitly require `listen` in `EventedFileUpdateCheckerTest` (#27867)Arthur Nogueira Neves2017-02-011-0/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, executing the `test_initialize_raises_an_ArgumentError_if_no_block_given` test alone will result in an error. ``` $ ./bin/test test/evented_file_update_checker_test.rb -n test_initialize_raises_an_ArgumentError_if_no_block_given Run options: -n test_initialize_raises_an_ArgumentError_if_no_block_given --seed 6692 # Running: E Error: EventedFileUpdateCheckerTest#test_initialize_raises_an_ArgumentError_if_no_block_given: NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen rails/activesupport/test/evented_file_update_checker_test.rb:21:in `teardown' ``` This is because if do not specify a file or directory for `EventedFileUpdateChecker`, do not require `listen`, and using listen method in teardown. https://github.com/rails/rails/blob/master/activesupport/lib/active_support/evented_file_update_checker.rb#L53..L65 Therefore, added listen's require to avoid errors.
| * explicitly require `listen` in `EventedFileUpdateCheckerTest`yuuji.yaginuma2017-02-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, executing the `test_initialize_raises_an_ArgumentError_if_no_block_given` test alone will result in an error. ``` $ ./bin/test test/evented_file_update_checker_test.rb -n test_initialize_raises_an_ArgumentError_if_no_block_given Run options: -n test_initialize_raises_an_ArgumentError_if_no_block_given --seed 6692 # Running: E Error: EventedFileUpdateCheckerTest#test_initialize_raises_an_ArgumentError_if_no_block_given: NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen rails/activesupport/test/evented_file_update_checker_test.rb:21:in `teardown' ``` This is because if do not specify a file or directory for `EventedFileUpdateChecker`, do not require `listen`, and using listen method in teardown. https://github.com/rails/rails/blob/master/activesupport/lib/active_support/evented_file_update_checker.rb#L53..L65 Therefore, added listen's require to avoid errors.
* | remove unused variableyuuji.yaginuma2017-02-011-1/+1
|/ | | | | | | | This removes the following warnings. ``` activesupport/test/file_update_checker_shared_tests.rb:279: warning: assigned but unused variable - checker ```
* Remove deprecated callbacks from ActionDispatch middlewaresRafael Mendonça França2017-01-311-1/+13
|
* Merge pull request #27857 from kenta-s/add-test-for-variable_size_secure_compareEileen M. Uchitelle2017-01-311-1/+6
|\ | | | | Add test for `variable_size_secure_compare`
| * Add test for `variable_size_secure_compare`kenta-s2017-01-311-1/+6
| |
* | Remove redundant right parentheses in number_helper [ci skip]kenta-s2017-01-311-1/+1
|/
* Raise in the initialize not in the executeRafael Mendonça França2017-01-313-13/+12
|
* Merge pull request #27824 from kenta-s/raise-an-error-if-no-block-givenRafael França2017-01-313-2/+17
|\ | | | | Raise an error if FileUpdateChecker#execute is called with no block
| * Raise an error if FileUpdateChecker#execute is called with no blockkenta-s2017-01-283-2/+17
| |
* | Merge pull request #27797 from y-yagi/correctly_check_error_messageArthur Nogueira Neves2017-01-302-2/+4
|\ \ | | | | | | correctly check error message
| * | correctly check error messageyuuji.yaginuma2017-01-252-2/+4
| | | | | | | | | | | | | | | | | | | | | `assert_raise` does not check error message. However, in some tests, it seems like expecting error message checking with `assert_raise`. Instead of specifying an error message in `assert_raise`, modify to use another assert to check the error message.
* | | Merge pull request #27822 from mtsmfm/bump-unicode-versionJeremy Daer2017-01-305-10/+38
|\ \ \ | | | | | | | | Update Unicode Version to 9.0.0
| * | | Update Unicode Version to 9.0.0Fumiaki MATSUSHIMA2017-01-285-10/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9.0.0 was released on June 21, 2016 http://blog.unicode.org/2016/06/announcing-unicode-standard-version-90.html http://www.unicode.org/versions/Unicode9.0.0/ There are some changes about grapheme cluster in Unicode 9.0.0: http://unicode.org/reports/tr29/#Grapheme_Cluster_Boundary_Rules ------------ I noticed that `unpack_graphemes` returns [Other] when the argument is Other ÷ Prepend (it must be [Other, Prepend]). But in [Unicode 8.0.0's Prepend has no characters](http://www.unicode.org/reports/tr29/tr29-27.html#Prepend) so we don't have to backport following patch: ```diff should_break = + if pos == eoc + true ```
* | | | Ruby constant look-up no longer falls back to top-level since 2.5Akira Matsuda2017-01-301-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behavior used to warn until 2.4, and raises since 2.5. The test here was intentinally named not to start with "test_" and so it used not to be executed because this never passes, but now is should pass in trunk. https://bugs.ruby-lang.org/issues/11547 https://github.com/ruby/ruby/commit/44a2576f798b07139adde2d279e48fdbe71a0148 closes #19897
* | | | Missing require 'active_support/core_ext/hash/keys'Akira Matsuda2017-01-291-0/+1
|/ / / | | | | | | | | | | | | | | | Without this, the test causes a "method redefined" warning because * first it loads I18n and defines Hash#deep_symbolize_keys inside I18n's lib/i18n/core_ext/hash.rb * then it loads AS/core_ext/hash/keys.rb afterwards
* | / Fix broken sample code for EventedFileUpdateChecker [ci skip]kenta-s2017-01-281-1/+1
| |/ |/|
* | Uninterned Symbol can be duped since ruby 2.4.1Akira Matsuda2017-01-261-1/+4
| | | | | | | | | | | | https://github.com/ruby/ruby/commit/11e6bd5ac2a2eebfa589bd6db8c9c4daa337733e Leaving the 2.4.0 conditional for now, in order never to forget backporting r57407 to 2.4.1
* | Fix grammar 'an hyphen' -> 'a hyphen' [ci skip]kenta-s2017-01-251-1/+1
| |
* | This seems to be working on JRuby 9KAkira Matsuda2017-01-251-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | % ruby -ve "p 'ほげ'.encode(Encoding::UTF_8_MAC)" jruby 1.7.26 (1.9.3p551) 2016-08-26 69763b8 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_45-b14 +jit [darwin-x86_64] "\u307B\u3052" % ruby -ve "p 'ほげ'.encode(Encoding::UTF_8_MAC)" jruby 9.1.7.0 (2.3.1) 2017-01-11 68056ae Java HotSpot(TM) 64-Bit Server VM 25.45-b02 on 1.8.0_45-b14 +jit [darwin-x86_64] "\u307B\u3051\u3099" % ruby -ve "p 'ほげ'.encode(Encoding::UTF_8_MAC)" ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin14] "\u307B\u3051\u3099"
* | Merge pull request #27798 from yui-knk/give_message_to_test_duplicableRichard Schneeman2017-01-251-1/+1
|\ \ | | | | | | Give a message to `#test_duplicable` assertion
| * | Give a message to `#test_duplicable` assertionyui-knk2017-01-251-1/+1
| | | | | | | | | | | | | | | Giving a message helps us to know what happened when we look at Travis CI.
* | | Change ActionView ERB Handler from Erubis to ErubiJeremy Evans2017-01-252-2/+13
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Erubi offers the following advantages for Rails: * Works with ruby's --enable-frozen-string-literal option * Has 88% smaller memory footprint * Does no freedom patching (Erubis adds a method to Kernel) * Has simpler internals (1 file, <150 lines of code) * Has an open development model (Erubis doesn't have a public source control repository or bug tracker) * Is not dead (Erubis hasn't been updated since 2011) Erubi is a simplified fork of Erubis that contains just the parts that are generally needed (which includes the parts that Rails uses). The only intentional difference in behavior is that it does not include support for <%=== tags for debug output. That could be added to the ActionView ERB handler if it is desired. The Erubis template handler remains in a deprecated state so that code that accesses it directly does not break. It can be removed after Rails 5.1.
* / Fix sample code for `expand_cache_key` usage [ci skip]kenta-s2017-01-241-2/+2
|/
* Add module name to BacktraceCleaner usage example [ci skip]kenta-s2017-01-221-1/+1
|
* add missing comment out [ci skip]bogdanvlviv2017-01-201-1/+1
|
* add missing comment out [ci skip]yuuji.yaginuma2017-01-201-7/+7
|
* Allocation free Integer#to_sJean Boussier2017-01-192-16/+19
|
* Unused class for testing since 93559da4826546d07014f8cfa399b64b4a143127Akira Matsuda2017-01-181-16/+0
|
* rm rm_f that is not in useAkira Matsuda2017-01-181-5/+0
|
* Adjust `Module.parent_name` to work when frozen; fixes #27637Corey Ward2017-01-173-32/+41
|
* Use appropriate assertion based on expectationCorey Ward2017-01-171-2/+7
| | | | | | | This resolves a stern Minitest “warning” about an upcoming behavior change in MiniTest 6 that will result in the test failing. https://github.com/seattlerb/minitest/issues/666
* Don't pollute Object with rubinius_skip and jruby_skipAkira Matsuda2017-01-171-10/+10
| | | | we call them only in the tests
* All currently supported rubies already have LoadError#pathAkira Matsuda2017-01-171-12/+0
|
* :golf: else + if = elsifAkira Matsuda2017-01-171-10/+8
|
* CHANGELOG: Raise ArgumentError when calling transliterate on anything other ↵Kevin McPhillips2017-01-161-0/+5
| | | | than a string
* Raise ArgumentError if attempting to transliterate anything that is not a stringKevin McPhillips2017-01-162-0/+20
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 00:25:24 +0000