aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Fix typo in commentAndrew White2017-03-031-1/+1
|
* Deprecate implicit coercion of `ActiveSupport::Duration`Andrew White2017-03-024-6/+147
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `ActiveSupport::Duration` implicitly converts to a seconds value when used in a calculation except for the explicit examples of addition and subtraction where the duration is the receiver, e.g: >> 2 * 1.day => 172800 This results in lots of confusion especially when using durations with dates because adding/subtracting a value from a date treats integers as a day and not a second, e.g: >> Date.today => Wed, 01 Mar 2017 >> Date.today + 2 * 1.day => Mon, 10 Apr 2490 To fix this we're implementing `coerce` so that we can provide a deprecation warning with the intent of removing the implicit coercion in Rails 5.2, e.g: >> 2 * 1.day DEPRECATION WARNING: Implicit coercion of ActiveSupport::Duration to a Numeric is deprecated and will raise a TypeError in Rails 5.2. => 172800 In Rails 5.2 it will raise `TypeError`, e.g: >> 2 * 1.day TypeError: ActiveSupport::Duration can't be coerced into Integer This is the same behavior as with other types in Ruby, e.g: >> 2 * "foo" TypeError: String can't be coerced into Integer >> "foo" * 2 => "foofoo" As part of this deprecation add `*` and `/` methods to `AS::Duration` so that calculations that keep the duration as the receiver work correctly whether the final receiver is a `Date` or `Time`, e.g: >> Date.today => Wed, 01 Mar 2017 >> Date.today + 1.day * 2 => Fri, 03 Mar 2017 Fixes #27457.
* Update `DateTime#change` to support usec and nsecAndrew White2017-03-023-16/+45
| | | | | | | | | | | Adding support for these options now allows us to update the `DateTime#end_of` methods to match the equivalent `Time#end_of` methods, e.g: datetime = DateTime.now.end_of_day datetime.nsec == 999999999 # => true Fixes #21424.
* Use DEFAULT_CIPHER constant in MessageEncryptorLukas Zapletal2017-03-011-1/+1
|
* Add Duration#before and #after as aliases for #ago and #sinceNick Johnstone2017-02-263-0/+31
| | | | | | | | | | | | | | It's common in test cases at my job to have code like this: let(:today) { customer_start_date + 2.weeks } let(:earlier_date) { today - 5.days } With this change, we can instead write let(:today) { 2.weeks.after(customer_start_date) } let(:earlier_date) { 5.days.before(today) } Closes #27721
* AS CHANGELOG Pass [ci skip]Vipul A M2017-02-261-3/+3
|
* Fix typo `HashWithIndifferentAcces` to `HashWithIndifferentAccess` [ci skip]Ryuta Kamizono2017-02-251-1/+1
|
* Merge pull request #28157 from robin850/hwia-soft-deprecationMatthew Draper2017-02-253-0/+35
|\ | | | | | | Soft-deprecate the `HashWithIndifferentAccess` constant
| * Add few tests for the top level `HashWithIndifferentAccess`Robin Dupret2017-02-251-0/+24
| | | | | | | | | | This ensures that if we try to hard-deprecate it again in the future, we won't break these behaviors.
| * Soft-deprecate the top-level HashWithIndifferentAccess classRobin Dupret2017-02-253-0/+12
| | | | | | | | | | | | | | Since using a `ActiveSupport::Deprecation::DeprecatedConstantProxy` would prevent people from inheriting this class and extending it from the `ActiveSupport::HashWithIndifferentAccess` one would break the ancestors chain, that's the best option we have here.
* | Merge pull request #28006 from fareastside/masterRafael Mendonça França2017-02-243-2/+21
|\ \ | | | | | | | | | Allow ActiveSupport::MarshalWithAutoloading#load to take a Proc
| * | add optional second argument to ActiveSupport core extension for ↵Jeff Latz2017-02-243-2/+21
| |/ | | | | | | Marshal#load so it can take a proc
* | Fix CHANGELOG entry position [ci skip]Rafael Mendonça França2017-02-241-2/+3
| |
* | Add missing gzip footer check in ActiveSupport::Gzip.decompressDylan Thacker-Smith2017-02-243-1/+15
|/ | | | | | | | A gzip file has a checksum and length for the decompressed data in its footer which isn't checked by just calling Zlib::GzipReader#read. Calling Zlib::GzipReader#close must be called after reading to the end of the file causes this check to be done, which is done by Zlib::GzipReader.wrap after its block is called.
* Make HWIA#compact not return nil when no nilsPavel Pravosud2017-02-232-1/+11
|
* Preparing for 5.1.0.beta1 releaseRafael Mendonça França2017-02-232-1/+3
|
* 🙈 :nodoc: `AS::Duration::ISO8601Serializer`Godfrey Chan2017-02-231-1/+1
| | | This class should not be used directly, the public API is `AS::Duration#iso8601`.
* Add more missing requiresAndrew White2017-02-221-0/+1
| | | | Further missing requires for Timeout exposed due to Bundler 1.14.5
* Add missing requiresAndrew White2017-02-221-0/+4
| | | | | Bundler 1.14.5 moved to lazily loading 'rubygems/spec_fetcher' which revealed some missing requires from the JSON encoding test file.
* Add CHANGELOG entry for #28104Andrew White2017-02-221-0/+4
|
* Preload to_datetime before freezing a TimeWithZone instanceAdam Rice2017-02-222-1/+3
|
* Merge pull request #27941 from ↵Kasper Timm Hansen2017-02-201-2/+2
|\ | | | | | | | | y-yagi/prevent_multiple_values_being_set_to_run_via Prevent multiple values being set to `run_via`
| * Prevent multiple values being set to `run_via`yuuji.yaginuma2017-02-181-2/+2
| | | | | | | | | | When executing the test via rake, since `rake` is set for `run_via`, `ruby` should not be set. Related 2cb6c27310452da11b93d729c3b760ce988106e1
* | Revert "Merge pull request #27925 from robin850/hwia-removal"Kasper Timm Hansen2017-02-203-46/+1
| | | | | | | | | | | | | | | | | | Pointed out by @matthewd that the HWIA subclass changes the AS scoped class and top-level HWIA hierarchies out from under existing classes. This reverts commit 71da39097b67114329be6d8db7fe6911124531af, reversing changes made to 41c33bd4b2ec3f4a482e6030b6fda15091d81e4a.
* | Merge pull request #27863 from robin850/api-improvementsMatthew Draper2017-02-212-0/+4
|\ \ | | | | | | Some improvements to the API site's sidebar
| * | Avoid documenting private or external classesRobin Dupret2017-02-072-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are a lot of monkey patches inside the code base but there's no need to document external constants so let's remove them from the documentation Also, since there are monkey patches for some test cases classes, there were sometimes both documented and sneaked under the wrong section in the sidebar. Finally, for future references, the `active_support/vendor` folder has been originally ignored in https://git.io/vDqfA but no longer exists. [ci skip]
* | | Deprecate the top-level `HashWithIndifferentAccess` contantRobin Dupret2017-02-193-1/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | This constant was kept for the sake of backward compatibility; it is still available under `ActiveSupport::HashWithIndifferentAccess`. Furthermore, since Ruby 2.5 (https://bugs.ruby-lang.org/issues/11547) won't support top level constant lookup, people would have to update their code anyway.
* | | Fix doc in Multibyte::Chars [ci skip]kenta-s2017-02-171-4/+5
| | |
* | | Remove redundant namespaces from sample code of `deprecated_method_warning` ↵kenta-s2017-02-151-3/+3
| | | | | | | | | | | | [ci skip]
* | | Not ants were harmed! 🐜Mario Uher2017-02-141-1/+1
| | |
* | | Fix the return of `deprecate_methods` in doc [ci skip]kenta-s2017-02-141-1/+1
| | |
* | | Remove unused requireRyuta Kamizono2017-02-121-1/+0
| | | | | | | | | | | | | | | | | | These files are not using `strip_heredoc`. Closes #27976
* | | Also not needed on this file, call to `mattr_accessor` got removed in ↵Edouard CHIN2017-02-121-1/+0
| | | | | | | | | | | | https://github.com/rails/rails/commit/9e98f3f7e61dfce0a48948c8d296400af8bfaf21#diff-1ecd313ff0ab827af30014553cf8918dL76
* | | Merge pull request #27973 from kenta-s/add-missing-test-for-time-blankAndrew White2017-02-121-1/+1
|\ \ \ | | | | | | | | Add Time#blank? to blank_test
| * | | Add Time#blank? to blank_testkenta-s2017-02-121-1/+1
| | | |
* | | | Add `Style/EmptyLinesAroundMethodBody` in `.rubocop.yml` and remove extra ↵Ryuta Kamizono2017-02-122-2/+0
|/ / / | | | | | | | | | empty lines
* | / deprecate `halt_callback_chains_on_return_false` instead of ↵yuuji.yaginuma2017-02-083-16/+7
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | `halt_and_display_warning_on_return_false` `halt_and_display_warning_on_return_false` is not a public API and application is using `halt_callback_chains_on_return_false`. https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults.rb.tt#L29 https://github.com/rails/rails/blob/5-0-stable/activesupport/lib/active_support.rb#L86..L88 Therefore, deprecate messages should be issued for `halt_callback_chains_on_return_false` instead of `halt_and_display_warning_on_return_false`.
* | Remove unused code now that the deprecated file was removedRafael Mendonça França2017-02-071-2/+1
| |
* | Deprecate halt_and_display_warning_on_return_falseRafael Mendonça França2017-02-072-5/+16
| |
* | Remove deprecated behavior that halts callbacks when the return is falseRafael Mendonça França2017-02-073-52/+6
| |
* | Document that string in if and unless option of callbacks are deprecatedRafael Mendonça França2017-02-071-4/+4
| |
* | Improve the exception message to direct people to all the possible valuesRafael Mendonça França2017-02-071-1/+2
| |
* | Merge pull request #27608 from ↵Rafael França2017-02-073-58/+68
|\ \ | | | | | | | | | | | | kamipo/remove_deprecated_passing_string_to_define_callback Remove deprecated passing string to define callback
| * | Deprecate passing string to `:if` and `:unless` conditional options on ↵Ryuta Kamizono2017-02-043-4/+38
| | | | | | | | | | | | `set_callback` and `skip_callback`
| * | Remove deprecated passing string to define callbackRyuta Kamizono2017-02-043-55/+31
| | | | | | | | | | | | And raise `ArgumentError` when passing string to define callback.
* | | Merge pull request #27919 from bf4/correct_spellingArthur Nogueira Neves2017-02-065-6/+6
|\ \ \ | | | | | | | | Correct spelling
| * | | Correct spellingBenjamin Fleischer2017-02-055-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` go get -u github.com/client9/misspell/cmd/misspell misspell -w -error -source=text . ```
* | | | Add tests for `blank?`kenta-s2017-02-063-0/+12
|/ / /
* / / Docs: Correction: Module::DelegationErrorJared Beck2017-02-031-7/+9
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the delegation target is nil and the allow_nil option is not in use, a Module::DelegationError is raised. class C delegate :a, to: :b def b nil end end C.new.a # => Module::DelegationError: C#a delegated to b.a, but b is nil [ci skip]
* | explicitly require `listen` in `EventedFileUpdateCheckerTest` (#27867)Arthur Nogueira Neves2017-02-011-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, executing the `test_initialize_raises_an_ArgumentError_if_no_block_given` test alone will result in an error. ``` $ ./bin/test test/evented_file_update_checker_test.rb -n test_initialize_raises_an_ArgumentError_if_no_block_given Run options: -n test_initialize_raises_an_ArgumentError_if_no_block_given --seed 6692 # Running: E Error: EventedFileUpdateCheckerTest#test_initialize_raises_an_ArgumentError_if_no_block_given: NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen rails/activesupport/test/evented_file_update_checker_test.rb:21:in `teardown' ``` This is because if do not specify a file or directory for `EventedFileUpdateChecker`, do not require `listen`, and using listen method in teardown. https://github.com/rails/rails/blob/master/activesupport/lib/active_support/evented_file_update_checker.rb#L53..L65 Therefore, added listen's require to avoid errors.
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 01:42:03 +0000