aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | Rename subsecond_fraction_digits option to time_precisionAndrew White2014-01-263-8/+8
| | | | | | |
* | | | | | | Consolidate JSON encoding tests in one fileAndrew White2014-01-262-46/+48
| | | | | | |
* | | | | | | Customize subsecond digits when encoding DateWithTimeParker Selbert2014-01-263-9/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The subsecond fraction digits had been hardcoded to 3. This forced all timestamps to include the subsecond digits with no way to customize the value. While the subsecond format is part of the ISO8601 spec, it is not adhered to by all parsers (notably mobile clients). This adds the ability to customize the number of digits used, optionally setting them to 0 in order to eliminate the subsecond fraction entirely: ActiveSupport::JSON::Encoding.subsecond_fraction_digits = 0
* | | | | | | Maintain current timezone when changing time during DST overlapAndrew White2014-01-264-3/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently if a time is changed during DST overlap in the autumn then the method `period_for_local` will return the DST period. However if the original time is not DST then this can be surprising and is not what is generally wanted. This commit changes that behavior to maintain the current period if it's in the list of periods returned by `periods_for_local`. It is possible to alter the behavior of `period_for_local` by specifying a second argument but since we may be change from another time that could be either DST or not then this would give inconsistent results. Fixes #12163.
* | | | | | | Fix secrets.yml path in exception messageCarlos Antonio da Silva2014-01-201-9/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The file is config/secrets.yml, not config/initializers/secrets.yml.
* | | | | | | Merge pull request #13765 from robertomiranda/secrets_tokenGuillermo Iguaran2014-01-191-4/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Update Error Message when secrets.secret_key_base isn't given
| * | | | | | | Update Error Message when secrets.secret_key_base isn't givenrobertomiranda2014-01-191-4/+4
| | | | | | | |
* | | | | | | | set encoding to binmode for pipeAnna Carey2014-01-171-0/+2
|/ / / / / / /
* | | | | | | Consistence in the block styleRafael Mendonça França2014-01-172-5/+5
| | | | | | |
* | | | | | | Remove warnings on Ruby 2.1Rafael Mendonça França2014-01-172-1/+9
| | | | | | |
* | | | | | | Remove warningRafael Mendonça França2014-01-161-2/+2
| | | | | | |
* | | | | | | define the delegate methods on one line. fixes #13724Aaron Patterson2014-01-162-20/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | sup haters
* | | | | | | Revert "methods are defined right after the module_eval, so we don't need to do"Piotr Sarnacki2014-01-161-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change breaks tests in activesupport/test/core_ext/module_test.rb: * test_delegation_exception_backtrace * test_delegation_exception_backtrace_with_allow_nil This reverts commit 0167765e3f84260522bc2f32d926c1f5dd44957c.
* | | | | | | methods are defined right after the module_eval, so we don't need to doAaron Patterson2014-01-151-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | any line number maths
* | | | | | | Merge pull request #13709 from akshay-vishnoi/typoYves Senn2014-01-141-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [ci skip] Grammar correction
| * | | | | | | [ci skip] Grammar correctionAkshay Vishnoi2014-01-141-1/+1
| | | | | | | |
* | | | | | | | standardize on jruby_skip & rbx_skipGaurish Sharma2014-01-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This Adds helpers(jruby_skip & rbx_skip). In Future, Plan is to use these helpers instead of calls directly to RUBY_ENGINE/RbConfig/JRUBY_VERSION
* | | | | | | | Merge pull request #13646 from jenseng/json_escapeGodfrey Chan2014-01-121-12/+12
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Clarify behavior of json_escape [ci skip]
| * | | | | | | | Clarify behavior of json_escape, update examplesJon Jensen2014-01-091-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The behavior of json_escape was fixed in 2f1c5789, but the doc changes and example in that commit incorrectly indicated that the return value would be html-safe. Since quotation marks are preserved, the raw value is not safe to use in other contexts (specifically HTML attributes).
* | | | | | | | | Merge pull request #13668 from prathamesh-sonpatki/issue-13667Andrew White2014-01-122-2/+5
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix iterating over DateTime by doing strict checking for Time objects
| * | | | | | | | | Fix iterating over DateTime by doing strict checking for Time objectsPrathamesh Sonpatki2014-01-112-2/+5
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | - Fixes #13667
* / / / / / / / / Check `respond_to` before delegation due to: ↵Aaron Patterson2014-01-092-1/+6
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/ruby/ruby/commit/d781caaf313b8649948c107bba277e5ad7307314
* | | | | | | | Merge pull request #13632 from tinogomes/masterRafael Mendonça França2014-01-094-0/+53
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Adding Hash#compact and Hash#compact! methods
| * | | | | | | | Adding Hash#compact and Hash#compact! methodstinogomes2014-01-094-0/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Adding Hash#compact and Hash#compact! methods * Using Ruby 1.9 syntax on documentation * Updating guides for `Hash#compact` and `Hash#compact!` methods * Updating CHANGELOG for ActiveSupport * Removing unecessary protected method and lambda for `Hash#compact` implementations * Performing `Hash#compact` implementation - https://gist.github.com/tinogomes/8332883 * fixing order position * Fixing typo
* | | | | | | | | clear cache on body close so that cache remains during renderingAaron Patterson2014-01-082-2/+45
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes #13547 The body may use the local cache during rendering. `call`ing the app doesn't mean that rendering is finished, so we need to wait until `close` is called on the body.
* | | | | | | | Revert "Speedup String#to"Yves Senn2014-01-082-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3. As described in PR #13627 this commit broke functionality when passing a negative Fixnum to the `String#to` method: ```ruby assert_equal "hell", s.to(-2) ``` Before the revert, this failed with: ``` 1) Failure: StringAccessTest#test_#to_with_negative_Fixnum,_position_is_counted_from_the_end [test/core_ext/string_ext_test.rb:275]: Expected: "hell" Actual: nil ``` This revert is to keep the functionality on `master` working. If there is another way to get the performance benefit and keep the documented functionality we can add that. /cc @amatsuda @carlosantoniodasilva
* | | | | | | | typo fix in test name. [ci skip].Yves Senn2014-01-081-1/+1
| | | | | | | |
* | | | | | | | `core_ext/string/access.rb` test what we are documenting.Yves Senn2014-01-081-50/+89
| |_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I also extracted the tests from a single bulk method into a separate test-case. The new tests cover the API described in the docs. There are two skipped tests, which are broken as of 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3 * #to with negative Fixnum, position is counted from the end * #from and #to can be combined This was brought to my attention by #13627. Closes #13627.
* | | | | | | Add 'e' var on rescue DalliError, in order to log itArthur Neves2014-01-061-2/+2
| | | | | | |
* | | | | | | Fix typo in AS changelog, improve highlight [ci skip]Carlos Antonio da Silva2014-01-061-2/+2
| | | | | | |
* | | | | | | quick formatting pass through CHANGELOGS. [ci skip].Yves Senn2014-01-061-10/+15
| | | | | | |
* | | | | | | Add CHANGELOG entry for #10634 [ci skip]Andrew White2014-01-051-0/+17
| | | | | | |
* | | | | | | Merge pull request #10634 from teleological/time_advance_gregorianAndrew White2014-01-052-4/+13
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Maintain proleptic gregorian in Time#advance
| * | | | | | | Maintain proleptic gregorian in Time#advanceRiley Lynch2013-05-152-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Time#advance uses Time#to_date and Date#advance to calculate a new date. The Date object returned by Time#to_date is constructed with the assumption that the Time object represents a proleptic gregorian date, but it is configured to observe the default julian calendar reform date (2299161j) for purposes of calculating month, date and year: Time.new(1582, 10, 4).to_date.to_s # => "1582-09-24" Time.new(1582, 10, 4).to_date.gregorian.to_s # => "1582-10-04" This patch ensures that when the intermediate Date object is advanced to yield a new Date object, that the Time object for return is contructed with a proleptic gregorian month, date and year.
* | | | | | | | Raise if MemCacheStore doenst receive a Dalli objArthur Neves2014-01-033-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | :mem_cache_store should receive a list of hosts or a dalli client, otherwise raise it. Also adding a changelog.
* | | | | | | | mem_cache_store requires dalli, so only accept dalli/clientArthur Neves2014-01-032-14/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | :mem_cache_store require dalli, rescue Dalli exceptions, and follow Dalli API. Memcached gem, for instance, doesnt work anymore, as the API are different. As we already require one client, we should make sure that client works, and not accept others, and if someone wants to use another memcache client they can write their own store adapter.
* | | | | | | | Don't lazy load the tzinfo libraryAndrew White2014-01-012-19/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lazy loading the tzinfo library doesn't really buy us anything because the gem is installed as a dependency via the gemspec and if a developer is using Active Support outside of Rails then they can cherry pick which files to load anyway. Fixes #13553
* | | | | | | | update copyright notices to 2014. [ci skip]Vipul A M2014-01-012-2/+2
| | | | | | | |
* | | | | | | | Avoid raising a NameError on FreeBSD using DateRobin Dupret2014-01-012-2/+10
| |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Date object has a xmlschema method starting with Ruby 1.9 so we were assuming that we could safely remove this method and redefine it later but the call to remove_method throws a NameError on FreeBSD so we should rely on remove_possible_method instead. This call is actually needed to avoid warnings when running the test suite. Fixes #11723
* | | | | | | blank? and present? commit to return singletons [Xavier Noria & Pavel Pravosud]Xavier Noria2013-12-283-25/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The contract of blank? and present? was in principle to return Object, as we generally do, the test suite and description was consistent with that, but some examples had comments like "# => true". This cannot be unclear, we either fix the examples, or update the contract. Since users may be already assuming singletons due to the examples and the fact that they were returned before 30ba7ee, the safest option seems to be to revise the contract and the implementation of String#blank? The motivation for 30ba7ee was to improve the performance of the predicate, the refactor based on === is on par regarding speed. With this commit we start documenting return types using YARD conventions. We plan to document return types gradually.
* | | | | | | Extracted blank matcher regexp to constantPaul Nikitochkin2013-12-281-1/+3
| | | | | | |
* | | | | | | Update to Unicode 6.3.0Norman Clarke2013-12-272-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6.3.0 was released on September 30, 2013. http://unicode-inc.blogspot.com.ar/2013/09/announcing-unicode-standard-version-63.html
* | | | | | | Use String#scrub when available to tidy bytesNorman Clarke2013-12-261-35/+35
| | | | | | |
* | | | | | | Merge pull request #13436 from robin850/patch-11Guillermo Iguaran2013-12-211-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add missing changelog entries and fix few typos
| * | | | | | | Fix few typos in the documentation [ci skip]Robin Dupret2013-12-211-1/+1
| | | | | | | |
* | | | | | | | Fix typo [ci skip]Carlos Antonio da Silva2013-12-211-1/+1
|/ / / / / / /
* | | | | | | Fix AS::NumberHelper results with large precisionsKenta Murata & Akira Matsuda2013-12-203-7/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | before: ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50 => "3.14158999999999988261834005243144929409027099609375" after: ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50 => "3.14159000000000000000000000000000000000000000000000"
* | | | | | | Make sure multiline string is not accepted by the regexpRafael Mendonça França2013-12-192-2/+10
| | | | | | |
* | | | | | | Revert "revises the release notes about message verifiers [ci skip]"Xavier Noria2013-12-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 293a1a68992ba3e3e80f9f0f685e866ff79bf11a.
* | | | | | | revises the release notes about message verifiers [ci skip]Xavier Noria2013-12-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Example code does not run yet with beta1.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 14:01:39 +0000