| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ruby 2.4 introduces `Array#sum`, but it only supports numeric elements,
breaking our `Enumerable#sum` which supports arbitrary `Object#+`.
To fix, override `Array#sum` with our compatible implementation.
Native Ruby 2.4:
%w[ a b ].sum
# => TypeError: String can't be coerced into Fixnum
With `Enumerable#sum` shim:
%w[ a b ].sum
# => 'ab'
We tried shimming the fast path and falling back to the compatible path
if it fails, but that ends up slower even in simple causes due to the cost
of exception handling. Our only choice is to override the native `Array#sum`
with our `Enumerable#sum`.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
```ruby
ActiveSupport::Duration.parse('P3Y6M4DT12H30M5S')
(3.years + 3.days).iso8601
```
Inspired by Arnau Siches' [ISO8601 gem](https://github.com/arnau/ISO8601/)
and rewritten by Andrey Novikov with suggestions from Andrew White. Test
data from the ISO8601 gem redistributed under MIT license.
(Will be used to support the PostgreSQL interval data type.)
|
| |\
| |
| |
| | |
Fix forced cache miss for fetch when called without a block.
|
| | |
| |
| |
| |
| |
| | |
- Raised an argument error if no block is passed to #fetch with
'force: true' option is set.
- Added tests for the same.
|
| |\ \
| |/
|/| |
Document consistency [ci skip]
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Introduce weeks and hours periods to Duration.
Change 1.week to create a 1 week duration instead of 7 days and 1.hour
to create a 1 hour duration instead of 3600 seconds.
|
| |/ /
| |
| |
| | |
This is just to remove astonishment from getting `3600 seconds` from typing `1.hour`.
|
| |\ \
| | |
| | | |
Specify that behavior will be deprecated in Rails 5.1
|
| | |/ |
|
| |/ |
|
| |\
| |
| | |
Restore Hash#transform_keys behavior to always return a Hash instance
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
We are using compare_without_coercion.
|
| |\ \
| | |
| | | |
Lesser '.' objects for number helpers
|
| | | |
| | |
| | |
| | | |
do the same string manipulation. This was we avoid the duplicate strings with freeze and append modifies existing string
|
| | | |
| | |
| | |
| | | |
iteration of calling the helper. Eases on some memory bloat
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Note that the fact that mtimes in the future are ignore was documented
just a few lines above. Since we know this has to be done, and the code
is quite clear due to variable naming, I think we can get rid of the
comment in the middle of the loop and shorten it even further.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | |/
|/|
| |
| | |
ActiveSupport::FileUpdateChecker#max_mtime
|
| |/
|
|
|
|
|
|
|
|
| |
- we are ending sentences properly
- fixing of space issues
- fixed continuity issues in some sentences.
Reverts https://github.com/rails/rails/commit/8fc97d198ef31c1d7a4b9b849b96fc08a667fb02 .
This change reverts making sure we add '.' at end of deprecation sentences.
This is to keep sentences within Rails itself consistent and with a '.' at the end.
|
| | |
|
| |\
| |
| | |
Clean up after a failure in a run callback
|
| | |
| |
| |
| | |
Also, make sure to call the +complete+ hooks if +run+ fails.
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
mtsmfm/fix-marshal-with-autoloading-for-nested-class
Fix marshal with autoloading for nested class/module
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
#24150 break autoloading for nested class/module.
There is test for nested class but it doesn't work correctly.
Following code will autoload `ClassFolder::ClassFolderSubclass` before `Marshal.load`:
`assert_kind_of ClassFolder::ClassFolderSubclass, Marshal.load(dumped)`
|
| |\ \ \
| |_|/
|/| |
| | | |
`number_to_phone` formats number with regexp
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
By default, this method formats US number. This commit extends its
functionality to format number for other countries with a custom regular
expression.
number_to_phone(18812345678, pattern: /(\d{3})(\d{4})(\d{4})/)
# => 188-1234-5678
The output phone number is divided into three groups, so the regexp
should also match three groups of numbers.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously `String#to_time` returned the midnight of the current date
in some cases where there was no relavant information in the string.
Now the method returns `nil` instead in those cases.
Fixes #22958.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The native DateTime#<=> implementation can be used to compare instances
with numeric values being considered as astronomical julian day numbers
so we should call that instead of returning nil.
Fixes #24228.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the test run was interrupted in some way then it left temporary
directories inside of test causing the git worktree to be in a dirty
state. By overriding the run method we can use the block form of
Dir.mktmpdir to ensure that the directories are cleaned up no matter
which way the test run is exited.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The constant reference A::B used to trigger autoloading causes a warning
to be logged about the possible use of :: in a void context so assign it
to the _ variable to prevent the warnings from being triggered.
|
| |\ \ \ |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
s/symantically/semantically/
[ci skip]
|
| | |/ /
|/| |
| | |
| | |
| | | |
Because `DateTime` inherits `Date` and `Date` includes `DateAndTime::Zones`,
`DateTime` not need to include `DateAndTime::Zones` again.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| |\ \ \
| |_|/
|/| |
| | | |
Add upcase_first method
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | | |
mattr_writer to mattr_reader
|
| | | |
| | |
| | | |
renamed cattr_reader to mattr_reader
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
[ci skip]
Sync AV, AR, AJ, AS, AM changelogs with our 5.0 release notes draft.
This is a follow up to c94045d and contains changes made since the
release of beta1.
|
| | | | |
|
