aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
...
* | Fix grouped expression warning - `warning: (...) interpreted as grouped ↵Vipul A M2014-11-061-2/+2
| | | | | | | | expression`
* | Merge pull request #17526 from rishijain/update_docs_6Vijay Dev2014-11-062-0/+15
|\ \ | | | | | | Update docs 6
| * | added example of squish!, remove, test case for multiple occurrence ofRishi Jain2014-11-062-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | pattern removal added example for string#remove and test case for remove of multiple occurence of pattern removed extra whitespaces
* | | docs, synchronize 4.2. release notes. [ci skip]Yves Senn2014-11-061-3/+3
|/ / | | | | | | /cc @chancancode
* | Merge pull request #15956 from zuhao/refactor_activesupport_dependencies_testYves Senn2014-11-051-101/+124
|\ \ | | | | | | | | | Cleanup loaded features and constants after dependency tests.
| * | Cleanup loaded features and constants after dependency tests.Zuhao Wan2014-06-281-100/+116
| | |
* | | tests, add note about the usage of a specific timezone. Closes #17448.Yves Senn2014-11-051-1/+1
| | |
* | | Merge pull request #17515 from prathamesh-sonpatki/rm-requireYves Senn2014-11-052-2/+0
|\ \ \ | | | | | | | | Removed the unused require of proxy_object
| * | | Removed the unused require of proxy_object and test related to itPrathamesh Sonpatki2014-11-052-2/+0
| | | | | | | | | | | | | | | | | | | | - Reference : https://github.com/rails/rails/pull/17493#issuecomment-61739359 - Duration stopped inheriting from ProxyObject in https://github.com/rails/rails/pull/16574
* | | | Fix broken string_ext_test due to change in timezonePrathamesh Sonpatki2014-11-051-1/+1
|/ / / | | | | | | | | | | | | - Russian time was changed to UTC+3 from UTC+4 recently. This broke the string_to_ext test.
* | | fix typo [ci skip]Vijay Dev2014-11-041-1/+1
| | |
* | | fixed typo [ci skip]Rishi Jain2014-11-041-1/+1
| | |
* | | added example for hash slice method [ci skip]Rishi Jain2014-11-041-2/+8
| |/ |/|
* | Merge pull request #17487 from pabloh/avoid_allocationsRafael Mendonça França2014-11-031-1/+1
|\ \ | | | | | | Avoid unnecessary allocations and method calls
| * | Avoid unnecessary allocations/callsPablo Herrero2014-11-021-1/+1
| | |
* | | Merge pull request #17383 from rwz/string-removeRafael Mendonça França2014-11-033-8/+26
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Make `String#remove` and `String#remove!` accept multiple arguments Conflicts: activesupport/CHANGELOG.md
| * | Make `String#remove` and `String#remove!` accept multiple argumentsPavel Pravosud2014-10-253-8/+26
| | |
* | | Call gsub with a Regexp instead of a String for better performancePablo Herrero2014-11-011-1/+1
| | |
* | | Prepare for 4.2.0.beta4 releaseGodfrey Chan2014-10-301-1/+1
| | |
* | | Remove redundant `to_s` in interpolationclaudiob2014-10-301-1/+1
| | |
* | | Do gsub with a regexp instead of a stringPablo Herrero2014-10-293-3/+3
| | |
* | | edit pass over all warningsXavier Noria2014-10-283-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch uniformizes warning messages. I used the most common style already present in the code base: * Capitalize the first word. * End the message with a full stop. * "Rails 5" instead of "Rails 5.0". * Backticks for method names and inline code. Also, converted a few long strings into the new heredoc convention.
* | | Fix doc markup for `NumberHelper` [ci skip]Ryunosuke SATO2014-10-291-5/+5
| | | | | | | | | | | | | | | The character "*" is unnecessary in option candidates. This incorrect markup was injected in e8c9aeca .
* | | Optimize TimeWithZoneTest#strftimePablo Herrero2014-10-273-10/+16
| | |
* | | Prefix internal method with _Rafael Mendonça França2014-10-251-2/+2
| | | | | | | | | | | | This will avoid naming clash with user defined methods
* | | fixes circularity check in dependenciesXavier Noria2014-10-254-1/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The check for circular loading should depend on a stack of files being loaded at the moment, rather than the collection of loaded files. This showed up indirectly in #16468, where a misspelled helper would incorrectly result in a circularity error message. References #16468
* | | instance_eval is evilAkira Matsuda2014-10-251-1/+1
| | |
* | | Avoid creating range objects (take II)Akira Matsuda2014-10-251-1/+5
| | |
* | | Revert a change made to the example in 1ac4525Godfrey Chan2014-10-241-1/+1
| | | | | | | | | | | | | | | | | | | | | @carlosantoniodasilva pointed out that when `@person` is nil then this would blow up when you ended up calling `#first`on `nil`. > "there’s no way to break a try chain when you enter it :D" [ci skip]
* | | Include return value in examples added in #17378 [ci skip]Zachary Scott2014-10-241-2/+2
| | |
* | | Improved try documentation [ci skip]Eugene Gilburg2014-10-241-8/+25
|/ / | | | | | | | | | | | | | | | | | | - better `if` example - Added chaining example to the try method description - Documented the `respond_to?` check to the try method description - Clearer wording to explain that argument error is raised on argument mismatch to responding method, rather than to non-responding method (which is handled without exception by `try`) - `.any?` is more precise than `! .blank?` - Don't need to use `try` on `children` as (for regular associations) they will always be a collection or array that responds to `first` - Fix typos/grammar
* | Merge pull request #17377 from aripollak/dry-try-bangGodfrey Chan2014-10-231-10/+6
|\ \ | | | | | | DRY up try/try!
| * | DRY up try/try!Ari Pollak2014-10-231-10/+6
| | |
* | | Merge pull request #17369 from rails/secure_compareGuillermo Iguaran2014-10-233-12/+31
|\ \ \ | |/ / |/| | Secure compare
| * | Use AS secure_compare in AS::MessageVerifierGuillermo Iguaran2014-10-231-12/+2
| | |
| * | Add AS::SecurityUtils.secure_compare for constant time string comparisonGuillermo Iguaran2014-10-232-0/+29
| | |
* | | Reword documentation for `uncountable` [ci skip]Melanie Gilman2014-10-231-1/+1
|/ /
* | Update CHANGELOG and release notes for e98f2a7Godfrey Chan2014-10-221-2/+2
| |
* | Bring try! into parity with try.Ari Pollak2014-10-222-5/+9
| | | | | | | | Based on commit 5e51bdda.
* | Merge pull request #17302 from ↵Rafael Mendonça França2014-10-181-2/+2
| | | | | | | | | | | | claudiob/replace-slower-block-call-with-faster-yield Replace (slower) block.call with (faster) yield
* | Revert "Replace (slower) block.call with (faster) yield"Zachary Scott2014-10-181-2/+2
| | | | | | | | This reverts commit 0ab075e75f58bf403f7ebe20546c7005f35db1f6.
* | [ci skip] Add Doc of with_options for the case when inherited default ↵Pramod Sharma2014-10-181-1/+15
| | | | | | | | options and original options have same keys
* | Replace (slower) block.call with (faster) yieldclaudiob2014-10-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Performance optimization: `yield` with an implicit `block` is faster than `block.call`. See http://youtu.be/fGFM_UrSp70?t=10m35s and the following benchmark: ```ruby require 'benchmark/ips' def fast yield end def slow(&block) block.call end Benchmark.ips do |x| x.report('fast') { fast{} } x.report('slow') { slow{} } end # => fast 154095 i/100ms # => slow 71454 i/100ms # => # => fast 7511067.8 (±5.0%) i/s - 37445085 in 4.999660s # => slow 1227576.9 (±6.8%) i/s - 6145044 in 5.028356s ```
* | Add necessary 'require reverse_merge' to HAWI.rbclaudiob2014-10-172-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hashes with indifferent access should support `reverse_merge` out-of-the-box but they don't; for instance the following code fails: ```ruby require 'active_support' require 'active_support/hash_with_indifferent_access' hash = HashWithIndifferentAccess.new key: :old_value hash.reverse_merge key: :new_value ``` This PR fixes the case above by simply requiring `active_support/core_ext/hash/reverse_merge` in `hash_with_indifferent_access.rb` and adding a test that confirms the fix. --- Here are more details about the bugfix. Currently, `reverse_merge` is [defined in HashWithIndifferentAccess](https://github.com/rails/rails/blob/4e8ea13ba1a0870905a46fac5f232d9f41eef8a4/activesupport/lib/active_support/hash_with_indifferent_access.rb#L208) by invoking `super`, that is by invoking `Hash#reverse_merge`: ```ruby def reverse_merge(other_hash) super(self.class.new_from_hash_copying_default(other_hash)) end ``` However, Ruby's `Hash` does not have the `reverse_merge` by default: it must be added by ActiveSupport, and that requires the following line of code to be present: ```ruby require 'active_support/core_ext/hash/reverse_merge' ```
* | some changelog formatting. [ci skip]Yves Senn2014-10-161-8/+8
| |
* | specify protocol for external linksRobin Neumann2014-10-152-2/+2
| | | | | | | | to ensure correct parsing result of rdoc
* | Merge pull request #17230 from robertoz-01/masterRafael Mendonça França2014-10-131-1/+1
|\ \ | | | | | | atomic_write rescue also Errno::EACCES
| * | atomic_write rescue also Errno::EACCESRoberto Zanon2014-10-101-1/+1
| | | | | | | | | atomic_write rescue also Errno::EACCES on changing file permission. It could be raised with some type of filesystem
* | | Replace Enumerable#reverse.each with Enumerable#reverse_eachErik Michaels-Ober2014-10-132-3/+3
|/ /
* | Merge pull request #17184 from fillman/masterRafael Mendonça França2014-10-071-6/+17
|\ \ | | | | | | fix autoload tests
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 09:31:02 +0000