aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Add missing require so that DateTime has the right superclassAndrew White2013-07-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the DateTime core extensions were loaded before the Date core extensions then you would get a superclass mismatch as DateTime hasn't been defined yet so it gets set to Object by the acts_like core extension. Fixes #11206
* | | | Add failing test for #9562Andrew White2013-07-101-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails 4.0.0 fails when trying to encode an ActiveSupport::TimeWithZone that wraps a DateTime instance. This is fixed on master so add a test to prevent regression. (cherry picked from commit ad01b8da354268cebfae1519c28d19d75576ccb1)
* | | | Better not mutate the given options HashAkira Matsuda2013-07-101-3/+3
| | | |
* | | | Simplify Array#in_groups_of codeAkira Matsuda2013-07-101-3/+1
| | | |
* | | | Speed up Array#splitAkira Matsuda2013-07-101-6/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Benchmark: user system total real old 0.510000 0.000000 0.510000 ( 0.506749) new 0.330000 0.000000 0.330000 ( 0.336187)
* | | | Speed up String#truncateAkira Matsuda2013-07-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Benchmark: user system total real old 1.550000 0.040000 1.590000 ( 1.585866) new 1.250000 0.040000 1.290000 ( 1.287693)
* | | | Speed up AS::Inflector.underscoreAkira Matsuda2013-07-101-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Benchmark: user system total real old 6.090000 0.120000 6.210000 ( 6.202039) new 5.930000 0.110000 6.040000 ( 6.042022)
* | | | Speedup AS::Inflector.camelizeAkira Matsuda2013-07-101-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Benchmark: user system total real old 5.960000 0.020000 5.980000 ( 5.981754) new 5.740000 0.030000 5.770000 ( 5.757201)
* | | | Speedup AS::Inflector.deconstantizeAkira Matsuda2013-07-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Benchmark: user system total real old 0.740000 0.000000 0.740000 ( 0.744358) new 0.550000 0.000000 0.550000 ( 0.553690)
* | | | Speedup String#toAkira Matsuda2013-07-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Benchmark: 1000000.times { str.to(30) } user system total real old 0.490000 0.110000 0.600000 ( 0.607374) new 0.390000 0.000000 0.390000 ( 0.387306)
* | | | Return local time for backwards compatibilityAndrew White2013-07-093-10/+27
| | | |
* | | | Retain UTC offset when using Time.at_with_coercionAndrew White2013-07-093-3/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The standard Ruby behavior for Time.at is to return the same type of time when passing an instance of Time as a single argument. Since the an ActiveSupport::TimeWithZone instance may be a different timezone than the system timezone and DateTime just understands offsets the best we can do is to return an instance of Time with the correct offset. Fixes #11350.
* | | | Fix microsecond precision of Time#at_with_coercionNeer Friedman2013-07-092-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When Time.at_with_coercion (wraps Time.at) is called with a single argument that "acts_like?(:time)" it is coerced to integer thus losing it's microsecond percision. This commits changes this to use `#to_f` to prevent the problem
* | | | Explicitly test for true and false.Jade Tucker2013-07-071-2/+2
| | | |
* | | | cache.exists? should return true/falseJade Tucker2013-07-071-1/+1
| | | |
* | | | Make HashWithIndifferentAccess#select always return the hash.Marc Schütz2013-07-063-1/+12
|/ / / | | | | | | | | | | | | Hash#select! returns nil if the hash didn't change and thus behaves differently from select, so it's return value can't be used as result for the latter.
* | | Adding back deprecation require in all.rbRashmi Yadav2013-07-051-0/+1
| | |
* | | Revert "remove string based terminators for `ActiveSupport::Callbacks`."Yves Senn2013-07-052-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d108672dada7ba97d3b3b56f0c6001cea621061e. Conflicts: activesupport/CHANGELOG.md
* | | fix typo in Active Support CHANGELOG. [ci skip]Yves Senn2013-07-051-1/+1
| | |
* | | remove string based terminators for `ActiveSupport::Callbacks`.Yves Senn2013-07-052-6/+4
| | |
* | | Removed unsued deprecation requireRashmi Yadav2013-07-042-2/+0
| | |
* | | method transplanting between modules isn't supported on 1.9Aaron Patterson2013-07-031-0/+11
| | |
* | | Fixed test broken by local_constant_names Arun Agrawal2013-07-031-6/+0
| | | | | | | | | depreciation removed
* | | Remove deprecated `String#encoding_aware?` Arun Agrawal2013-07-034-15/+4
| | | | | | | | | core extensions (`core_ext/string/encoding`).
* | | Remove deprecated `Module#local_constant_names` Arun Agrawal2013-07-032-16/+4
| | | | | | | | | in favor of `Module#local_constants`
* | | Remove deprecated `DateTime.local_offset`Arun Agrawal2013-07-032-7/+4
| | |
* | | Remove deprecated Logger core extensions (core_ext/logger.rb)Carlos Antonio da Silva2013-07-033-68/+4
| | |
* | | Merge pull request #11265 from vipulnsward/deprecated_time_methodsYves Senn2013-07-033-90/+5
|\ \ \ | | | | | | | | Remove deprecated `Time` methods
| * | | Remove deprecated `Time#time_with_datetime_fallback`, `Time#utc_time`Vipul A M2013-07-033-90/+5
| | | | | | | | | | | | | | | | and `Time#local_time` in favour of `Time#utc` and `Time#local`
* | | | use American English: "favor" not "favour" [ci skip]Yves Senn2013-07-031-1/+1
|/ / / | | | | | | | | | according to http://guides.rubyonrails.org/api_documentation_guidelines.html#english
* | | Remove deprecated Hash#diff with no replacement.Carlos Antonio da Silva2013-07-024-23/+7
| | | | | | | | | | | | | | | If you're using it to compare hashes for the purpose of testing, please use MiniTest's assert_equal instead.
* | | Merge pull request #10909 from dockyard/masterCarlos Antonio da Silva2013-07-021-6/+6
|\ \ \ | |/ / |/| | Use symbols instead of strings in ActiveSupport::Concern
| * | Use symbols instead of stringsBrian Cardarella2013-06-101-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveSupport::Concern is used all over Rails This PR will only create 3 new objects as keys are never recreated and are not subject to garbage collection. The strings were being uniquely created and garbage collected. I don't have any performance numbers but this should be better than all of the GC.
* | | Remove deprecated `Date#to_time_in_current_zone`Vipul A M2013-07-023-22/+4
| | |
* | | Remove deprecated `Proc#bind` with no replacement.Carlos Antonio da Silva2013-07-014-32/+4
| | |
* | | Remove deprecated Array#uniq_by and Array#uniq_by!Carlos Antonio da Silva2013-07-014-50/+5
| | | | | | | | | | | | Use native Array#uniq and Array#uniq! instead.
* | | Remove deprecated AS::BasicObject, use AS::ProxyObject insteadCarlos Antonio da Silva2013-07-014-24/+4
| | |
* | | Add missing requireCarlos Antonio da Silva2013-07-011-0/+1
| | | | | | | | | | | | | | | | | | Commit cfa35c55bb38b27af305ad21408e181bc3cd739e removed the buffered_logger from AS, which required the logger file. Now we need to add the proper require here.
* | | remove deprecated `BufferedLogger`.Yves Senn2013-07-014-44/+4
| | |
* | | remove deprecated `assert_present` and `assert_blank`.Yves Senn2013-07-013-78/+4
| | |
* | | Further clean-up of ActiveSupport::CallbacksGenadi Samokovarov2013-07-011-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #11195 I noticed a trailing comma in the docs, but I decided to further clean it up. What I have done: * Clean up the trailing comma in the docs and some extra whitespace lines. * Used `Array#extract` options to factor the repetitive pattern of `args.last.is_a(Hash) ? ...` * Renamed the local var `config` to `options` in `define_callbacks`, as `options` seems to be the de facto name for the options objects. * Renamed the local var `l` to `line` in `define_callback` (maybe it meant `lambda` in the context) as single `l` may look like `1` in some fonts.
* | | unified the param names across all callbacks manipulation methodsSteven Yang2013-07-011-10/+10
| | | | | | | | | | | | | | | | | | | | | _ Rename the define_callbacks params to `names` - in order to match the naming conventions for `get_callbacks` and `set_callbacks` at https://github.com/rails/rails/blob/master/activesupport/lib/active_support/callbacks.rb#L736-743 - `define_callbacks` just register names(events), not define the real callback functions. - Rename the `reset_callbacks` params
* | | updated AS:Callbacks doc for terminator option in define_callbacks methodSteven Yang2013-06-301-3/+4
| | | | | | | | | | | | The change is commited at ba552764344bc0a3c25b8576ec11f127ceaa16da
* | | fix grammar, change 'an' to 'a' [ci skip]Prathamesh Sonpatki2013-06-271-3/+3
| | |
* | | Move delegation error constant to inside ModuleCarlos Antonio da Silva2013-06-262-3/+5
| | |
* | | Merge pull request #10828 from southpolesteve/delegation_error_classYves Senn2013-06-262-2/+4
|\ \ \ | | | | | | | | Create DelegationError class
| * | | Add DelegationError class. Rasied by delegation to a nil objectSteve Faulkner2013-06-262-2/+4
| | | |
* | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-06-261-1/+0
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/layout.html.erb
| * | | | Remove a comment related to 920753fRobin Dupret2013-06-261-1/+0
| | | | | | | | | | | | | | | Since 920753f, double assignment isn't used anymore
* | | | | Merge pull request #10542 from waseem/remove_requireCarlos Antonio da Silva2013-06-251-1/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove unnecessary require from active_support/inflector/methods.rb