Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | do not keep a reference to the chain in the callback objects | Aaron Patterson | 2013-05-10 | 1 | -12/+10 |
| | |||||
* | fix deprecation test | Aaron Patterson | 2013-05-10 | 1 | -0/+2 |
| | |||||
* | push merge code to the callback itself | Aaron Patterson | 2013-05-10 | 1 | -18/+10 |
| | |||||
* | dup the callback and set the chain | Aaron Patterson | 2013-05-10 | 1 | -8/+8 |
| | |||||
* | remove klass because it is not used | Aaron Patterson | 2013-05-10 | 1 | -9/+7 |
| | |||||
* | rename instance variables | Aaron Patterson | 2013-05-10 | 1 | -12/+14 |
| | |||||
* | push duplicates? logic to the instance | Aaron Patterson | 2013-05-10 | 1 | -16/+7 |
| | |||||
* | callback chain is in charge of the cache, so remove method based cache | Aaron Patterson | 2013-05-10 | 1 | -21/+0 |
| | |||||
* | __define_callbacks method is not necessary anymore | Aaron Patterson | 2013-05-10 | 1 | -8/+1 |
| | |||||
* | just run compiled callbacks since they are cached | Aaron Patterson | 2013-05-10 | 1 | -14/+4 |
| | |||||
* | cache compiled callbacks | Aaron Patterson | 2013-05-10 | 1 | -7/+27 |
| | |||||
* | use delegation over inheritance so we can figure when to cache / bust cache | Aaron Patterson | 2013-05-10 | 1 | -5/+22 |
| | |||||
* | fixing activemodel tests | Aaron Patterson | 2013-05-10 | 1 | -1/+2 |
| | |||||
* | use an environment object to hold state about the filter calls | Aaron Patterson | 2013-05-10 | 1 | -21/+41 |
| | |||||
* | object based callbacks cannot be duplicated | Aaron Patterson | 2013-05-10 | 1 | -7/+4 |
| | |||||
* | pass the run block as a normal variable to the rest of the callbacks | Aaron Patterson | 2013-05-10 | 1 | -12/+12 |
| | |||||
* | fixing more variable names | Aaron Patterson | 2013-05-10 | 1 | -10/+10 |
| | |||||
* | fix variable name | Aaron Patterson | 2013-05-10 | 1 | -6/+6 |
| | |||||
* | reduce the number of lambas | Aaron Patterson | 2013-05-10 | 1 | -5/+2 |
| | |||||
* | callback sequence is no longer used | Aaron Patterson | 2013-05-10 | 1 | -6/+0 |
| | |||||
* | no need for variable assignments, just pass the values in | Aaron Patterson | 2013-05-10 | 1 | -6/+2 |
| | |||||
* | make_lambda is never called with an Array | Aaron Patterson | 2013-05-10 | 1 | -2/+0 |
| | |||||
* | callbacks are wrapped with lambdas | Aaron Patterson | 2013-05-10 | 1 | -106/+76 |
| | |||||
* | remove dead code | Aaron Patterson | 2013-05-10 | 1 | -10/+0 |
| | |||||
* | fix method names | Aaron Patterson | 2013-05-10 | 1 | -40/+44 |
| | |||||
* | using lambas for the callback bodies | Aaron Patterson | 2013-05-10 | 1 | -32/+12 |
| | |||||
* | wrap all options in lambas | Aaron Patterson | 2013-05-10 | 1 | -7/+13 |
| | |||||
* | conditions in callbacks return consistent lambdas | Aaron Patterson | 2013-05-10 | 1 | -9/+43 |
| | |||||
* | Merge pull request #10535 from vipulnsward/remove_var | Carlos Antonio da Silva | 2013-05-09 | 1 | -1/+0 |
|\ | | | | | remove redundant var | ||||
| * | remove redundant var | Vipul A M | 2013-05-09 | 1 | -1/+0 |
| | | |||||
* | | Merge pull request #10531 from waseem/refactor_require | Carlos Antonio da Silva | 2013-05-09 | 1 | -4/+4 |
|\ \ | | | | | | | Require different core extensions correctly. | ||||
| * | | Require different core extensions correctly. | Waseem Ahmad | 2013-05-09 | 1 | -4/+4 |
| |/ | | | | | | | | | | | The begin rescue block is specifically to catch LoadError while loading i18n gem. Other core extensions, under active support, should be required outside of the begin rescue block. | ||||
* / | rails -> Rails [ci skip] | Prathamesh Sonpatki | 2013-05-09 | 2 | -2/+2 |
|/ | |||||
* | use public send on the scope parameters | Aaron Patterson | 2013-05-08 | 1 | -1/+1 |
| | |||||
* | add test for object conditional with scope | Aaron Patterson | 2013-05-08 | 1 | -0/+19 |
| | |||||
* | using strings as scopes is not used anywhere, so remove it | Aaron Patterson | 2013-05-08 | 1 | -1/+1 |
| | |||||
* | adding a class conditional test | Aaron Patterson | 2013-05-08 | 1 | -0/+12 |
| | |||||
* | adding tests for lambdas as conditions | Aaron Patterson | 2013-05-08 | 2 | -1/+41 |
| | |||||
* | separate identification computation | Aaron Patterson | 2013-05-08 | 1 | -24/+18 |
| | |||||
* | separate filters from source code | Aaron Patterson | 2013-05-08 | 1 | -20/+31 |
| | |||||
* | if the callbacks are not the same class, they cannot be duplicates | Aaron Patterson | 2013-05-08 | 1 | -2/+6 |
| | |||||
* | fix object comparison case | Aaron Patterson | 2013-05-08 | 1 | -1/+5 |
| | |||||
* | polymorphic comparison operator | Aaron Patterson | 2013-05-08 | 1 | -11/+24 |
| | |||||
* | we need to indicate the type of callback | Aaron Patterson | 2013-05-08 | 1 | -2/+2 |
| | |||||
* | Merge pull request #10355 from burke/master | Jeremy Kemper | 2013-05-08 | 1 | -39/+19 |
|\ | | | | | Use Ruby's native Encoding functionality to implement `tidy_bytes` | ||||
| * | Use ruby's Encoding support for tidy_bytes | Burke Libbey | 2013-05-08 | 1 | -39/+19 |
| | | | | | | | | | | | | | | | | | | | | The previous implementation was quite slow. This leverages some of the transcoding abilities built into Ruby 1.9 instead. It is roughly 96% faster. The roundtrip through UTF_8_MAC here is because ruby won't let you transcode from UTF_8 to UTF_8. I chose the closest encoding I could find as an intermediate. | ||||
* | | adding more tests around callback inconsistencies | Aaron Patterson | 2013-05-08 | 1 | -5/+47 |
| | | |||||
* | | refactor tests for more points | Aaron Patterson | 2013-05-08 | 1 | -4/+5 |
| | | |||||
* | | adding test to demonstrate inconsistencies in the AS::Callbacks api | Aaron Patterson | 2013-05-08 | 1 | -0/+41 |
|/ | |||||
* | dependency ActiveSupport::Deprecation | Tomohiko Himura | 2013-05-09 | 1 | -0/+2 |
| |