aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #17913 from claudiob/add-docs-to-time-with-zoneRafael Mendonça França2014-12-041-2/+23
|\ | | | | Add documentation to six AS::TimeWithZone methods [ci skip]
| * Add documentation to six AS::TimeWithZone methodsclaudiob2014-12-041-2/+23
| | | | | | | | [ci skip]
* | Fix MessageVerifier's #verified in CHANGELOGclaudiob2014-12-041-4/+4
|/ | | | | | | | [ci skip] As confirmed by @lleger (the author of `verified`) [in this comment](https://github.com/rails/rails/pull/17727#issuecomment-65488743): > Actually, it no longer returns false explicitly (bc8cc56), so I guess the CHANGELOG isn't totally accurate. It returns nil instead (but the functionality isn't practically different).
* Copy-edit the MessageVerifier documentation [ci skip]Rafael Mendonça França2014-12-041-7/+6
|
* Merge pull request #17905 from claudiob/add-doc-to-message-verifierRafael Mendonça França2014-12-041-4/+50
|\ | | | | Add documentation to MessageVerifier
| * Add documentation to MessageVerifierclaudiob2014-12-031-4/+50
| | | | | | | | | | | | | | | | [ci skip] Complements #17727 and closes ee73d9ff8. @lleger How do you feel about this?
* | Remove "rescue" clause around "require 'openssl'"claudiob2014-12-032-22/+4
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some `require 'openssl'` statements were surrounded by `rescue` blocks to deal with Ruby versions that did not support `OpenSSL::Digest::SHA1` or `OpenSSL::PKCS5`. [As @jeremy explains](https://github.com/rails/rails/commit/a6a0904fcb12b876469c48b1c885aadafe9188cf#commitcomment-8826666) in the original commit: > If jruby didn't have jruby-openssl gem, the require wouldn't work. Not sure whether either of these are still relevant today. According to the [release notes for JRuby 1.7.13](http://www.jruby.org/2014/06/24/jruby-1-7-13.html): > jruby-openssl 0.9.5 bundled which means the above `rescue` block is not needed anymore. All the Ruby versions supported by the current version of Rails provide those OpenSSL libraries, so Travis CI should also be happy by removing the `rescue` blocks. --- Just to confirm, with JRuby: $ ruby --version #=> jruby 1.7.16.1 (1.9.3p392) 2014-10-28 4e93f31 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_20-b26 +jit [darwin-x86_64] $ irb irb(main):001:0> require 'openssl' #=> true irb(main):002:0> OpenSSL::Digest::SHA1 #=> OpenSSL::Digest::SHA1 irb(main):003:0> OpenSSL::PKCS5 # => OpenSSL::PKCS5 And with Ruby 2.1: $ ruby --version #=> ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0] $ irb irb(main):001:0> require 'openssl' #=> true irb(main):002:0> OpenSSL::Digest::SHA1 #=> OpenSSL::Digest::SHA1 irb(main):003:0> OpenSSL::PKCS5 #=> OpenSSL::PKCS5
* Add some FIXME notes about documentation [ci skip]Rafael Mendonça França2014-12-021-0/+4
|
* Prefer object/nil over `true`/`false`Rafael Mendonça França2014-12-021-6/+4
| | | | | | | | | | | This is the project guideline and the reasons are: * That follows standard Ruby semantics. * Allows the implementation to avoid artificial code like !! or something ? true : false * You do not need to rely on the exact type of 3rd party code. For example, if your method returns str.end_with?('foo') you do not need to make sure end_with? returns a singleton. Your predicate just propagates predicate semantics up regardless of what end_with? returns.
* Add `#verified` and `#valid_message?` to MessageVerifierLogan Leger2014-12-013-22/+47
| | | | | | | | | | | This commit adds a `#verified` method to `ActiveSupport::MessageVerifier` which will return either `false` when it encounters an error or the message. `#verify` continues to raise an `InvalidSignature` exception on error. This commit also adds a convenience boolean method on `MessageVerifier` as a way to check if a message is valid without performing the decoding.
* Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-2917-28/+24
|
* Merge pull request #17816 from byroot/prevent-numeric-to-s-to-allocate-an-arrayRafael Mendonça França2014-11-292-16/+25
|\ | | | | Prevent Numeric#to_s from allocating an array
| * Prevent Numeric#to_s from allocating an arrayJean Boussier2014-11-282-16/+25
| |
* | Bump required Ruby version to 2.1.0claudiob2014-11-281-1/+1
| | | | | | | | | | | | | | | | | | [This article](http://weblog.rubyonrails.org/2014/8/20/Rails-4-2-beta1/#maintenance-consequences-and-rails-5-0) states that: > Rails 5.0 is in most likelihood going to target Ruby 2.2. Before the exact minimum version is fully decided, @arthurnn [suggests](https://github.com/rails/rails/pull/17830#issuecomment-64940383) that **at least** version 2.1.0 **must** be required by the `gemspec` files.
* | fixed indent of end in jdom.rbbigtone12842014-11-281-1/+1
| |
* | Start Rails 5 development :tada:Rafael Mendonça França2014-11-282-391/+4
|/ | | | | | | We will support only Ruby >= 2.1. But right now we don't accept pull requests with syntax changes to drop support to Ruby 1.9.
* Document `String#html_safe` [ci skip]Sean Griffin2014-11-241-0/+5
| | | | | | It should be part of the documented public API, since we have an entire section of the guides dedicated to it. Documented in a way that addresses the concerns which kept it undocumented in the past.
* Update to Unicode 7.0.0Benjamin Fleischer2014-11-152-1/+1
| | | | | | | | 7.0.0 was released on June 16, 2014 http://unicode-inc.blogspot.com.ar/2014/10/unicode-version-70-complete-text-of.html ruby bin/generate_tables
* Abstract encoding strategy for ActiveSupport::MessageVerifierRyan Mohr2014-11-121-2/+10
|
* Merge pull request #17047 from betesh/masterRafael Mendonça França2014-11-111-0/+1
|\ | | | | Time includes DateAndTime::Zones acts_like(:time)
| * Time includes DateAndTime::Zones acts_like(:time)betesh2014-11-091-0/+1
| |
* | dependencies.rb: keep the decorated #load and #require private [closes #17553]Xavier Noria2014-11-103-13/+36
| |
* | added description for rails generators, and fixed sentence formation for ↵Rishi Jain2014-11-101-1/+1
|/ | | | active_support/notifications [ci skip]
* Merge pull request #17493 from petewest/duration-comparableAaron Patterson2014-11-072-0/+14
|\ | | | | Delegate comparison operator to value
| * Delegate comparison operator to valuePeter West2014-11-032-0/+14
| |
* | added example of hash#except, and removed extra whitespaces [ci skip]Rishi Jain2014-11-072-5/+11
| |
* | Fix grouped expression warning - `warning: (...) interpreted as grouped ↵Vipul A M2014-11-061-2/+2
| | | | | | | | expression`
* | Merge pull request #17526 from rishijain/update_docs_6Vijay Dev2014-11-062-0/+15
|\ \ | | | | | | Update docs 6
| * | added example of squish!, remove, test case for multiple occurrence ofRishi Jain2014-11-062-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | pattern removal added example for string#remove and test case for remove of multiple occurence of pattern removed extra whitespaces
* | | docs, synchronize 4.2. release notes. [ci skip]Yves Senn2014-11-061-3/+3
|/ / | | | | | | /cc @chancancode
* | Merge pull request #15956 from zuhao/refactor_activesupport_dependencies_testYves Senn2014-11-051-101/+124
|\ \ | | | | | | | | | Cleanup loaded features and constants after dependency tests.
| * | Cleanup loaded features and constants after dependency tests.Zuhao Wan2014-06-281-100/+116
| | |
* | | tests, add note about the usage of a specific timezone. Closes #17448.Yves Senn2014-11-051-1/+1
| | |
* | | Merge pull request #17515 from prathamesh-sonpatki/rm-requireYves Senn2014-11-052-2/+0
|\ \ \ | | | | | | | | Removed the unused require of proxy_object
| * | | Removed the unused require of proxy_object and test related to itPrathamesh Sonpatki2014-11-052-2/+0
| | | | | | | | | | | | | | | | | | | | - Reference : https://github.com/rails/rails/pull/17493#issuecomment-61739359 - Duration stopped inheriting from ProxyObject in https://github.com/rails/rails/pull/16574
* | | | Fix broken string_ext_test due to change in timezonePrathamesh Sonpatki2014-11-051-1/+1
|/ / / | | | | | | | | | | | | - Russian time was changed to UTC+3 from UTC+4 recently. This broke the string_to_ext test.
* | | fix typo [ci skip]Vijay Dev2014-11-041-1/+1
| | |
* | | fixed typo [ci skip]Rishi Jain2014-11-041-1/+1
| | |
* | | added example for hash slice method [ci skip]Rishi Jain2014-11-041-2/+8
| |/ |/|
* | Merge pull request #17487 from pabloh/avoid_allocationsRafael Mendonça França2014-11-031-1/+1
|\ \ | | | | | | Avoid unnecessary allocations and method calls
| * | Avoid unnecessary allocations/callsPablo Herrero2014-11-021-1/+1
| | |
* | | Merge pull request #17383 from rwz/string-removeRafael Mendonça França2014-11-033-8/+26
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Make `String#remove` and `String#remove!` accept multiple arguments Conflicts: activesupport/CHANGELOG.md
| * | Make `String#remove` and `String#remove!` accept multiple argumentsPavel Pravosud2014-10-253-8/+26
| | |
* | | Call gsub with a Regexp instead of a String for better performancePablo Herrero2014-11-011-1/+1
| | |
* | | Prepare for 4.2.0.beta4 releaseGodfrey Chan2014-10-301-1/+1
| | |
* | | Remove redundant `to_s` in interpolationclaudiob2014-10-301-1/+1
| | |
* | | Do gsub with a regexp instead of a stringPablo Herrero2014-10-293-3/+3
| | |
* | | edit pass over all warningsXavier Noria2014-10-283-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch uniformizes warning messages. I used the most common style already present in the code base: * Capitalize the first word. * End the message with a full stop. * "Rails 5" instead of "Rails 5.0". * Backticks for method names and inline code. Also, converted a few long strings into the new heredoc convention.
* | | Fix doc markup for `NumberHelper` [ci skip]Ryunosuke SATO2014-10-291-5/+5
| | | | | | | | | | | | | | | The character "*" is unnecessary in option candidates. This incorrect markup was injected in e8c9aeca .
* | | Optimize TimeWithZoneTest#strftimePablo Herrero2014-10-273-10/+16
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 23:54:32 +0000