aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Make dependencies.rb add a name to NameErrorArthur Neves2014-06-202-4/+7
| | |
* | | Merge pull request #15799 from ↵Yves Senn2014-06-1810-122/+47
|\ \ \ | | | | | | | | | | | | | | | | zuhao/refactor_activesupport_time_zone_test_helpers Extract out with_env_tz helper method.
| * | | Extract out with_env_tz helper method.Zuhao Wan2014-06-1810-122/+47
| | | | | | | | | | | | | | | | | | | | It’s used at so many places that extracting it out into a helper file is worth doing.
* | | | Fix documentation from #15669 [ci skip]Zachary Scott2014-06-171-3/+5
| | | |
* | | | [ci skip] fix doc for the Hash#assert_valid_keysAditya Kapoor2014-06-171-3/+3
| | | |
* | | | Move test teardown into `ensure` block.Zuhao Wan2014-06-171-1/+2
|/ / /
* | | Formatting fix in AS changelog [ci skip]Juanjo Bazán2014-06-161-2/+5
| | |
* | | Merge pull request #15684 from aditya-kapoor/add-tests-for-assert-valid-keysRafael Mendonça França2014-06-161-0/+15
|\ \ \ | | | | | | | | Add test cases for Hash#asset_valid_keys
| * | | Add test cases for Hash#asset_valid_keysAditya Kapoor2014-06-141-0/+15
| | | |
* | | | remove unnecessary calling of `I18n.backend.store_translations(empty, {})`Kuldeep Aggarwal2014-06-152-13/+4
| | | | | | | | | | | | | | | | | | | | Clean up I18n stored translations after test continuation with #15714
* | | | Merge pull request #15679 from akshay-vishnoi/test-casesRafael Mendonça França2014-06-131-1/+19
|\ \ \ \ | |/ / / |/| | | Add missing test cases for #assert_no_difference
| * | | Add missing test cases for #assert_no_differenceAkshay Vishnoi2014-06-131-1/+19
| | | |
* | | | Merge pull request #15680 from akshay-vishnoi/doc_changesSean Griffin2014-06-121-1/+1
|\ \ \ \ | | | | | | | | | | [ci skip] BigDecimal#duplicable? returns false in 1.9.x
| * | | | [ci skip] BigDecimal#duplicable? returns false in 1.9.xAkshay Vishnoi2014-06-131-1/+1
| |/ / /
* / / / [ci skip] Correct output of #assert_notAkshay Vishnoi2014-06-121-1/+1
|/ / /
* | | Revert "remove unnecssary require of `to_param`, as `to_query` is already ↵Rafael Mendonça França2014-06-114-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | require `to_param`" Revert "No need to require to_param, it is already required in to_query.rb" This reverts commits ccdd97662e1fb00c23c90d59f65c091904959561 and d697ee14264a90a39cdbe87857656d8b314ac9b7. Reason by @jeremy: These requires are not for implementation dependency. They ensure that requiring array conversions provides to_query, to_param, and other array conversion behaviors. The fact that to_query is implemented in terms of to_param is just a coincidence. If to_query removed its to_param require, then someone requiring array conversions would no longer have to_param available. This change removes these intentional dependencies on to_param in favor of implementation side effects—an undesirable move that's susceptible to regression.
* | | remove unnecssary require of `to_param`, as `to_query` is already require ↵Kuldeep Aggarwal2014-06-123-3/+0
| | | | | | | | | | | | `to_param`
* | | No need to require to_param, it is already required in to_query.rbAkshay Vishnoi2014-06-111-1/+0
| | |
* | | Move test for blank.rb under objectAkshay Vishnoi2014-06-111-0/+0
| | |
* | | Merge pull request #15628 from akshay-vishnoi/test-casesYves Senn2014-06-111-0/+4
|\ \ \ | | | | | | | | Add test cases for #in? and #presence_in
| * | | Add test cases for #in? and #presence_inAkshay Vishnoi2014-06-111-0/+4
| |/ /
* | | remove deprecated code. Rely on `describe` provided by minitestAaron Patterson2014-06-101-24/+0
| | |
* | | Merge pull request #15616 from apanzerj/fix_long_key_pathsRafael Mendonça França2014-06-103-0/+13
|\ \ \ | | | | | | | | fix error with long keys in ActiveSupport::Cache::FileStore
| * | | fix error with long keys in ActiveSupport::Cache::FileStoreAdam Panzer2014-06-103-0/+13
| |/ /
* / / [ci skip] Add Docs for strip_insignificant_zeros option in number helpersAkshay Vishnoi2014-06-101-8/+7
|/ /
* | [ci skip] Correct output and use valid options of number helpersAkshay Vishnoi2014-06-101-2/+2
| |
* | Fix bug that make HashWithIndifferentAccess work differently of HashRafael Mendonça França2014-06-092-1/+9
| | | | | | | | | | Before HashWithIndifferentAccess were doing deep_dup of the inner hashes when Hash doesn't do. Now both are behaving in the same way.
* | Add Missing Test Cases for the constantizeAditya Kapoor2014-06-071-0/+11
| |
* | Merge pull request #15421 from gchan/time_with_zone_precisionMatthew Draper2014-06-053-1/+36
|\ \ | | | | | | | | | Fixed `ActiveSupport::TimeWithZone#-` so precision is not unnecessarily lost
| * | Fixed `ActiveSupport::TimeWithZone#-` so precision is not unnecessarily lostGordon Chan2014-05-303-1/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When working with objects with a nanosecond component, the `-` method may unnecessarily cause loss of precision. `ActiveSupport::TimeWithZone#-` should return the same result as if we were using `Time#-`: Time.now.end_of_day - Time.now.beginning_of_day #=> 86399.999999999 Before: Time.zone.now.end_of_day.nsec #=> 999999999 Time.zone.now.end_of_day - Time.zone.now.beginning_of_day #=> 86400.0 After: Time.zone.now.end_of_day - Time.zone.now.beginning_of_day #=> 86399.999999999
* | | Correct result, previously showing wrong resultAkshay Vishnoi2014-06-041-1/+1
| | |
* | | Merge pull request #15447 from akshay-vishnoi/test-casesRafael Mendonça França2014-06-031-0/+8
|\ \ \ | | | | | | | | Test `except!` in other cases too
| * | | Test `except!` in other cases tooAkshay Vishnoi2014-05-311-0/+8
| | | |
* | | | drastically reduce object allocationsAaron Patterson2014-06-021-6/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | before this change, we were allocating AS::SafeBuffer objects that were being interpolated in to a string, so the safe buffer object was being thrown away. This change only allocates a string (vs a string *and* a safebuffer) and interpolates the string. On my test application, this reduced the AS::SafeBuffer objects from 1527k per request to about 500 per request.
* | | | reduce AS::SafeBuffer allocationsAaron Patterson2014-06-021-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | html_escape_interpolated_argument is only used in mutation methods: https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L174 https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L179 The return value doesn't need to be converted to an AS::SafeBuffer since we know that the current object is an AS::SafeBuffer and will be mutated, and the return value from html_escape_interpolated_argument will be thrown away
* | | | concat is a hotspot (via AV#append=), so just directly define the methodsAaron Patterson2014-06-021-4/+6
| | | |
* | | | Merge pull request #15379 from xuanxu/rational_precisionRafael Mendonça França2014-06-023-5/+16
|\ \ \ \ | | | | | | | | | | Fix AS::NumberHelper results with rationals
| * | | | Fix AS::NumberHelper results with rationalsJuanjo Bazán2014-05-313-5/+16
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | :precision was incorrectly being applied to Rationals before: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.3" after: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.33"
* | | | Merge pull request #15464 from tgxworld/improve_notifications_logicMatthew Draper2014-06-032-8/+18
|\ \ \ \ | | | | | | | | | | Improvements to ActiveSupport::Notifications.
| * | | | Avoid looping through subscribers when unsubscribing with a subscriber object.Guo Xiang Tan2014-06-011-5/+10
| | | | |
| * | | | Update documentation to reflect unsubscription with name.Guo Xiang Tan2014-06-012-4/+9
| | | | |
* | | | | Feature requests should be made on the mailing list, not submitted toZachary Scott2014-06-011-1/+6
|/ / / / | | | | | | | | | | | | the issue tracker. See also #15455 [ci skip]
* / / / [ci skip] Correct output of Hash#symbolize_keysAkshay Vishnoi2014-05-311-2/+2
|/ / /
* | | Tiny formatting fix in AS change log [ci skip]Robin Dupret2014-05-311-4/+4
| | |
* | | [ci skip] Correct documentation of HashWithIndifferentAccess#dupAkshay Vishnoi2014-05-311-2/+2
| | |
* | | HashWithIndifferentAccess#dup doc [ci skip]James Blanding2014-05-301-1/+8
| | | | | | | | | | | | | | | The phrase "exact copy" in the existing docmentation is somewhat misleading.
* | | Merge pull request #15313 from ↵Rafael Mendonça França2014-05-301-0/+8
|\ \ \ | | | | | | | | | | | | | | | | andreychernih/time-with-zone-string-conversion-speed-up Speed-up TimeWithZone to String conversion
| * | | Speed-up TimeWithZone to String conversionAndrey Chernih2014-05-271-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've noticed that `String(model.created_at)` is performing poorly in comparision with other fields. The source of the problem is a way `Kernel#String` works: it first tries to call `to_str` (which causes `NoMethodError` in `method_missing`) and then calls `to_s`. Performance tests: tz = Time.zone.now Benchmark.ips do |x| x.report { String(tz) } end Without this code: Calculating ------------------------------------- 572 i/100ms ------------------------------------------------- 10177.7 (±18.2%) i/s - 48620 in 5.000325s With this code: Calculating ------------------------------------- 1518 i/100ms ------------------------------------------------- 138984.2 (±10.1%) i/s - 677028 in 4.974897s
* | | | :scissors: removed deprecated `Numeric#ago` and friendsGodfrey Chan2014-05-303-62/+15
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replacements: 5.ago => 5.seconds.ago 5.until => 5.seconds.until 5.since => 5.seconds.since 5.from_now => 5.seconds.from_now The removed tests does not affect coverage – we have equivalent test cases in the tests for `AS::Duration`. See #12389 for the history and rationale behind this.
* | | Merge pull request #12080 from ShayDavidson/fix_datetime_partial_datesMatthew Draper2014-05-283-1/+31
|\ \ \ | | | | | | | | | | | | Added partial days support to `DateTime`'s `advance` method.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-30 05:15:00 +0000