aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* blank? and present? commit to return singletons [Xavier Noria & Pavel Pravosud]Xavier Noria2013-12-283-25/+57
| | | | | | | | | | | | | | | | | | The contract of blank? and present? was in principle to return Object, as we generally do, the test suite and description was consistent with that, but some examples had comments like "# => true". This cannot be unclear, we either fix the examples, or update the contract. Since users may be already assuming singletons due to the examples and the fact that they were returned before 30ba7ee, the safest option seems to be to revise the contract and the implementation of String#blank? The motivation for 30ba7ee was to improve the performance of the predicate, the refactor based on === is on par regarding speed. With this commit we start documenting return types using YARD conventions. We plan to document return types gradually.
* Extracted blank matcher regexp to constantPaul Nikitochkin2013-12-281-1/+3
|
* Update to Unicode 6.3.0Norman Clarke2013-12-272-1/+1
| | | | | | 6.3.0 was released on September 30, 2013. http://unicode-inc.blogspot.com.ar/2013/09/announcing-unicode-standard-version-63.html
* Use String#scrub when available to tidy bytesNorman Clarke2013-12-261-35/+35
|
* Merge pull request #13436 from robin850/patch-11Guillermo Iguaran2013-12-211-1/+1
|\ | | | | Add missing changelog entries and fix few typos
| * Fix few typos in the documentation [ci skip]Robin Dupret2013-12-211-1/+1
| |
* | Fix typo [ci skip]Carlos Antonio da Silva2013-12-211-1/+1
|/
* Fix AS::NumberHelper results with large precisionsKenta Murata & Akira Matsuda2013-12-203-7/+62
| | | | | | | | | before: ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50 => "3.14158999999999988261834005243144929409027099609375" after: ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50 => "3.14159000000000000000000000000000000000000000000000"
* Make sure multiline string is not accepted by the regexpRafael Mendonça França2013-12-192-2/+10
|
* Revert "revises the release notes about message verifiers [ci skip]"Xavier Noria2013-12-191-1/+1
| | | | This reverts commit 293a1a68992ba3e3e80f9f0f685e866ff79bf11a.
* revises the release notes about message verifiers [ci skip]Xavier Noria2013-12-191-1/+1
| | | | Example code does not run yet with beta1.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-12-204-10/+10
|\
| * fixed typo mistake time_formats.rb -> date_formats.rb [ci skip]Kuldeep Aggarwal2013-12-101-1/+1
| |
| * Typos. return -> returns. [ci skip]Lauro Caetano2013-12-034-10/+10
| |
* | Merge pull request #13406 from hincupetru/masterRafael Mendonça França2013-12-192-1/+7
|\ \ | | | | | | Fixed configurable.rb regular expression name check
| * | Fixed configurable.rb regular expression name checkHincu Petru2013-12-192-1/+7
| | |
* | | Merge pull request #13401 from akshay-vishnoi/refactorRafael Mendonça França2013-12-192-9/+13
|\ \ \ | |/ / |/| | Prevent creation of instance methods when `instance_reader = false`, Grammar checks, Conditional statements combined
| * | Prevent creation of instance methods when `instance_reader = false`, Grammar ↵Akshay Vishnoi2013-12-192-9/+13
| | | | | | | | | | | | checks, Conditional statements combined
* | | Prefer assert_raise instead of flunk + rescue to test for exceptionsCarlos Antonio da Silva2013-12-195-48/+31
| | | | | | | | | | | | | | | | | | Change most tests to make use of assert_raise returning the raised exception rather than relying on a combination of flunk + rescue to check for exception types/messages.
* | | Fix asserting the correct exception message in dependencies testCarlos Antonio da Silva2013-12-191-2/+2
|/ / | | | | | | | | | | | | | | | | | | In Minitest, the second argument of assert_raise(s) accepts a string as the message that should be shown in case of a failure in the assertion (eg nothing was raised when it should), and not the exception message to be matched. To do that we need to save the exception returned from assert_raise(s) into a local variable and check for the exception message using it.
* | Unused classes in AS testsAkira Matsuda2013-12-194-30/+0
| |
* | Merge pull request #13400 from nishant-cyro/docsGuillermo Iguaran2013-12-181-1/+1
|\ \ | | | | | | fix typos and grammar mistake [ci skip]
| * | fix typos and grammar mistake [ci skip]nishant-cyro2013-12-191-1/+1
| | |
* | | Merge pull request #13366 from vipulnsward/minitest-namespace-changeGodfrey Chan2013-12-182-5/+5
|\ \ \ | | | | | | | | Change all `MiniTest` to `Minitest`
| * | | Change all `MiniTest` to `Minitest` since, `MiniTest` namespace has been ↵Vipul A M2013-12-182-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | renamed to `Minitest` Ref: https://github.com/seattlerb/minitest/blob/master/History.txt
* | | | Unused classes in test caseAkira Matsuda2013-12-191-25/+0
| | | |
* | | | Merge pull request #13367 from abhishekjain16/new_branchYves Senn2013-12-181-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | change to DateTime.civil_from_format from DateTime.civil_from_fromat in ... [ci skip]
| * | | change to DateTime.civil_from_format from DateTime.civil_from_fromat in ↵abhishek2013-12-181-1/+1
| | | | | | | | | | | | | | | | changelog [ci skip]
* | | | Get ready to release 4.1.0.beta1David Heinemeier Hansson2013-12-171-1/+1
| | | |
* | | | Merge pull request #13346 from chancancode/release_notes_etcYves Senn2013-12-171-1/+1
|\ \ \ \ | | | | | | | | | | Release notes fixes [ci skip]
| * | | | Some assorted fixes for the 4.1 release notes:Godfrey Chan2013-12-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Added release notes for secrets.yml and mentioned it in the highlights * Added release notes for Mailer previews and mentioned it in the highlights * Added release notes for Module#concerning * Removed mention for AV extraction from the highlights * Rearranged the major features to put highlighted features first * Various improvements and typo fixes [ci skip]
* | | | | Merge pull request #13341 from carlosantoniodasilva/ca-i18nCarlos Antonio da Silva2013-12-174-10/+27
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | Default I18n.enforce_available_locales to true We will default this option to true from now on to ensure users properly handle their list of available locales whenever necessary. This option was added as a security measure and thus Rails will follow it defaulting to secure option. Also improve the handling of I18n config options in its railtie, taking the new enforce_available_locales option into account, by setting it as the last one in the process. This ensures no other configuration will trigger a deprecation warning due to that setting.
| * | | | Require I18n >= 0.6.9Carlos Antonio da Silva2013-12-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The option enforce_available_locales is only available on latest versions, so require the last available one which has the option + other related fixes and should not have backward compatibility issues.
| * | | | Add changelog and upgrading notice related to I18n enforce_available_locales ↵Carlos Antonio da Silva2013-12-171-5/+13
| | | | | | | | | | | | | | | | | | | | handling
| * | | | Disable available locales checks to avoid warnings running the testsCarlos Antonio da Silva2013-12-171-0/+3
| | | | |
| * | | | Default I18n.enforce_available_locales to trueCarlos Antonio da Silva2013-12-171-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We will default this option to true from now on to ensure users properly handle their list of available locales whenever necessary. This option was added as a security measure and thus Rails will follow it defaulting to secure option. Also improve the handling of I18n config options in its railtie, taking the new enforce_available_locales option into account, by setting it as the last one in the process. This ensures no other configuration will trigger a deprecation warning due to that setting.
* | | | | concern doesn't include the module automaticallyRafael Mendonça França2013-12-171-1/+0
|/ / / / | | | | | | | | | | | | [ci skip]
* | | | Fix indent on AS changelog [ci skip]Carlos Antonio da Silva2013-12-171-18/+18
| | | |
* | | | Introduce Module#concerningJeremy Kemper2013-12-174-0/+219
| | | | | | | | | | | | | | | | | | | | | | | | A natural, low-ceremony way to separate responsibilities within a class. Imported from https://github.com/37signals/concerning#readme
* | | | Merge pull request #13321 from mezis/fix-safebuffer-interpolation-masterJeremy Kemper2013-12-162-7/+37
|\ \ \ \ | | | | | | | | | | Fixes interpolation on SafeBuffer
| * | | | Fixes interpolation on SafeBufferJulien Letessier2013-12-142-7/+37
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Interpolation was untested and did not work with hash arguments. Adds - support for interpolation with hash argument - tests for the above - tests for safe/unsafe interpolation
* | | | Merge pull request #13307 from akshay-vishnoi/typoRafael Mendonça França2013-12-151-2/+2
|\ \ \ \ | |/ / / |/| | | Spelling and Grammar check [ci skip]
| * | | Spelling and Grammar check [ci skip]Akshay Vishnoi2013-12-161-2/+2
| | | |
* | | | Perf: save ~9% of object allocations on heavy requests.Jeremy Kemper2013-12-121-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The per-thread registry is keyed on the class name, and each request for the class name returns a new string. This is in the hot path for a lot of Active Record behavior, so we easily accumulate thousands of repeated strings. To fix, we simply cache the key when the class is first extended with the module. TODO: Eliminate this module. The per-thread instance concept is common, but this technique confuses and obfuscates.
* | | | Merge pull request #13229 from vipulnsward/fix-10635-testsRafael Mendonça França2013-12-122-2/+17
|\ \ \ \ | | | | | | | | | | Fix test-error introduced by #10635.
| * | | | PR #10635 introduces rescue from ArgumentError thrown by ↵Vipul A M2013-12-122-2/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `Base64.strict_decode64`. This broke natural order of things for `StaleSessionCheck#stale_session_check!` which tried auto_loading a class based on `ArgumentError` message , and later retrying the `Marshal#load` of class, successfully allowing auto_loading. This PR tries to fix this behavior by forwarding `ArgumentError` 's not raised by `Base64.strict_decode64` , as is, ahead to `StaleSessionCheck#stale_session_check!`
* | | | | Copy-edit the parent commitRafael Mendonça França2013-12-121-6/+8
| | | | |
* | | | | Merge pull request #13268 from aayushkhandelwal11/masterRafael Mendonça França2013-12-121-22/+16
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | Moving the common code of increment and decrement of cache file store in...
| * | | | Moving the common code of increment and decrement of cache file store into ↵Aayush khandelwal2013-12-121-22/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | seprate function Removing the double checking for the value of id simplifying code for checking conditional code for key Removing the default values for parameters removing reduntant code and asiigning value of id in local variable removing wrongly added line break[ci ckip] reverting code
* | | | | Changelog improvements [ci skip]Carlos Antonio da Silva2013-12-121-1/+1
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 02:56:40 +0000