| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During the `5.0.0.beta1` release, the CHANGELOGs got an entry like the
following:
```
* No changes.
```
It is kinda confusing as there are indeed changes after it. Not a
biggie, just a small pass over the CHANGELOGs.
[ci skip]
|
|\
| |
| |
| |
| |
| | |
[ci skip]
Change output timming of sample code
|
| |
| |
| |
| | |
- Expect returns "new value 1" but, retuns nil, because output at thread is not finished. Move val_1 output to finished thread.
|
|\ \
| | |
| | | |
Fix documentation for mattr_accessor methods [ci skip]
|
| | | |
|
|/ /
| |
| |
| |
| | |
Suppress warning (warning: ambiguous first argument; put
parentheses or a space even after `/' operator)
|
| |
| |
| |
| |
| |
| |
| | |
It is in the code to provides backward compatibility for people that
have this class serialized as YAML in some storage.
Closes #22681
|
| |
| |
| |
| |
| | |
Also, added a test case to make sure that the default deprecation horizon is
always bigger than the current Rails version.
|
|\ \
| | |
| | | |
Fix cache fetch miss notification order
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes https://github.com/rails/rails/issues/22477.
When I improved the caching instrumentation in
edd33c08d98723ae9bb89cf7f019277117ed6414, I inadvertently changed the
order of AS notifications when there is a cache miss.
|
| | | |
|
| | |
| | |
| | |
| | | |
:tada: :beers:
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This test needs to have a require for the Listen gem or else it returns
an error when run by itself or with a certain order in the Active
Support tests. We use `silence_warnings` because Listen has some
warnings about private methods. It's already silenced when it's required
in Active Support EventedFileUpdateChecker.
```
1) Error:
EventedFileUpdateCheckerTest#test_should_not_execute_the_block_if_no_paths_are_given:
NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen
test/evented_file_update_checker_test.rb:21:in `teardown'
```
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The test was was in here twice so we were seeing this error:
```
activesupport/test/caching_test.rb:658:
warning: method redefined; discarding old test_local_cache_of_read_nil
activesupport/test/caching_test.rb:634:
warning: previous definition of test_local_cache_of_read_nil was here
```
|
| | |
| | |
| | | |
We went back to `Thread.current[]` in 33e11e59.
|
| | |
| | |
| | |
| | |
| | |
| | | |
accessors"
This reverts commit 301f43820562c6a70dffe30f4227ff0751f47d4f per @matthewd on https://github.com/rails/rails/pull/22630/files#r47997074
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We call the thread variable accessors on `Thread.current`, which matches Ruby's
documentation:
http://ruby-doc.org/core-2.2.0/Thread.html#method-i-thread_variable_get
Fix these to stay `current` ( ͡° ͜ʖ ͡°)
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
class and module variables that live per-thread
|
|\ \ \
| | | |
| | | | |
Add Logger option to disable message broadcasts
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When setting the Rails logger to log to STDOUT, it would broadcast the
log twice in development. This adds a setting that will prevent messages
from being broadcast to multiple logs, while still allowing calls to
`#close`, `#level=`, `#progname=`, and `#formatter=` to be broadcasted.
Fixes #14769, #11415
|
|\ \ \
| | | |
| | | | |
Use Module.prepend instead of alias_method for Range#to_s
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Delete dead code comments
|
| | | | | |
|
| | |/ /
| |/| |
| | | |
| | | | |
ActiveSupport::Multibyte::Unicode::Codepoint doesn't support this API
|
|\ \ \ \
| |/ / /
|/| | | |
Deprecate passing string to define callback.
|
| |/ / |
|
| | |
| | |
| | |
| | | |
See the rationale in the comment present in this patch.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before this commit, the sole presence of the Listen constant
enabled the evented file watcher (unless listen resorted to
the polling backend).
This way, applications may depend on listen for other stuff
independently of this feature. Also, allows teams with mixed
setups to decide at boot time whether the evented watcher
should be enabled for each particular instance.
|
| |
| |
| |
| |
| | |
Corrects the time comparison to be `Time.now < time` which allows the user to
be set only when the current time is less than the 2 week window given in the
example.
|
| |
| |
| |
| | |
Better English.
|
|\ \
| | |
| | | |
[ci skip] Add a dollar sign to each command in the READMEs
|
| |/
| |
| |
| |
| |
| | |
According to pr #22443 in the guides there's always a dollar sign before every command, so why is in the main README a `$` and in every submodule a `%`?
Just eye candy..
|
|\ \
| | |
| | | |
Subscribing to notifications while inside the said instrumented section
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The issue is that on the exit from Instrumenter#instrument section,
an Evented listener will run into an error because its thread local
(Thread.current[:_timestack]) has not been set up by the #start
method (this obviously happens because the Evented listeners didn't
exist at the time, since no subscribtion to that section was made yet).
Note: support for subscribing to instrumented sections, while being
inside those instrumented sections, might be removed in the future.
Maybe fixes #21873.
|
|\ \ \
| |_|/
|/| | |
even if a write fails, store the raw value
|
| |/ |
|
|\ \
| |/
|/| |
rescue memcached errors in a consistent way
|
| | |
|
| |
| |
| |
| |
| | |
The failure have returned, so disabling the tests again. (The upgrade is
fine to keep.)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In listen 3.0.4 and below, the `#stop` method on the notification
backends are a no-op, meaning that we are leaking them per test. This
ended up triggering another bug in Ruby that causes our builds to fail
randomly on CI.
listen bug: https://github.com/guard/listen/issues/353
ruby bug: https://bugs.ruby-lang.org/issues/11744
|