aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Speedup String#to"Yves Senn2014-01-082-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3. As described in PR #13627 this commit broke functionality when passing a negative Fixnum to the `String#to` method: ```ruby assert_equal "hell", s.to(-2) ``` Before the revert, this failed with: ``` 1) Failure: StringAccessTest#test_#to_with_negative_Fixnum,_position_is_counted_from_the_end [test/core_ext/string_ext_test.rb:275]: Expected: "hell" Actual: nil ``` This revert is to keep the functionality on `master` working. If there is another way to get the performance benefit and keep the documented functionality we can add that. /cc @amatsuda @carlosantoniodasilva
* typo fix in test name. [ci skip].Yves Senn2014-01-081-1/+1
|
* `core_ext/string/access.rb` test what we are documenting.Yves Senn2014-01-081-50/+89
| | | | | | | | | | | | | I also extracted the tests from a single bulk method into a separate test-case. The new tests cover the API described in the docs. There are two skipped tests, which are broken as of 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3 * #to with negative Fixnum, position is counted from the end * #from and #to can be combined This was brought to my attention by #13627. Closes #13627.
* Add 'e' var on rescue DalliError, in order to log itArthur Neves2014-01-061-2/+2
|
* Fix typo in AS changelog, improve highlight [ci skip]Carlos Antonio da Silva2014-01-061-2/+2
|
* quick formatting pass through CHANGELOGS. [ci skip].Yves Senn2014-01-061-10/+15
|
* Add CHANGELOG entry for #10634 [ci skip]Andrew White2014-01-051-0/+17
|
* Merge pull request #10634 from teleological/time_advance_gregorianAndrew White2014-01-052-4/+13
|\ | | | | Maintain proleptic gregorian in Time#advance
| * Maintain proleptic gregorian in Time#advanceRiley Lynch2013-05-152-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Time#advance uses Time#to_date and Date#advance to calculate a new date. The Date object returned by Time#to_date is constructed with the assumption that the Time object represents a proleptic gregorian date, but it is configured to observe the default julian calendar reform date (2299161j) for purposes of calculating month, date and year: Time.new(1582, 10, 4).to_date.to_s # => "1582-09-24" Time.new(1582, 10, 4).to_date.gregorian.to_s # => "1582-10-04" This patch ensures that when the intermediate Date object is advanced to yield a new Date object, that the Time object for return is contructed with a proleptic gregorian month, date and year.
* | Raise if MemCacheStore doenst receive a Dalli objArthur Neves2014-01-033-0/+15
| | | | | | | | | | | | :mem_cache_store should receive a list of hosts or a dalli client, otherwise raise it. Also adding a changelog.
* | mem_cache_store requires dalli, so only accept dalli/clientArthur Neves2014-01-032-14/+1
| | | | | | | | | | | | | | :mem_cache_store require dalli, rescue Dalli exceptions, and follow Dalli API. Memcached gem, for instance, doesnt work anymore, as the API are different. As we already require one client, we should make sure that client works, and not accept others, and if someone wants to use another memcache client they can write their own store adapter.
* | Don't lazy load the tzinfo libraryAndrew White2014-01-012-19/+8
| | | | | | | | | | | | | | | | | | Lazy loading the tzinfo library doesn't really buy us anything because the gem is installed as a dependency via the gemspec and if a developer is using Active Support outside of Rails then they can cherry pick which files to load anyway. Fixes #13553
* | update copyright notices to 2014. [ci skip]Vipul A M2014-01-012-2/+2
| |
* | Avoid raising a NameError on FreeBSD using DateRobin Dupret2014-01-012-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | The Date object has a xmlschema method starting with Ruby 1.9 so we were assuming that we could safely remove this method and redefine it later but the call to remove_method throws a NameError on FreeBSD so we should rely on remove_possible_method instead. This call is actually needed to avoid warnings when running the test suite. Fixes #11723
* | blank? and present? commit to return singletons [Xavier Noria & Pavel Pravosud]Xavier Noria2013-12-283-25/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The contract of blank? and present? was in principle to return Object, as we generally do, the test suite and description was consistent with that, but some examples had comments like "# => true". This cannot be unclear, we either fix the examples, or update the contract. Since users may be already assuming singletons due to the examples and the fact that they were returned before 30ba7ee, the safest option seems to be to revise the contract and the implementation of String#blank? The motivation for 30ba7ee was to improve the performance of the predicate, the refactor based on === is on par regarding speed. With this commit we start documenting return types using YARD conventions. We plan to document return types gradually.
* | Extracted blank matcher regexp to constantPaul Nikitochkin2013-12-281-1/+3
| |
* | Update to Unicode 6.3.0Norman Clarke2013-12-272-1/+1
| | | | | | | | | | | | 6.3.0 was released on September 30, 2013. http://unicode-inc.blogspot.com.ar/2013/09/announcing-unicode-standard-version-63.html
* | Use String#scrub when available to tidy bytesNorman Clarke2013-12-261-35/+35
| |
* | Merge pull request #13436 from robin850/patch-11Guillermo Iguaran2013-12-211-1/+1
|\ \ | | | | | | Add missing changelog entries and fix few typos
| * | Fix few typos in the documentation [ci skip]Robin Dupret2013-12-211-1/+1
| | |
* | | Fix typo [ci skip]Carlos Antonio da Silva2013-12-211-1/+1
|/ /
* | Fix AS::NumberHelper results with large precisionsKenta Murata & Akira Matsuda2013-12-203-7/+62
| | | | | | | | | | | | | | | | | | before: ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50 => "3.14158999999999988261834005243144929409027099609375" after: ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50 => "3.14159000000000000000000000000000000000000000000000"
* | Make sure multiline string is not accepted by the regexpRafael Mendonça França2013-12-192-2/+10
| |
* | Revert "revises the release notes about message verifiers [ci skip]"Xavier Noria2013-12-191-1/+1
| | | | | | | | This reverts commit 293a1a68992ba3e3e80f9f0f685e866ff79bf11a.
* | revises the release notes about message verifiers [ci skip]Xavier Noria2013-12-191-1/+1
| | | | | | | | Example code does not run yet with beta1.
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-12-204-10/+10
|\ \
| * | fixed typo mistake time_formats.rb -> date_formats.rb [ci skip]Kuldeep Aggarwal2013-12-101-1/+1
| | |
| * | Typos. return -> returns. [ci skip]Lauro Caetano2013-12-034-10/+10
| | |
* | | Merge pull request #13406 from hincupetru/masterRafael Mendonça França2013-12-192-1/+7
|\ \ \ | | | | | | | | Fixed configurable.rb regular expression name check
| * | | Fixed configurable.rb regular expression name checkHincu Petru2013-12-192-1/+7
| | | |
* | | | Merge pull request #13401 from akshay-vishnoi/refactorRafael Mendonça França2013-12-192-9/+13
|\ \ \ \ | |/ / / |/| | | Prevent creation of instance methods when `instance_reader = false`, Grammar checks, Conditional statements combined
| * | | Prevent creation of instance methods when `instance_reader = false`, Grammar ↵Akshay Vishnoi2013-12-192-9/+13
| | | | | | | | | | | | | | | | checks, Conditional statements combined
* | | | Prefer assert_raise instead of flunk + rescue to test for exceptionsCarlos Antonio da Silva2013-12-195-48/+31
| | | | | | | | | | | | | | | | | | | | | | | | Change most tests to make use of assert_raise returning the raised exception rather than relying on a combination of flunk + rescue to check for exception types/messages.
* | | | Fix asserting the correct exception message in dependencies testCarlos Antonio da Silva2013-12-191-2/+2
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | In Minitest, the second argument of assert_raise(s) accepts a string as the message that should be shown in case of a failure in the assertion (eg nothing was raised when it should), and not the exception message to be matched. To do that we need to save the exception returned from assert_raise(s) into a local variable and check for the exception message using it.
* | | Unused classes in AS testsAkira Matsuda2013-12-194-30/+0
| | |
* | | Merge pull request #13400 from nishant-cyro/docsGuillermo Iguaran2013-12-181-1/+1
|\ \ \ | | | | | | | | fix typos and grammar mistake [ci skip]
| * | | fix typos and grammar mistake [ci skip]nishant-cyro2013-12-191-1/+1
| | | |
* | | | Merge pull request #13366 from vipulnsward/minitest-namespace-changeGodfrey Chan2013-12-182-5/+5
|\ \ \ \ | | | | | | | | | | Change all `MiniTest` to `Minitest`
| * | | | Change all `MiniTest` to `Minitest` since, `MiniTest` namespace has been ↵Vipul A M2013-12-182-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | renamed to `Minitest` Ref: https://github.com/seattlerb/minitest/blob/master/History.txt
* | | | | Unused classes in test caseAkira Matsuda2013-12-191-25/+0
| | | | |
* | | | | Merge pull request #13367 from abhishekjain16/new_branchYves Senn2013-12-181-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | change to DateTime.civil_from_format from DateTime.civil_from_fromat in ... [ci skip]
| * | | | change to DateTime.civil_from_format from DateTime.civil_from_fromat in ↵abhishek2013-12-181-1/+1
| | | | | | | | | | | | | | | | | | | | changelog [ci skip]
* | | | | Get ready to release 4.1.0.beta1David Heinemeier Hansson2013-12-171-1/+1
| | | | |
* | | | | Merge pull request #13346 from chancancode/release_notes_etcYves Senn2013-12-171-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Release notes fixes [ci skip]
| * | | | | Some assorted fixes for the 4.1 release notes:Godfrey Chan2013-12-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Added release notes for secrets.yml and mentioned it in the highlights * Added release notes for Mailer previews and mentioned it in the highlights * Added release notes for Module#concerning * Removed mention for AV extraction from the highlights * Rearranged the major features to put highlighted features first * Various improvements and typo fixes [ci skip]
* | | | | | Merge pull request #13341 from carlosantoniodasilva/ca-i18nCarlos Antonio da Silva2013-12-174-10/+27
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Default I18n.enforce_available_locales to true We will default this option to true from now on to ensure users properly handle their list of available locales whenever necessary. This option was added as a security measure and thus Rails will follow it defaulting to secure option. Also improve the handling of I18n config options in its railtie, taking the new enforce_available_locales option into account, by setting it as the last one in the process. This ensures no other configuration will trigger a deprecation warning due to that setting.
| * | | | | Require I18n >= 0.6.9Carlos Antonio da Silva2013-12-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The option enforce_available_locales is only available on latest versions, so require the last available one which has the option + other related fixes and should not have backward compatibility issues.
| * | | | | Add changelog and upgrading notice related to I18n enforce_available_locales ↵Carlos Antonio da Silva2013-12-171-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | handling
| * | | | | Disable available locales checks to avoid warnings running the testsCarlos Antonio da Silva2013-12-171-0/+3
| | | | | |
| * | | | | Default I18n.enforce_available_locales to trueCarlos Antonio da Silva2013-12-171-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We will default this option to true from now on to ensure users properly handle their list of available locales whenever necessary. This option was added as a security measure and thus Rails will follow it defaulting to secure option. Also improve the handling of I18n config options in its railtie, taking the new enforce_available_locales option into account, by setting it as the last one in the process. This ensures no other configuration will trigger a deprecation warning due to that setting.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 22:35:00 +0000