Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | :fire: these are lambdas now [ci skip] | Godfrey Chan | 2014-07-03 | 1 | -9/+2 |
| | | | This has changed since around 2b1500d6 | ||||
* | The hex escape sequence can be of any length | Godfrey Chan | 2014-07-02 | 1 | -1/+1 |
| | |||||
* | Fix escape_once double-escaping hex-encoded entities | John F. Douthat | 2014-07-02 | 1 | -1/+1 |
| | | | | (This is a manual merge of #9102) | ||||
* | `DateTime#to_f` now preserves fractional seconds. | John Paul Ashenfelter | 2014-07-02 | 3 | -2/+10 |
| | | | | | | | Previously this method always returns `.0` in the fractional part. This commit changes it to preserve the fractional seconds instead. Fixes #15994. | ||||
* | Add `Hash#map_values` to ActiveSupport | Sean Griffin | 2014-06-29 | 4 | -0/+76 |
| | | | | | Didn't get a chance to convert existing code, I'll skim through the code base to make use of this later this afternoon. | ||||
* | Tiny documentation fixes [ci skip] | Robin Dupret | 2014-06-29 | 1 | -1/+1 |
| | |||||
* | Quick pass through Active Support and guides CHANGELOG | Robin Dupret | 2014-06-29 | 1 | -0/+2 |
| | | | | [ci skip] | ||||
* | Merge pull request #15943 from wagenet/cache-instrumentation | Rafael Mendonça França | 2014-06-27 | 2 | -11/+17 |
|\ | | | | | | | Always instrument ActiveSupport::Cache | ||||
| * | Always instrument ActiveSupport::Cache | Peter Wagenet | 2014-06-27 | 1 | -11/+10 |
| | | | | | | | | | | | | | | | | The current approach is broken because it uses a thread local value which means on multi-threaded environments it has to be turned on per thread. Secondly, ActiveSupport::Notifications does not instrument items when there are not subscribers so this flag is unnecessary. | ||||
* | | Update documentation for run_callbacks | jamesprior | 2014-06-27 | 1 | -1/+2 |
| | | | | | | In some cases run_callbacks will return nil. I'm attempting to update the documentation for the method to clarify. | ||||
* | | Merge pull request #14247 from robin850/inflections-with-uncountables | Rafael Mendonça França | 2014-06-26 | 3 | -5/+18 |
|\ \ | |/ |/| | Make the apply_inflections method case-sensitive | ||||
| * | Make the apply_inflections method case-sensitive | Robin Dupret | 2014-06-26 | 3 | -5/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since d3071db1, the apply_inflections method check if the downcased version of a string is contained inside the "whitelist" of uncountable words. However, if the word is composed of capital letters, it won't be matched in the list while it should. We can't simply revert to the previous behavior as there is a performance concern (benchmarked over /usr/share/dict/words): Before d3071db1 135.610000 0.290000 135.900000 (137.807081) Since d3071db1 22.170000 0.020000 22.190000 ( 22.530005) With the patch 22.060000 0.020000 22.080000 ( 22.125771) Benchmarked with http://git.io/aFnWig This way, the solution is to put the down-case version of words inside the @uncountables array. | ||||
* | | :nodoc: our SecureRandom patches [ci skip] | Godfrey Chan | 2014-06-26 | 1 | -4/+4 |
| | | | | | | | | | | | | | | These methods shouldn't be added to `SecureRandom`, as they are neither secure nor random. The more appropriate place for this seems to be `Digest`, so we should move them there. (Pull request welcomed!) Marking this `:nodoc:` for now, so we don't accidentally ship it as public API. See https://github.com/rails/rails/pull/15306/files#r13055862 for details. | ||||
* | | Merge pull request #15845 from robin850/jruby-isolation | Rafael Mendonça França | 2014-06-26 | 1 | -6/+16 |
|\ \ | |/ |/| | Make the isolated tests run on JRuby | ||||
| * | Make the isolated tests run on JRuby | Robin Dupret | 2014-06-21 | 1 | -6/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | As there is no forking on JRuby, we need to spawn sub-processes to make the tests run in isolation. Previously, we were defining globally env variables and running the test file through backticks and delete these variables once the test ran. Now, we simply rely on IO.popen as this is cross-platform and the env variables are available during the child-process execution only so there are no race conditions. [Ben Browning & Robin Dupret] | ||||
* | | docs, fix BacktraceCleaner code example. Closes #15911. [ci skip] | Yves Senn | 2014-06-25 | 1 | -1/+1 |
| | | |||||
* | | Fix a bug where NameError#name returns a qualified name in string | Yuki Nishijima | 2014-06-24 | 2 | -5/+5 |
| | | | | | | | | | | | | | | Ruby's original behaviour is that : * It only returns a const name, not a qualified aname * It returns a symbol, not a string | ||||
* | | Create with_env helper for tests. | Zuhao Wan | 2014-06-22 | 1 | -14/+13 |
| | | |||||
* | | Merge pull request #15856 from zuhao/refactor_activesupport_decoding_test | Yves Senn | 2014-06-22 | 1 | -11/+19 |
|\ \ | | | | | | | Use with_parse_json_times helper in tests. | ||||
| * | | Use with_parse_json_times helper in tests. | Zuhao Wan | 2014-06-22 | 1 | -11/+19 |
| |/ | |||||
* / | Avoid hardcoded magic number in test teardown. | Zuhao Wan | 2014-06-22 | 1 | -14/+19 |
|/ | |||||
* | Add regression test for NameError#name | Arthur Neves | 2014-06-20 | 2 | -2/+5 |
| | |||||
* | Make dependencies.rb add a name to NameError | Arthur Neves | 2014-06-20 | 2 | -4/+7 |
| | |||||
* | Merge pull request #15799 from ↵ | Yves Senn | 2014-06-18 | 10 | -122/+47 |
|\ | | | | | | | | | zuhao/refactor_activesupport_time_zone_test_helpers Extract out with_env_tz helper method. | ||||
| * | Extract out with_env_tz helper method. | Zuhao Wan | 2014-06-18 | 10 | -122/+47 |
| | | | | | | | | | | It’s used at so many places that extracting it out into a helper file is worth doing. | ||||
* | | Fix documentation from #15669 [ci skip] | Zachary Scott | 2014-06-17 | 1 | -3/+5 |
| | | |||||
* | | [ci skip] fix doc for the Hash#assert_valid_keys | Aditya Kapoor | 2014-06-17 | 1 | -3/+3 |
| | | |||||
* | | Move test teardown into `ensure` block. | Zuhao Wan | 2014-06-17 | 1 | -1/+2 |
|/ | |||||
* | Formatting fix in AS changelog [ci skip] | Juanjo Bazán | 2014-06-16 | 1 | -2/+5 |
| | |||||
* | Merge pull request #15684 from aditya-kapoor/add-tests-for-assert-valid-keys | Rafael Mendonça França | 2014-06-16 | 1 | -0/+15 |
|\ | | | | | Add test cases for Hash#asset_valid_keys | ||||
| * | Add test cases for Hash#asset_valid_keys | Aditya Kapoor | 2014-06-14 | 1 | -0/+15 |
| | | |||||
* | | remove unnecessary calling of `I18n.backend.store_translations(empty, {})` | Kuldeep Aggarwal | 2014-06-15 | 2 | -13/+4 |
| | | | | | | | | | | Clean up I18n stored translations after test continuation with #15714 | ||||
* | | Merge pull request #15679 from akshay-vishnoi/test-cases | Rafael Mendonça França | 2014-06-13 | 1 | -1/+19 |
|\ \ | |/ |/| | Add missing test cases for #assert_no_difference | ||||
| * | Add missing test cases for #assert_no_difference | Akshay Vishnoi | 2014-06-13 | 1 | -1/+19 |
| | | |||||
* | | Merge pull request #15680 from akshay-vishnoi/doc_changes | Sean Griffin | 2014-06-12 | 1 | -1/+1 |
|\ \ | | | | | | | [ci skip] BigDecimal#duplicable? returns false in 1.9.x | ||||
| * | | [ci skip] BigDecimal#duplicable? returns false in 1.9.x | Akshay Vishnoi | 2014-06-13 | 1 | -1/+1 |
| |/ | |||||
* / | [ci skip] Correct output of #assert_not | Akshay Vishnoi | 2014-06-12 | 1 | -1/+1 |
|/ | |||||
* | Revert "remove unnecssary require of `to_param`, as `to_query` is already ↵ | Rafael Mendonça França | 2014-06-11 | 4 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | | require `to_param`" Revert "No need to require to_param, it is already required in to_query.rb" This reverts commits ccdd97662e1fb00c23c90d59f65c091904959561 and d697ee14264a90a39cdbe87857656d8b314ac9b7. Reason by @jeremy: These requires are not for implementation dependency. They ensure that requiring array conversions provides to_query, to_param, and other array conversion behaviors. The fact that to_query is implemented in terms of to_param is just a coincidence. If to_query removed its to_param require, then someone requiring array conversions would no longer have to_param available. This change removes these intentional dependencies on to_param in favor of implementation side effects—an undesirable move that's susceptible to regression. | ||||
* | remove unnecssary require of `to_param`, as `to_query` is already require ↵ | Kuldeep Aggarwal | 2014-06-12 | 3 | -3/+0 |
| | | | | `to_param` | ||||
* | No need to require to_param, it is already required in to_query.rb | Akshay Vishnoi | 2014-06-11 | 1 | -1/+0 |
| | |||||
* | Move test for blank.rb under object | Akshay Vishnoi | 2014-06-11 | 1 | -0/+0 |
| | |||||
* | Merge pull request #15628 from akshay-vishnoi/test-cases | Yves Senn | 2014-06-11 | 1 | -0/+4 |
|\ | | | | | Add test cases for #in? and #presence_in | ||||
| * | Add test cases for #in? and #presence_in | Akshay Vishnoi | 2014-06-11 | 1 | -0/+4 |
| | | |||||
* | | remove deprecated code. Rely on `describe` provided by minitest | Aaron Patterson | 2014-06-10 | 1 | -24/+0 |
| | | |||||
* | | Merge pull request #15616 from apanzerj/fix_long_key_paths | Rafael Mendonça França | 2014-06-10 | 3 | -0/+13 |
|\ \ | | | | | | | fix error with long keys in ActiveSupport::Cache::FileStore | ||||
| * | | fix error with long keys in ActiveSupport::Cache::FileStore | Adam Panzer | 2014-06-10 | 3 | -0/+13 |
| |/ | |||||
* / | [ci skip] Add Docs for strip_insignificant_zeros option in number helpers | Akshay Vishnoi | 2014-06-10 | 1 | -8/+7 |
|/ | |||||
* | [ci skip] Correct output and use valid options of number helpers | Akshay Vishnoi | 2014-06-10 | 1 | -2/+2 |
| | |||||
* | Fix bug that make HashWithIndifferentAccess work differently of Hash | Rafael Mendonça França | 2014-06-09 | 2 | -1/+9 |
| | | | | | Before HashWithIndifferentAccess were doing deep_dup of the inner hashes when Hash doesn't do. Now both are behaving in the same way. | ||||
* | Add Missing Test Cases for the constantize | Aditya Kapoor | 2014-06-07 | 1 | -0/+11 |
| |