aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Use symbols instead of stringsBrian Cardarella2013-06-101-6/+6
| | | | | | | | | | ActiveSupport::Concern is used all over Rails This PR will only create 3 new objects as keys are never recreated and are not subject to garbage collection. The strings were being uniquely created and garbage collected. I don't have any performance numbers but this should be better than all of the GC.
* Merge pull request #10897 from prathamesh-sonpatki/active-support-typosCarlos Antonio da Silva2013-06-101-3/+3
|\ | | | | Fixed typos in activesupport [ci skip]
| * Fixed typos in activesupport [ci skip]Prathamesh Sonpatki2013-06-091-3/+3
| | | | | | | | | | - eval'ed to eval'd in accordance with https://github.com/rails/rails/pull/10889 - tried to improve statement about compiling Procs into methods using define_method
* | Don't blindly call blame_file! on exceptions in ↵Andrew Kreiling2013-06-094-1/+19
|/ | | | | | | | | | | | ActiveSupport::Dependencies::Loadable It is possible under some environments to receive an Exception that is not extended with Blamable (e.g. JRuby). ActiveSupport::Dependencies::Loadable#load_dependency blindly call blame_file! on the exception which throws it's own NoMethodError exception and hides the original Exception. This commit fixes #9521
* Override Time.at to work with Time-like valuesAndrew White2013-06-083-0/+38
| | | | | | | Time.at allows passing a single Time argument which is then converted to an integer. The conversion code since 1.9.3r429 explicitly checks for an instance of Time so we need to override it to allow DateTime and ActiveSupport::TimeWithZone values.
* Fix some typosVipul A M2013-06-072-2/+2
|
* Merge pull request #10784 from senny/10526_prevent_key_transformationRafael Mendonça França2013-06-033-6/+25
|\ | | | | Prevent side effects in `Hash#with_indifferent_access`.
| * Prevent side effects in `Hash#with_indifferent_access`.Yves Senn2013-05-293-6/+25
| |
* | The behavior we had in place in rc1 was actually to convert to DateTime and ↵David Heinemeier Hansson2013-06-031-2/+2
| | | | | | | | use <=> from there. Restore that.
* | Allow Date to be compared with Time (like it was possible to compare Time ↵David Heinemeier Hansson2013-06-032-0/+15
| | | | | | | | with Date)
* | Remove active_support/testing/pending.rb was deprecated.kennyj2013-06-013-27/+0
| |
* | Remove ActiveSupport::Benchmarkable#silence was deprecated.kennyj2013-06-011-10/+0
| |
* | Remove active_support/json/variable was deprecated.kennyj2013-06-013-26/+0
| |
* | Running isolated testsArun Agrawal2013-05-282-19/+6
|/ | | | These stopped running don't know when. But these should be running now.
* Merge pull request #10763 from senny/10758_to_sentence_with_blank_elementsCarlos Antonio da Silva2013-05-261-0/+4
|\ | | | | test-case for `Array#to_sentence` with `blank?` items.
| * add test-case for `Array#to_sentence with blank items.Yves Senn2013-05-261-0/+4
| |
* | Merge pull request #10762 from vipulnsward/change_compatibilityCarlos Antonio da Silva2013-05-261-3/+3
|\ \ | | | | | | compatability => compatibility
| * | compatability => compatibilityVipul A M2013-05-261-3/+3
| |/
* / Fix some typo in method names, variablesVipul A M2013-05-264-4/+4
|/
* Require only minitest.Rafael Mendonça França2013-05-221-1/+1
| | | | | minitest/autorun required minitest/spec and we are avoiding to require it.
* Merge pull request #10667 from rubys/minitest-autorunRafael Mendonça França2013-05-221-1/+1
|\ | | | | Eliminate minitest warnings
| * Eliminate minitest warningsSam Ruby2013-05-171-1/+1
| | | | | | | | https://github.com/seattlerb/minitest/commit/9a57c520ceac76abfe6105866f8548a94eb357b6#L15R8
* | Merge pull request #10659 from vipulnsward/normalize_param2Rafael Mendonça França2013-05-191-3/+3
|\ \ | | | | | | "normalize_callback_params" doesn't require name param
| * | "normalize_callback_params" doesn't require name paramVipul A M2013-05-171-3/+3
| |/
* / Bug fix: Evented notification subscribers can handle published eventsCarl Lerche2013-05-172-0/+29
|/
* Revert "just call the class method since we know the callbacks are stored at ↵Aaron Patterson2013-05-161-2/+1
| | | | | | the" This reverts commit 55975c71ec9c2c18b67020484959ff5c69d4d3fb.
* Merge pull request #10652 from md5/concern-multiple-includedRafael Mendonça França2013-05-163-0/+28
|\ | | | | Raise an error when multiple included blocks are defined for a Concern
| * Raise when multiple included blocks are definedMike Dillon2013-05-163-0/+28
| |
* | Merge pull request #10527 from zenspider/squishy_minitest5Aaron Patterson2013-05-167-129/+32
|\ \ | |/ |/| Squishy minitest5
| * oops. I should have only required minitest, not minitets/autorun. muscle memory.Ryan Davis2013-05-091-1/+1
| |
| * tweak dependenciesRyan Davis2013-05-081-1/+1
| |
| * Updates to make rails 4 happy with minitest 5:Ryan Davis2013-05-066-128/+31
| | | | | | | | | | | | | | | | | | | | + Namespace changes, overhaul of runners. + Internal ivar name changes - Removed a logger globally applied to tests that spew everywhere?!? + Override Minitest#__run to sort tests by name. + Reworked testing isolation to work with the new cleaner architecture. - Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago. - Minor report output differences.
* | Revert "Merge pull request #10600 from aditya-kapoor/code_refactor"Rafael Mendonça França2013-05-151-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8ce3c1e5dde9fb180813e4d89324db03da110b13, reversing changes made to f93da579ce7f77dbd58b9a2165861aee265b8c93. Reason: It slow down the running time. require "diffbench" load 'output_safety.rb' N = 10000 b = ActiveSupport::SafeBuffer.new("hello world") DiffBench.bm do report "capitalize in safe buffer" do N.times do b.capitalize end end end > git checkout 069ea45; diffbench bench.rb; diffbench bench.rb;diffbench bench.rb;diffbench bench.rb;diffbench bench.rb;diffbench bench.rb;diffbench bench.rb; Running benchmark with current working tree Checkout HEAD^ Running benchmark with HEAD^ Checkout to previous HEAD again user system total real ----------------------------------capitalize in safe buffer After patch: 0.010000 0.000000 0.010000 ( 0.009733) Before patch: 0.010000 0.000000 0.010000 ( 0.007702) Improvement: -26% Running benchmark with current working tree Checkout HEAD^ Running benchmark with HEAD^ Checkout to previous HEAD again user system total real ----------------------------------capitalize in safe buffer After patch: 0.010000 0.000000 0.010000 ( 0.009768) Before patch: 0.010000 0.000000 0.010000 ( 0.007896) Improvement: -24% Running benchmark with current working tree Checkout HEAD^ Running benchmark with HEAD^ Checkout to previous HEAD again user system total real ----------------------------------capitalize in safe buffer After patch: 0.010000 0.000000 0.010000 ( 0.009938) Before patch: 0.010000 0.000000 0.010000 ( 0.007768) Improvement: -28% Running benchmark with current working tree Checkout HEAD^ Running benchmark with HEAD^ Checkout to previous HEAD again user system total real ----------------------------------capitalize in safe buffer After patch: 0.010000 0.000000 0.010000 ( 0.010001) Before patch: 0.010000 0.000000 0.010000 ( 0.007873) Improvement: -27% Running benchmark with current working tree Checkout HEAD^ Running benchmark with HEAD^ Checkout to previous HEAD again user system total real ----------------------------------capitalize in safe buffer After patch: 0.010000 0.000000 0.010000 ( 0.009670) Before patch: 0.010000 0.000000 0.010000 ( 0.007800) Improvement: -24% Running benchmark with current working tree Checkout HEAD^ Running benchmark with HEAD^ Checkout to previous HEAD again user system total real ----------------------------------capitalize in safe buffer After patch: 0.010000 0.000000 0.010000 ( 0.009949) Before patch: 0.010000 0.000000 0.010000 ( 0.007752) Improvement: -28%
* | just call the class method since we know the callbacks are stored at theAaron Patterson2013-05-151-1/+2
| | | | | | | | class level
* | this variable is used, so we don't have to use double assignmentsAaron Patterson2013-05-151-1/+1
| |
* | remove dead codeAaron Patterson2013-05-151-23/+4
| |
* | remove deprecation noticesAaron Patterson2013-05-152-26/+0
| |
* | stop keeping a reference to the options hashAaron Patterson2013-05-151-12/+7
| |
* | conditions are guaranteed to be arrays by initializeAaron Patterson2013-05-151-2/+2
| |
* | simplify the condions lambda generationAaron Patterson2013-05-151-12/+2
| |
* | use unless instead of if!Aaron Patterson2013-05-151-3/+3
| |
* | Fix HWIA#to_hash behavior with array of hashes.kennyj2013-05-162-2/+7
| |
* | only dup the options once, the Callback object does not mutate themAaron Patterson2013-05-141-2/+2
| |
* | make the compile method thread safeAaron Patterson2013-05-141-5/+7
| |
* | use inject rather than multiple assignmentsAaron Patterson2013-05-141-4/+2
| |
* | deprecating string based terminatorsAaron Patterson2013-05-142-5/+12
| |
* | halting lambda must be instance execedAaron Patterson2013-05-141-2/+2
| |
* | fixing arity2 testAaron Patterson2013-05-141-3/+8
| |
* | Merge pull request #10266 from vipulnsward/fix_HIA_to_hashRafael Mendonça França2013-05-142-3/+11
|\ \ | | | | | | fix HashWithIndifferentAccess#to_hash behaviour
| * | fix HashWithIndifferentAccess#to_hash behaviourVipul A M2013-04-192-3/+11
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 19:16:15 +0000