aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* split DELEGATION_RESERVED_METHOD_NAMES in halfToshimaru2016-12-091-4/+5
|
* stop using removed `render :text`yuuji.yaginuma2016-12-031-2/+2
| | | | Follow up to 79a5ea9eadb4d43b62afacedc0706cbe88c54496
* Exclude singleton classes from `subclasses` and `descendants`Sean Griffin2016-12-012-0/+11
| | | | | | | | This behavior changed in Ruby starting with 2.3.0, as a result of https://bugs.ruby-lang.org/issues/11360. This results in a change in behavior of these methods which is likely undesirable. Fixes #27238
* Merge pull request #27206 from kirs/fix-testing-isolation-2Matthew Draper2016-12-011-7/+8
|\ | | | | Fix arguments passing in testing isolation
| * Fix arguments passing in testing isolationKir Shatrov2016-11-301-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue affects MRI 2.2.5, MRI 2.3.3, JRuby 9.1.6.0. It can be reproduced by: ``` $ cd activemodel $ NO_FORK=1 bundle exec rake test ``` If we wrap original arguments in quotes, it will be considered as a one big single argument. Later, [`rake/rake_test_loader.rb`](https://github.com/ruby/rake/blob/7863b97/lib/rake/rake_test_loader.rb#L15) will iterate over ARGS and try to require that huge single "argument" (which is a list of multiple .rb files). This leads to an exception: ``` /Users/kir/Project s/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:15:in `require': cannot load such file -- /Users/kir/Projects/opensource/rails/activemodel/test/cases/ attribute_assignment_test.rb [stripped] /Users/kir/Projects/opensource/rails/activemodel/test/cases/validations/with_validation_test.rb /Users/kir/Projects/opensource/rails/activemodel/test/cases/validations_test .rb (LoadError) from /Users/kir/Projects/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:15:in `block in <main>' from /Users/kir/Projects/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:4:in `select' from /Users/kir/Projects/opensource/rails/vendor/bundle/gems/rake-11.3.0/lib/rake/rake_test_loader.rb:4:in `<main>' ``` Originally quotes were introduced in https://github.com/rails/rails/pull/19819 to fix MRI 2.2.2. The fix solves issue on all affected platforms: MRI 2.2.5, MRI 2.3.3, JRuby 9.1.6.0.
* | Missing require 'active_support/notifications'Akira Matsuda2016-11-301-0/+1
| |
* | Treat combined durations as a single unitSean Griffin2016-11-292-3/+20
| | | | | | | | | | | | | | | | | | | | | | | | Prior to this commit, `3.months - 3.months` would result in a duration that has the "parts" of `[[:months, 3], [:months, -3]]`. This would mean that it was subtly different than `2.months - 2.months`. When applied to a time, the date might actually change if the resulting day doesn't exist however many months in the future, even though in both cases we just wanted to add `0`, which should always be an identity operation. With this change, we now store the parts as a hash, so `3.months - 3.months` is simply stored as `{ months: 0 }`.
* | use public Module#include instead of send :includeyuuji.yaginuma2016-11-271-1/+1
| | | | | | | | Follow up to #18767
* | Merge pull request #26874 from tgxworld/fix_broadcast_loggerMatthew Draper2016-11-252-5/+21
|\ \ | | | | | | `Broadcast#silence` breaks custom loggers that do not include `Logg…
| * | `Broadcast#silence` breaks custom loggers that does not include `LoggerSilence`.Guo Xiang Tan2016-10-242-5/+21
| | |
* | | Fix `require_dependency` message formatRyuta Kamizono2016-11-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `depend_on` message format is `"No such file to load -- %s.rb"`. But `require_dependency` message is missing `.rb` suffix. ``` % git grep -n 'No such file to load' actionview/test/actionpack/abstract/helper_test.rb:112: assert_equal "No such file to load -- very_invalid_file_name.rb", e.message activesupport/lib/active_support/dependencies.rb:245: def require_dependency(file_name, message = "No such file to load -- %s.rb") activesupport/lib/active_support/dependencies.rb:333: def depend_on(file_name, message = "No such file to load -- %s.rb") ```
* | | update bin/test scripts to prevent double runs.Yves Senn2016-11-211-2/+0
| |/ |/| | | | | | | The test runner was updated to make use of autorun. This caused the `bin/test` scripts to run Minitest twice.
* | ✂️ needless lines beneath private.Kasper Timm Hansen2016-11-206-6/+0
| |
* | Move tests to a module, include in subclasses, style lintingJon Moss2016-11-201-188/+195
| | | | | | | | | | | | | | | | This fixes an error where the test runner would try and run XMLMiniEngineTest like a normal test class, except it's abstract. Now, to circumvent this, we don't include any of the actual tests in XMLMiniEngineTest; they are wrapped in a module that is included in subclass when they inherit from XMLMiniEngineTest. Pretty neat, huh?
* | Create XMLMiniEngineTest; base class for all testsJon Moss2016-11-207-63/+33
| |
* | Code styling cleanupJon Moss2016-11-207-152/+162
| |
* | Create `CommonXMLMiniAdapterTest`; common tests moduleJon Moss2016-11-207-916/+279
| | | | | | | | | | | | Created a new module (a la Action Cable subscription adapter's test suite) to be included in all sub class test to ensure compatability and reduce duplicated code.
* | Do not include `ActiveSupport` into test classesJon Moss2016-11-193-33/+27
| | | | | | | | | | | | | | | | | | | | | | Will help get rid of errors like the following: ``` 1) Error: JDOMEngineTest#test_order=: ArgumentError: wrong number of arguments (0 for 1) /Users/jon/code/rails/rails/activesupport/lib/active_support/core_ext/module/attribute_accessors.rb:106:in `test_order=' ```
* | Merge pull request #27070 from jonhyman/patch-raw-trueRafael França2016-11-171-1/+1
|\ \ | | | | | | Removes 'raw: true' from MemCacheStore#read_multi
| * | Removes 'raw: true' from MemCacheStore#read_multi, per ↵Jonathan Hyman2016-11-161-1/+1
| | | | | | | | | | | | https://github.com/rails/rails/issues/27066.
* | | Refactor the handling of fallback exception handlersSean Griffin2016-11-171-10/+5
| | |
* | | Call fallback exception handlers with the right exceptionSean Griffin2016-11-172-4/+11
|/ / | | | | | | | | | | | | | | The issue presented in #26246 showed a deeper underlying problem. When we fell back to the exception handler for an exceptions cause, we were calling that handler with the outer raised exception. This breaks the calling code's expectations, especially if the exception has methods on it behond those from `StandardError`.
* | Fix testing isolationKir Shatrov2016-11-151-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AS::Testing::Isolation has two ways to isolate the process: forking and subprocessing. The second way is used on JRuby and other platforms that don't support forking. The way how subprocessing works is that we prepare a command to run a new process: ``` /opt/rubies/2.3.0/bin/ruby -I{skipped_load_path} test/initializable_test.rb '' -nInitializableTests::Basic#test_Initializer_provides_context's_class_name ``` As you see, there's unescaped quote at the end of the line. It leads to: ``` sh: -c: line 0: unexpected EOF while looking for matching `'' sh: -c: line 1: syntax error: unexpected end of file ``` This fixes tests on MRI + NO_FORK variable and on JRuby :tada:
* | remove duplicated changelog entry [ci skip]yuuji.yaginuma2016-11-151-4/+0
| |
* | Merge pull request #27035 from rails/remove-active-support-deprecationsAndrew White2016-11-1430-685/+76
|\ \ | | | | | | Remove Active Support deprecations
| * | Remove deprecated class ActiveSupport::Concurrency::LatchAndrew White2016-11-142-25/+4
| | |
| * | Remove deprecated separator argument from parameterizeAndrew White2016-11-145-44/+6
| | |
| * | Remove deprecated method Numeric#to_formatted_sAndrew White2016-11-143-11/+4
| | |
| * | Remove deprecated method alias_method_chainAndrew White2016-11-143-263/+4
| | |
| * | Remove deprecated constant MissingSourceFIleAndrew White2016-11-143-10/+4
| | |
| * | Remove deprecated Module.qualified_const_get/set/defined?Andrew White2016-11-145-190/+5
| | |
| * | Update CHANGELOGAndrew White2016-11-131-0/+48
| | |
| * | Remove deprecated :prefix optionAndrew White2016-11-133-37/+1
| | |
| * | Remove deprecated new_from_hash_copying_defaultAndrew White2016-11-132-16/+0
| | |
| * | Remove deprecated time marshal core_ext fileAndrew White2016-11-131-3/+0
| | |
| * | Remove deprecated struct core_ext fileAndrew White2016-11-131-3/+0
| | |
| * | Remove deprecated module method_transplanting fileAndrew White2016-11-131-3/+0
| | |
| * | Remove deprecated local_constantsAndrew White2016-11-132-18/+0
| | |
| * | Remove deprecated kernel debugger fileAndrew White2016-11-131-3/+0
| | |
| * | Remove deprecated namespaced_keyAndrew White2016-11-132-14/+0
| | |
| * | Remove deprecated set_cache_valueAndrew White2016-11-132-17/+0
| | |
| * | Remove deprecated escape_keyAndrew White2016-11-132-14/+0
| | |
| * | Remove deprecated key_file_pathAndrew White2016-11-132-14/+0
| | |
* | | Revert "Merge pull request #25811 from oss92/to_sentence_fallback_string"Rafael Mendonça França2016-11-143-20/+3
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit bad3a120f1690f393d8f6204b3ceee60f0ce707b, reversing changes made to 2384317465ccb1dfca456a2b7798714b99f32711. Reason: Adding a new option in the API for something that can be done with a `#presence` check could do.
* | | Merge pull request #26222 from vipulnsward/26134-fixRafael França2016-11-131-6/+5
|\ \ \ | | | | | | | | Format and send logs to logger.fatal from DebugExceptions
| * | | Format and send logs to logger.fatal from DebugExceptions instead of calling ↵Vipul A M2016-11-121-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | fatal multiple times. Expose tags_text from TaggedLogging to be used for log formatting Fixes #26134
* | | | Remove warning from access to Bignum class, 2**64 is already a known bignum ↵Vipul A M2016-11-131-1/+0
| |/ / |/| | | | | | | | value. See also http://patshaughnessy.net/2014/1/9/how-big-is-a-bignum for smallest bignum value
* | | Fix typo in constant referenceAndrew White2016-11-131-1/+1
| | |
* | | It's a NAN not InfinityAndrew White2016-11-131-1/+1
| | |
* | | Use literal values in assertionsAndrew White2016-11-131-6/+4
| | | | | | | | | | | | | | | Using the method you're testing to generate expected values can lead to bugs being masked.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 10:38:16 +0000