Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Explicitly test for true and false. | Jade Tucker | 2013-07-07 | 1 | -2/+2 |
| | |||||
* | cache.exists? should return true/false | Jade Tucker | 2013-07-07 | 1 | -1/+1 |
| | |||||
* | Make HashWithIndifferentAccess#select always return the hash. | Marc Schütz | 2013-07-06 | 3 | -1/+12 |
| | | | | | Hash#select! returns nil if the hash didn't change and thus behaves differently from select, so it's return value can't be used as result for the latter. | ||||
* | Adding back deprecation require in all.rb | Rashmi Yadav | 2013-07-05 | 1 | -0/+1 |
| | |||||
* | Revert "remove string based terminators for `ActiveSupport::Callbacks`." | Yves Senn | 2013-07-05 | 2 | -4/+6 |
| | | | | | | | | This reverts commit d108672dada7ba97d3b3b56f0c6001cea621061e. Conflicts: activesupport/CHANGELOG.md | ||||
* | fix typo in Active Support CHANGELOG. [ci skip] | Yves Senn | 2013-07-05 | 1 | -1/+1 |
| | |||||
* | remove string based terminators for `ActiveSupport::Callbacks`. | Yves Senn | 2013-07-05 | 2 | -6/+4 |
| | |||||
* | Removed unsued deprecation require | Rashmi Yadav | 2013-07-04 | 2 | -2/+0 |
| | |||||
* | method transplanting between modules isn't supported on 1.9 | Aaron Patterson | 2013-07-03 | 1 | -0/+11 |
| | |||||
* | Fixed test broken by local_constant_names | Arun Agrawal | 2013-07-03 | 1 | -6/+0 |
| | | | depreciation removed | ||||
* | Remove deprecated `String#encoding_aware?` | Arun Agrawal | 2013-07-03 | 4 | -15/+4 |
| | | | core extensions (`core_ext/string/encoding`). | ||||
* | Remove deprecated `Module#local_constant_names` | Arun Agrawal | 2013-07-03 | 2 | -16/+4 |
| | | | in favor of `Module#local_constants` | ||||
* | Remove deprecated `DateTime.local_offset` | Arun Agrawal | 2013-07-03 | 2 | -7/+4 |
| | |||||
* | Remove deprecated Logger core extensions (core_ext/logger.rb) | Carlos Antonio da Silva | 2013-07-03 | 3 | -68/+4 |
| | |||||
* | Merge pull request #11265 from vipulnsward/deprecated_time_methods | Yves Senn | 2013-07-03 | 3 | -90/+5 |
|\ | | | | | Remove deprecated `Time` methods | ||||
| * | Remove deprecated `Time#time_with_datetime_fallback`, `Time#utc_time` | Vipul A M | 2013-07-03 | 3 | -90/+5 |
| | | | | | | | | and `Time#local_time` in favour of `Time#utc` and `Time#local` | ||||
* | | use American English: "favor" not "favour" [ci skip] | Yves Senn | 2013-07-03 | 1 | -1/+1 |
|/ | | | | according to http://guides.rubyonrails.org/api_documentation_guidelines.html#english | ||||
* | Remove deprecated Hash#diff with no replacement. | Carlos Antonio da Silva | 2013-07-02 | 4 | -23/+7 |
| | | | | | If you're using it to compare hashes for the purpose of testing, please use MiniTest's assert_equal instead. | ||||
* | Merge pull request #10909 from dockyard/master | Carlos Antonio da Silva | 2013-07-02 | 1 | -6/+6 |
|\ | | | | | Use symbols instead of strings in ActiveSupport::Concern | ||||
| * | Use symbols instead of strings | Brian Cardarella | 2013-06-10 | 1 | -6/+6 |
| | | | | | | | | | | | | | | | | | | | | ActiveSupport::Concern is used all over Rails This PR will only create 3 new objects as keys are never recreated and are not subject to garbage collection. The strings were being uniquely created and garbage collected. I don't have any performance numbers but this should be better than all of the GC. | ||||
* | | Remove deprecated `Date#to_time_in_current_zone` | Vipul A M | 2013-07-02 | 3 | -22/+4 |
| | | |||||
* | | Remove deprecated `Proc#bind` with no replacement. | Carlos Antonio da Silva | 2013-07-01 | 4 | -32/+4 |
| | | |||||
* | | Remove deprecated Array#uniq_by and Array#uniq_by! | Carlos Antonio da Silva | 2013-07-01 | 4 | -50/+5 |
| | | | | | | | | Use native Array#uniq and Array#uniq! instead. | ||||
* | | Remove deprecated AS::BasicObject, use AS::ProxyObject instead | Carlos Antonio da Silva | 2013-07-01 | 4 | -24/+4 |
| | | |||||
* | | Add missing require | Carlos Antonio da Silva | 2013-07-01 | 1 | -0/+1 |
| | | | | | | | | | | | | Commit cfa35c55bb38b27af305ad21408e181bc3cd739e removed the buffered_logger from AS, which required the logger file. Now we need to add the proper require here. | ||||
* | | remove deprecated `BufferedLogger`. | Yves Senn | 2013-07-01 | 4 | -44/+4 |
| | | |||||
* | | remove deprecated `assert_present` and `assert_blank`. | Yves Senn | 2013-07-01 | 3 | -78/+4 |
| | | |||||
* | | Further clean-up of ActiveSupport::Callbacks | Genadi Samokovarov | 2013-07-01 | 1 | -10/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #11195 I noticed a trailing comma in the docs, but I decided to further clean it up. What I have done: * Clean up the trailing comma in the docs and some extra whitespace lines. * Used `Array#extract` options to factor the repetitive pattern of `args.last.is_a(Hash) ? ...` * Renamed the local var `config` to `options` in `define_callbacks`, as `options` seems to be the de facto name for the options objects. * Renamed the local var `l` to `line` in `define_callback` (maybe it meant `lambda` in the context) as single `l` may look like `1` in some fonts. | ||||
* | | unified the param names across all callbacks manipulation methods | Steven Yang | 2013-07-01 | 1 | -10/+10 |
| | | | | | | | | | | | | | | _ Rename the define_callbacks params to `names` - in order to match the naming conventions for `get_callbacks` and `set_callbacks` at https://github.com/rails/rails/blob/master/activesupport/lib/active_support/callbacks.rb#L736-743 - `define_callbacks` just register names(events), not define the real callback functions. - Rename the `reset_callbacks` params | ||||
* | | updated AS:Callbacks doc for terminator option in define_callbacks method | Steven Yang | 2013-06-30 | 1 | -3/+4 |
| | | | | | | | | The change is commited at ba552764344bc0a3c25b8576ec11f127ceaa16da | ||||
* | | fix grammar, change 'an' to 'a' [ci skip] | Prathamesh Sonpatki | 2013-06-27 | 1 | -3/+3 |
| | | |||||
* | | Move delegation error constant to inside Module | Carlos Antonio da Silva | 2013-06-26 | 2 | -3/+5 |
| | | |||||
* | | Merge pull request #10828 from southpolesteve/delegation_error_class | Yves Senn | 2013-06-26 | 2 | -2/+4 |
|\ \ | | | | | | | Create DelegationError class | ||||
| * | | Add DelegationError class. Rasied by delegation to a nil object | Steve Faulkner | 2013-06-26 | 2 | -2/+4 |
| | | | |||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-06-26 | 1 | -1/+0 |
|\ \ \ | | | | | | | | | | | | | | | | | Conflicts: guides/source/layout.html.erb | ||||
| * | | | Remove a comment related to 920753f | Robin Dupret | 2013-06-26 | 1 | -1/+0 |
| | | | | | | | | | | | | Since 920753f, double assignment isn't used anymore | ||||
* | | | | Merge pull request #10542 from waseem/remove_require | Carlos Antonio da Silva | 2013-06-25 | 1 | -1/+0 |
|\ \ \ \ | | | | | | | | | | | Remove unnecessary require from active_support/inflector/methods.rb | ||||
| * | | | | Remove unnecessary require from active_support/inflector/methods.rb | Waseem Ahmad | 2013-05-10 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `active_support/inflections` already requires `active_support/inflector/inflections`. There's no need to require it in `active_support/inflector/methods`. | ||||
* | | | | | Merge pull request #10627 from vipulnsward/destructive_symbolize | Carlos Antonio da Silva | 2013-06-25 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | Change to destructive `deep_symbolize_keys` to avoid a new hash creation. | ||||
| * | | | | | change to destructive `deep_symbolize_keys` after ↵ | Vipul A M | 2013-05-15 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/df24b8790f22384a068fece7042f04ffd2fcb33e which allows to do so. This helps to avoid extra hash object creation, by symbolizing inplace | ||||
* | | | | | | Merge pull request #11046 from arunagw/verbose_mode_on | Carlos Antonio da Silva | 2013-06-25 | 1 | -1/+1 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Verbose mode on when running tests | ||||
| * | | | | | | Adding verbose in isolated test. | Arun Agrawal | 2013-06-21 | 1 | -1/+1 |
| | | | | | | | |||||
* | | | | | | | Saying gemcutter => rubygems [ci skip] | Arun Agrawal | 2013-06-21 | 1 | -1/+1 |
|/ / / / / / | |||||
* | | | | | | Fix BacktraceCleaner#noise for multiple silencers. | Mark J. Titorenko | 2013-06-20 | 3 | -5/+29 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous implementation of BacktraceSilencer#noise did not work correctly if more than one silencer was configured -- specifically, it would only return noise which was matched by all silencers. The new implementation is such that anything that has been matched by silencers is removed from the backtrace using Array#- (array difference), ie. we now return all elements within a backtrace that have been matched by any silencer (and are thus removed by #silence). Fixes #11030. | ||||
* | | | | | | add documentation for `ActiveSupport::Testing::SetupAndTeardown`. | Yves Senn | 2013-06-19 | 1 | -2/+17 |
| | | | | | | |||||
* | | | | | | better documentation for `AS::Testing::Declarative#test`. [ci skip] | Yves Senn | 2013-06-19 | 1 | -3/+6 |
| | | | | | | |||||
* | | | | | | we only support 1.9+, so just check for a name | Aaron Patterson | 2013-06-17 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | be consistent about parameter types passed to new_constants_in | Aaron Patterson | 2013-06-17 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Rewind StringIO instances before be parsed again | Paco Guzman | 2013-06-16 | 5 | -0/+5 |
| | | | | | | |||||
* | | | | | | Use xml instead already parsed xml | Paco Guzman | 2013-06-16 | 1 | -1/+1 |
| | | | | | |