aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | Add missing gzip footer check in ActiveSupport::Gzip.decompressDylan Thacker-Smith2017-02-243-1/+15
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A gzip file has a checksum and length for the decompressed data in its footer which isn't checked by just calling Zlib::GzipReader#read. Calling Zlib::GzipReader#close must be called after reading to the end of the file causes this check to be done, which is done by Zlib::GzipReader.wrap after its block is called.
* | | | | | Make HWIA#compact not return nil when no nilsPavel Pravosud2017-02-232-1/+11
| | | | | |
* | | | | | Preparing for 5.1.0.beta1 releaseRafael Mendonça França2017-02-232-1/+3
| | | | | |
* | | | | | 🙈 :nodoc: `AS::Duration::ISO8601Serializer`Godfrey Chan2017-02-231-1/+1
| |_|/ / / |/| | | | | | | | | This class should not be used directly, the public API is `AS::Duration#iso8601`.
* | | | | Add more missing requiresAndrew White2017-02-221-0/+1
| | | | | | | | | | | | | | | | | | | | Further missing requires for Timeout exposed due to Bundler 1.14.5
* | | | | Add missing requiresAndrew White2017-02-221-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Bundler 1.14.5 moved to lazily loading 'rubygems/spec_fetcher' which revealed some missing requires from the JSON encoding test file.
* | | | | Add CHANGELOG entry for #28104Andrew White2017-02-221-0/+4
| | | | |
* | | | | Preload to_datetime before freezing a TimeWithZone instanceAdam Rice2017-02-222-1/+3
| | | | |
* | | | | Merge pull request #27941 from ↵Kasper Timm Hansen2017-02-201-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | y-yagi/prevent_multiple_values_being_set_to_run_via Prevent multiple values being set to `run_via`
| * | | | | Prevent multiple values being set to `run_via`yuuji.yaginuma2017-02-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When executing the test via rake, since `rake` is set for `run_via`, `ruby` should not be set. Related 2cb6c27310452da11b93d729c3b760ce988106e1
* | | | | | Revert "Merge pull request #27925 from robin850/hwia-removal"Kasper Timm Hansen2017-02-203-46/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pointed out by @matthewd that the HWIA subclass changes the AS scoped class and top-level HWIA hierarchies out from under existing classes. This reverts commit 71da39097b67114329be6d8db7fe6911124531af, reversing changes made to 41c33bd4b2ec3f4a482e6030b6fda15091d81e4a.
* | | | | | Merge pull request #27863 from robin850/api-improvementsMatthew Draper2017-02-212-0/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | Some improvements to the API site's sidebar
| * | | | | | Avoid documenting private or external classesRobin Dupret2017-02-072-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are a lot of monkey patches inside the code base but there's no need to document external constants so let's remove them from the documentation Also, since there are monkey patches for some test cases classes, there were sometimes both documented and sneaked under the wrong section in the sidebar. Finally, for future references, the `active_support/vendor` folder has been originally ignored in https://git.io/vDqfA but no longer exists. [ci skip]
* | | | | | | Deprecate the top-level `HashWithIndifferentAccess` contantRobin Dupret2017-02-193-1/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This constant was kept for the sake of backward compatibility; it is still available under `ActiveSupport::HashWithIndifferentAccess`. Furthermore, since Ruby 2.5 (https://bugs.ruby-lang.org/issues/11547) won't support top level constant lookup, people would have to update their code anyway.
* | | | | | | Fix doc in Multibyte::Chars [ci skip]kenta-s2017-02-171-4/+5
| | | | | | |
* | | | | | | Remove redundant namespaces from sample code of `deprecated_method_warning` ↵kenta-s2017-02-151-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | Not ants were harmed! 🐜Mario Uher2017-02-141-1/+1
| | | | | | |
* | | | | | | Fix the return of `deprecate_methods` in doc [ci skip]kenta-s2017-02-141-1/+1
| | | | | | |
* | | | | | | Remove unused requireRyuta Kamizono2017-02-121-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These files are not using `strip_heredoc`. Closes #27976
* | | | | | | Also not needed on this file, call to `mattr_accessor` got removed in ↵Edouard CHIN2017-02-121-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/9e98f3f7e61dfce0a48948c8d296400af8bfaf21#diff-1ecd313ff0ab827af30014553cf8918dL76
* | | | | | | Merge pull request #27973 from kenta-s/add-missing-test-for-time-blankAndrew White2017-02-121-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add Time#blank? to blank_test
| * | | | | | | Add Time#blank? to blank_testkenta-s2017-02-121-1/+1
| | | | | | | |
* | | | | | | | Add `Style/EmptyLinesAroundMethodBody` in `.rubocop.yml` and remove extra ↵Ryuta Kamizono2017-02-122-2/+0
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | empty lines
* | / / / / / deprecate `halt_callback_chains_on_return_false` instead of ↵yuuji.yaginuma2017-02-083-16/+7
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `halt_and_display_warning_on_return_false` `halt_and_display_warning_on_return_false` is not a public API and application is using `halt_callback_chains_on_return_false`. https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults.rb.tt#L29 https://github.com/rails/rails/blob/5-0-stable/activesupport/lib/active_support.rb#L86..L88 Therefore, deprecate messages should be issued for `halt_callback_chains_on_return_false` instead of `halt_and_display_warning_on_return_false`.
* | | | | | Remove unused code now that the deprecated file was removedRafael Mendonça França2017-02-071-2/+1
| | | | | |
* | | | | | Deprecate halt_and_display_warning_on_return_falseRafael Mendonça França2017-02-072-5/+16
| | | | | |
* | | | | | Remove deprecated behavior that halts callbacks when the return is falseRafael Mendonça França2017-02-073-52/+6
| | | | | |
* | | | | | Document that string in if and unless option of callbacks are deprecatedRafael Mendonça França2017-02-071-4/+4
| | | | | |
* | | | | | Improve the exception message to direct people to all the possible valuesRafael Mendonça França2017-02-071-1/+2
| | | | | |
* | | | | | Merge pull request #27608 from ↵Rafael França2017-02-073-58/+68
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/remove_deprecated_passing_string_to_define_callback Remove deprecated passing string to define callback
| * | | | | | Deprecate passing string to `:if` and `:unless` conditional options on ↵Ryuta Kamizono2017-02-043-4/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `set_callback` and `skip_callback`
| * | | | | | Remove deprecated passing string to define callbackRyuta Kamizono2017-02-043-55/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | And raise `ArgumentError` when passing string to define callback.
* | | | | | | Merge pull request #27919 from bf4/correct_spellingArthur Nogueira Neves2017-02-065-6/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Correct spelling
| * | | | | | | Correct spellingBenjamin Fleischer2017-02-055-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` go get -u github.com/client9/misspell/cmd/misspell misspell -w -error -source=text . ```
* | | | | | | | Add tests for `blank?`kenta-s2017-02-063-0/+12
|/ / / / / / /
* / / / / / / Docs: Correction: Module::DelegationErrorJared Beck2017-02-031-7/+9
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the delegation target is nil and the allow_nil option is not in use, a Module::DelegationError is raised. class C delegate :a, to: :b def b nil end end C.new.a # => Module::DelegationError: C#a delegated to b.a, but b is nil [ci skip]
* | | | | | explicitly require `listen` in `EventedFileUpdateCheckerTest` (#27867)Arthur Nogueira Neves2017-02-011-0/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, executing the `test_initialize_raises_an_ArgumentError_if_no_block_given` test alone will result in an error. ``` $ ./bin/test test/evented_file_update_checker_test.rb -n test_initialize_raises_an_ArgumentError_if_no_block_given Run options: -n test_initialize_raises_an_ArgumentError_if_no_block_given --seed 6692 # Running: E Error: EventedFileUpdateCheckerTest#test_initialize_raises_an_ArgumentError_if_no_block_given: NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen rails/activesupport/test/evented_file_update_checker_test.rb:21:in `teardown' ``` This is because if do not specify a file or directory for `EventedFileUpdateChecker`, do not require `listen`, and using listen method in teardown. https://github.com/rails/rails/blob/master/activesupport/lib/active_support/evented_file_update_checker.rb#L53..L65 Therefore, added listen's require to avoid errors.
| * | | | | | explicitly require `listen` in `EventedFileUpdateCheckerTest`yuuji.yaginuma2017-02-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, executing the `test_initialize_raises_an_ArgumentError_if_no_block_given` test alone will result in an error. ``` $ ./bin/test test/evented_file_update_checker_test.rb -n test_initialize_raises_an_ArgumentError_if_no_block_given Run options: -n test_initialize_raises_an_ArgumentError_if_no_block_given --seed 6692 # Running: E Error: EventedFileUpdateCheckerTest#test_initialize_raises_an_ArgumentError_if_no_block_given: NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen rails/activesupport/test/evented_file_update_checker_test.rb:21:in `teardown' ``` This is because if do not specify a file or directory for `EventedFileUpdateChecker`, do not require `listen`, and using listen method in teardown. https://github.com/rails/rails/blob/master/activesupport/lib/active_support/evented_file_update_checker.rb#L53..L65 Therefore, added listen's require to avoid errors.
* | | | | | | remove unused variableyuuji.yaginuma2017-02-011-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the following warnings. ``` activesupport/test/file_update_checker_shared_tests.rb:279: warning: assigned but unused variable - checker ```
* | | | | | Remove deprecated callbacks from ActionDispatch middlewaresRafael Mendonça França2017-01-311-1/+13
| | | | | |
* | | | | | Merge pull request #27857 from kenta-s/add-test-for-variable_size_secure_compareEileen M. Uchitelle2017-01-311-1/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add test for `variable_size_secure_compare`
| * | | | | | Add test for `variable_size_secure_compare`kenta-s2017-01-311-1/+6
| | | | | | |
* | | | | | | Remove redundant right parentheses in number_helper [ci skip]kenta-s2017-01-311-1/+1
|/ / / / / /
* | | | | | Raise in the initialize not in the executeRafael Mendonça França2017-01-313-13/+12
| | | | | |
* | | | | | Merge pull request #27824 from kenta-s/raise-an-error-if-no-block-givenRafael França2017-01-313-2/+17
|\ \ \ \ \ \ | | | | | | | | | | | | | | Raise an error if FileUpdateChecker#execute is called with no block
| * | | | | | Raise an error if FileUpdateChecker#execute is called with no blockkenta-s2017-01-283-2/+17
| | | | | | |
* | | | | | | Merge pull request #27797 from y-yagi/correctly_check_error_messageArthur Nogueira Neves2017-01-302-2/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | correctly check error message
| * | | | | | | correctly check error messageyuuji.yaginuma2017-01-252-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `assert_raise` does not check error message. However, in some tests, it seems like expecting error message checking with `assert_raise`. Instead of specifying an error message in `assert_raise`, modify to use another assert to check the error message.
* | | | | | | | Merge pull request #27822 from mtsmfm/bump-unicode-versionJeremy Daer2017-01-305-10/+38
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Update Unicode Version to 9.0.0
| * | | | | | | | Update Unicode Version to 9.0.0Fumiaki MATSUSHIMA2017-01-285-10/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9.0.0 was released on June 21, 2016 http://blog.unicode.org/2016/06/announcing-unicode-standard-version-90.html http://www.unicode.org/versions/Unicode9.0.0/ There are some changes about grapheme cluster in Unicode 9.0.0: http://unicode.org/reports/tr29/#Grapheme_Cluster_Boundary_Rules ------------ I noticed that `unpack_graphemes` returns [Other] when the argument is Other ÷ Prepend (it must be [Other, Prepend]). But in [Unicode 8.0.0's Prepend has no characters](http://www.unicode.org/reports/tr29/tr29-27.html#Prepend) so we don't have to backport following patch: ```diff should_break = + if pos == eoc + true ```
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 01:23:23 +0000