aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* fix typo on commentsPaulo Ancheta2015-12-231-1/+1
|
* Merge pull request #20507 from rabbitt/bugfix/logger-threadsafetyRafael França2015-12-233-4/+119
|\ | | | | Fixes LoggerSilence#silence threadsafety
| * Fixes LoggerSilence#silence threadsafetyCarl P. Corliss2015-12-233-4/+119
| | | | | | | | | | | | | | - uses instance defined level if no custom local log level defined - Keeps track of local log level per [ thread + object-instance ] - prevents memory leakage by removing local level hash key/value on #silence method exit - avoids the use of Thread local variables
* | Add caveat to number_to_currency docs [ci skip]Derek Prior2015-12-231-0/+8
|/ | | | | | | | | | | | | | I've worked on a few applications that have gone through the internationalization process and had issues because they were using `number_to_currency`. The minute a user is allowed to change their locale, they can change the price displayed on a page from 10 US dollars to 10 Mexican Pesos, which is far from the same amount of money. Unlike other helpers that rely on i18n, `number_to_currency` does not produce equivalent results when the locale is changed. As I've explained this to a few groups of developers now, I thought it might make for a good caveat in the docs.
* release notes, extract notable changes from Active Support CHANGELOG.Yves Senn2015-12-231-12/+12
| | | | [ci skip]
* Use CGI.escapeHTML for html escapeTakashi Kokubun2015-12-211-4/+2
|
* No more no changes entries in the CHANGELOGsGenadi Samokovarov2015-12-211-3/+0
| | | | | | | | | | | | | | During the `5.0.0.beta1` release, the CHANGELOGs got an entry like the following: ``` * No changes. ``` It is kinda confusing as there are indeed changes after it. Not a biggie, just a small pass over the CHANGELOGs. [ci skip]
* Merge pull request #22581 from hirocaster/fix-expect-sample-codeYves Senn2015-12-211-4/+5
|\ | | | | | | | | | | [ci skip] Change output timming of sample code
| * Change output timming of sample codehirocaster2015-12-141-2/+2
| | | | | | | | - Expect returns "new value 1" but, retuns nil, because output at thread is not finished. Move val_1 output to finished thread.
* | Merge pull request #22706 from habermann24/fix_mattr_accessor_docsYves Senn2015-12-211-6/+6
|\ \ | | | | | | Fix documentation for mattr_accessor methods [ci skip]
| * | Fix documentation for mattr_accessor methodsJan Habermann2015-12-201-6/+6
| | |
* | | Suppress warning ambiguous first argumentyui-knk2015-12-201-1/+1
|/ / | | | | | | | | Suppress warning (warning: ambiguous first argument; put parentheses or a space even after `/' operator)
* | Add a commend about deprecation of ActiveSupport::OrderedHashRafael Mendonça França2015-12-201-1/+1
| | | | | | | | | | | | | | It is in the code to provides backward compatibility for people that have this class serialized as YAML in some storage. Closes #22681
* | Deprecation warning now targets at 5.1Akira Matsuda2015-12-192-2/+6
| | | | | | | | | | Also, added a test case to make sure that the default deprecation horizon is always bigger than the current Rails version.
* | Merge pull request #22479 from RobinClowers/fix-cache-notification-orderKasper Timm Hansen2015-12-192-20/+24
|\ \ | | | | | | Fix cache fetch miss notification order
| * | Fix cache fetch miss notification orderRobin Clowers2015-12-022-20/+24
| | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/22477. When I improved the caching instrumentation in edd33c08d98723ae9bb89cf7f019277117ed6414, I inadvertently changed the order of AS notifications when there is a cache miss.
* | | Add CHANGELOG headers for Rails 5.0.0.beta1eileencodes2015-12-181-0/+5
| | |
* | | Change `alpha` to `beta1` to prep for release of Rails 5eileencodes2015-12-181-1/+1
| | | | | | | | | | | | :tada: :beers:
* | | Fix test that fails in isolationeileencodes2015-12-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test needs to have a require for the Listen gem or else it returns an error when run by itself or with a certain order in the Active Support tests. We use `silence_warnings` because Listen has some warnings about private methods. It's already silenced when it's required in Active Support EventedFileUpdateChecker. ``` 1) Error: EventedFileUpdateCheckerTest#test_should_not_execute_the_block_if_no_paths_are_given: NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen test/evented_file_update_checker_test.rb:21:in `teardown' ```
* | | Delete duplicate testeileencodes2015-12-181-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test was was in here twice so we were seeing this error: ``` activesupport/test/caching_test.rb:658: warning: method redefined; discarding old test_local_cache_of_read_nil activesupport/test/caching_test.rb:634: warning: previous definition of test_local_cache_of_read_nil was here ```
* | | [ci skip] Revert most of ff851017Kasper Timm Hansen2015-12-181-2/+2
| | | | | | | | | We went back to `Thread.current[]` in 33e11e59.
* | | Revert "Use Thread.current.thread_variable_set/get insetad of the direct ↵David Heinemeier Hansson2015-12-181-4/+4
| | | | | | | | | | | | | | | | | | accessors" This reverts commit 301f43820562c6a70dffe30f4227ff0751f47d4f per @matthewd on https://github.com/rails/rails/pull/22630/files#r47997074
* | | [ci skip] Add `Thread.current` to match internalsKasper Timm Hansen2015-12-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | We call the thread variable accessors on `Thread.current`, which matches Ruby's documentation: http://ruby-doc.org/core-2.2.0/Thread.html#method-i-thread_variable_get Fix these to stay `current` ( ͡° ͜ʖ ͡°)
* | | Clarify thread_mattr_accessor subclass behavior documentationNate Berkopec2015-12-171-8/+9
| | | | | | | | | | | | [ci skip]
* | | Copy-edit the Per Thread attribute accessor documentationRafael Mendonça França2015-12-171-3/+3
| | | | | | | | | | | | [ci skip]
* | | Use Thread.current.thread_variable_set/get insetad of the direct accessorsDavid Heinemeier Hansson2015-12-171-4/+4
| | |
* | | Fix typo in thread_mattr_accessor doco [ci skip]Nate Berkopec2015-12-171-1/+1
| | |
* | | Use separate test class nameDavid Heinemeier Hansson2015-12-171-1/+1
| | |
* | | Use consistent referencesDavid Heinemeier Hansson2015-12-171-3/+3
| | |
* | | Add thread_m/cattr_accessor/reader/writer suite of methods for declaring ↵David Heinemeier Hansson2015-12-175-0/+302
| | | | | | | | | | | | class and module variables that live per-thread
* | | Merge pull request #22592 from nwjsmith/disable-logger-message-broadcastsEileen M. Uchitelle2015-12-163-23/+40
|\ \ \ | | | | | | | | Add Logger option to disable message broadcasts
| * | | Add Logger option to disable message broadcastsNate Smith2015-12-163-23/+40
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | When setting the Rails logger to log to STDOUT, it would broadcast the log twice in development. This adds a setting that will prevent messages from being broadcast to multiple logs, while still allowing calls to `#close`, `#level=`, `#progname=`, and `#formatter=` to be broadcasted. Fixes #14769, #11415
* | | Merge pull request #22556 from imanel/range_prependKasper Timm Hansen2015-12-161-10/+7
|\ \ \ | | | | | | | | Use Module.prepend instead of alias_method for Range#to_s
| * | | Use Module.prepend instead of alias_method for Range#to_sBernard Potocki2015-12-161-10/+7
| | | |
* | | | Don't leak Object constants in core_ext/module/qualified_constGenadi Samokovarov2015-12-163-74/+107
| | | |
* | | | Merge pull request #22605 from tonyta/delete-dead-commentsRafael França2015-12-162-6/+0
|\ \ \ \ | | | | | | | | | | Delete dead code comments
| * | | | delete code commented out (and replaced) in e93d0a5Tony Ta2015-12-151-1/+0
| | | | |
| * | | | deletes commented code introduced in f238d495Tony Ta2015-12-151-5/+0
| | |/ / | |/| | | | | | | | | | ActiveSupport::Multibyte::Unicode::Codepoint doesn't support this API
* | | | Merge pull request #22598 from yui-knk/deprecate_string_callbackRafael França2015-12-163-5/+26
|\ \ \ \ | |/ / / |/| | | Deprecate passing string to define callback.
| * | | Deprecate passing string to define callback.yui-knk2015-12-163-5/+26
| |/ /
* | | lazy load listen in coreXavier Noria2015-12-131-1/+4
| | | | | | | | | | | | See the rationale in the comment present in this patch.
* | | let config.file_watcher be the way to enable the evented file watcherXavier Noria2015-12-131-4/+9
|/ / | | | | | | | | | | | | | | | | | | | | Before this commit, the sole presence of the Listen constant enabled the evented file watcher (unless listen resorted to the polling backend). This way, applications may depend on listen for other stuff independently of this feature. Also, allows teams with mixed setups to decide at boot time whether the evented watcher should be enabled for each particular instance.
* | Correct the time comparison for remember_me tokenJeffrey Warren2015-12-101-1/+1
| | | | | | | | | | Corrects the time comparison to be `Time.now < time` which allows the user to be set only when the current time is less than the 2 week window given in the example.
* | renames AS::FileEventedUpdateChecker to AS::EventedFileUpdateCheckerXavier Noria2015-12-093-6/+6
| | | | | | | | Better English.
* | Merge pull request #22517 from Elektron1c97/masterRafael França2015-12-071-2/+1
|\ \ | | | | | | [ci skip] Add a dollar sign to each command in the READMEs
| * | [ci skip] Add a dollar sign to each command in the READMEsElektron1c972015-12-061-2/+1
| |/ | | | | | | | | | | According to pr #22443 in the guides there's always a dollar sign before every command, so why is in the main README a `$` and in every submodule a `%`? Just eye candy..
* | Merge pull request #22428 from thedarkone/subs-notifEileen M. Uchitelle2015-12-063-4/+24
|\ \ | | | | | | Subscribing to notifications while inside the said instrumented section
| * | Subscribing to notifications while inside the said instrumented section.thedarkone2015-11-283-4/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue is that on the exit from Instrumenter#instrument section, an Evented listener will run into an error because its thread local (Thread.current[:_timestack]) has not been set up by the #start method (this obviously happens because the Evented listeners didn't exist at the time, since no subscribtion to that section was made yet). Note: support for subscribing to instrumented sections, while being inside those instrumented sections, might be removed in the future. Maybe fixes #21873.
* | | Merge pull request #22202 from grosser/grosser/write-consistentArthur Nogueira Neves2015-12-052-4/+12
|\ \ \ | |_|/ |/| | even if a write fails, store the raw value
| * | even if a write fails, store the raw valueMichael Grosser2015-11-292-4/+12
| |/
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 13:59:00 +0000