aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* fix nodocsVijay Dev2011-12-091-1/+1
|
* Remove NilClass whiners feature.José Valim2011-12-082-83/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Removing this feature causes boost in performance when using Ruby 1.9. Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str` in some STDLIB methods (like Array#join). To do such implicit conversions, Ruby 1.9 always dispatches the method and rescues the NoMethodError exception in case one is raised. Therefore, since the whiners feature defined NilClass#method_missing, such implicit conversions for nil became much, much slower. In fact, just defining NilClass#method_missing (even without the whiners feature) already causes a massive slow down. Here is a snippet that shows such slow down: require "benchmark" Benchmark.realtime { 1_000.times { [nil,nil,nil].join } } class NilClass def method_missing(*args) raise NoMethodError end end Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
* Fix inflection regexes for mouse, miceMark Rushakoff2011-12-072-4/+8
|
* Just track "require" if we have something in the watching stack.José Valim2011-12-061-1/+5
| | | | | | | | A patch has been provided earlier and we have asked for feedback: https://gist.github.com/1437939 Except one case, all other cases showed improvements in boot time.
* make method signatures match the superclass signatureAaron Patterson2011-12-051-2/+2
|
* return value is never tested, so stop calling `presence`Aaron Patterson2011-12-051-1/+1
|
* Merge pull request #3845 from sumbach/test-return-value-from-requireAaron Patterson2011-12-041-0/+79
|\ | | | | Add tests for the return value of require
| * Simplify load and require testsSam Umbach2011-12-031-4/+4
| | | | | | | | - These tests don't use autoloading so there's no need to add anything to autoload_paths
| * Test that require and load raise LoadError if file not foundSam Umbach2011-12-031-0/+16
| |
| * Test return value of ActiveSupport::Dependencies::Loadable#loadSam Umbach2011-12-031-0/+16
| |
| * Test return value of ActiveSupport::Dependencies::Loadable#requireSam Umbach2011-12-031-0/+47
| | | | | | | | | | - Add tests to protect from regressions in require's return value behavior - See a10606c490471d8e1483acb3b31d7f2d51e9ebbe (require needs to return true or false) for the original bug fix
* | Restore performance of ERB::Util.html_escapeJon Jensen2011-12-032-7/+18
|/ | | | | | | Revert html_escape to do a single gsub again, but add the "n" flag (no language, i.e. not multi-byte) to protect against XSS via invalid utf8 Signed-off-by: José Valim <jose.valim@gmail.com>
* Added Enumerable#pluck to wrap the common pattern of collect(&:method) *DHH*David Heinemeier Hansson2011-12-023-3/+19
|
* switch WatchStack to use composition, tighten up APIAaron Patterson2011-11-301-6/+13
|
* Revert "Implement ArraySerializer and move old serialization API to a new ↵José Valim2011-11-301-1/+1
| | | | | | | | | | | | | namespace." This reverts commit 8896b4fdc8a543157cdf4dfc378607ebf6c10ab0. Conflicts: activemodel/lib/active_model.rb activemodel/lib/active_model/serializable.rb activemodel/lib/active_model/serializer.rb activemodel/test/cases/serializer_test.rb
* Revert "avoid hundreds of thousands of calls to (Symbol|String)#to_s"Aaron Patterson2011-11-301-2/+2
| | | | | Test coverage isn't comprehensive enough to catch what this breaks. :( This reverts commit 45dad592e47944704ab6951351b2fa29d4a2385f.
* avoid hundreds of thousands of calls to (Symbol|String)#to_sAaron Patterson2011-11-301-2/+2
|
* Log 'Filter chain halted as CALLBACKNAME rendered or redirected' every time ↵José Valim2011-11-302-5/+25
| | | | a before callback halts.
* Module#synchronize is deprecated with no replacement. Please use `monitor` ↵Aaron Patterson2011-11-293-89/+5
| | | | from ruby's standard library.
* Fix typo in AS::TaggedLoggingClaudio Poli2011-11-291-1/+1
|
* Revert "Used any? instead of length call"Xavier Noria2011-11-282-2/+2
| | | | | | | | | Reason: This is slower, and any? is not equivalent in the general case. See discussion in https://github.com/rails/rails/pull/3779 This reverts commit 20cbf8eddc3844126d20f1218f068889d17b0dcf.
* Used any? instead of length callRahul P. Chaudhari2011-11-282-2/+2
|
* Merge pull request #3767 from tadast/object_inYehuda Katz2011-11-262-7/+27
|\ | | | | Object#in? also accepts multiple parameters
| * Object#in? also accepts multiple parametersTadas Tamošauskas2011-11-262-7/+27
| |
* | add more tests for monday and sunday methodsVijay Dev2011-11-261-0/+2
| |
* | Tests added for monday and sunday Arun Agrawal2011-11-261-0/+8
| | | | | | | | | | Reference commits : a8f2860d0e7db86c61bb70935006100b04667ab1 80ac4dc6d0632937ccf61b38bc15fc2f6e27b18b
* | Adds Time#sunday methodVijay Dev2011-11-261-0/+6
| |
* | Convert aliases monday and sunday to methodsVijay Dev2011-11-262-3/+18
| | | | | | | | | | | | | | | | A recent change to beginning_of_week and end_of_week added an argument that can be used to specify the week's starting day as a symbol. Now these methods were aliased as monday and sunday respectively which as a consequence of the argument addition, made calls like obj.monday(:sunday) possible. This commit makes them methods on their own.
* | minor doc changesVijay Dev2011-11-261-3/+3
| |
* | some tweaks to PR#3547. [Closes #3547]Xavier Noria2011-11-252-7/+15
| |
* | API docstrings updated with default value infogregolsen2011-11-252-6/+6
| |
* | beginning_of_week extended in both Time and Date so that to return week ↵gregolsen2011-11-254-16/+70
| | | | | | | | start based on start day that is monday by default
* | Rely solely on active_model_serializer and remove the fancy constant lookup.José Valim2011-11-232-0/+6
| |
* | Implement ArraySerializer and move old serialization API to a new namespace.José Valim2011-11-231-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | The following constants were renamed: ActiveModel::Serialization => ActiveModel::Serializable ActiveModel::Serializers::JSON => ActiveModel::Serializable::JSON ActiveModel::Serializers::Xml => ActiveModel::Serializable::XML The main motivation for such a change is that `ActiveModel::Serializers::JSON` was not actually a serializer, but a module that when included allows the target to be serializable to JSON. With such changes, we were able to clean up the namespace to add true serializers as the ArraySerializer.
* | Add safe_constantize to ActiveSupport::Dependencies.José Valim2011-11-232-28/+43
| |
* | Merge branch 'master' into serializersJosé Valim2011-11-2340-1876/+2523
|\ \
| * | Optimize cache expansion by skipping rails cache id in nested keys.José Valim2011-11-232-58/+64
| | |
| * | Fix #3737 AS::expand_cache_key generates wrong key in certain situations ↵Olek Janiszewski2011-11-232-3/+14
| | | | | | | | | | | | | | | | | | | | | (part 2) `nil` and `false` both expand to `""` (empty string), while `true` expands to `"true"`; `false` should expand to `"false"`
| * | Fix #3737 AS::expand_cache_key generates wrong key in certain situationsOlek Janiszewski2011-11-232-12/+14
| | | | | | | | | | | | | | | `cache_key` method is never called when the argument is a 1-element array with something that responds to `cache_key`
| * | Merge pull request #3725 from marcandre/twz_eqlYehuda Katz2011-11-224-4/+30
| |\ \ | | | | | | | | Fix inconsistencies with Time{WithZone}#{hash,eql?}
| | * | Fix inconsistencies with Time{WithZone}#{hash,eql?}Marc-Andre Lafortune2011-11-224-4/+30
| | | |
| * | | remove nodoc on OrderedHashVijay Dev2011-11-221-1/+1
| | | |
| * | | tests predicates according to the boolean interpretation of their return ↵Xavier Noria2011-11-211-48/+48
| | | | | | | | | | | | | | | | | | | | | | | | value, not expecting specifically true or false Respecting Genuine assert_equal false Edition
| * | | Deprecate InstanceMethods namespace handling in ActiveSupport::Concern.José Valim2011-11-212-15/+7
| | | | | | | | | | | | | | | | This avoids the unnecessary "yo dawg, I heard you like include, so I put a module that includes your module when it is included" approach when building extensions.
| * | | Revert "tests predicates according to the boolean interpretation of their ↵Xavier Noria2011-11-212-51/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | return value, not expecting specifically true or false" Reason: there were some genuine tests for false when reading values, going to revise those ones. This reverts commit a539a5e3f3be68f027d3dfe43f88dc9f0642c743.
| * | | tests predicates according to the boolean interpretation of their return ↵Xavier Noria2011-11-212-55/+51
| | | | | | | | | | | | | | | | value, not expecting specifically true or false
| * | | cache entry: options[:compressed] is a regular flag, no need for !!Xavier Noria2011-11-212-4/+4
| | | |
| * | | adds a comment to clarify an edge caseXavier Noria2011-11-211-0/+3
| | | |
| * | | a couple of spurious spaces I saw in passingXavier Noria2011-11-211-2/+2
| | |/ | |/|
| * | Merge pull request #3668 from gregolsen/api_docstring_fixSantiago Pastorino2011-11-192-4/+4
| |\ \ | | | | | | | | updating API docstring so that user can infer default value
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 12:35:56 +0000