| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
PR #29163 introduced a change in behavior when a duration was
the denominator in a calculation - this was incorrect as dividing
by a duration should always return a `Numeric`. The behavior of
previous versions of Rails has been restored.
Fixes #29592.
|
|
|
|
| |
Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com>
|
|\
| |
| | |
Fix test failure in message verifier tests
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Without this, I get the following result on my machine
```
# Running:
F
Failure:
MessageVerifierTest#test_backward_compatibility_messages_signed_without_metadata [/home/deivid/Code/rails/activesupport/test/message_verifier_test.rb:91]:
--- expected
+++ actual
@@ -1 +1 @@
-{:some=>"data", :now=>2010-01-01 00:00:00 +0100}
+{:some=>"data", :now=>2010-01-01 00:00:00 +0000}
bin/test test/message_verifier_test.rb:89
```
|
|/ |
|
|
|
|
|
|
|
| |
The paragraphs retread ground covered by the title and the usage examples,
so let's just remove them.
[ Assain Jaleel & Kasper Timm Hansen ]
|
|\
| |
| | |
Document metadata support for MessageEncryptor
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | | |
Remove time stubs after each test
|
| | |
| | |
| | |
| | | |
Reverts 7abb6e0.
|
| | |
| | |
| | |
| | | |
[ Assain Jaleel & Kasper Timm Hansen ]
|
| |/
|/|
| |
| | |
[ Assain Jaleel & Kasper Timm Hansen ]
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Fix HashWithIndifferentAccess#default when include?(nil)
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The implementation of HashWithIndifferentAccess#default didn't
distinguish `default` from `default(nil)`, which caused an incorrect
result for `default` if `nil` was used as a key.
Define HashWithIndifferentAccess#dig so that hackery that behaves
differently from Hash#default can be removed from
HashWithIndifferentAccess#default.
|
|\ \
| | |
| | | |
Add documentation for class_attribute default option
|
| | | |
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We have some indentation cops. But now there is a little inconsistent
params indentations. Enable `Layout/FirstParameterIndentation` cop to
prevent newly inconsistent indentation added and auto-correct to
existing violations.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | |/
| |/|
| | |
| | |
| | |
| | | |
ActiveSupport::Cache::RedisStore
Broken in 8da30ad.
|
| |/ |
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
By making the Rails minitest behave like a standard minitest plugin
we're much more likely to not break when people use other minitest
plugins. Like minitest-focus and pride.
To do this, we need to behave like minitest: require files up front
and then perform the plugin behavior via the at_exit hook.
This also saves us a fair bit of wrangling with test file loading.
Finally, since the environment and warnings options have to be applied
as early as possible, and since minitest loads plugins at_exit, they
have to be moved to the test command.
* Don't expect the root method.
It's likely this worked because we eagerly loaded the Rails minitest plugin
and that somehow defined a root method on `Rails`.
* Assign a backtrace to failed exceptions.
Otherwise Minitest pukes when attempting to filter the backtrace (which
Rails' backtrace cleaner then removes).
Means the exception message test has to be revised too.
This is likely caused by the rails minitest plugin now being loaded for
these tests and assigning a default backtrace cleaner.
|
| |
| |
| |
| | |
Time.now` (#29681)
|
| |\
| | |
| | | |
Update MessageEncryptor example to use dynamic key length
|
| | |
| | |
| | |
| | | |
by OpenSSL
|
| |\ \
| | | |
| | | | |
Use frozen-string-literal in ActiveSupport
|
| | | | |
|
| |\ \ \
| | | | |
| | | | | |
Mention Time.zone.parse possibly throwing ArgumentError
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
```
/Users/kamipo/src/github.com/rails/rails/activesupport/test/core_ext/module_test.rb:402: warning: `*' interpreted as argument prefix
/Users/kamipo/src/github.com/rails/rails/activesupport/test/core_ext/module_test.rb:420: warning: `*' interpreted as argument prefix
```
|
| |\ \ \ \
| | |_|/ /
| |/| | |
| | | | | |
Return prefixed method names from `Module.delegate`, if using prefixes
|
| |/ / /
| | | |
| | | |
| | | | |
if using prefix version.
|
| |\ \ \ |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
|
| | |\ \ \
| | | | | |
| | | | | |
| | | | | | |
Enforce frozen string in Rubocop
|
| | | | | | |
|
| | |\ \ \ \
| | | |_|_|/
| | |/| | |
| | | | | | |
Make ActiveSupport frozen-string-literal friendly.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The ActiveSupport test suite only passes currently if it uses the latest unreleased commits for dalli, and a patch for Builder:
https://github.com/tenderlove/builder/pull/6
Beyond that, all external dependencies (at least, to the extent they’re used by ActiveSupport) are happy, including Nokogiri as of 1.8.0.
|
| |/ / / / |
|
| | |/ /
| |/| | |
|
| |\ \ \
| | | | |
| | | | | |
Add source code and changelog links to gemspecs
|
| | | | | |
|
| |\ \ \ \
| | | | | |
| | | | | | |
Remove useless class checking for `ActiveSupport::Callbacks`s result_lambda
|