aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #18554 from mechanicles/use-take-methodSantiago Pastorino2015-01-171-1/+1
|\ | | | | A little performance improvement using 'take' method over 'first'
| * A little performance improvement using 'take' method over 'first'Santosh Wadghule2015-01-161-1/+1
| |
* | - Moved hwia frozen value assignment test to hash_ext_test similar to other ↵Vipul A M2015-01-172-7/+9
| | | | | | | | | | | | | | tests - Fixed the wrong use of with_indifferent_access on hash in the test which failed for isolated tests - Renamed to appropriately specify what the test does
* | Fix assignment for frozen value in HWIAAditya Kapoor2015-01-173-1/+15
|/
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-01-152-81/+71
|\
| * Fix docs for ActiveSupport::Inflector methodsclaudiob2015-01-032-81/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many methods in ActiveSupport::Inflector were actually documenting the String methods with the same name. For instance the doc for `camelize` said: > If the argument to +camelize+ is set to <tt>:lower</tt>... while it should say: > If the +uppercase_first_letter+ parameter is set to false [ci skip]
* | Add missing time zone definitions for Russian FederationAndrey Novikov2015-01-132-1/+9
| | | | | | | | Also sync Russian Federation time zones with `zone.tab` file from tzdata version 2014j.
* | Removing :en in favor of I18n.default_locale in duration#inspectDominik Masur2015-01-122-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hi there, i have an app without english as available locale. So i got an error when we try to inspect something like 1.day. This is done automatically when we use the dalli cache. I would like to change the :en to ::I18n.default_locale to be sure that this is always constant and is an available locale. Tests are all green with this change. Calculating ------------------------------------- :locale => :en 2.024k i/100ms :locale => ::I18n.default_locale 2.236k i/100ms ------------------------------------------------- :locale => :en 25.758k (±26.3%) i/s - 117.392k :locale => ::I18n.default_locale 26.311k (±18.1%) i/s - 127.452k
* | Merge pull request #18436 from deepj/fork-detectionCarlos Antonio da Silva2015-01-111-1/+1
|\ \ | | | | | | Better fork detection in ActiveSupport::Testing::Isolation
| * | Better fork detection in ActiveSupport::Testing::Isolationdeepj2015-01-101-3/+1
| | | | | | | | | | | | | | | Process.respond_to?(:fork) returns false if fork is not available. More on http://www.ruby-doc.org/core-2.0.0/Process.html#method-c-fork
* | | No need of requiring `rbconfig`, it is by-default loadedKuldeep Aggarwal2015-01-102-3/+0
|/ /
* | formatting pass over CHANGELOGs. [ci skip]Yves Senn2015-01-101-1/+3
| |
* | Add missing requireGuillermo Iguaran2015-01-091-0/+2
| |
* | Add SecureRandom.base58Guillermo Iguaran2015-01-093-0/+45
| |
* | Use Ruby's #include? to avoid relying on AS extensionCarlos Antonio da Silva2015-01-061-1/+1
| | | | | | | | | | | | | | | | The build has failed when running the date/time ext tests in isolation due to the missing extension, so better than adding a require is using just Ruby in this case. https://travis-ci.org/rails/rails/jobs/46107954#L1077
* | Add #prev_day and #next_day as counterparts to #yesterday and #tomorrow for ↵George Claghorn2015-01-063-6/+31
| | | | | | | | Date, Time, and DateTime
* | Add same_time option to #prev_week and #next_week for Date, Time, and DateTimeGeorge Claghorn2015-01-063-17/+42
| |
* | Add #on_weekend?, #next_weekday, and #prev_weekday methods to Date, Time, ↵George Claghorn2015-01-063-0/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | and DateTime `#on_weekend?` returns true if the receiving date/time falls on a Saturday or Sunday. `#next_weekday` returns a new date/time representing the next day that does not fall on a Saturday or Sunday. `#prev_weekday` returns a new date/time representing the previous day that does not fall on a Saturday or Sunday.
* | adding documentation for 'remove_possible_method' and 'redefine_method' [ci ↵George Millo2015-01-051-0/+3
| | | | | | | | skip]
* | Merge pull request #18090 from egilburg/patch-3Rafael Mendonça França2015-01-041-9/+1
|\ \ | | | | | | | | | simplify ActiveSupport.test_order definition
| * | simplify ActiveSupport.test_order definitionEugene Gilburg2014-12-181-9/+2
| | |
* | | Do not include Active Support on testsRafael Mendonça França2015-01-043-30/+24
| | | | | | | | | | | | It was not done to be included
* | | Merge pull request #18328 from brainopia/remove_tz_proxyRafael Mendonça França2015-01-042-11/+6
|\ \ \ | | | | | | | | Use directly TZInfo::Timezone without proxy
| * | | Use directly TZInfo::Timezone without proxybrainopia2015-01-042-11/+6
| | | | | | | | | | | | | | | | | | | | Since real timezone is loaded anyway in `#utc_offset` which is called during `#create`
* | | | Remove extra class_eval for Ruby 1.9Carlos Antonio da Silva2015-01-041-5/+2
| | | |
* | | | Remove workaround to a Ruby 2.0.0 bugRafael Mendonça França2015-01-041-7/+0
| | | |
* | | | Remove Struct#to_h backportRafael Mendonça França2015-01-043-17/+5
| | | |
* | | | String already respond_to scrub at Ruby 2.2Rafael Mendonça França2015-01-041-2/+1
| | | |
* | | | singleton_class? is already pressent at Ruby 2.2Rafael Mendonça França2015-01-041-8/+0
| | | |
* | | | Remove unneeded Time patch to support Ruby 1.9Rafael Mendonça França2015-01-042-30/+2
| | | |
* | | | Remove some comments about Ruby 1.9 behaviorsRafael Mendonça França2015-01-044-7/+7
| | | |
* | | | Remove debugger supportRafael Mendonça França2015-01-043-35/+3
| | | | | | | | | | | | | | | | | | | | bebugger doesn't work with Ruby 2.2 so we don't need to support it anymore
* | | | Remove LoadError#path hack for Ruby 1.9claudiob2015-01-041-2/+0
| | | | | | | | | | | | | | | | | | | | Now that Rails requires Ruby >= 2.0 there is need to skip the `test_depend_on_path` test.
* | | | Remove hack to support BigDecimal in Ruby 1.9claudiob2015-01-042-21/+3
| | | | | | | | | | | | | | | | | | | | Now that Rails requires Ruby >= 2.0, there is no need to check whether `BigDecimal` exists or not.
* | | | remove files which is dependent on ruby1.9 as we do not support Ruby1.9Kuldeep Aggarwal2015-01-041-11/+3
|/ / / | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/attribute_methods/read.rb
* | | Remove unneeded `require 'as/deprecation'`claudiob2015-01-041-1/+0
| | | | | | | | | | | | | | | Tests should still pass after removing `require 'active_support/deprecation'` from these files since the related deprecations have been removed.
* | | Change the default test order from `:sorted` to `:random`Rafael Mendonça França2015-01-043-30/+18
| | |
* | | Remove deprecated ActiveSupport::JSON::Encoding::CircularReferenceError.Rafael Mendonça França2015-01-043-46/+4
| | |
* | | Remove deprecated ActiveSupport::JSON::Encoding.encode_big_decimal_as_string=Rafael Mendonça França2015-01-043-43/+5
| | |
* | | Remove deprecated `ActiveSupport::SafeBuffer#prepend`Rafael Mendonça França2015-01-043-16/+4
| | |
* | | Remove deprecated methods at `Kernel`.Rafael Mendonça França2015-01-043-127/+6
| | | | | | | | | | | | `silence_stderr`, `silence_stream`, `capture` and `quietly`.
* | | Remove deprecated core_ext/big_decimal/yaml_conversions fileRafael Mendonça França2015-01-043-25/+5
| | |
* | | Remove deprecated ActiveSupport::Cache::Store.instrumentRafael Mendonça França2015-01-042-14/+5
| | |
* | | Merge pull request #17227 from claudiob/explicitly-abort-callbacksRafael Mendonça França2015-01-035-11/+175
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps. Conflicts: railties/CHANGELOG.md
| * | | Add config to halt callback chain on return falseclaudiob2015-01-024-7/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This stems from [a comment](rails#17227 (comment)) by @dhh. In summary: * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning. * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning. For this purpose, this commit introduces a Rails configuration option: ```ruby config.active_support.halt_callback_chains_on_return_false ``` For new Rails 5.0 apps, this option will be set to `false` by a new initializer `config/initializers/callback_terminator.rb`: ```ruby Rails.application.config.active_support.halt_callback_chains_on_return_false = false ``` For existing apps ported to Rails 5.0, the initializers above will not exist. Even running `rake rails:update` will not create this initializer. Since the default value of `halt_callback_chains_on_return_false` is set to `true`, these apps will still accept `return true` as a way to halt callback chains, displaying a deprecation warning. Developers will be able to switch to the new behavior (and stop the warning) by manually adding the line above to their `config/application.rb`. A gist with the suggested release notes to add to Rails 5.0 after this commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
| * | | Deprecate `false` as the way to halt AS callbacksclaudiob2015-01-023-3/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After this commit, returning `false` in a callback will display a deprecation warning to make developers aware of the fact that they need to explicitly `throw(:abort)` if their intention is to halt a callback chain. This commit also patches two internal uses of AS::Callbacks (inside ActiveRecord and ActionDispatch) which sometimes return `false` but whose returned value is not meaningful for the purpose of execution. In both cases, the returned value is set to `true`, which does not affect the execution of the callbacks but prevents unrequested deprecation warnings from showing up.
| * | | Throw :abort halts default CallbackChainsclaudiob2015-01-023-10/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes arguments and default value of CallbackChain's :terminator option. After this commit, Chains of callbacks defined **without** an explicit `:terminator` option will be halted as soon as a `before_` callback throws `:abort`. Chains of callbacks defined **with** a `:terminator` option will maintain their existing behavior of halting as soon as a `before_` callback matches the terminator's expectation. For instance, ActiveModel's callbacks will still halt the chain when a `before_` callback returns `false`.
* | | | Fix a few typos [ci skip]Robin Dupret2015-01-031-1/+1
| |_|/ |/| |
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-01-032-3/+23
|\ \ \ | |/ / |/| |
| * | Better docs for NameErrorclaudiob2014-12-251-0/+14
| | | | | | | | | | | | | | | | | | Add examples for missing_name, missing_name? [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 12:28:52 +0000