aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Remove AS methods that are never invokedclaudiob2015-09-131-68/+6
| | | | | | | | | | | | | | | | | | | | Fixes #21122 - does not change any current behavior; simply reflects the fact that two conditions of the if/else statement are never reached. The reason is #17227 which adds a default terminator to AS::Callbacks. Therefore, even callback chains that do not define a terminator now have a terminator, and `chain_config.key?(:terminator)` is always true. Of course, if no terminator was defined, then we want this new default terminator not to do anything special. What the terminator actually does (or should do) is discussed in #21218 but the simple fact that a default terminator exists makes this current PR valid. *Note* that the conditional/simple methods have not been removed in AS::Conditionals::Filter::After because of `:skip_after_callbacks_if_terminated` which lets a user decide **not** to skip after callbacks even if the chain was terminated.
* Fixed Time conversion example for UTC time zone [ci skip]Ronak Jangir2015-09-081-1/+1
|
* Merge pull request #20534 from qnm/activesupport-require-issueYves Senn2015-09-071-0/+1
|\ | | | | Add require to ensure Time#advance works without implicit required
| * Remove accidental ruby-versionRob Sharp2015-06-121-1/+0
| |
| * Add missing require to ensure #advance will work without being implicity ↵Rob Sharp2015-06-122-0/+2
| | | | | | | | required
* | Merge pull request #21250 from ronakjangir47/safe_constYves Senn2015-09-071-0/+4
|\ \ | | | | | | | | | safe_constantize - Added Object scoped missing test cases
| * | safe_constantize - Added Object scoped missing test casesRonak Jangir2015-09-061-0/+2
| | |
* | | Removed Extra ‘the’ [ci skip]Ronak Jangir2015-09-061-1/+1
|/ /
* | Update Unicode Version to 8.0.0Anshul Sharma2015-09-043-1/+5
| |
* | docs, make `blank?` behavior clear. Closes #21468. [ci skip]Yves Senn2015-09-021-2/+2
| |
* | Merge pull request #21467 from yui-knk/doc/subscribeZachary Scott2015-09-021-2/+2
|\ \ | | | | | | [ci skip] Add description about which object
| * | [ci skip] Add description about which objectyui-knk2015-09-021-2/+2
| | | | | | | | | | | | `ActiveSupport::Notifications.subscribe` expects as second parameter.
* | | No need CHANGELOG entry for #21421 [ci skip]Rafael Mendonça França2015-09-011-6/+0
| | |
* | | ArrayInquirer to correctly find symbols or stringsLeigh Halliday2015-08-283-11/+22
|/ / | | | | | | | | | | | | | | | | The problem existed where if your ArrayInquirer values were strings but you checked them using any? with a symbol, it would not find the value. Now it will correctly check whether both the String form or the Symbol form are included in the Array. `
* | Tiny documentation improvements [ci skip]Robin Dupret2015-08-281-5/+6
| |
* | - Extracted `DELIMITED_REGEX` to `delimited_regex` method and made use of ↵Vipul A M2015-08-284-2/+23
| | | | | | | | | | | | | | | | | | | | user passed `options[:delimited_regex]` if available. Changed `DELIMITED_REGEX` to `DEFAULT)DELIMITED_REGEX` to signify what it means. - Added tests for number to delimited and number to currency in both actionview and activesupport. Changes Changes
* | 10X speed improvements for AS::Dependencies.loadable_constants_for_pathJean Boussier2015-08-271-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the autoload_paths start to grows, this methods is quite a hotspot >> ActiveSupport::Dependencies.autoload_paths.size => 49 >> Benchmark.ips { |x| x.report('baseline') { ActiveSupport::Dependencies.loadable_constants_for_path(File.expand_path('app/models/shop')) }} Calculating ------------------------------------- baseline 90.000 i/100ms ------------------------------------------------- baseline 1.073k (±20.2%) i/s - 4.950k After the patch Calculating ------------------------------------- patched 883.000 i/100ms ------------------------------------------------- patched 11.050k (±19.7%) i/s - 50.331k
* | Merge pull request #21387 from ronakjangir47/remove_dup_minitestKasper Timm Hansen2015-08-261-2/+0
|\ \ | | | | | | Removed duplicate require 'minitest/mock'
| * | Removed duplicate requiring minitest/mock as it is already required in ↵Ronak Jangir2015-08-261-2/+0
| | | | | | | | | | | | method_call_assertions
* | | Fixed to_datetime docs [ci skip]Ronak Jangir2015-08-261-2/+3
|/ /
* | Merge pull request #21257 from jdantonio/async-jobKasper Timm Hansen2015-08-251-1/+1
|\ \ | | | | | | Initial implementation of ActiveJob AsyncAdapter.
| * | Initial implementation of ActiveJob AsyncAdapter.Jerry D'Antonio2015-08-251-1/+1
| | |
* | | Merge pull request #21281 from ronakjangir47/added_docsRafael Mendonça França2015-08-251-1/+10
|\ \ \ | |/ / |/| | Added docs for TimeWithZone [ci skip]
| * | Added docs for TimeWithZone [ci skip]Ronak Jangir2015-08-181-1/+10
| | |
* | | use `caller_locations` instead of `caller`Aaron Patterson2015-08-242-3/+14
| | | | | | | | | | | | | | | We have `caller_locations`, so we don't need to parse the strings in the callstack.
* | | minor documentation improvement [ci skip]Sam Auciello2015-08-241-2/+2
| | |
* | | temp files are no more requireGaurav Sharma2015-08-251-2/+0
| | | | | | | | | `:nail_care:`
* | | Merge branch 'master' of github.com:rails/railsVijay Dev2015-08-2443-278/+884
|\ \ \ | | | | | | | | | | | | | | | | Conflicts: guides/source/security.md
| * \ \ Merge pull request #16245 from byroot/more-atomic-writeMatthew Draper2015-08-211-27/+29
| |\ \ \ | | | | | | | | | | File renaming should be the last operation of an atomic write
| | * | | File renaming should be the last operation of an atomic writeJean Boussier2015-08-201-27/+29
| | | | |
| * | | | Merge pull request #21300 from jonahb/cacheYves Senn2015-08-201-1/+1
| |\ \ \ \ | | | | | | | | | | | | Correct cache store superclass in comment [ci skip]
| | * | | | Correct cache store superclass in commentJonah Burke2015-08-191-1/+1
| | | |/ / | | |/| |
| * | | | Merge pull request #21279 from ronakjangir47/test_cleanupKasper Timm Hansen2015-08-202-2/+10
| |\ \ \ \ | | |/ / / | |/| | | Cleaned up generators tests using internal assertion helper
| | * | | Cleaned up generators tests using internal assertion helperRonak Jangir2015-08-202-2/+10
| | |/ /
| * / / Use == 0 instead of .zero? in #tryJean Boussier2015-08-171-1/+1
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The perf gain is relatively minor but consistent: ``` Calculating ------------------------------------- 0.zero? 137.091k i/100ms 1.zero? 137.350k i/100ms 0 == 0 142.207k i/100ms 1 == 0 144.724k i/100ms ------------------------------------------------- 0.zero? 8.893M (± 6.5%) i/s - 44.280M 1.zero? 8.751M (± 6.4%) i/s - 43.677M 0 == 0 10.033M (± 7.0%) i/s - 49.915M 1 == 0 9.814M (± 8.0%) i/s - 48.772M ``` And try! is quite a big hotspot for us so every little gain is appreciable.
| * | Replacing lambda with proc getting argument error because of it.Ronak Jangir2015-08-172-1/+7
| | |
| * | Merge pull request #20647 from twalpole/method_source_dependencyRafael Mendonça França2015-08-141-0/+1
| |\ \ | | | | | | | | Add method_source dependency to activesupport
| | * | Add method_source dependency to activesupportThomas Walpole2015-07-291-0/+1
| | | |
| * | | Merge pull request #21025 from ronakjangir47/assertsKasper Timm Hansen2015-08-132-1/+18
| |\ \ \ | | | | | | | | | | Added helper methods to stub any instance
| | * | | Added helper methods to stub any instanceRonak Jangir2015-08-132-1/+18
| | | | |
| * | | | Merge pull request #21219 from repinel/assert-human-size-prefix-deprecatedYves Senn2015-08-131-8/+10
| |\ \ \ \ | | | | | | | | | | | | Assert that the `:prefix` option of `number_to_human_size` is deprecated
| | * | | | Assert that the `:prefix` option of `number_to_human_size` is deprecatedRoque Pinel2015-08-121-8/+10
| | | | | |
| * | | | | Merge pull request #21217 from myrridin/myrridin-documentation-updatesZachary Scott2015-08-122-4/+4
| |\ \ \ \ \ | | |/ / / / | |/| | | | [ci skip] Documentation: Switch around a common phrase for readability
| | * | | | [ci skip] Switch around a common idiom for readabilityThomas Hart II2015-08-052-4/+4
| | | |/ / | | |/| |
| * | | | [ci skip] Fix rdoc markupakihiro172015-08-121-1/+1
| | |/ / | |/| |
| * | | :nodoc: internal class [ci skip]Godfrey Chan2015-08-101-1/+1
| | | |
| * | | Deprecate :si prefix in number_to_human_size without replacementJean Boussier2015-08-102-9/+15
| | | |
| * | | Deprecate the :prefix option of `number_to_human_size`Jean Boussier2015-08-102-2/+4
| | | |
| * | | Merge pull request #21124 from kirs/feature/reload-i18nKasper Timm Hansen2015-08-101-2/+17
| |\ \ \ | | | | | | | | | | Reload I18n.load_path in development
| | * | | Reload I18n locales in developmentKir Shatrov2015-08-101-2/+17
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-04 11:00:03 +0000