aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge pull request #24422 from matthewd/extinguish-executor-exceptionsMatthew Draper2016-04-073-4/+156
|\ \ \ \ | | | | | | | | | | Clean up after a failure in a run callback
| * | | | Directly support stateful executor hooksMatthew Draper2016-04-053-4/+156
| | | | | | | | | | | | | | | | | | | | Also, make sure to call the +complete+ hooks if +run+ fails.
* | | | | Avoid unused captureRyuta Kamizono2016-04-051-1/+1
| | | | |
* | | | | Merge pull request #24345 from ↵Rafael França2016-04-052-4/+19
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | mtsmfm/fix-marshal-with-autoloading-for-nested-class Fix marshal with autoloading for nested class/module
| * | | | | Fix marshal with autoloading for nested class/moduleFumiaki MATSUSHIMA2016-03-282-4/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #24150 break autoloading for nested class/module. There is test for nested class but it doesn't work correctly. Following code will autoload `ClassFolder::ClassFolderSubclass` before `Marshal.load`: `assert_kind_of ClassFolder::ClassFolderSubclass, Marshal.load(dumped)`
* | | | | | Merge pull request #24401 from pan/number-to-phoneRafael Mendonça França2016-04-054-3/+28
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | `number_to_phone` formats number with regexp
| * | | | | `number_to_phone` formats number with regexpPan GaoYong2016-04-024-3/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By default, this method formats US number. This commit extends its functionality to format number for other countries with a custom regular expression. number_to_phone(18812345678, pattern: /(\d{3})(\d{4})(\d{4})/) # => 188-1234-5678 The output phone number is divided into three groups, so the regexp should also match three groups of numbers.
* | | | | | Match `String#to_time`'s behaviour to rubySiim Liiser2016-04-043-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously `String#to_time` returned the midnight of the current date in some cases where there was no relavant information in the string. Now the method returns `nil` instead in those cases. Fixes #22958.
* | | | | | Call super instead of returning nil for DateTime#<=>Andrew White2016-04-033-5/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The native DateTime#<=> implementation can be used to compare instances with numeric values being considered as astronomical julian day numbers so we should call that instead of returning nil. Fixes #24228.
* | | | | | Use block form of Dir.mktmpdir to ensure tidy upAndrew White2016-04-031-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the test run was interrupted in some way then it left temporary directories inside of test causing the git worktree to be in a dirty state. By overriding the run method we can use the block form of Dir.mktmpdir to ensure that the directories are cleaned up no matter which way the test run is exited.
* | | | | | Prevent void context warningsAndrew White2016-04-032-2/+2
| |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | The constant reference A::B used to trigger autoloading causes a warning to be logged about the possible use of :: in a void context so assign it to the _ variable to prevent the warnings from being triggered.
* | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-04-031-1/+1
|\ \ \ \ \
| * | | | | s/responsibilty/responsibility/Vipul A M2016-03-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | s/symantically/semantically/ [ci skip]
* | | | | | Remove not needed includingyui-knk2016-04-022-7/+0
| |/ / / / |/| | | | | | | | | | | | | | | | | | | Because `DateTime` inherits `Date` and `Date` includes `DateAndTime::Zones`, `DateTime` not need to include `DateAndTime::Zones` again.
* | | | | Fix method String#upcase_firstbogdanvlviv2016-03-314-4/+16
| | | | |
* | | | | Replace _meth with _method to remove ambiguityScott Latham2016-03-301-3/+3
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | Merge pull request #23895 from glaucocustodio/add_upcase_first_methodRafael Mendonça França2016-03-304-0/+22
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | Add upcase_first method
| * | | | Add upcase_first methodGlauco Custódio2016-02-254-0/+22
| | |_|/ | |/| |
* | | | Fix typo in Action Pack changelog [ci skip]Prathamesh Sonpatki2016-03-251-1/+1
| | | |
* | | | fixed spelling in the attribute_accessors docuTorsten Braun2016-03-231-1/+1
| | | | | | | | | | | | mattr_writer to mattr_reader
* | | | fixed spellin in the mattr_reader documentationTorsten Braun2016-03-231-1/+1
| | | | | | | | | | | | renamed cattr_reader to mattr_reader
* | | | guides, sync 5.0 release notes with changelogsYves Senn2016-03-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Sync AV, AR, AJ, AS, AM changelogs with our 5.0 release notes draft. This is a follow up to c94045d and contains changes made since the release of beta1.
* | | | Improve code readability in ActiveSupport::DependenciesAaron Ang2016-03-161-5/+6
| | | |
* | | | Add comments to ActiveSupport::Dependencies to help understandingAaron Ang2016-03-161-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In a previous patch, all log-related stuff was removed. However, some logs are still useful to understand the code. Therefore, in this patch, I put those log messages back as comments. [ci skip]
* | | | no need to clear an unusued collectionXavier Noria2016-03-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the code reaches that line new_constants is no longer needed. We only need here to iterate over it to discard stuff and done. Note that constant_watch_stack.new_constants returns a new reference each time it is invoked, so that #clear call was not cleaning state in some internal structure (which would have been a bit dirty as well at this level of coupling).
* | | | removes unreachable codeXavier Noria2016-03-161-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This array literal cannot be reached. The previous begin either returns to the caller via the explicit return in the ensure block if all goes well, or else propagates whatever make the begin block abort execution. I have investigated the origin of this a bit. In the past the ensure block didn't have a return call, see for example c08547d. Later on the return was added in 4da4506, but the trailing literal was left there.
* | | | tests the raising/throwing discards the watching stackXavier Noria2016-03-163-4/+8
| | | |
* | | | s/removes/discards/Xavier Noria2016-03-161-2/+2
| | | |
* | | | adds coverage for raising while autoloadingXavier Noria2016-03-162-0/+12
| | | |
* | | | adds coverage for throwing while autoloadingXavier Noria2016-03-152-0/+14
| | | | | | | | | | | | | | | | References #24205.
* | | | Remove log-related stuff from ActiveSupport::DependenciesAaron Ang2016-03-151-44/+0
| | | | | | | | | | | | | | | | | | | | In this patch, all log-related stuff in `ActiveSupport::Dependencies` is removed because the logging is no longer useful.
* | | | Use the most highest priority exception handler when cause is setSean Griffin2016-03-111-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was some subtle breakage caused by #18774, when we removed `#original_exception` in favor of `#cause`. However, `#cause` is automatically set by Ruby when raising an exception from a rescue block. With this change, we will use whichever handler has the highest priority (whichever call to `rescue_from` came last). In cases where the outer has lower precidence than the cause, but the outer is what should be handled, cause will need to be explicitly unset. Fixes #23925
* | | | Merge pull request #24150 from exviva/unmarshal-infinite-retryXavier Noria2016-03-113-1/+20
|\ \ \ \ | | | | | | | | | | Prevent `Marshal.load` from looping infinitely
| * | | | Prevent `Marshal.load` from looping infinitelyOlek Janiszewski2016-03-113-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a bug in `Marshal.load` that caused it to loop indefinitely when trying to autoload a constant that resolved to a different name. This could occur when marshalling an ActiveRecord 4.0 object (e.g. into memcached) and then trying to unmarshal it with Rails 4.2. The marshalled payload contains a reference to `ActiveRecord::ConnectionAdapters::Mysql2Adapter::Column`, which in Rails 4.2 resolves to `ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter::Column`.
* | | | | Merge pull request #24143 from perceptec/fix-thread-mattr-accessor-refsMatthew Draper2016-03-122-2/+8
|\ \ \ \ \ | | | | | | | | | | | | Fix `thread_mattr_accessor` thread-local variable naming
| * | | | | Fix `thread_mattr_accessor` thread-local variable namingMichael Ryan2016-03-112-2/+8
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implentation of `thread_mattr_accessor` is setting differently-named thread variables when defining class and instance writer methods, so the method isn't working as documented: Account.user = "DHH" Account.user # => "DHH" Account.new.user # => nil a = Account.new a.user = "ABC" # => "ABC" a.class.user # => "DHH" At this point `:attr_Account_user` and `:attr_Class_user` thread-local variables have been created. Modify the reader and writer methods to use the class name instead of 'Class'.
* / / / / use `ActiveSupport::Reloader.to_prepare` instead of deprecated ↵yuuji.yaginuma2016-03-111-1/+1
|/ / / / | | | | | | | | | | | | `ActionDispatch::Reloader.to_prepare` [ci skip]
* | | | Add missing require to tryRafael Mendonça França2016-03-111-0/+2
| | | |
* | | | Remove unused try requireBart de Water2016-03-101-1/+0
| | | |
* | | | revises the homepage URL in the gemspecs [ci skip]Xavier Noria2016-03-101-1/+1
| | | | | | | | | | | | | | | | References https://github.com/rails/homepage/issues/46.
* | | | friendly error message if missing listenJerry Cheung2016-03-081-1/+7
| |/ / |/| |
* | | Prevent nested ExecutionWrapper calls even when using run! directlyMatthew Draper2016-03-042-9/+16
| | |
* | | Fix CHANGELOG spacing [ci skip]Jeremy Daer2016-03-021-2/+2
| | |
* | | Merge pull request #23991 from kamipo/fix_activesupport_reloaderMatthew Draper2016-03-021-4/+3
|\ \ \ | | | | | | | | Fix `ActiveSupport::Reloader.check!`
| * | | Fix `ActiveSupport::Reloader.check!`Ryuta Kamizono2016-03-021-4/+3
| | | | | | | | | | | | | | | | | | | | The test failure in `bug_report_templates/action_controller_master.rb` is due to `app.reloader.check` is `nil`.
* | | | Merge pull request #23932 from arthurnn/arthurnn/remove_load_pathsArthur Nogueira Neves2016-03-011-7/+0
|\ \ \ \ | | | | | | | | | | Remove load_paths file
| * | | | Remove load_paths fileArthur Neves2016-02-271-7/+0
| | |/ / | |/| |
* | | | Remove duplicated `test_` prefix [ci skip]Ryuta Kamizono2016-03-021-1/+1
| |/ / |/| |
* | | Merge pull request #23936 from yui-knk/local_constants_to_be_publicRafael Mendonça França2016-03-014-3/+17
|\ \ \ | | | | | | | | | | | | Deprecate `Module.local_constants`
| * | | Deprecate `Module.local_constants`yui-knk2016-03-014-3/+17
| |/ / | | | | | | | | | | | | After Ruby 1.9, we can easily get the constants that have been defined locally by `Module.constants(false)`.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 09:23:41 +0000