Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Extract ActiveSupport::NumberHelper methods to classes | Matt Bridges | 2013-07-01 | 10 | -314/+533 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to the overall complexity of each method individually as well as the global shared private module methods, this pulls each helper into it's own converter class inheriting from a generic `NumberBuilder` class. * The `NumberBuilder` class contains the private methods needed for each helper method an eliminates the need for special definition of specialized private module methods. * The `ActiveSupport::NumberHelper::DEFAULTS` constant has been moved into the `NumberBuilder` class because the `NumberBuilder` is the only class which needs access to it. * For each of the builders, the `#convert` method is broken down to smaller parts and extracted into private methods for clarity of purpose. * Most of the mutation that once was necessary has now been eliminated. * Several of the mathematical operations for percentage, delimited, and rounded have been moved into private methods to ease readability and clarity. * Internationalization is still a bit crufty, and definitely could be improved, but it is functional and a bit easier to follow. The following helpers were extracted into their respective classes. * `#number_to_percentage` -> `NumberToPercentageConverter` * `#number_to_delimited` -> `NumberToDelimitedConverter` * `#number_to_phone` -> `NumberToPhoneConverter` * `#number_to_currency` -> `NumberToCurrencyConverter` * `#number_to_rounded` -> `NumberToRoundedConverter` * `#number_to_human_size` -> `NumberToHumanSizeConverter` * `#number_to_human` -> `NumberToHumanConverter` | ||||
* | add documentation for `ActiveSupport::Testing::SetupAndTeardown`. | Yves Senn | 2013-06-19 | 1 | -2/+17 |
| | |||||
* | better documentation for `AS::Testing::Declarative#test`. [ci skip] | Yves Senn | 2013-06-19 | 1 | -3/+6 |
| | |||||
* | we only support 1.9+, so just check for a name | Aaron Patterson | 2013-06-17 | 1 | -1/+1 |
| | |||||
* | be consistent about parameter types passed to new_constants_in | Aaron Patterson | 2013-06-17 | 1 | -1/+1 |
| | |||||
* | Rewind StringIO instances before be parsed again | Paco Guzman | 2013-06-16 | 5 | -0/+5 |
| | |||||
* | Use xml instead already parsed xml | Paco Guzman | 2013-06-16 | 1 | -1/+1 |
| | |||||
* | Merge pull request #10727 from pacoguzman/fix-xml-mini-tests | Rafael Mendonça França | 2013-06-15 | 6 | -6/+6 |
|\ | | | | | Fix XmlMini different backends tests | ||||
| * | Compare with the parsed result from REXML backend | Paco Guzman | 2013-05-22 | 6 | -6/+6 |
| | | |||||
* | | Updated the doc for const_regexp [ci skip] | Arun Agrawal | 2013-06-15 | 1 | -1/+3 |
| | | |||||
* | | Fix AS changelog [ci skip] | Carlos Antonio da Silva | 2013-06-14 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #10946 from arunagw/build_fix_for_object_const_get_nil | Xavier Noria | 2013-06-14 | 1 | -0/+3 |
|\ \ | | | | | | | We need to check exception name to be nil | ||||
| * | | Changing const_regexp to check for constant name. | Arun Agrawal | 2013-06-15 | 1 | -0/+3 |
| | | | | | | | | | | | | We need to return Regexp.escape(camel_cased_word) if the split is blank. | ||||
* | | | Add CHANGELOG entry for #10740 | Rafael Mendonça França | 2013-06-14 | 1 | -0/+9 |
| | | | | | | | | | | | | [ci skip] | ||||
* | | | Merge pull request #10740 from mrsimo/hash-with-indifferent-access-select | Rafael Mendonça França | 2013-06-14 | 2 | -0/+34 |
|\ \ \ | |/ / |/| | | HashWithIndifferentAccess#select working as intended | ||||
| * | | HashWithIndifferentAccess#select working as intended | Albert Llop | 2013-05-23 | 2 | -0/+34 |
| | | | | | | | | | | | | | | | | | | Before this commit, #reject returned a HashWithIndifferentAccess, whereas #select returned a Hash. Now #select also returns a HashWithIndifferentAccess. | ||||
* | | | Merge pull request #10943 from killthekitten/10932_constantize_empty | Xavier Noria | 2013-06-14 | 2 | -5/+10 |
|\ \ \ | | | | | | | | | Fix #10932. Treat "" and "::" as invalid on constantize | ||||
| * | | | Fix #10932. Treat "" and "::" as invalid on constantize | Nikolay Shebanov | 2013-06-14 | 2 | -5/+10 |
| | | | | |||||
* | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-06-14 | 3 | -8/+8 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md | ||||
| * | | | | minor doc changes to `ActiveSupport::BacktraceCleaner`. | Yves Senn | 2013-06-12 | 1 | -5/+5 |
| | | | | | |||||
| * | | | | correction on cache.fetch race_condition_ttl | dickeyxxx | 2013-05-23 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Documentation: Notifications queue does not run in a thread. | David Butler | 2013-05-20 | 1 | -2/+2 |
| | | | | | |||||
* | | | | | Add missing nsec test for 17f5d8e | Andrew White | 2013-06-13 | 1 | -0/+5 |
| | | | | | |||||
* | | | | | Keep sub-second resolution when wrapping a DateTime value | Andrew White | 2013-06-13 | 5 | -5/+32 |
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | Add `DateTime#usec` and `DateTime#nsec` so that `ActiveSupport::TimeWithZone` keeps sub-second resolution when wrapping a `DateTime` value. Fixes #10855 | ||||
* | | | | Drop extra variable from test | Vipul A M | 2013-06-12 | 1 | -2/+2 |
| | | | | |||||
* | | | | remove some evals from callback conditionals | Aaron Patterson | 2013-06-11 | 1 | -0/+10 |
| | | | | |||||
* | | | | Merge pull request #10897 from prathamesh-sonpatki/active-support-typos | Carlos Antonio da Silva | 2013-06-10 | 1 | -3/+3 |
|\ \ \ \ | | | | | | | | | | | Fixed typos in activesupport [ci skip] | ||||
| * | | | | Fixed typos in activesupport [ci skip] | Prathamesh Sonpatki | 2013-06-09 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | - eval'ed to eval'd in accordance with https://github.com/rails/rails/pull/10889 - tried to improve statement about compiling Procs into methods using define_method | ||||
* | | | | | Don't blindly call blame_file! on exceptions in ↵ | Andrew Kreiling | 2013-06-09 | 4 | -1/+19 |
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveSupport::Dependencies::Loadable It is possible under some environments to receive an Exception that is not extended with Blamable (e.g. JRuby). ActiveSupport::Dependencies::Loadable#load_dependency blindly call blame_file! on the exception which throws it's own NoMethodError exception and hides the original Exception. This commit fixes #9521 | ||||
* | | | | Override Time.at to work with Time-like values | Andrew White | 2013-06-08 | 3 | -0/+38 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Time.at allows passing a single Time argument which is then converted to an integer. The conversion code since 1.9.3r429 explicitly checks for an instance of Time so we need to override it to allow DateTime and ActiveSupport::TimeWithZone values. | ||||
* | | | | Fix some typos | Vipul A M | 2013-06-07 | 2 | -2/+2 |
| | | | | |||||
* | | | | Merge pull request #10784 from senny/10526_prevent_key_transformation | Rafael Mendonça França | 2013-06-03 | 3 | -6/+25 |
|\ \ \ \ | | | | | | | | | | | Prevent side effects in `Hash#with_indifferent_access`. | ||||
| * | | | | Prevent side effects in `Hash#with_indifferent_access`. | Yves Senn | 2013-05-29 | 3 | -6/+25 |
| | | | | | |||||
* | | | | | The behavior we had in place in rc1 was actually to convert to DateTime and ↵ | David Heinemeier Hansson | 2013-06-03 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | use <=> from there. Restore that. | ||||
* | | | | | Allow Date to be compared with Time (like it was possible to compare Time ↵ | David Heinemeier Hansson | 2013-06-03 | 2 | -0/+15 |
| | | | | | | | | | | | | | | | | | | | | with Date) | ||||
* | | | | | Remove active_support/testing/pending.rb was deprecated. | kennyj | 2013-06-01 | 3 | -27/+0 |
| | | | | | |||||
* | | | | | Remove ActiveSupport::Benchmarkable#silence was deprecated. | kennyj | 2013-06-01 | 1 | -10/+0 |
| | | | | | |||||
* | | | | | Remove active_support/json/variable was deprecated. | kennyj | 2013-06-01 | 3 | -26/+0 |
| | | | | | |||||
* | | | | | Running isolated tests | Arun Agrawal | 2013-05-28 | 2 | -19/+6 |
|/ / / / | | | | | | | | | | | | | These stopped running don't know when. But these should be running now. | ||||
* | | | | Merge pull request #10763 from senny/10758_to_sentence_with_blank_elements | Carlos Antonio da Silva | 2013-05-26 | 1 | -0/+4 |
|\ \ \ \ | | | | | | | | | | | test-case for `Array#to_sentence` with `blank?` items. | ||||
| * | | | | add test-case for `Array#to_sentence with blank items. | Yves Senn | 2013-05-26 | 1 | -0/+4 |
| | |/ / | |/| | | |||||
* | | | | Merge pull request #10762 from vipulnsward/change_compatibility | Carlos Antonio da Silva | 2013-05-26 | 1 | -3/+3 |
|\ \ \ \ | | | | | | | | | | | compatability => compatibility | ||||
| * | | | | compatability => compatibility | Vipul A M | 2013-05-26 | 1 | -3/+3 |
| |/ / / | |||||
* / / / | Fix some typo in method names, variables | Vipul A M | 2013-05-26 | 4 | -4/+4 |
|/ / / | |||||
* | | | Require only minitest. | Rafael Mendonça França | 2013-05-22 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | minitest/autorun required minitest/spec and we are avoiding to require it. | ||||
* | | | Merge pull request #10667 from rubys/minitest-autorun | Rafael Mendonça França | 2013-05-22 | 1 | -1/+1 |
|\ \ \ | |_|/ |/| | | Eliminate minitest warnings | ||||
| * | | Eliminate minitest warnings | Sam Ruby | 2013-05-17 | 1 | -1/+1 |
| | | | | | | | | | | | | https://github.com/seattlerb/minitest/commit/9a57c520ceac76abfe6105866f8548a94eb357b6#L15R8 | ||||
* | | | Merge pull request #10659 from vipulnsward/normalize_param2 | Rafael Mendonça França | 2013-05-19 | 1 | -3/+3 |
|\ \ \ | |_|/ |/| | | "normalize_callback_params" doesn't require name param | ||||
| * | | "normalize_callback_params" doesn't require name param | Vipul A M | 2013-05-17 | 1 | -3/+3 |
| |/ | |||||
* / | Bug fix: Evented notification subscribers can handle published events | Carl Lerche | 2013-05-17 | 2 | -0/+29 |
|/ |