| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When `rails console` or `rails server` are used along with a logger set to output to `STDOUT` then the contents will show up twice. This happens because the logger is extended with `ActiveSupportLogger.broadcast` with a destination of STDOUT even if it is already outputting to `STDOUT`.
Previously PR #22592 attempted to fix this issue, but it ended up causing NoMethodErrors. A better approach than relying on adding a method and flow control is to inspect the log destination directly. For this `ActiveSupport::Logger.logger_outputs_to?` was introduced
```ruby
logger = Logger.new(STDOUT)
ActiveSupport::Logger.logger_outputs_to?(logger, STDOUT)
# => true
```
To accomplish this we must look inside of an instance variable of standard lib's Logger `@logdev`. There is a related Ruby proposal to expose this method in a standard way: https://bugs.ruby-lang.org/issues/11955
|
|
|
|
| |
This reverts related commits due to #22917.
|
|
|
|
|
| |
petabyte and exabyte numeric conversion has been added after the 5.0.0.beta1 release.
ref: 85048e90ab6ff6963919a9d10493b3910cd67b68
|
|
|
|
| |
[ci skip]
|
|\
| |
| |
| |
| | |
rthbound/adds-exception-object-to-instrumenter-payload
Adds exception object to instrumenter's payload
|
| |
| |
| |
| |
| |
| |
| | |
- Adds new key/value pair to payload when an exception is raised
e.g. `:exception_object=> #<RuntimeError: FAIL>`
- Updates relevant test
- Adds CHANGELOG entry
|
| | |
|
| | |
|
|\ \
| |/
|/| |
Support extended grapheme clusters and UAX 29
|
| |
| |
| |
| | |
We how have tests for every rule in UAX 29.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
http://www.unicode.org/reports/tr29/tr29-21.html is the version of UAX
29 that corresponds to Unicode 6.2.0. Unicode.unpack_graphemes now
implements all the rules listed there, including the ones for extended
grapheme clusters.
I added a new optional test,
test/multibyte_grapheme_break_conformance.rb, that is heavily based on
test/multibyte_normalization_conformance.rb, which runs the Unicode test
suite.
|
| |
| |
| |
| |
| | |
This test is only testing normalization behavior, not any other Unicode
behaviors.
|
| |
| |
| |
| | |
This will make it easier to add the rest of the rules listed in UAX 29.
|
| | |
|
|\ \
| | |
| | | |
Add test coverage for ActiveSupport::NumericWithFormat#to_formatted_s
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add a missing require to ActiveSupport::NumericWithFormat
|
| |/ / |
|
| | | |
|
| | |
| | |
| | | |
It's numeric and the framework is called Action Controller.
|
|\ \ \
| | | |
| | | | |
Document `Logger#broadcast_messages` option
|
| |/ / |
|
| | |
| | |
| | |
| | | |
CHANGELOG entry for petabyte and exabyte
|
|\ \ \
| | | |
| | | | |
Add support for Petabyte and Exabyte in number to human size
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fixes LoggerSilence#silence threadsafety
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | | |
- uses instance defined level if no custom local log level defined
- Keeps track of local log level per [ thread + object-instance ]
- prevents memory leakage by removing local level hash key/value on #silence method exit
- avoids the use of Thread local variables
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I've worked on a few applications that have gone through the
internationalization process and had issues because they were using
`number_to_currency`. The minute a user is allowed to change their
locale, they can change the price displayed on a page from 10 US dollars
to 10 Mexican Pesos, which is far from the same amount of money.
Unlike other helpers that rely on i18n, `number_to_currency` does not
produce equivalent results when the locale is changed.
As I've explained this to a few groups of developers now, I thought it
might make for a good caveat in the docs.
|
|/ /
| |
| |
| | |
[ci skip]
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
During the `5.0.0.beta1` release, the CHANGELOGs got an entry like the
following:
```
* No changes.
```
It is kinda confusing as there are indeed changes after it. Not a
biggie, just a small pass over the CHANGELOGs.
[ci skip]
|
|\ \
| | |
| | |
| | |
| | |
| | | |
[ci skip]
Change output timming of sample code
|
| | |
| | |
| | |
| | | |
- Expect returns "new value 1" but, retuns nil, because output at thread is not finished. Move val_1 output to finished thread.
|
|\ \ \
| | | |
| | | | |
Fix documentation for mattr_accessor methods [ci skip]
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | | |
Suppress warning (warning: ambiguous first argument; put
parentheses or a space even after `/' operator)
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It is in the code to provides backward compatibility for people that
have this class serialized as YAML in some storage.
Closes #22681
|
| | |
| | |
| | |
| | |
| | | |
Also, added a test case to make sure that the default deprecation horizon is
always bigger than the current Rails version.
|
|\ \ \
| | | |
| | | | |
Fix cache fetch miss notification order
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixes https://github.com/rails/rails/issues/22477.
When I improved the caching instrumentation in
edd33c08d98723ae9bb89cf7f019277117ed6414, I inadvertently changed the
order of AS notifications when there is a cache miss.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
:tada: :beers:
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This test needs to have a require for the Listen gem or else it returns
an error when run by itself or with a certain order in the Active
Support tests. We use `silence_warnings` because Listen has some
warnings about private methods. It's already silenced when it's required
in Active Support EventedFileUpdateChecker.
```
1) Error:
EventedFileUpdateCheckerTest#test_should_not_execute_the_block_if_no_paths_are_given:
NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen
test/evented_file_update_checker_test.rb:21:in `teardown'
```
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The test was was in here twice so we were seeing this error:
```
activesupport/test/caching_test.rb:658:
warning: method redefined; discarding old test_local_cache_of_read_nil
activesupport/test/caching_test.rb:634:
warning: previous definition of test_local_cache_of_read_nil was here
```
|
| | | |
| | | |
| | | | |
We went back to `Thread.current[]` in 33e11e59.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
accessors"
This reverts commit 301f43820562c6a70dffe30f4227ff0751f47d4f per @matthewd on https://github.com/rails/rails/pull/22630/files#r47997074
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We call the thread variable accessors on `Thread.current`, which matches Ruby's
documentation:
http://ruby-doc.org/core-2.2.0/Thread.html#method-i-thread_variable_get
Fix these to stay `current` ( ͡° ͜ʖ ͡°)
|