aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Changes "if secret.nil?" to unless secret in MessageVerfierKostiantyn Kahanskyi2014-09-121-1/+1
|
* MessageVerifier raises an appropriate exception if the secret is nilKostiantyn Kahanskyi2014-09-123-0/+13
| | | | | Otherwise this will lead to another error later on when generating a signature: TypeError (no implicit conversion of nil into String).
* Define the configuration at Active SupportRafael Mendonça França2014-09-112-10/+17
|
* Default to sorting user's test cases for nowGodfrey Chan2014-09-084-7/+86
| | | | | | | | | | | Goals: 1. Default to :random for newly generated applications 2. Default to :sorted for existing applications with a warning 3. Only show the warning once 4. Only show the warning if the app actually uses AS::TestCase Fixes #16769
* Fix for inflector's incorrect camelCase replacement for acronymsMatthew Draper2014-09-064-1/+10
| | | | | | Fixes #8015, #9756. [Fred Wu & Matthew Draper]
* Time#change throws exception with an out-of-range :usecAgis-2014-09-043-0/+7
| | | | | | | | | | https://github.com/rails/rails/commit/98b46bf5e201307cae56ee14bf41363a539779c5 did not properly handled out-of-range `:usec`s. Passing a `:usec` that's out of range now throws an `ArgumentError` as it should. Fixes #16759.
* Methods are not duplicable.Peter Jaros2014-09-033-1/+16
|
* Leave all our tests as order_dependent! for nowMatthew Draper2014-09-021-0/+5
| | | | | | | | | We're seeing too many failures to believe otherwise. This reverts commits bc116a55ca3dd9f63a1f1ca7ade3623885adcc57, cbde413df3839e06dd14e3c220e9800af91e83ab, bf0a67931dd8e58f6f878b9510ae818ae1f29a3a, and 2440933fe2c27b27bcafcd9019717800db2641aa.
* Merge pull request #16450 from ↵Yves Senn2014-09-025-5/+48
|\ | | | | | | | | | | tgxworld/dont_swallow_error_when_identifying_constant_from_test_name Do not swallow exception on NameError within constant.
| * Use `safe_constantize`.Guo Xiang Tan2014-09-024-5/+41
| | | | | | | | Fixes https://github.com/rails/rails/issues/9933.
* | remove trailing whitespace. [ci skip]Yves Senn2014-09-021-2/+2
|/
* Refer to the library name instead of the constantRobin Dupret2014-08-301-1/+1
| | | | | | | | | When we are loading a component and we want to know its version, we are actually not speaking about the constant but the library itself. [ci skip] [Godfrey Chan & Xavier Noria]
* Bring back the test cases for `presence`Godfrey Chan2014-08-291-0/+5
| | | | This was removed by mistake in 5e51bdd
* reduce object allocations in utc_offsetAaron Patterson2014-08-291-2/+2
| | | | | | `try` allocates an array on every call, we should avoid calling it in hotspots. This reduced AttributeMethodsTest#test_setting_time_zone_aware_attribute_with_string from 18k allocations to 14k
* We tenderized the wrong method! Object#try already had the yield option, ↵David Heinemeier Hansson2014-08-295-34/+20
| | | | just needed some tenderloving instance_eval to fit the bill
* Clarify the origin of this great addition to Rails :trollface: :trollface ↵David Heinemeier Hansson2014-08-291-1/+1
| | | | :trollface:
* Use instance_eval on @tenderlove's suggestion :trollface:David Heinemeier Hansson2014-08-293-7/+8
|
* Update examples to show real worthDavid Heinemeier Hansson2014-08-292-2/+11
|
* Added yield to Object#presenceDavid Heinemeier Hansson2014-08-293-1/+23
|
* Merge branch 'master' of github.com:rails/railsDavid Heinemeier Hansson2014-08-2910-8/+31
|\
| * Keep the first string we fetchMatthew Draper2014-08-271-1/+1
| | | | | | | | Otherwise, it's possible for GC to run in between, and fail the test.
| * [ci skip] use proper apostropheankit19102014-08-251-1/+1
| |
| * Skip #eql? tests on Rubinius for AS::DurationRobin Dupret2014-08-241-0/+3
| | | | | | | | | | | | | | | | | | Since Rubinius is relying on #instance_of? for its definition of #eql? (http://git.io/MtmbbA) but ActiveSupport::Duration should behave like is_a? it returns true with `Fixnum`. Thus, for the moment, the last assertion is failing so we have to skip this test.
| * Follow-up to #16560Robin Dupret2014-08-243-9/+11
| | | | | | | | | | | | | | For the sake of backward-compatibility, we need to make #instance_of? return true for Fixnum. On the other hand, the method should still give true for ActiveSupport::Duration itself which was not the case before.
| * Use zero-padding for number_to_rounded_converterZachary Scott2014-08-221-1/+1
| |
| * Merge pull request #16560 from robin850/rbx-duration-eqlRafael Mendonça França2014-08-223-2/+16
| |\ | | | | | | Define the Duration#instance_of? method
| | * Define the Duration#instance_of? methodRobin Dupret2014-08-183-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Duration is extending from ProxyObject which extends itself from BasicObject, the Duration object doesn't respond to the #instance_of? method. Thus, the #method_missing hook get triggered, delegating the method to its `value` attribute. However, Rubinius' #eql? definition relies on #instance_of?, thus this will equal to true with a Fixnum (since its `value` attribute is a Fixnum) while it should not. The previous behavior was wrong anyway, no matter the implementation.
| * | Fixes the digits counter of AS's NumberToRoundedConverterXavier Noria2014-08-202-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Zero has one digit, but Math.log10(0) returns -Infinity. The method needs to special-case zero. The patch adds a regression test that is not clearly related to the underlying issue because digit_count is private and has no coverage. Gray area. This bug was uncovered by 60062cf.
| * | Merge pull request #16573 from zzak/test_test_to_test_case_testSantiago Pastorino2014-08-201-0/+0
| |\ \ | | | | | | | | Move as/test_test to as/test_case_test
| | * | Move as/test_test to as/test_case_testZachary Scott2014-08-191-0/+0
| | | |
| * | | Updated the deprecation warnings to 5.0Cristian Bica2014-08-201-1/+1
| | | |
| * | | Add documentation intro to example for `Object#itself`.Zachary Scott2014-08-191-2/+5
| |/ / | | | | | | | | | | | | Also moved comment for removal above `unless()` to not confuse RDoc with the documentation for this method.
* / / Preparing for 4.2.0.beta1 releaseDavid Heinemeier Hansson2014-08-191-1/+1
|/ /
* | Require rack/utilsRafael Mendonça França2014-08-191-0/+2
| |
* | Move date and time requires to time_travel_test, also includeZachary Scott2014-08-192-2/+4
| | | | | | | | | | | | 'abstract_unit'. cc #16564
* | Merge pull request #16564 from zzak/move_time_travel_testJeremy Kemper2014-08-192-69/+68
|\ \ | | | | | | Move TimeHelperTest to TimeTravelTest from `as/test_test.rb`
| * | Move TimeHelperTest to TimeTravelTest from `as/test_test.rb`Zachary Scott2014-08-192-69/+68
| | |
* | | Protect against error when parsing parameters with Bad RequestRafael Mendonça França2014-08-191-0/+3
|/ / | | | | | | Related with #11795.
* | "warning: assigned but unused variable"Akira Matsuda2014-08-191-1/+0
| |
* | Use the released beta of i18nCarlos Antonio da Silva2014-08-181-1/+1
|/
* Expectations firstAkira Matsuda2014-08-181-4/+4
|
* Merge branch 'master' of github.com:rails/railsDavid Heinemeier Hansson2014-08-173-5/+6
|\
| * Preload UnicodeDatabase outside the loopAkira Matsuda2014-08-181-0/+1
| | | | | | | | | | | | This fixes random multibyte_chars_test fail under Ruby 1.9.3. I don't know why the tests fail. And I really don't know why this fixes. Maybe we need some more investigation...
| * formatAkira Matsuda2014-08-181-2/+1
| |
| * Merge pull request #16467 from strzalek/cookies-digest-config-option2Godfrey Chan2014-08-171-1/+2
| |\ | | | | | | | | | | | | | | | | | | | | | Cookies digest config option (pt. 2) Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_dispatch/middleware/cookies.rb
| | * Add config option for cookies digestŁukasz Strzałkowski2014-08-121-1/+2
| | | | | | | | | | | | | | | | | | You can now configure custom digest for cookies in the same way as `serializer`: config.action_dispatch.cookies_digest = 'SHA256'
| * | Merge pull request #16338 from robin850/rbx-safe-constantizeMatthew Draper2014-08-181-2/+2
| |\ \ | | | | | | | | Avoid relying on error messages when rescuing
| | * | Avoid relying on error messages when rescuingRobin Dupret2014-08-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we are rescuing from an error, it's a brittle approach to do checks with regular expressions on the raised message because it may change in in the future and error messages are different across implementations. The NameError API could be improved at the MRI level but for now we need to rely on its #name. A #== check will only pass for top level constants or only when the last constant of the path is missing so we need to rely on #include? instead. For instance: begin Namespace::Foo rescue NameError => e e.name # => :Namespace end However, if the name-space already exists, only the name of the first missing constant in the path is returned (e.g. for Math::PHI, the name would be :PHI). JRuby will return a fully qualified name (:"Math::PHI"). We need to keep the == check for 1.9 compatibility since const_get will raise a NameError with a name attribute set to the given string if it's one of "::" or "". See http://git.io/jnSN7g for further information.
* | | | Fix rounding errors with #travel_to by resetting the usec on any passed time ↵David Heinemeier Hansson2014-08-173-4/+20
|/ / / | | | | | | | | | to zero, so we only travel with per-second precision, not anything deeper than that.
* | | Avoid mutating the constants in a test caseAkira Matsuda2014-08-162-6/+4
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 04:19:02 +0000