aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #18090 from egilburg/patch-3Rafael Mendonça França2015-01-041-9/+1
|\ | | | | | | simplify ActiveSupport.test_order definition
| * simplify ActiveSupport.test_order definitionEugene Gilburg2014-12-181-9/+2
| |
* | Do not include Active Support on testsRafael Mendonça França2015-01-043-30/+24
| | | | | | | | It was not done to be included
* | Merge pull request #18328 from brainopia/remove_tz_proxyRafael Mendonça França2015-01-042-11/+6
|\ \ | | | | | | Use directly TZInfo::Timezone without proxy
| * | Use directly TZInfo::Timezone without proxybrainopia2015-01-042-11/+6
| | | | | | | | | | | | | | | Since real timezone is loaded anyway in `#utc_offset` which is called during `#create`
* | | Remove extra class_eval for Ruby 1.9Carlos Antonio da Silva2015-01-041-5/+2
| | |
* | | Remove workaround to a Ruby 2.0.0 bugRafael Mendonça França2015-01-041-7/+0
| | |
* | | Remove Struct#to_h backportRafael Mendonça França2015-01-043-17/+5
| | |
* | | String already respond_to scrub at Ruby 2.2Rafael Mendonça França2015-01-041-2/+1
| | |
* | | singleton_class? is already pressent at Ruby 2.2Rafael Mendonça França2015-01-041-8/+0
| | |
* | | Remove unneeded Time patch to support Ruby 1.9Rafael Mendonça França2015-01-042-30/+2
| | |
* | | Remove some comments about Ruby 1.9 behaviorsRafael Mendonça França2015-01-044-7/+7
| | |
* | | Remove debugger supportRafael Mendonça França2015-01-043-35/+3
| | | | | | | | | | | | | | | bebugger doesn't work with Ruby 2.2 so we don't need to support it anymore
* | | Remove LoadError#path hack for Ruby 1.9claudiob2015-01-041-2/+0
| | | | | | | | | | | | | | | Now that Rails requires Ruby >= 2.0 there is need to skip the `test_depend_on_path` test.
* | | Remove hack to support BigDecimal in Ruby 1.9claudiob2015-01-042-21/+3
| | | | | | | | | | | | | | | Now that Rails requires Ruby >= 2.0, there is no need to check whether `BigDecimal` exists or not.
* | | remove files which is dependent on ruby1.9 as we do not support Ruby1.9Kuldeep Aggarwal2015-01-041-11/+3
|/ / | | | | | | | | Conflicts: activerecord/lib/active_record/attribute_methods/read.rb
* | Remove unneeded `require 'as/deprecation'`claudiob2015-01-041-1/+0
| | | | | | | | | | Tests should still pass after removing `require 'active_support/deprecation'` from these files since the related deprecations have been removed.
* | Change the default test order from `:sorted` to `:random`Rafael Mendonça França2015-01-043-30/+18
| |
* | Remove deprecated ActiveSupport::JSON::Encoding::CircularReferenceError.Rafael Mendonça França2015-01-043-46/+4
| |
* | Remove deprecated ActiveSupport::JSON::Encoding.encode_big_decimal_as_string=Rafael Mendonça França2015-01-043-43/+5
| |
* | Remove deprecated `ActiveSupport::SafeBuffer#prepend`Rafael Mendonça França2015-01-043-16/+4
| |
* | Remove deprecated methods at `Kernel`.Rafael Mendonça França2015-01-043-127/+6
| | | | | | | | `silence_stderr`, `silence_stream`, `capture` and `quietly`.
* | Remove deprecated core_ext/big_decimal/yaml_conversions fileRafael Mendonça França2015-01-043-25/+5
| |
* | Remove deprecated ActiveSupport::Cache::Store.instrumentRafael Mendonça França2015-01-042-14/+5
| |
* | Merge pull request #17227 from claudiob/explicitly-abort-callbacksRafael Mendonça França2015-01-035-11/+175
|\ \ | | | | | | | | | | | | | | | | | | Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps. Conflicts: railties/CHANGELOG.md
| * | Add config to halt callback chain on return falseclaudiob2015-01-024-7/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This stems from [a comment](rails#17227 (comment)) by @dhh. In summary: * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning. * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning. For this purpose, this commit introduces a Rails configuration option: ```ruby config.active_support.halt_callback_chains_on_return_false ``` For new Rails 5.0 apps, this option will be set to `false` by a new initializer `config/initializers/callback_terminator.rb`: ```ruby Rails.application.config.active_support.halt_callback_chains_on_return_false = false ``` For existing apps ported to Rails 5.0, the initializers above will not exist. Even running `rake rails:update` will not create this initializer. Since the default value of `halt_callback_chains_on_return_false` is set to `true`, these apps will still accept `return true` as a way to halt callback chains, displaying a deprecation warning. Developers will be able to switch to the new behavior (and stop the warning) by manually adding the line above to their `config/application.rb`. A gist with the suggested release notes to add to Rails 5.0 after this commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
| * | Deprecate `false` as the way to halt AS callbacksclaudiob2015-01-023-3/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After this commit, returning `false` in a callback will display a deprecation warning to make developers aware of the fact that they need to explicitly `throw(:abort)` if their intention is to halt a callback chain. This commit also patches two internal uses of AS::Callbacks (inside ActiveRecord and ActionDispatch) which sometimes return `false` but whose returned value is not meaningful for the purpose of execution. In both cases, the returned value is set to `true`, which does not affect the execution of the callbacks but prevents unrequested deprecation warnings from showing up.
| * | Throw :abort halts default CallbackChainsclaudiob2015-01-023-10/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes arguments and default value of CallbackChain's :terminator option. After this commit, Chains of callbacks defined **without** an explicit `:terminator` option will be halted as soon as a `before_` callback throws `:abort`. Chains of callbacks defined **with** a `:terminator` option will maintain their existing behavior of halting as soon as a `before_` callback matches the terminator's expectation. For instance, ActiveModel's callbacks will still halt the chain when a `before_` callback returns `false`.
* | | Fix a few typos [ci skip]Robin Dupret2015-01-031-1/+1
| | |
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-01-032-3/+23
|\ \ \ | |/ / |/| |
| * | Better docs for NameErrorclaudiob2014-12-251-0/+14
| | | | | | | | | | | | | | | | | | Add examples for missing_name, missing_name? [ci skip]
| * | Add docs for `Object.nil!`claudiob2014-12-221-3/+9
| | | | | | | | | | | | | | | | | | Also add doc examples for `Object.nil`. [ci skip]
* | | Merge pull request #9065 from atombender/masterRafael Mendonça França2015-01-022-1/+16
|\ \ \ | | | | | | | | Fix TaggedLogging to allow loggers to be instantiated multiple times without having to share the stack of tags
| * | | Fix TaggedLogging to allow loggers to be instantiated multiple times without ↵Alexander Staubo2013-01-242-1/+16
| | | | | | | | | | | | | | | | having to share the stack of tags. This is accomplished by using a unique key for the thread-local tag list. Fixes #9064.
* | | | Deprecate `MissingSourceFile` in favor of `LoadError`.Rafael Mendonça França2015-01-023-1/+19
| | | | | | | | | | | | | | | | | | | | `MissingSourceFile` was just an alias to `LoadError` and was not being raised inside the framework.
* | | | Merge pull request #8740 from amatsuda/missing_source_fileRafael Mendonça França2015-01-022-26/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | replace use of MissingSourceFile with LoadError Conflicts: activesupport/test/core_ext/load_error_test.rb
| * | | | replace use of MissingSourceFile with LoadErrorAkira Matsuda2013-01-042-18/+3
| | | | |
* | | | | Remove thread variables backportRafael Mendonça França2015-01-022-161/+0
| | | | | | | | | | | | | | | | | | | | They are already present on Ruby 2.2
* | | | | Merge pull request #16749 from robin850/rbx-name-errorRafael Mendonça França2015-01-021-0/+2
|\ \ \ \ \ | | | | | | | | | | | | Rely on NameError#name instead of its error message
| * | | | | Skip an error message related assertion on RubiniusRobin Dupret2014-10-281-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rubinius' error messages don't call `#inspect` on the concerned object while the assertion is here to address a wrong inspection on MRI with time zones so let's keep this test for now on Rubinius.
* | | | | | Do not check only for the Rails constantRafael Mendonça França2015-01-022-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This constant may be define for auxiliar gems like rails-html-sanitizer and these methods call will fail.
* | | | | | Remove conversion code for old Rails cache entryRafael Mendonça França2015-01-012-50/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This code was there just to convert entries generated in Rails 4.0.0.beta1 applications to a supported format. It is almost unlikely that any existent application have this cache entry format in their caches at the point that Rails 5 will be released so we don't need this code anymore.
* | | | | | Check by @v before converting the entry on expired?Rafael Mendonça França2015-01-012-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should convert when @v is defined not @value. The test was calling value first that already converts the entry so we are not catching this bug.
* | | | | | Merge pull request #18271 from arunagw/change-copyright-yearRobin Dupret2015-01-012-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Update copyright notices to 2015 [ci skip]
| * | | | | | Update copyright notices to 2015 [ci skip]Arun Agrawal2014-12-312-2/+2
| | | | | | |
* | | | | | | Changelog edits [ci skip]Robin Dupret2014-12-311-4/+10
|/ / / / / /
* | | | | | Merge pull request #18219 from jaroslawr/masterAaron Patterson2014-12-301-74/+116
|\ \ \ \ \ \ | | | | | | | | | | | | | | Flatten the call stacks ActiveSupport::Callbacks produces, fix #18011.
| * | | | | | Flatten the call stacks ActiveSupport::Callbacks produces, fix #18011.Jaroslaw Rzeszotko2014-12-271-74/+116
| | | | | | |
* | | | | | | Fix comment typo in debugger.rbmntj2014-12-301-1/+1
| | | | | | |
* | | | | | | Removed Object#itself as it's implemented in ruby 2.2Cristian Bica2014-12-293-25/+0
| | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-29 06:46:26 +0000