aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Remove unused instance variableschneems2016-01-061-1/+0
|
* [close #22917] Don't output to `STDOUT` twiceschneems2016-01-062-3/+21
| | | | | | | | | | | | | | When `rails console` or `rails server` are used along with a logger set to output to `STDOUT` then the contents will show up twice. This happens because the logger is extended with `ActiveSupportLogger.broadcast` with a destination of STDOUT even if it is already outputting to `STDOUT`. Previously PR #22592 attempted to fix this issue, but it ended up causing NoMethodErrors. A better approach than relying on adding a method and flow control is to inspect the log destination directly. For this `ActiveSupport::Logger.logger_outputs_to?` was introduced ```ruby logger = Logger.new(STDOUT) ActiveSupport::Logger.logger_outputs_to?(logger, STDOUT) # => true ``` To accomplish this we must look inside of an instance variable of standard lib's Logger `@logdev`. There is a related Ruby proposal to expose this method in a standard way: https://bugs.ruby-lang.org/issues/11955
* Revert "Add Logger option to disable message broadcasts"schneems2016-01-053-45/+22
| | | | This reverts related commits due to #22917.
* move CHANGELOG entry to the appropriate position [ci skip]yuuji.yaginuma2016-01-031-3/+2
| | | | | petabyte and exabyte numeric conversion has been added after the 5.0.0.beta1 release. ref: 85048e90ab6ff6963919a9d10493b3910cd67b68
* New changelog entries are added to the top.Rafael Mendonça França2016-01-011-6/+6
| | | | [ci skip]
* Merge pull request #22856 from ↵Rafael França2016-01-013-1/+8
|\ | | | | | | | | rthbound/adds-exception-object-to-instrumenter-payload Adds exception object to instrumenter's payload
| * Adds exception object to instrumenter's payloadRyan T. Hosford2015-12-313-1/+8
| | | | | | | | | | | | | | - Adds new key/value pair to payload when an exception is raised e.g. `:exception_object=> #<RuntimeError: FAIL>` - Updates relevant test - Adds CHANGELOG entry
* | Update copyright notices to 2016 [ci skip]Rashmi Yadav2015-12-312-3/+3
| |
* | Add CHANGELOG entry for #12877 [ci skip]Rafael Mendonça França2015-12-311-0/+5
| |
* | Merge pull request #12877 from aroben/extended-graphemesRafael França2015-12-314-16/+272
|\ \ | |/ |/| Support extended grapheme clusters and UAX 29
| * Beef up #grapheme_length testsAdam Roben2013-11-131-3/+29
| | | | | | | | We how have tests for every rule in UAX 29.
| * Support extended grapheme clusters and UAX 29Adam Roben2013-11-132-0/+91
| | | | | | | | | | | | | | | | | | | | | | | | http://www.unicode.org/reports/tr29/tr29-21.html is the version of UAX 29 that corresponds to Unicode 6.2.0. Unicode.unpack_graphemes now implements all the rules listed there, including the ones for extended grapheme clusters. I added a new optional test, test/multibyte_grapheme_break_conformance.rb, that is heavily based on test/multibyte_normalization_conformance.rb, which runs the Unicode test suite.
| * Rename multibyte_conformance.rb to multibyte_normalization_conformance.rbAdam Roben2013-11-131-2/+2
| | | | | | | | | | This test is only testing normalization behavior, not any other Unicode behaviors.
| * Refactor Unicode.unpack_graphemes slightlyAdam Roben2013-11-131-13/+23
| | | | | | | | This will make it easier to add the rest of the rules listed in UAX 29.
* | Fix - to_s(:db) on Numeric rangeAkshay Vishnoi2015-12-293-1/+31
| |
* | Merge pull request #22824 from maclover7/add-numericwithformat-testsYves Senn2015-12-291-0/+6
|\ \ | | | | | | Add test coverage for ActiveSupport::NumericWithFormat#to_formatted_s
| * | Add test coverage for ActiveSupport::NumericWithFormat#to_formatted_sJon Moss2015-12-281-0/+6
| | |
* | | Merge pull request #22822 from maclover7/fix-22805Richard Schneeman2015-12-281-0/+1
|\ \ \ | | | | | | | | Add a missing require to ActiveSupport::NumericWithFormat
| * | | Add a missing require to ActiveSupport::NumericWithFormatJon Moss2015-12-281-0/+1
| |/ /
* | | Removed extra "the" in the documentation of `broadcast_message` [ci skip]Prathamesh Sonpatki2015-12-281-1/+1
| | |
* | | [ci skip] Fix typos in Active Support changelog.Kasper Timm Hansen2015-12-271-2/+2
| | | | | | | | | It's numeric and the framework is called Action Controller.
* | | Merge pull request #22771 from nwjsmith/document-broadcast-messagesEileen M. Uchitelle2015-12-271-1/+9
|\ \ \ | | | | | | | | Document `Logger#broadcast_messages` option
| * | | Document `Logger#broadcast_messages` optionNate Smith2015-12-231-1/+9
| |/ /
* | | Add CHANGELOG entry for #22759eileencodes2015-12-271-0/+4
| | | | | | | | | | | | CHANGELOG entry for petabyte and exabyte
* | | Merge pull request #22759 from akshay-vishnoi/human-size-helperEileen M. Uchitelle2015-12-276-3/+33
|\ \ \ | | | | | | | | Add support for Petabyte and Exabyte in number to human size
| * | | Add support for Petabyte and Exabyte in number to human sizeAkshay Vishnoi2015-12-226-3/+33
| | | |
* | | | fix typo on commentsPaulo Ancheta2015-12-231-1/+1
| | | |
* | | | Merge pull request #20507 from rabbitt/bugfix/logger-threadsafetyRafael França2015-12-233-4/+119
|\ \ \ \ | | | | | | | | | | Fixes LoggerSilence#silence threadsafety
| * | | | Fixes LoggerSilence#silence threadsafetyCarl P. Corliss2015-12-233-4/+119
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | - uses instance defined level if no custom local log level defined - Keeps track of local log level per [ thread + object-instance ] - prevents memory leakage by removing local level hash key/value on #silence method exit - avoids the use of Thread local variables
* / | | Add caveat to number_to_currency docs [ci skip]Derek Prior2015-12-231-0/+8
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've worked on a few applications that have gone through the internationalization process and had issues because they were using `number_to_currency`. The minute a user is allowed to change their locale, they can change the price displayed on a page from 10 US dollars to 10 Mexican Pesos, which is far from the same amount of money. Unlike other helpers that rely on i18n, `number_to_currency` does not produce equivalent results when the locale is changed. As I've explained this to a few groups of developers now, I thought it might make for a good caveat in the docs.
* / / release notes, extract notable changes from Active Support CHANGELOG.Yves Senn2015-12-231-12/+12
|/ / | | | | | | [ci skip]
* | Use CGI.escapeHTML for html escapeTakashi Kokubun2015-12-211-4/+2
| |
* | No more no changes entries in the CHANGELOGsGenadi Samokovarov2015-12-211-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | During the `5.0.0.beta1` release, the CHANGELOGs got an entry like the following: ``` * No changes. ``` It is kinda confusing as there are indeed changes after it. Not a biggie, just a small pass over the CHANGELOGs. [ci skip]
* | Merge pull request #22581 from hirocaster/fix-expect-sample-codeYves Senn2015-12-211-4/+5
|\ \ | | | | | | | | | | | | | | | [ci skip] Change output timming of sample code
| * | Change output timming of sample codehirocaster2015-12-141-2/+2
| | | | | | | | | | | | - Expect returns "new value 1" but, retuns nil, because output at thread is not finished. Move val_1 output to finished thread.
* | | Merge pull request #22706 from habermann24/fix_mattr_accessor_docsYves Senn2015-12-211-6/+6
|\ \ \ | | | | | | | | Fix documentation for mattr_accessor methods [ci skip]
| * | | Fix documentation for mattr_accessor methodsJan Habermann2015-12-201-6/+6
| | | |
* | | | Suppress warning ambiguous first argumentyui-knk2015-12-201-1/+1
|/ / / | | | | | | | | | | | | Suppress warning (warning: ambiguous first argument; put parentheses or a space even after `/' operator)
* | | Add a commend about deprecation of ActiveSupport::OrderedHashRafael Mendonça França2015-12-201-1/+1
| | | | | | | | | | | | | | | | | | | | | It is in the code to provides backward compatibility for people that have this class serialized as YAML in some storage. Closes #22681
* | | Deprecation warning now targets at 5.1Akira Matsuda2015-12-192-2/+6
| | | | | | | | | | | | | | | Also, added a test case to make sure that the default deprecation horizon is always bigger than the current Rails version.
* | | Merge pull request #22479 from RobinClowers/fix-cache-notification-orderKasper Timm Hansen2015-12-192-20/+24
|\ \ \ | | | | | | | | Fix cache fetch miss notification order
| * | | Fix cache fetch miss notification orderRobin Clowers2015-12-022-20/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/22477. When I improved the caching instrumentation in edd33c08d98723ae9bb89cf7f019277117ed6414, I inadvertently changed the order of AS notifications when there is a cache miss.
* | | | Add CHANGELOG headers for Rails 5.0.0.beta1eileencodes2015-12-181-0/+5
| | | |
* | | | Change `alpha` to `beta1` to prep for release of Rails 5eileencodes2015-12-181-1/+1
| | | | | | | | | | | | | | | | :tada: :beers:
* | | | Fix test that fails in isolationeileencodes2015-12-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test needs to have a require for the Listen gem or else it returns an error when run by itself or with a certain order in the Active Support tests. We use `silence_warnings` because Listen has some warnings about private methods. It's already silenced when it's required in Active Support EventedFileUpdateChecker. ``` 1) Error: EventedFileUpdateCheckerTest#test_should_not_execute_the_block_if_no_paths_are_given: NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen test/evented_file_update_checker_test.rb:21:in `teardown' ```
* | | | Delete duplicate testeileencodes2015-12-181-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test was was in here twice so we were seeing this error: ``` activesupport/test/caching_test.rb:658: warning: method redefined; discarding old test_local_cache_of_read_nil activesupport/test/caching_test.rb:634: warning: previous definition of test_local_cache_of_read_nil was here ```
* | | | [ci skip] Revert most of ff851017Kasper Timm Hansen2015-12-181-2/+2
| | | | | | | | | | | | We went back to `Thread.current[]` in 33e11e59.
* | | | Revert "Use Thread.current.thread_variable_set/get insetad of the direct ↵David Heinemeier Hansson2015-12-181-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | accessors" This reverts commit 301f43820562c6a70dffe30f4227ff0751f47d4f per @matthewd on https://github.com/rails/rails/pull/22630/files#r47997074
* | | | [ci skip] Add `Thread.current` to match internalsKasper Timm Hansen2015-12-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We call the thread variable accessors on `Thread.current`, which matches Ruby's documentation: http://ruby-doc.org/core-2.2.0/Thread.html#method-i-thread_variable_get Fix these to stay `current` ( ͡° ͜ʖ ͡°)
* | | | Clarify thread_mattr_accessor subclass behavior documentationNate Berkopec2015-12-171-8/+9
| | | | | | | | | | | | | | | | [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 05:59:21 +0000