| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\
| |
| | |
Making the retrieval of the cache store class a method
|
| |
| |
| |
| | |
comments for the expand_cache_key method.
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and avoids multiple evaluation of the target method
Notes:
1) I hope nilness is a word.
2) See rationale for avoiding multiple evaluation in a comment in the patch, credit goes to @jeremy for pointing out this gotcha in the existing implementation.
3) Embeds a little joke dedicated to @pixeltrix (it could be worse! :D).
References #10347.
|
|\
| |
| |
| |
| | |
Improve poor security recommendation in docs
[ci skip]
|
| |
| |
| |
| |
| | |
As reported in #9960, the current documentation recommends an insecure practice for
key generation from a password (a single round of SHA-256). The modified documentation
uses ActiveSupport::KeyGenerator to perform proper key stretching.
|
|\ \
| | |
| | |
| | |
| | | |
JonRowe/update_as_date_next_week_to_document_intent
Propose better documentation for ActiveSupports `next_week` functionaility
|
| | | |
|
| | | |
|
|/ /
| |
| |
| |
| |
| | |
Add documentation and test to delegation method that make sure we're
aware that when a delegated object is not nil or false and doesn't
respond to the method it will still raise a NoMethodError exception.
|
| | |
|
|\ \
| | |
| | | |
refactor initialization of array
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The changes in b79adc4323 had a bug where if the time in the String
was in standard time but the current time was in daylight savings then
the calculated adjustment was off by an hour.
This commit fixes this and adds extra tests for the following:
* time in string is standard time, current time is standard time
* time in string is standard time, current time is daylight savings
* time in string is daylight savings, current time is standard time
* time in string is daylight savings, current time is daylight savings
Fixes #10306.
|
| | |
|
| |
| |
| |
| | |
subscriber queues. Helps limit the number of thread locals.
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | | |
Fixes skipping object callback filters
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This allows you to skip callbacks that are defined by objects, e.g. for
`ActionController`:
skip_after_filter MySpecialFilter
Previously this didn't work due to a bug in how Rails compared callbacks
in `Callback#matches?`. When a callback is compiled, if it's an object
filter (i.e. not a method, proc, etc.), `Callback` now defines a method on
`@klass` that is derived from the class name rather than `@callback_id`.
So, when `skip_callback` tries to find the appropriate callback to
remove, `Callback` can regenerate the method name for the filter
object and return the correct value for `Callback#matches?`.
|
| | | |
|
| | |
| | |
| | |
| | | |
"There're" => There are for better readability
|
|\ \ \
| | | |
| | | | |
Reorganize MessageEncryptor
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
1) According to OpenSSL's documentation, cipher.random_iv must be called
after cipher.encrypt and already sets the generated IV on the cipher.
2) OpenSSL::CipherError was moved to OpenSSL::Cipher::CipherError in
Ruby 1.8.7. Since Rails 4 requires at least Ruby 1.9.3, support for
the old location can be dropped.
|
| | | |
| | | |
| | | |
| | | | |
same, so their logic is being refactored.
|
| | | |
| | | |
| | | |
| | | | |
its own method.
|
| | | |
| | | |
| | | | |
[ci skip]
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Thank you @fxn :green_heart::yellow_heart::heart::purple_heart::blue_heart:
[ci skip]
|
|\ \ \ \
| |/ / /
|/| | | |
Extract a Subscriber base class from LogSubscriber
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds a ActiveSupport::Subscriber base class that LogSubscriber inherits
from. By inheriting from Subscriber, other kinds of subscribers can take
advantage of the event attachment system.
|
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | | |
[ci skip]
|
|/ / / |
|
|\ \ \ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Existing code was delegating to the instance with delegate
macro calls, or invoking the instance method to reach
the object and call its instance methods.
But the point is to have a clean class-level interface where
the thread local instance is hidden in the implementation.
References #11c6973.
References #10198.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* It focuses on how to use it.
* Removes some ambigueties in the original docs about whether the state is stored in the class.
* Documents it provides class-level accessors via method_missing.
* Documents that if the extended class has an initializer, it must accept no arguments.
|
| | | |
| | | |
| | | |
| | | | |
Also update the documentation on the number of supported time zones.
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
refactor order hash test; remove unused method param
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
Conflicts:
guides/source/action_mailer_basics.md
|
| | | | |
|
| | | | |
|