aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
Commit message (Collapse)AuthorAgeFilesLines
* Got overhead down from 127 to 85. All tests pass:Yehuda Katz2009-08-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | * Tentatively replaced HeaderHash with SimpleHeaderHash, which does not preserve case but does handle converting Arrays to Strings in to_hash. This requires further discussion. * Moved default_charset to ActionDispatch::Response to avoid having to hop over to ActionController. Ideally, this would be a constant on AD::Response, but some tests expect to be able to change it dynamically and I didn't want to change them yet. * Completely override #initialize from Rack::Response. Previously, it was creating a HeaderHash, and then we were creating an entirely new one. There is no way to call super without incurring the overhead of creating a HeaderHash. * Override #write from Rack::Response. Its implementation tracks Content-Length, and doing so adds additional overhead that could be mooted if other middleware changes the body. It is more efficiently done at the top-level server. * Change sending_file to an instance_variable instead of header inspection. In general, if a state is important, it should be set as a property of the response not reconstructed later. * Set the Etag to @body instead of .body. AS::Cache.expand_cache_key handles Arrays fine, and it's more efficient to let it handle the body parts, since it is not forced to create a joined String. * If we detect the default cache control case, just set it, rather than setting the constituent parts and then running the normal (expensive) code to generate the string.
* Allow delegating to nil, because the method might actually exist on itBryan Helmkamp2009-08-102-5/+21
|
* Correctly handle offsets in Multibyte::Chars#index and #rindex.Erik Ostrom2009-08-092-4/+11
| | | | | | | | The offset in codepoints was being passed directly to the wrapped string's index/rindex method. Now we translate the offset into bytes first. [#3028 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fixing isolation testJay Pignata2009-08-091-1/+1
| | | | | | [#3022 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix that JSON parser fails to read escaped backslashes.Daniel Sheppard2009-08-092-4/+9
| | | | | | [#973 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix that irregular plural inflections should not be double-pluralized: ↵Prem Sichanugrist2009-08-092-0/+13
| | | | | | | | 'people'.pluralize should return 'people' not 'peoples'. [#1183 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* pare down core_ext dependencyJeremy Kemper2009-08-091-2/+1
|
* Add rindex to ActiveSupport::Multibyte::Chars.Erik Ostrom2009-08-092-0/+20
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* make private_and_public_methods unmemoizable [#2372 state:resolved]jeem2009-08-092-1/+45
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Support deep-merging HashWithIndifferentAccess.Andrew Moreland2009-08-092-4/+17
| | | | | | [#2732 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Improving test coverage for Range#sum [#2489]José Valim2009-08-091-1/+1
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix that Hash#to_xml and Array#to_xml shouldn't modify their options hashes ↵David Burger2009-08-094-0/+16
| | | | | | [#672 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix failing dependencies test relying on . being in LOAD_PATHJeremy Kemper2009-08-091-2/+4
|
* Extract repetitive methodJeremy Kemper2009-08-091-33/+37
|
* Uses &:fooJeremy Kemper2009-08-091-0/+1
|
* Remove unnecessary &block from Range#sum and add tests for (num..float).sumPratik Naik2009-08-092-1/+2
|
* Make enumerable test run stand alonePratik Naik2009-08-091-0/+1
|
* Optimize Range#sum only for integers [#2489]José Valim2009-08-092-2/+4
|
* Setting usec (and nsec for Ruby 1.9) on Time#end_of_* methods [#1255 ↵Hugo Peixoto2009-08-093-32/+32
| | | | | | status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Optimize Range#sum to use arithmetic progression when a block is not given ↵José Valim2009-08-092-0/+11
| | | | | | [#2489]. Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix deprecating =-methods by using send [#2431 status:resolved]Michael Siebert2009-08-092-9/+13
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Temporary fix to get our LoadError monkey-patch working with newer JRuby. We ↵Yehuda Katz2009-08-091-1/+2
| | | | should probably remove MissingSourceFile and just monkey-patch LoadError instead of overriding LoadError.new.
* Enumerable#sum now works will all enumerables, even if they don't respond to ↵Marc-Andre Lafortune2009-08-082-4/+6
| | | | | | | | :size [#2489 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fixed a bug in JSON decoding with Yaml backend, where a combination of ↵Bas Van Klinkenberg2009-08-082-8/+17
| | | | | | dates, escaped or unicode encoded data and arrays would make the parser fail with a ParseError exception. [#2831 state:resolved] Signed-off-by: Yehuda Katz <wycats@gmail.com>
* Extract String#bytesize shimJeremy Kemper2009-08-013-3/+14
|
* Merge branch 'master' of git://github.com/rails/railsJosé Valim2009-07-2811-14/+18
|\
| * Merge docrailsPratik Naik2009-07-2511-14/+18
| |
* | Solving merge conflicts.José Valim2009-07-213-79/+89
|\|
| * Ruby 1.9.2 compat: name method was renamed to __name__ since MiniTest 1.4.x ↵Akira Matsuda2009-07-211-1/+2
| | | | | | | | | | | | [#2922 state:resolved] Signed-off-by: Yehuda Katz <wycats@gmail.com>
| * * don't include String#% for Ruby 1.9Sven Fuchs2009-07-182-78/+87
| | | | | | | | | | | | | | | | | | | | * raise a KeyError exception for missing named interpolation args (like Ruby 1.9 does) * raise an ArgumentError when mixing named and unnamed placeholders (like Ruby 1.9 does) * improve docs and comply a bit more w/ Rails names/conventions [#2870 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* | Merge branch 'master' of git://github.com/rails/railsJosé Valim2009-07-164-4/+8
|\|
| * ActiveSupport Hash optimizations [#2902 state:resolved]Lourens Naude2009-07-154-4/+8
| | | | | | | | Signed-off-by: Carl Lerche <carllerche@mac.com>
* | Merge branch 'master' of git://github.com/rails/railsJosé Valim2009-07-085-75/+226
|\|
| * Use the i18n gem if present instead of vendor code. [#2871 state:resolved]Lawrence Pit2009-07-071-5/+4
| | | | | | | | Signed-off-by: Yehuda Katz <wycats@gmail.com>
| * Ruby 1.9 style String interpolation support for lower ruby versions. Thanks ↵Lawrence Pit2009-07-073-0/+150
| | | | | | | | | | | | to code from Masao Mutoh's GetText gem. [#2870 state:resolved] Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local>
| * Get Initializer tests running without requiring parts of Rails being loaded ↵Yehuda Katz + Carl Lerche2009-07-061-70/+72
| | | | | | | | first
* | Use active_support/mini since we just need inflections.José Valim2009-07-061-2/+2
| |
* | Merge branch 'master' of git://github.com/rails/railsJosé Valim2009-07-037-10/+68
|\|
| * Adds support for def self.setup in isolation tests for setup that should be ↵Yehuda Katz + Carl Lerche2009-07-022-2/+20
| | | | | | | | run only once in the parent
| * Fixed ActiveSupport::OrderedHash::[] work identically to ::Hash::[] in ruby ↵Brian Abreu2009-07-022-5/+42
| | | | | | | | | | | | 1.8.7 [#2832 state:resolved] Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
| * wycats forgot a +1, so I added it [#2749 state:resolved]Aaron Patterson2009-07-021-1/+1
| | | | | | | | Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
| * make #inspect if zero length duration return '0 seconds' instead of empty ↵Levin Alexander2009-07-022-2/+5
| | | | | | | | | | | | string [#2838 state:resolved] Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
* | Merge branch 'master' of git://github.com/rails/railsJosé Valim2009-07-0221-42/+337
|\|
| * Fixes bug where Memcached connections get corrupted when an invalid expire ↵Yehuda Katz + Carl Lerche2009-07-012-2/+30
| | | | | | | | is passed in [#2854 state:resolved]
| * JSON.escape returns UTF-8 stringsJeremy Kemper2009-07-012-7/+14
| | | | | | | | [#2849 state:resolved]
| * uses Hash#except/sliceJeremy Kemper2009-07-011-0/+2
| |
| * Forgot to commit the new file. This is slightly embarrassing.Yehuda Katz + Carl Lerche2009-07-011-0/+2
| |
| * Apparently stdlib isn't std enoughYehuda Katz + Carl Lerche2009-07-011-4/+6
| |
| * Modify isolation test to require a file not in use anywhere in RailsYehuda Katz + Carl Lerche2009-07-011-4/+4
| |
| * Merge branch 'master' of git@github.com:rails/railsJeremy Kemper2009-07-0118-35/+319
| |\