Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "Merge pull request #10034 from ↵ | Rafael Mendonça França | 2013-04-04 | 3 | -33/+1 |
| | | | | | | | | | benofsky/fix_skipping_object_callback_filters" This reverts commit c79c6980647eb76bfa52178711fb04ba7e9d403b, reversing changes made to ba4c27479add60b783a0e623c8a5d176c1dc9043. This broke all the tests. See https://travis-ci.org/rails/rails/builds/6061839 | ||||
* | Merge pull request #10034 from benofsky/fix_skipping_object_callback_filters | Rafael Mendonça França | 2013-04-04 | 3 | -1/+33 |
|\ | | | | | Fixes skipping object callback filters | ||||
| * | Fixes skipping object callback filters | Ben McRedmond | 2013-04-04 | 3 | -1/+33 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows you to skip callbacks that are defined by objects, e.g. for `ActionController`: skip_after_filter MySpecialFilter Previously this didn't work due to a bug in how Rails compared callbacks in `Callback#matches?`. When a callback is compiled, if it's an object filter (i.e. not a method, proc, etc.), `Callback` now defines a method on `@klass` that is derived from the class name rather than `@callback_id`. So, when `skip_callback` tries to find the appropriate callback to remove, `Callback` can regenerate the method name for the filter object and return the correct value for `Callback#matches?`. | ||||
* | | Further simplify enumerable group_by test | Carlos Antonio da Silva | 2013-04-04 | 1 | -3/+1 |
| | | |||||
* | | Replaced inject with map | Anupam Choudhury | 2013-04-04 | 1 | -2/+2 |
| | | |||||
* | | Removed unused comma after loop variable | Anupam Choudhury | 2013-04-04 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #10080 from vipulnsward/railties_warning_fix_v2 | Steve Klabnik | 2013-04-03 | 1 | -0/+1 |
|\ \ | | | | | | | add require to suppress warning; remove variable | ||||
| * | | add require to suppress warning; remove variable | Vipul A M | 2013-04-04 | 1 | -0/+1 |
| | | | |||||
* | | | Fixed Typo | Prathamesh Sonpatki | 2013-04-04 | 1 | -1/+1 |
| | | | |||||
* | | | Fix some railties test warnings | Vipul A M | 2013-04-03 | 1 | -3/+2 |
|/ / | |||||
* | | Rename DummyKeyGenerator -> LegacyKeyGenerator | Trevor Turk | 2013-04-02 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #10041 from vipulnsward/more_destructive_merge | Santiago Pastorino | 2013-04-02 | 2 | -2/+2 |
|\ \ | | | | | | | change merge to merge! in AS on new hashes | ||||
| * | | change merge to merge! in AS on new hashes | Vipul A M | 2013-04-02 | 2 | -2/+2 |
| |/ | |||||
* / | Added missing assert | Anupam Choudhury | 2013-04-02 | 6 | -25/+37 |
|/ | |||||
* | Merge pull request #9997 from vipulnsward/hash_destructive_merge | Carlos Antonio da Silva | 2013-03-30 | 2 | -2/+2 |
|\ | | | | | Change merge to merge! to avoid creating new objects | ||||
| * | change merge to merge! | Vipul A M | 2013-03-29 | 2 | -2/+2 |
| | | |||||
* | | Merge pull request #10007 from vipulnsward/fix_AS_typos | Carlos Antonio da Silva | 2013-03-30 | 3 | -14/+14 |
|\ \ | | | | | | | Fix some typos in AS | ||||
| * | | fix some typos in AS | Vipul A M | 2013-03-30 | 3 | -14/+14 |
| |/ | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-03-30 | 2 | -4/+4 |
|\ \ | |/ |/| | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/adapter_test.rb guides/source/testing.md [ci skip] | ||||
| * | Fix some typos | Akira Matsuda | 2013-03-25 | 1 | -1/+1 |
| | | |||||
| * | Using American English spellings over British style spellings | Prathamesh Sonpatki | 2013-03-21 | 1 | -3/+3 |
| | | |||||
* | | determine_constant_from_test_name does not swallow NoMethodErrors [Yves Senn] | Xavier Noria | 2013-03-28 | 2 | -0/+12 |
| | | |||||
* | | Merge pull request #9523 from ↵ | Rafael Mendonça França | 2013-03-27 | 4 | -2/+16 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | stopdropandrew/Instrumenter#instrument-yields-payload ActiveSupport::Notifications::Instrumenter#instrument should yield Conflicts: activesupport/CHANGELOG.md | ||||
| * | | ActiveSupport::Notifications::Instrumenter#instrument should yield | stopdropandrew | 2013-03-02 | 4 | -3/+16 |
| | | | | | | | | | | | | its payload the same way that ActiveSupport::Notifications does. Fix spelling in test name. | ||||
* | | | Fixed timezone mapping of Ulaanbaatar. | Zolzaya | 2013-03-27 | 1 | -1/+1 |
| | | | |||||
* | | | Bump TZInfo version to 0.3.37 based on version v2013b of the underlying tz data. | kennyj | 2013-03-26 | 1 | -1/+1 |
| | | | |||||
* | | | Updated docs due to removal of serializer accessor | Albert Lash | 2013-03-24 | 1 | -3/+3 |
| | | | |||||
* | | | Merge pull request #8501 from charliesome/version-to-s | Rafael Mendonça França | 2013-03-23 | 1 | -6/+7 |
|\ \ \ | | | | | | | | | Add #to_s method to VERSION modules | ||||
| * | | | Add version method to top level modules | Charlie Somerville | 2013-03-21 | 1 | -6/+7 |
| | | | | |||||
* | | | | Tidying up some require : removing useless sort and homogenizing with the ↵ | Intrepidd | 2013-03-20 | 1 | -2/+2 |
|/ / / | | | | | | | | | | rest of the code the wat the includes are done | ||||
* | | | remove unused payloads in blocks in caching instrumentation | Vipul A M | 2013-03-19 | 1 | -3/+3 |
| | | | |||||
* | | | Fix warning: mismatched indentatmmismatched indentations at 'end' with 'def' | kennyj | 2013-03-19 | 1 | -1/+1 |
| | | | |||||
* | | | Revert "instruct RDoc to only parse Ruby files under lib [Fixes #9779]" | Xavier Noria | 2013-03-18 | 1 | -1/+1 |
| | | | | | | | | | | | | This reverts commit c24528fbc94dea9946a563be3bed9559583bdc57. | ||||
* | | | instruct RDoc to only parse Ruby files under lib [Fixes #9779] | Xavier Noria | 2013-03-18 | 1 | -1/+1 |
| | | | |||||
* | | | Merge branch 'master-sec' | Aaron Patterson | 2013-03-18 | 5 | -2/+45 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master-sec: fix protocol checking in sanitization [CVE-2013-1857] JDOM XXE Protection [CVE-2013-1856] fix incorrect ^$ usage leading to XSS in sanitize_css [CVE-2013-1855] stop calling to_sym when building arel nodes [CVE-2013-1854] | ||||
| * | | | JDOM XXE Protection [CVE-2013-1856] | Ben Murphy | 2013-03-15 | 5 | -2/+45 |
| | | | | |||||
* | | | | Merge pull request #9774 from ↵ | Andrew White | 2013-03-18 | 3 | -0/+15 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | senny/9772_reraise_no_method_error_in_proper_context `TimeWithZone` raises `NoMethodError` in proper context. | ||||
| * | | | | `TimeWithZone` raises `NoMethodError` in proper context. | Yves Senn | 2013-03-18 | 3 | -0/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9772. `TimeWithZone` delegates everything to the wrapped `Time` object using `method_missing`. The result is that `NoMethodError` error will be raised in the context of `Time` which leads to a misleading debug output. | ||||
* | | | | | fix repeat of test; remove unused variable by use of each_key | Vipul A M | 2013-03-18 | 2 | -2/+2 |
|/ / / / | |||||
* | | | | Merge pull request #9757 from vipulnsward/remove_message_param | Carlos Antonio da Silva | 2013-03-17 | 1 | -1/+1 |
|\ \ \ \ | | | | | | | | | | | remove unused parameter passed to assert_query_equal method | ||||
| * | | | | remove unused parameter passed to assert_query_equal method | Vipul A M | 2013-03-17 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Merge pull request #9758 from vipulnsward/remove_from_rakefile | Carlos Antonio da Silva | 2013-03-17 | 1 | -2/+0 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove extra lines from Rakefile, which threw warning | ||||
| * | | | | | extra lines from Rakefile removed, which also threw warning | Vipul A M | 2013-03-17 | 1 | -2/+0 |
| |/ / / / | |||||
* / / / / | refactor test to drop unnecessary hash creation, test directly instead | Vipul A M | 2013-03-17 | 1 | -16/+10 |
|/ / / / | |||||
* | | | | Revert "Merge pull request #8156 from fredwu/acronym_fix-master" | Steve Klabnik | 2013-03-16 | 3 | -8/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 867dc1700f32aae6f98c4651bd501597e6b52bc0, reversing changes made to 9a421aaa8285cf2a7ecb1af370748b0337818930. This breaks anyone who's using ForceSSL: https://travis-ci.org/rails-api/rails-api/jobs/5556065 Please see comments on #8156 for some discussion. | ||||
* | | | | revises the CHANGELOG entry from 26aa265 [ci skip] | Xavier Noria | 2013-03-16 | 1 | -2/+3 |
| | | | | |||||
* | | | | Added Inflector#underscore fix to the changelog | Fred Wu | 2013-03-17 | 1 | -0/+4 |
| | | | | |||||
* | | | | Fixed a bug where the inflector would replace camelCase strings and ↵ | Fred Wu | 2013-03-17 | 2 | -1/+3 |
| | | | | | | | | | | | | | | | | disregarding specified acronyms, fixes #8015 | ||||
* | | | | Revert "make new rails apps log to STDOUT" | Steve Klabnik | 2013-03-15 | 2 | -19/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit b7d9d6e2cd5082d269dafbc0316e2107febe1451. Per discussion with @jeremy and @rubys on Campfire. | ||||
* | | | | make new rails apps log to STDOUT | Terence Lee | 2013-03-15 | 2 | -0/+19 |
| | | | |