Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #21631 from RobinClowers/fix-cache-instrumentation | Jeremy Daer | 2015-10-09 | 1 | -0/+28 |
|\ | | | | | | | Fix cache fetch instrumentation | ||||
| * | Add test cases for Cache#fetch instrumentation | Robin Clowers | 2015-09-14 | 1 | -0/+28 |
| | | |||||
* | | Merge pull request #20600 from ↵ | Andrew White | 2015-10-02 | 1 | -2/+2 |
|\ \ | | | | | | | | | | | | | mtsmfm/xmlschema-should-display-more-than-6-digits TimeWithZone#xmlschema should be able to display more than 6 digits | ||||
| * | | TimeWithZone#xmlschema should be able to display more than 6 digits | Fumiaki MATSUSHIMA | 2015-09-30 | 1 | -2/+2 |
| | | | |||||
* | | | Regex fix for mattr_accessor validation | Aliaksandr Buhayeu | 2015-10-01 | 1 | -0/+14 |
| | | | | | | | | | | | | | | | Change ^ and $ operators to \A and \z to prevent code injection after the line breaks | ||||
* | | | Refactor AS::Callbacks halt config and fix the documentation | Roque Pinel | 2015-10-01 | 1 | -2/+2 |
|/ / | | | | | | | | | | | | | | | | | Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false` to `AS::Callbacks.halt_and_display_warning_on_return_false` base on [this discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580) Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8 | ||||
* | | Merge pull request #21767 from ronakjangir47/missing_transform_values_test | Rafael Mendonça França | 2015-09-25 | 1 | -0/+12 |
|\ \ | | | | | | | Added missing tests for transform_values! which returns Enumerator | ||||
| * | | Added missing tests for transform_values! which returns Enumerator without ↵ | Ronak Jangir | 2015-09-26 | 1 | -0/+12 |
| | | | | | | | | | | | | blocks | ||||
* | | | Added missing tests for transform_keys! which returns Enumerator without block | Ronak Jangir | 2015-09-26 | 1 | -0/+12 |
|/ / | |||||
* | | Make `assert_difference` return the result of the yielded block. | Lucas Mazza | 2015-09-24 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With this we can perform new assertions on the returned value without having to cache it with an outer variable or wrapping all subsequent assertions inside the `assert_difference` block. Before: ``` post = nil assert_difference -> { Post.count }, 1 do Post.create end assert_predicate post, :persisted? ``` Now: ``` post = assert_difference -> { Post.count } do Post.create end assert_predicate post, :persisted? ``` | ||||
* | | Fix the AS::Callbacks terminator regression from 4.2.3 | Roque Pinel | 2015-09-22 | 1 | -12/+8 |
| | | | | | | | | | | | | Rails 4.2.3 AS::Callbacks will not halt chain if `false` is returned. That is the behavior of specific callbacks like AR::Callbacks and AM::Callbacks. | ||||
* | | :hocho: Typos | Akira Matsuda | 2015-09-21 | 1 | -1/+1 |
| | | |||||
* | | :scissors: empty line at the top of files | Akira Matsuda | 2015-09-21 | 5 | -5/+0 |
|/ | |||||
* | Merge pull request #21250 from ronakjangir47/safe_const | Yves Senn | 2015-09-07 | 1 | -0/+4 |
|\ | | | | | | | safe_constantize - Added Object scoped missing test cases | ||||
| * | safe_constantize - Added Object scoped missing test cases | Ronak Jangir | 2015-09-06 | 1 | -0/+2 |
|/ | |||||
* | ArrayInquirer to correctly find symbols or strings | Leigh Halliday | 2015-08-28 | 1 | -2/+7 |
| | | | | | | | | | The problem existed where if your ArrayInquirer values were strings but you checked them using any? with a symbol, it would not find the value. Now it will correctly check whether both the String form or the Symbol form are included in the Array. ` | ||||
* | - Extracted `DELIMITED_REGEX` to `delimited_regex` method and made use of ↵ | Vipul A M | 2015-08-28 | 1 | -0/+1 |
| | | | | | | | | | | user passed `options[:delimited_regex]` if available. Changed `DELIMITED_REGEX` to `DEFAULT)DELIMITED_REGEX` to signify what it means. - Added tests for number to delimited and number to currency in both actionview and activesupport. Changes Changes | ||||
* | Removed duplicate requiring minitest/mock as it is already required in ↵ | Ronak Jangir | 2015-08-26 | 1 | -2/+0 |
| | | | | method_call_assertions | ||||
* | Cleaned up generators tests using internal assertion helper | Ronak Jangir | 2015-08-20 | 1 | -0/+6 |
| | |||||
* | Replacing lambda with proc getting argument error because of it. | Ronak Jangir | 2015-08-17 | 1 | -0/+6 |
| | |||||
* | Merge pull request #21025 from ronakjangir47/asserts | Kasper Timm Hansen | 2015-08-13 | 1 | -0/+13 |
|\ | | | | | Added helper methods to stub any instance | ||||
| * | Added helper methods to stub any instance | Ronak Jangir | 2015-08-13 | 1 | -0/+13 |
| | | |||||
* | | Assert that the `:prefix` option of `number_to_human_size` is deprecated | Roque Pinel | 2015-08-12 | 1 | -8/+10 |
|/ | |||||
* | Deprecate :si prefix in number_to_human_size without replacement | Jean Boussier | 2015-08-10 | 1 | -9/+11 |
| | |||||
* | Only invoke the default block for mattr_accessor once so that it does not ↵ | Lachlan Sylvester | 2015-08-07 | 1 | -0/+6 |
| | | | | cause issues if it is not idempotent | ||||
* | Small tweaks to mainly lock-ordering tests. | thedarkone | 2015-07-22 | 1 | -21/+58 |
| | | | | | | * only test the upgrade path, * add test to verify non upgrades can’t preempt, * add reentrancy assertion. | ||||
* | Handle thread death during lock acquisition | Matthew Draper | 2015-07-21 | 1 | -0/+21 |
| | | | | | | Specifically, clean up if the thread is killed while it's blocked awaiting the lock... if we get killed on some other arbitrary line, the result remains quite undefined. | ||||
* | Adjust expectations around purpose/compatibility options | Matthew Draper | 2015-07-21 | 1 | -8/+35 |
| | |||||
* | Add some meta-assertions for the custom assertions | Matthew Draper | 2015-07-21 | 1 | -11/+63 |
| | | | | | | I accidentally discovered `assert_threads_not_stuck` couldn't fail, so the simplest solution was to prove they're all now working in both directions. | ||||
* | Order of execution is only guaranteed if upgrading | Matthew Draper | 2015-07-21 | 1 | -1/+3 |
| | | | | | If the thread isn't yet holding any form of lock, it has no claim over what may / may not run while it's blocked. | ||||
* | Tests for AS::Concurrency::ShareLock. | thedarkone | 2015-07-20 | 1 | -0/+194 |
| | |||||
* | Fix `TimeWithZone#eql?` to handle `TimeWithZone` created from `DateTime` | Roque Pinel | 2015-07-19 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | Before: ```ruby twz = DateTime.now.in_time_zone twz.eql?(twz.dup) => false ``` Now: ```ruby twz = DateTime.now.in_time_zone twz.eql?(twz.dup) => true ``` Please notice that this fix the `TimeWithZone` comparison to itself, not to `DateTime`. Based on #3725, `DateTime` should not be equal to `TimeWithZone`. | ||||
* | ActiveSupport::HashWithIndifferentAccess select and reject should return ↵ | Bernard Potocki | 2015-07-17 | 1 | -0/+10 |
| | | | | enumerator if called without block | ||||
* | Expand coverage of JSON gem tests | Godfrey Chan | 2015-07-11 | 1 | -16/+30 |
| | |||||
* | Expand the JSON test coverage for Struct and Hash (?!) | Godfrey Chan | 2015-07-11 | 1 | -1/+13 |
| | |||||
* | Add tests to ensure we don't interfere with json gem's output | Godfrey Chan | 2015-07-11 | 3 | -102/+160 |
| | |||||
* | Require yaml for XML mini isolation test. | Kasper Timm Hansen | 2015-07-11 | 1 | -0/+1 |
| | |||||
* | Require yaml for time_zone isolation test. | Kasper Timm Hansen | 2015-07-11 | 1 | -0/+1 |
| | | | | See 2f26f611 for more info. | ||||
* | Add multiple expected calls to assert_called_with. | Kasper Timm Hansen | 2015-07-10 | 1 | -0/+7 |
| | |||||
* | Require yaml for time_with_zone isolation test | Prem Sichanugrist | 2015-07-10 | 1 | -0/+1 |
| | | | | | Same fix as 109e71d2bb6d2305a091fe7ea96d4f6e9c7cd52d but after mocha got removed in 2f28e5b6417fd4e5d6060983b36262737558b613. | ||||
* | Reuse the same test for HWIA reverse_merge! | Rafael Mendonça França | 2015-07-10 | 1 | -3/+1 |
| | |||||
* | Merge pull request #20828 from Sirupsen/hash-indifferent-dup-default-proc | Rafael Mendonça França | 2015-07-10 | 2 | -11/+37 |
|\ | | | | | active_support/indifferent_access: fix not raising when default_proc does | ||||
| * | test/hash: move lonely indifferent hash test | Simon Eskildsen | 2015-07-10 | 2 | -11/+6 |
| | | |||||
| * | active_support/indifferent_hash: dont raise on to_hash when default_proc raises | Simon Eskildsen | 2015-07-10 | 1 | -0/+14 |
| | | |||||
| * | active_support/indifferent_hash: fix cloning default_proc on dup | Simon Eskildsen | 2015-07-10 | 1 | -0/+17 |
| | | |||||
* | | Removed use of mocha in active_support | Ronak Jangir | 2015-07-10 | 8 | -65/+87 |
| | | |||||
* | | Add method call assertions for internal use. | Kasper Timm Hansen | 2015-07-08 | 1 | -0/+91 |
|/ | | | | | Add `assert_called` and `assert_not_called` to boil down the boilerplate we need to write to assert methods are called certain number of times. | ||||
* | remove bad test. | Aaron Patterson | 2015-06-25 | 1 | -4/+0 |
| | |||||
* | Escape HTML entities in JSON keys | Rafael Mendonça França | 2015-06-16 | 1 | -0/+7 |
| | | | | Fixes CVE-2015-3226 | ||||
* | Merge pull request #20440 from repinel/fix-message-verifier-encoding-issue | Matthew Draper | 2015-06-16 | 1 | -0/+1 |
|\ | | | | | Fix the message verifier encoding issue |