Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | True, False, and Nil should be represented in as_json as themselves. | Erich Menge | 2012-05-29 | 1 | -0/+6 |
| | |||||
* | JRuby return different Array for module contents. | Arun Agrawal | 2012-05-29 | 1 | -1/+1 |
| | | | | | Test was failing against JRuby. It loads like [Constant3 Constant1] | ||||
* | Merge pull request #6525 from freerange/minitest-passthrough-exceptions | José Valim | 2012-05-29 | 1 | -8/+50 |
|\ | | | | | Exceptions like Interrupt & NoMemoryError should not be rescued in tests. | ||||
| * | Exceptions like Interrupt should not be rescued. | James Mead | 2012-05-28 | 1 | -8/+50 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Neither Test::Unit nor MiniTest rescue exceptions like Interrupt or NoMemoryError, but ActiveSupport::Testing::SetupAndTeardown#run which overrides MiniTest::Unit::TestCase#run rescues them. Rescuing an Interrupt exception is annoying, because it means when you are running a lot of tests e.g. when running one of the rake test tasks, you cannot break out using ctrl-C. Rescuing exceptions like NoMemoryError is foolish, because the most sensible thing to happen is for the process to terminate as soon as possible. This solution probably needs some finessing e.g. I'm not clear whether the assumption is that only MiniTest is supported. Also early versions of MiniTest did not have this behaviour. However, hopefully it's a start. Integrating with Test::Unit & MiniTest has always been a pain. It would be great if both of them provided sensible extension points for the kind of things that both Rails and Mocha want to do. | ||||
* | | decoupling activesupport performance testing from actionview and adding tests | Andrew Mutz | 2012-05-28 | 1 | -0/+40 |
|/ | |||||
* | Fix handling of negative zero in number_to_currency | Jared Beck | 2012-05-28 | 1 | -0/+2 |
| | |||||
* | Moving NumberHelpers from ActionView to ActiveSupport | Andrew Mutz | 2012-05-27 | 3 | -0/+639 |
| | |||||
* | Truncate now has the ability to receive a html option that allows it to call ↵ | Li Ellis Gallardo | 2012-05-26 | 1 | -0/+4 |
| | | | | | | | | | | | | rails helpers. This way if my text is long I don't have to do something like this: .text = truncate(@text, :length => 27) if @text.size >= 27 = link_to "continue", notes_path, ....."") | ||||
* | Fix Range#sum optimized version | Alexey Vakhov | 2012-05-25 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | | | At 1bd4d1c67459a91415ee73a8f55d2309c0d62a87 was added Range#sum optimized version for arithmetic progressions. This improvment injected a defect with not integer range boundaries. The defect was fixed by e0adfa82c05f9c975005f102b4bcaebfcd17d241. The second commit really disabled optimization at all because in Ruby integer-valued numbers are instances of Fixnum and Bignum classes. We should #use is_a? (#kind_of?) method instead #instance_of? to check if value is numerical: 1.class # => Fixnum 1.instance_of?(Integer) # => false 1.is_a?(Integer) # => true -100_000_000_000.class # => Bignum -100_000_000_000.instance_of?(Integer) # => false -100_000_000_000.is_a?(Integer) # => true Moreover original implementation of Range#sum has a defect with reverse range boundaries. If the first boundary is less than the second range is empty. Current commit fixes and tests this case too. | ||||
* | Add missing requires for deep_dup and hash ext test | Carlos Antonio da Silva | 2012-05-24 | 1 | -0/+1 |
| | |||||
* | Use deep_dup in the deep_transform_keys tests. | Rafael Mendonça França | 2012-05-24 | 1 | -20/+98 |
| | | | | | | | | Using only dup make some tests to not catch up an implementation error because the methods were changing the nested hashes. Related to: https://github.com/rails/rails/commit/541429fbe49b0671adb3842ab1818230d670ef9f#L1R96 | ||||
* | Add Hash#deep_transform_keys and Hash#deep_transform_keys! Also convert ↵ | Mark McSpadden | 2012-05-23 | 1 | -1/+16 |
| | | | | deep_*_keys to use deep_transform_keys. | ||||
* | Adding deep versions of stringify_keys and symbolize_keys (plain and bang) ↵ | Lucas Húngaro | 2012-05-23 | 1 | -0/+92 |
| | | | | for nested hashes | ||||
* | Add Hash#transform_keys and Hash#transform_keys! and refactor *_keys methods ↵ | Mark McSpadden | 2012-05-23 | 1 | -0/+15 |
| | | | | to use them. | ||||
* | changed xml type datetime to dateTime, fixes #6328 | Angelo capilleri | 2012-05-23 | 1 | -2/+2 |
| | | | | | | | | | XmlMini define the xml 'datatime', but according to http://www.w3.org/TR/xmlschema-2/#dateTime could be better change this to 'dateTime' with upper case letter 'T. So 'DateTime' and 'Time' are redefined from 'datetime' to 'dateTime' add the changing to the changelog | ||||
* | Merge pull request #5125 from winston/log_exception_when_cache_read_fails | Michael Koziarski | 2012-05-21 | 1 | -0/+9 |
|\ | | | | | #read_entry in ActiveSupport::Cache::FileStore should log details of the exception when an exception is thrown | ||||
| * | #read_entry in ActiveSupport::Cache::FileStore should log details of the ↵ | Winston | 2012-02-22 | 1 | -0/+9 |
| | | | | | | | | exception when an exception is thrown. | ||||
* | | Add instance_accessor option to class_attribute | Alexey Vakhov | 2012-05-22 | 1 | -0/+7 |
| | | |||||
* | | Don't use assert_block method. It will be deprecated. | kennyj | 2012-05-20 | 1 | -1/+1 |
| | | |||||
* | | Handle case where ancestor is not the end of the chain | Andrew White | 2012-05-19 | 1 | -0/+2 |
| | | |||||
* | | Fix constantize so top level constants are looked up properly. | Marc-Andre Lafortune | 2012-05-19 | 1 | -0/+18 |
| | | |||||
* | | Make constantize look down the ancestor chain (excluding Object) | Marc-Andre Lafortune | 2012-05-19 | 1 | -0/+17 |
| | | |||||
* | | Merge pull request #6376 from jgaskins/timestamp-microseconds | Jeremy Kemper | 2012-05-18 | 1 | -1/+3 |
|\ \ | | | | | | | Increase numeric-timestamp precision to nanoseconds | ||||
| * | | Increase `AR#cache_key` precision to nanoseconds | Jamie Gaskins | 2012-05-19 | 1 | -1/+3 |
| | | | |||||
* | | | Merge pull request #6183 from nashby/fix-issue-6179 | Jeremy Kemper | 2012-05-18 | 3 | -33/+49 |
|\ \ \ | | | | | | | | | wrap time ranges with timezones | ||||
| * | | | respect nsec in TimeWithZone | Vasiliy Ermolovich + Sergey Nartimov | 2012-05-18 | 3 | -35/+43 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when we pass fractional usec to Time methods we should use Rational instead of Float because of accuracy problem Time.local(2011,6,12,23,59,59,999999.999).nsec # => 999999998 Time.local(2011,6,12,23,59,59,Rational(999999999, 1000)).nsec # => 999999999 | ||||
| * | | | wrap time ranges with timezones, closes #6179 | Vasiliy Ermolovich | 2012-05-17 | 1 | -1/+9 |
| | | | | |||||
* | | | | Fix warning: possibly useless use of % in void context | kennyj | 2012-05-19 | 1 | -1/+1 |
| | | | | |||||
* | | | | doesn't modify params in SafeBuffer#% | Vasiliy Ermolovich | 2012-05-18 | 1 | -0/+7 |
| |/ / |/| | | |||||
* | | | Merge pull request #6361 from markmcspadden/issue_6265 | José Valim | 2012-05-17 | 1 | -2/+2 |
|\ \ \ | | | | | | | | | Remove special cases for duplicable? on Class and Module | ||||
| * | | | Remove special cases for duplicable? on Class and Module | Mark McSpadden | 2012-05-17 | 1 | -2/+2 |
| | | | | |||||
* | | | | Ensure blocks given to subscriber are properly yield | José Valim | 2012-05-17 | 1 | -1/+1 |
| | | | | |||||
* | | | | Fix an issue with inflection where my_analyses (in plular form) incorrectly ↵ | Anuj Dutta | 2012-05-16 | 1 | -0/+1 |
|/ / / | | | | | | | | | | converted to my_analyasis(in singular form). | ||||
* | | | fix safe string interpolation with SafeBuffer#%, closes #6352 | Vasiliy Ermolovich | 2012-05-16 | 1 | -0/+24 |
| | | | |||||
* | | | Merge pull request #5571 from jarkko/5559-fix-dst-jump-bug-on-master | Aaron Patterson | 2012-05-15 | 1 | -0/+18 |
|\ \ \ | | | | | | | | | [#5559] Do not black out the system timezone DST jump hour if Time.zone ... | ||||
| * | | | [#5559] Do not black out the system timezone DST jump hour if Time.zone ↵ | Jarkko Laine | 2012-03-24 | 1 | -0/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | differs from that. The system timezone DST jump hour should not be blacked out by Time.zone.parse if current Time.zone does not do the jump at that time. Fixes #5559. | ||||
* | | | | remove useless tests for Range#step | Vasiliy Ermolovich | 2012-05-13 | 1 | -10/+0 |
| | | | | |||||
* | | | | Remove blockless_step leave all that up to Ruby | Santiago Pastorino | 2012-05-13 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | Closes #6297 | ||||
* | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-12 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | Conflicts: activesupport/lib/active_support/callbacks.rb | ||||
| * | | | | Fix copypaste. [ci skip] | Edward Tsech | 2012-05-11 | 1 | -2/+2 |
| | | | | | |||||
* | | | | | Object#try can't call private methods | Vasiliy Ermolovich | 2012-05-12 | 1 | -1/+13 |
| | | | | | |||||
* | | | | | Remove useless load path modifications | Santiago Pastorino | 2012-05-11 | 2 | -5/+0 |
| | | | | | |||||
* | | | | | Test Hash#except can receive more than one argument. | Edward Tsech | 2012-05-11 | 1 | -0/+6 |
| | | | | | |||||
* | | | | | add unless_exist option to memory store | grosser | 2012-05-10 | 1 | -0/+7 |
| | | | | | |||||
* | | | | | AS::Callbacks#run_callbacks remove key argument | Francesco Rodriguez | 2012-05-10 | 2 | -4/+4 |
|/ / / / | |||||
* | | | | Merge pull request #6064 from gazay/fix_guides_for_as_core_ext | Xavier Noria | 2012-05-07 | 1 | -0/+12 |
|\ \ \ \ | |_|/ / |/| | | | Fix guides for as core ext | ||||
| * | | | Added tests for comparsion operator for Range | Alexey Gaziev | 2012-05-07 | 1 | -0/+12 |
| | | | | |||||
* | | | | Keep all methods in object/deep_dup | Piotr Sarnacki | 2012-05-06 | 1 | -2/+1 |
| | | | | |||||
* | | | | Nice logic for deep_dup in rails | Alexey Gaziev | 2012-05-06 | 2 | -15/+54 |
| | | | | |||||
* | | | | Merge pull request #6169 from marcandre/respond_to_missing | José Valim | 2012-05-05 | 3 | -0/+18 |
|\ \ \ \ | | | | | | | | | | | Respond to missing |