| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Also, added a test case to make sure that the default deprecation horizon is
always bigger than the current Rails version.
|
|\
| |
| | |
Fix cache fetch miss notification order
|
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes https://github.com/rails/rails/issues/22477.
When I improved the caching instrumentation in
edd33c08d98723ae9bb89cf7f019277117ed6414, I inadvertently changed the
order of AS notifications when there is a cache miss.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This test needs to have a require for the Listen gem or else it returns
an error when run by itself or with a certain order in the Active
Support tests. We use `silence_warnings` because Listen has some
warnings about private methods. It's already silenced when it's required
in Active Support EventedFileUpdateChecker.
```
1) Error:
EventedFileUpdateCheckerTest#test_should_not_execute_the_block_if_no_paths_are_given:
NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen
test/evented_file_update_checker_test.rb:21:in `teardown'
```
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The test was was in here twice so we were seeing this error:
```
activesupport/test/caching_test.rb:658:
warning: method redefined; discarding old test_local_cache_of_read_nil
activesupport/test/caching_test.rb:634:
warning: previous definition of test_local_cache_of_read_nil was here
```
|
| | |
|
| |
| |
| |
| | |
class and module variables that live per-thread
|
|\ \
| | |
| | | |
Add Logger option to disable message broadcasts
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When setting the Rails logger to log to STDOUT, it would broadcast the
log twice in development. This adds a setting that will prevent messages
from being broadcast to multiple logs, while still allowing calls to
`#close`, `#level=`, `#progname=`, and `#formatter=` to be broadcasted.
Fixes #14769, #11415
|
| | | |
|
|/ / |
|
| |
| |
| |
| | |
Better English.
|
|\ \
| | |
| | | |
Subscribing to notifications while inside the said instrumented section
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The issue is that on the exit from Instrumenter#instrument section,
an Evented listener will run into an error because its thread local
(Thread.current[:_timestack]) has not been set up by the #start
method (this obviously happens because the Evented listeners didn't
exist at the time, since no subscribtion to that section was made yet).
Note: support for subscribing to instrumented sections, while being
inside those instrumented sections, might be removed in the future.
Maybe fixes #21873.
|
|/ |
|
|
|
|
|
| |
The failure have returned, so disabling the tests again. (The upgrade is
fine to keep.)
|
|
|
|
|
|
|
|
|
|
| |
In listen 3.0.4 and below, the `#stop` method on the notification
backends are a no-op, meaning that we are leaking them per test. This
ended up triggering another bug in Ruby that causes our builds to fail
randomly on CI.
listen bug: https://github.com/guard/listen/issues/353
ruby bug: https://bugs.ruby-lang.org/issues/11744
|
|
|
|
|
|
| |
There is a known issue with the listen tests that casuses files to be
incorrectly GC'ed even when they are still in-use. The current is to
only run them in isolation to avoid randomly failing our test suite.
|
|
|
|
| |
Looking at the history of this file it seems this code was never actually used.
|
| |
|
|\
| |
| | |
send normalized keys to the cache backends so they do not need to man…
|
| |
| |
| |
| | |
this themselves
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before
./Users/Juan/dev/rails/activesupport/test/file_update_checker_shared_tests.rb:20: warning: instance variable @tmpdir not initialized
After
No warnings
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
"checker" is the name being used everywhere.
|
| |
| |
| |
| | |
This sucks, but otherwise I get occasional Fs on Mac OS X.
|
| |
| |
| |
| |
| | |
Mac OS X tries by all means to hide that /var is /private/var, and that is
what FSEvents reports back.
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
In particular files are no longer created in the current working directory,
but in a temporary folder.
|
| | |
|
| |
| |
| |
| | |
This commit also bases everything on Pathname internally.
|
| | |
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
| |
This is the implementation of the file update checker written
by Puneet Agarwal for GSoC 2015 (except for the tiny version
of the listen gem, which was 3.0.2 in the original patch).
Puneet's branch became too out of sync with upstream. This is
the final work in one single clean commit.
Credit goes in the first line using a convention understood
by the contrib app.
|
|\
| |
| | |
Parameterize with options to preserve the case of string
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Added test cases
Using kwargs instead of three seperate functions
Updated parameterize in transliterate.rb
Updated parameterize in transliterate.rb
Added deprecation warnings and updating RDoc+Guide
Misspelled separtor. Fixed.
Deprecated test cases and added support to parameterize with keyword parameters
Squashing commits.
Fixed test cases and added deprecated test cases
Small changes to Gemfile.lock and CHANGELOG
Update Gemfile.lock
|
|\ \
| | |
| | | |
do not override fetch on local cache
|
| |/
| |
| |
| |
| |
| | |
fetch is supposed to behave differently, this was a mistake merged in
https://github.com/rails/rails/pull/22194
|