aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test
Commit message (Collapse)AuthorAgeFilesLines
* Suppress warning ambiguous first argumentyui-knk2015-12-201-1/+1
| | | | | Suppress warning (warning: ambiguous first argument; put parentheses or a space even after `/' operator)
* Deprecation warning now targets at 5.1Akira Matsuda2015-12-191-1/+5
| | | | | Also, added a test case to make sure that the default deprecation horizon is always bigger than the current Rails version.
* Merge pull request #22479 from RobinClowers/fix-cache-notification-orderKasper Timm Hansen2015-12-191-12/+16
|\ | | | | Fix cache fetch miss notification order
| * Fix cache fetch miss notification orderRobin Clowers2015-12-021-12/+16
| | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/22477. When I improved the caching instrumentation in edd33c08d98723ae9bb89cf7f019277117ed6414, I inadvertently changed the order of AS notifications when there is a cache miss.
* | Fix test that fails in isolationeileencodes2015-12-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test needs to have a require for the Listen gem or else it returns an error when run by itself or with a certain order in the Active Support tests. We use `silence_warnings` because Listen has some warnings about private methods. It's already silenced when it's required in Active Support EventedFileUpdateChecker. ``` 1) Error: EventedFileUpdateCheckerTest#test_should_not_execute_the_block_if_no_paths_are_given: NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen test/evented_file_update_checker_test.rb:21:in `teardown' ```
* | Delete duplicate testeileencodes2015-12-181-8/+0
| | | | | | | | | | | | | | | | | | | | | | The test was was in here twice so we were seeing this error: ``` activesupport/test/caching_test.rb:658: warning: method redefined; discarding old test_local_cache_of_read_nil activesupport/test/caching_test.rb:634: warning: previous definition of test_local_cache_of_read_nil was here ```
* | Use separate test class nameDavid Heinemeier Hansson2015-12-171-1/+1
| |
* | Add thread_m/cattr_accessor/reader/writer suite of methods for declaring ↵David Heinemeier Hansson2015-12-171-0/+109
| | | | | | | | class and module variables that live per-thread
* | Merge pull request #22592 from nwjsmith/disable-logger-message-broadcastsEileen M. Uchitelle2015-12-161-18/+32
|\ \ | | | | | | Add Logger option to disable message broadcasts
| * | Add Logger option to disable message broadcastsNate Smith2015-12-161-18/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | When setting the Rails logger to log to STDOUT, it would broadcast the log twice in development. This adds a setting that will prevent messages from being broadcast to multiple logs, while still allowing calls to `#close`, `#level=`, `#progname=`, and `#formatter=` to be broadcasted. Fixes #14769, #11415
* | | Don't leak Object constants in core_ext/module/qualified_constGenadi Samokovarov2015-12-161-60/+70
| | |
* | | Deprecate passing string to define callback.yui-knk2015-12-161-4/+14
|/ /
* | renames AS::FileEventedUpdateChecker to AS::EventedFileUpdateCheckerXavier Noria2015-12-091-4/+4
| | | | | | | | Better English.
* | Merge pull request #22428 from thedarkone/subs-notifEileen M. Uchitelle2015-12-061-0/+15
|\ \ | | | | | | Subscribing to notifications while inside the said instrumented section
| * | Subscribing to notifications while inside the said instrumented section.thedarkone2015-11-281-0/+15
| |/ | | | | | | | | | | | | | | | | | | | | | | | | The issue is that on the exit from Instrumenter#instrument section, an Evented listener will run into an error because its thread local (Thread.current[:_timestack]) has not been set up by the #start method (this obviously happens because the Evented listeners didn't exist at the time, since no subscribtion to that section was made yet). Note: support for subscribing to instrumented sections, while being inside those instrumented sections, might be removed in the future. Maybe fixes #21873.
* / even if a write fails, store the raw valueMichael Grosser2015-11-291-0/+8
|/
* Partially revert 14b20ceGodfrey Chan2015-11-271-0/+5
| | | | | The failure have returned, so disabling the tests again. (The upgrade is fine to keep.)
* Upgrade to listen 3.0.5, re-enable testsGodfrey Chan2015-11-261-5/+0
| | | | | | | | | | In listen 3.0.4 and below, the `#stop` method on the notification backends are a no-op, meaning that we are leaking them per test. This ended up triggering another bug in Ruby that causes our builds to fail randomly on CI. listen bug: https://github.com/guard/listen/issues/353 ruby bug: https://bugs.ruby-lang.org/issues/11744
* Only run listen tests in isolation, for nowGodfrey Chan2015-11-261-0/+5
| | | | | | There is a known issue with the listen tests that casuses files to be incorrectly GC'ed even when they are still in-use. The current is to only run them in isolation to avoid randomly failing our test suite.
* Remove unused codeWill Jessop2015-11-241-4/+1
| | | | Looking at the history of this file it seems this code was never actually used.
* add deprecations for a smooth transition after #22215Michael Grosser2015-11-191-0/+27
|
* Merge pull request #22215 from grosser/grosser/normalize_keyRafael França2015-11-161-5/+5
|\ | | | | send normalized keys to the cache backends so they do not need to man…
| * send normalized keys to the cache backends so they do not need to manage ↵Michael Grosser2015-11-101-5/+5
| | | | | | | | this themselves
| * Add days_in_year methodJon Pascoe2015-11-101-0/+19
| |
* | Fix instance variable not defined warning from Active Support test suiteJuanitoFatas2015-11-121-1/+1
| | | | | | | | | | | | | | | | | | | | Before ./Users/Juan/dev/rails/activesupport/test/file_update_checker_shared_tests.rb:20: warning: instance variable @tmpdir not initialized After No warnings
* | revises the implementation of Pathname#ascendant_of? (in refinement)Xavier Noria2015-11-111-0/+29
| |
* | Add days_in_year methodJon Pascoe2015-11-111-0/+19
| |
* | modernizes the test definitions in the file monitors suiteXavier Noria2015-11-111-16/+17
| |
* | applies code style guidelinesXavier Noria2015-11-113-7/+7
| |
* | renames the module with shared tests for file monitorsXavier Noria2015-11-103-5/+5
| |
* | the evented monitor filters out descendantsXavier Noria2015-11-101-0/+30
| |
* | better tmp file management in the monitors suiteXavier Noria2015-11-101-36/+88
| |
* | adds another test case in the monitors suiteXavier Noria2015-11-101-1/+17
| |
* | editorial pass over test method namesXavier Noria2015-11-091-5/+5
| |
* | improves waiting in the file monitors suiteXavier Noria2015-11-093-23/+21
| |
* | adds more tests for the file monitorsXavier Noria2015-11-091-0/+60
| |
* | s/watcher/checker/gXavier Noria2015-11-081-3/+3
| | | | | | | | "checker" is the name being used everywhere.
* | more ad-hoc sleepsXavier Noria2015-11-081-2/+4
| | | | | | | | This sucks, but otherwise I get occasional Fs on Mac OS X.
* | create the tmpdir under testXavier Noria2015-11-081-1/+1
| | | | | | | | | | Mac OS X tries by all means to hide that /var is /private/var, and that is what FSEvents reports back.
* | encapsulate sleep margin when touching filesXavier Noria2015-11-081-5/+6
| |
* | renames the monitor creation helperXavier Noria2015-11-083-11/+11
| |
* | refactors the file monitors test suiteXavier Noria2015-11-083-57/+47
| | | | | | | | | | In particular files are no longer created in the current working directory, but in a temporary folder.
* | let listen stop all listeners on teardownXavier Noria2015-11-081-0/+5
| |
* | stop ascending at the longest common subpathXavier Noria2015-11-081-0/+60
| | | | | | | | This commit also bases everything on Pathname internally.
* | remove unused constants in the file monitor suitesXavier Noria2015-11-082-4/+0
| |
* | initial edit pass over the evented file checker patchXavier Noria2015-11-083-41/+67
| |
* | implements an evented file update checker [Puneet Agarwal]Xavier Noria2015-11-083-103/+135
|/ | | | | | | | | | | | This is the implementation of the file update checker written by Puneet Agarwal for GSoC 2015 (except for the tiny version of the listen gem, which was 3.0.2 in the original patch). Puneet's branch became too out of sync with upstream. This is the final work in one single clean commit. Credit goes in the first line using a convention understood by the contrib app.
* Merge pull request #21897 from swaathi/masterKasper Timm Hansen2015-11-073-4/+90
|\ | | | | Parameterize with options to preserve the case of string
| * Parameterize with options to preserve case of stringSwaathi K2015-11-073-4/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added test cases Using kwargs instead of three seperate functions Updated parameterize in transliterate.rb Updated parameterize in transliterate.rb Added deprecation warnings and updating RDoc+Guide Misspelled separtor. Fixed. Deprecated test cases and added support to parameterize with keyword parameters Squashing commits. Fixed test cases and added deprecated test cases Small changes to Gemfile.lock and CHANGELOG Update Gemfile.lock
* | Merge pull request #22197 from grosser/grosser/fetchKasper Timm Hansen2015-11-071-2/+9
|\ \ | | | | | | do not override fetch on local cache