aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #8830 from antoinelyset/masterXavier Noria2013-01-281-3/+4
|\ | | | | Improve String#squish whitespaces matching
| * Improve String#squish whitespaces matchingAntoine Lyset2013-01-221-3/+4
| |
* | Use Encoding::UTF_8 constant :do_not_litter:Akira Matsuda2013-01-281-2/+2
| |
* | Set Thread.abort_on_exception for the whole AS, AP, and AR testsAkira Matsuda + Koichi Sasada2013-01-241-0/+2
| | | | | | | | this would give us some more clues in case a test silently dies inside Thread
* | Fix some wrong String extensions testsAkira Matsuda2013-01-231-7/+9
| | | | | | | | | | | | * ASCII_STRING was not an ASCII String * BYTE_STRING was not an in valid UTF-8 String * added an assertion for non-UTF-8 String
* | Test String#dasherizeAkira Matsuda2013-01-231-0/+6
| |
* | Test that rescue_from accepts a class name in StringAkira Matsuda2013-01-231-2/+1
| |
* | Test Kernel#quietlyAkira Matsuda2013-01-231-0/+12
| |
* | Test try! with a blockAkira Matsuda2013-01-231-0/+4
| |
* | Test that DeprecatedConstantProxy does not warn when accessing its classAkira Matsuda2013-01-231-0/+1
| |
* | Missing AS::Deprecation::DeprecatedObjectProxy testAkira Matsuda2013-01-231-0/+5
| |
* | Test that a DateTime acts_like_dateAkira Matsuda2013-01-231-0/+4
|/
* Merge pull request #8671 from xuanxu/fix_irregularXavier Noria2013-01-211-0/+1
|\ | | | | Inflector irregular singularize rules
| * Inflector irregular singularize rulesJuanjo Bazán2013-01-011-0/+1
| |
* | Use `DateTime.parse` inside `String#to_datetime`Andrew White2013-01-211-0/+6
| | | | | | | | | | | | | | | | | | | | Use the standard library's `DateTime.parse` because it's marginally faster and supports partial date/time strings. Benchmark: user system total real old 3.980000 0.000000 3.980000 ( 3.987606) new 3.640000 0.010000 3.650000 ( 3.641342)
* | Standardise the return value of `to_time`Andrew White2013-01-215-17/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit standardises the return value of `to_time` to an instance of `Time` in the local system timezone, matching the Ruby core and standard library behavior. The default form for `String#to_time` has been changed from :utc to :local but research seems to suggest the latter is the more common form. Also fix an edge condition with `String#to_time` where the string has a timezone offset in it and the mode is :local. e.g: # Before: >> "2000-01-01 00:00:00 -0500".to_time(:local) => 2000-01-01 05:00:00 -0500 # After: >> "2000-01-01 00:00:00 -0500".to_time(:local) => 2000-01-01 00:00:00 -0500 Closes #2453
* | Fix failing test about date.order translation valuesCarlos Antonio da Silva2013-01-191-1/+1
| | | | | | | | Introduced in b718998f3e8e6f3d01ad138e40f08fbcc3736285.
* | Test to allow Range including DateTime and DateTime::Infinitygsphanikumar2013-01-141-0/+6
| | | | | | | | Closes #8587
* | extract PerformanceTest into rails-performance_tests gemYves Senn2013-01-101-68/+0
| |
* | adding start / finish on the instrumenter, adding tests for the classAaron Patterson2013-01-091-0/+50
| |
* | Merge pull request #8859 from tehgeekmeister/masterVijay Dev2013-01-091-2/+2
|\ \ | | | | | | Fix a typo in a test.
| * | s/messqage/message/ in message_encryptor_test.rbEzekiel Smithburg2013-01-091-2/+2
| | |
* | | CVE-2013-0156: Safe XML params parsing. Doesn't allow symbols or yaml.Jeremy Kemper2013-01-081-6/+22
| | |
* | | Revert "Merge branch 'master-sec'"Jeremy Kemper2013-01-081-22/+6
| | | | | | | | | | | | | | | This reverts commit 88cc1688d0cb828c17706b41a8bd27870f2a2beb, reversing changes made to f049016cd348627bf8db0d72382d7580bf802a79.
* | | CVE-2013-0156: Safe XML params parsing. Doesn't allow symbols or yaml.Jeremy Kemper2013-01-081-6/+22
|/ /
* | Namespace HashWithIndifferentAccessAkira Matsuda2013-01-071-1/+1
| |
* | Remove unnecessary begin..rescue..end, use only rescueAkira Matsuda2013-01-062-14/+10
| |
* | deprecate `assert_blank` and `assert_present`.Yves Senn2013-01-053-20/+29
| | | | | | | | | | They don't add any benefits over `assert object.blank?` and `assert object.present?`
* | Better error message for String#to_dateKelly Stannard2013-01-041-0/+1
| | | | | | | | | | | | | | | | | | | | I did this because to_date gives a very unhelpful error message if you do not pass in a correct date. In the process I think this cleans up the code nicely and even better it tends to be slightly faster than the current implementation. Benchmark https://gist.github.com/4440875
* | Remove assert_nothing_raisedRafael Mendonça França2013-01-036-67/+49
| |
* | Added ability to compare date/time with infinitybUg2013-01-046-0/+126
|/ | | | | | | | | | | | | | | | | Date, DateTime, Time and TimeWithZone can now be compared to infinity, so it's now possible to create ranges with one infinite bound and date/time object as another bound. Ex.: @range = Range.new(Date.today, Float::INFINITY) Also it's possible to check inclusion of date/time in range with conversion. Ex.: @range.include?(Time.now + 1.year) # => true @range.include?(DateTime.now + 1.year) # => true Ability to create date/time ranges with infinite bound is required for handling postgresql range types.
* Only call MiniTest.autorun if the dependecy is presentRafael Mendonça França2012-12-314-16/+12
|
* Alias refute methods to assert_not and perfer assert_not on testsRafael Mendonça França2012-12-312-3/+3
|
* Remove unneeded testsRafael Mendonça França2012-12-311-22/+0
| | | | These tests are needed only if we are using MiniTest::Spec
* Add active_support/testing/autorunRafael Mendonça França2012-12-312-2/+2
| | | | | minitest/autorun load minitest/spec polluting the global namespace with the DSL that we don't want on Rails
* Test that assert_not returns true. Use assert_raises instead of doing ↵Jeremy Kemper2012-12-281-17/+7
| | | | begin/rescue/else.
* Introduce assert_not to replace 'assert !foo'Jeremy Kemper2012-12-281-0/+21
|
* rewrite order dependent test case. #8185Yves Senn2012-12-271-1/+2
| | | | | | As reported (https://github.com/rails/rails/pull/8185#issuecomment-11702226) this test relied on the order a hash was serialized. Comparing the parsed hash makes the test no longer order dependent.
* Make test logs easier to read.Jeremy Kemper2012-12-261-2/+1
| | | | | | Tagging every message in tests makes the logs really wide. It's great for grepping, but annoying to open in an editor or a narrow terminal. Try out a different approach: spit out a heading before each test.
* deprecation warning when BufferedLogger is instantiatedYves Senn2012-12-251-0/+8
|
* ActiveSupport::BufferedLogger can be subclassedYves Senn2012-12-251-0/+14
|
* minor grammar fixZoltan Kiss2012-12-241-1/+1
|
* silences "possibly useless use of :: in void context" warningsXavier Noria2012-12-241-7/+3
| | | | | | | | | | | | | The AS utility silence_warnings does not really silence this one, because it is issued at parse-time. It seemed to in some places because the constant was the only expression in the block and therefore it was its return value, that could potentially be used by silence_warnings are return value of the yield call. To bypass the warning we assign to a variable. The chosen variable is "_" because it is special-cased in parse.c not to issue an "assigned but unused variable" warning in turn.
* Move background jobs to the 'jobs' branch until fully baked. Not shipping ↵Jeremy Kemper2012-12-213-283/+0
| | | | with Rails 4.0.
* Merge pull request #8471 from kytrinyx/refactor-xml-to-hashSteve Klabnik2012-12-211-1/+1
|\ | | | | WIP Refactor xml conversion to hash
| * Refactor Hash.from_xml.Steve Klabnik + Katrina Owen2012-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Three basic refactors in this PR: * We extracted the logic into a method object. We now don't define a tone of extraneous methods on Hash, even if they were private. * Extracted blocks of the case statement into methods that do the work. This makes the logic more clear. * Extracted complicated if clauses into their own query methods. They often have two or three terms, this makes it much easier to see what they _do_. We took care not to refactor too much as to not break anything, and put comments where we suspect tests are missing. We think ActiveSupport::XMLMini might be a good candidate to move to a plugin in the future.
* | Merge pull request #7376 from ↵Rafael Mendonça França2012-12-212-10/+62
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | dmitriy-kiriyenko/fix-double-callback-in-same-statement Prevent callback from being set twice. Conflicts: activesupport/CHANGELOG.md
| * | Prevent callback from being set twice.Dmitriy Kiriyenko2012-12-202-10/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you add one callack in two separate `set_callback` calls - it is only called once. When you do it in one `set_callback` call - it is called twice. This violates the principle of least astonishment for me. Duplicating callback is usually an error. There is a correct and obvious way to do anything without this "feature". If you want to do before_save :clear_balance, :calculate_tax, :clear_balance or whatever, you should better do before_save :carefully_calculate_tax def carefully_calculate_tax clear_balance calculate_tax clear_balance end And this even opens gates for some advanced refactorings, unlike the first approach. My assumptions are: - Principle of least astonishment is violated, when callbacks are either prevented from duplication, or not. - Duplicating callbacks is usually an error. When it is intentional - it's a smell of a bad design and can be approached without abusing this "feature". My suggestion is: do not allow duplicating callbacks in one callback call, like it is not allowed in separate callbacks call.
* | | Add ActiveSupport::Logger#silence that works the same as the old ↵David Heinemeier Hansson2012-12-211-0/+10
| | | | | | | | | | | | Logger#silence extension
* | | AS::BasicObject can be inherited fromPavel Pravosud2012-12-151-0/+12
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-23 14:58:39 +0000