aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test
Commit message (Collapse)AuthorAgeFilesLines
* Match HashWithIndifferentAccess#default's behaviour with Hash#defaultDavid Cornu2016-01-071-2/+2
|
* [close #22917] Don't output to `STDOUT` twiceschneems2016-01-061-2/+10
| | | | | | | | | | | | | | When `rails console` or `rails server` are used along with a logger set to output to `STDOUT` then the contents will show up twice. This happens because the logger is extended with `ActiveSupportLogger.broadcast` with a destination of STDOUT even if it is already outputting to `STDOUT`. Previously PR #22592 attempted to fix this issue, but it ended up causing NoMethodErrors. A better approach than relying on adding a method and flow control is to inspect the log destination directly. For this `ActiveSupport::Logger.logger_outputs_to?` was introduced ```ruby logger = Logger.new(STDOUT) ActiveSupport::Logger.logger_outputs_to?(logger, STDOUT) # => true ``` To accomplish this we must look inside of an instance variable of standard lib's Logger `@logdev`. There is a related Ruby proposal to expose this method in a standard way: https://bugs.ruby-lang.org/issues/11955
* Revert "Add Logger option to disable message broadcasts"schneems2016-01-051-32/+18
| | | | This reverts related commits due to #22917.
* Merge pull request #22856 from ↵Rafael França2016-01-011-1/+1
|\ | | | | | | | | rthbound/adds-exception-object-to-instrumenter-payload Adds exception object to instrumenter's payload
| * Adds exception object to instrumenter's payloadRyan T. Hosford2015-12-311-1/+1
| | | | | | | | | | | | | | - Adds new key/value pair to payload when an exception is raised e.g. `:exception_object=> #<RuntimeError: FAIL>` - Updates relevant test - Adds CHANGELOG entry
* | Merge pull request #12877 from aroben/extended-graphemesRafael França2015-12-313-3/+234
|\ \ | |/ |/| Support extended grapheme clusters and UAX 29
| * Beef up #grapheme_length testsAdam Roben2013-11-131-3/+29
| | | | | | | | We how have tests for every rule in UAX 29.
| * Support extended grapheme clusters and UAX 29Adam Roben2013-11-131-0/+76
| | | | | | | | | | | | | | | | | | | | | | | | http://www.unicode.org/reports/tr29/tr29-21.html is the version of UAX 29 that corresponds to Unicode 6.2.0. Unicode.unpack_graphemes now implements all the rules listed there, including the ones for extended grapheme clusters. I added a new optional test, test/multibyte_grapheme_break_conformance.rb, that is heavily based on test/multibyte_normalization_conformance.rb, which runs the Unicode test suite.
| * Rename multibyte_conformance.rb to multibyte_normalization_conformance.rbAdam Roben2013-11-131-2/+2
| | | | | | | | | | This test is only testing normalization behavior, not any other Unicode behaviors.
* | Fix - to_s(:db) on Numeric rangeAkshay Vishnoi2015-12-292-0/+26
| |
* | Merge pull request #22824 from maclover7/add-numericwithformat-testsYves Senn2015-12-291-0/+6
|\ \ | | | | | | Add test coverage for ActiveSupport::NumericWithFormat#to_formatted_s
| * | Add test coverage for ActiveSupport::NumericWithFormat#to_formatted_sJon Moss2015-12-281-0/+6
| | |
* | | Merge pull request #22759 from akshay-vishnoi/human-size-helperEileen M. Uchitelle2015-12-272-2/+26
|\ \ \ | | | | | | | | Add support for Petabyte and Exabyte in number to human size
| * | | Add support for Petabyte and Exabyte in number to human sizeAkshay Vishnoi2015-12-222-2/+26
| |/ /
* / / Fixes LoggerSilence#silence threadsafetyCarl P. Corliss2015-12-231-2/+83
|/ / | | | | | | | | | | | | - uses instance defined level if no custom local log level defined - Keeps track of local log level per [ thread + object-instance ] - prevents memory leakage by removing local level hash key/value on #silence method exit - avoids the use of Thread local variables
* | Suppress warning ambiguous first argumentyui-knk2015-12-201-1/+1
| | | | | | | | | | Suppress warning (warning: ambiguous first argument; put parentheses or a space even after `/' operator)
* | Deprecation warning now targets at 5.1Akira Matsuda2015-12-191-1/+5
| | | | | | | | | | Also, added a test case to make sure that the default deprecation horizon is always bigger than the current Rails version.
* | Merge pull request #22479 from RobinClowers/fix-cache-notification-orderKasper Timm Hansen2015-12-191-12/+16
|\ \ | | | | | | Fix cache fetch miss notification order
| * | Fix cache fetch miss notification orderRobin Clowers2015-12-021-12/+16
| | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/22477. When I improved the caching instrumentation in edd33c08d98723ae9bb89cf7f019277117ed6414, I inadvertently changed the order of AS notifications when there is a cache miss.
* | | Fix test that fails in isolationeileencodes2015-12-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test needs to have a require for the Listen gem or else it returns an error when run by itself or with a certain order in the Active Support tests. We use `silence_warnings` because Listen has some warnings about private methods. It's already silenced when it's required in Active Support EventedFileUpdateChecker. ``` 1) Error: EventedFileUpdateCheckerTest#test_should_not_execute_the_block_if_no_paths_are_given: NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen test/evented_file_update_checker_test.rb:21:in `teardown' ```
* | | Delete duplicate testeileencodes2015-12-181-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test was was in here twice so we were seeing this error: ``` activesupport/test/caching_test.rb:658: warning: method redefined; discarding old test_local_cache_of_read_nil activesupport/test/caching_test.rb:634: warning: previous definition of test_local_cache_of_read_nil was here ```
* | | Use separate test class nameDavid Heinemeier Hansson2015-12-171-1/+1
| | |
* | | Add thread_m/cattr_accessor/reader/writer suite of methods for declaring ↵David Heinemeier Hansson2015-12-171-0/+109
| | | | | | | | | | | | class and module variables that live per-thread
* | | Merge pull request #22592 from nwjsmith/disable-logger-message-broadcastsEileen M. Uchitelle2015-12-161-18/+32
|\ \ \ | | | | | | | | Add Logger option to disable message broadcasts
| * | | Add Logger option to disable message broadcastsNate Smith2015-12-161-18/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When setting the Rails logger to log to STDOUT, it would broadcast the log twice in development. This adds a setting that will prevent messages from being broadcast to multiple logs, while still allowing calls to `#close`, `#level=`, `#progname=`, and `#formatter=` to be broadcasted. Fixes #14769, #11415
* | | | Don't leak Object constants in core_ext/module/qualified_constGenadi Samokovarov2015-12-161-60/+70
| | | |
* | | | Deprecate passing string to define callback.yui-knk2015-12-161-4/+14
|/ / /
* | | renames AS::FileEventedUpdateChecker to AS::EventedFileUpdateCheckerXavier Noria2015-12-091-4/+4
| | | | | | | | | | | | Better English.
* | | Merge pull request #22428 from thedarkone/subs-notifEileen M. Uchitelle2015-12-061-0/+15
|\ \ \ | | | | | | | | Subscribing to notifications while inside the said instrumented section
| * | | Subscribing to notifications while inside the said instrumented section.thedarkone2015-11-281-0/+15
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue is that on the exit from Instrumenter#instrument section, an Evented listener will run into an error because its thread local (Thread.current[:_timestack]) has not been set up by the #start method (this obviously happens because the Evented listeners didn't exist at the time, since no subscribtion to that section was made yet). Note: support for subscribing to instrumented sections, while being inside those instrumented sections, might be removed in the future. Maybe fixes #21873.
* / / even if a write fails, store the raw valueMichael Grosser2015-11-291-0/+8
|/ /
* | Partially revert 14b20ceGodfrey Chan2015-11-271-0/+5
| | | | | | | | | | The failure have returned, so disabling the tests again. (The upgrade is fine to keep.)
* | Upgrade to listen 3.0.5, re-enable testsGodfrey Chan2015-11-261-5/+0
| | | | | | | | | | | | | | | | | | | | In listen 3.0.4 and below, the `#stop` method on the notification backends are a no-op, meaning that we are leaking them per test. This ended up triggering another bug in Ruby that causes our builds to fail randomly on CI. listen bug: https://github.com/guard/listen/issues/353 ruby bug: https://bugs.ruby-lang.org/issues/11744
* | Only run listen tests in isolation, for nowGodfrey Chan2015-11-261-0/+5
| | | | | | | | | | | | There is a known issue with the listen tests that casuses files to be incorrectly GC'ed even when they are still in-use. The current is to only run them in isolation to avoid randomly failing our test suite.
* | Remove unused codeWill Jessop2015-11-241-4/+1
| | | | | | | | Looking at the history of this file it seems this code was never actually used.
* | add deprecations for a smooth transition after #22215Michael Grosser2015-11-191-0/+27
| |
* | Merge pull request #22215 from grosser/grosser/normalize_keyRafael França2015-11-161-5/+5
|\ \ | | | | | | send normalized keys to the cache backends so they do not need to man…
| * | send normalized keys to the cache backends so they do not need to manage ↵Michael Grosser2015-11-101-5/+5
| | | | | | | | | | | | this themselves
| * | Add days_in_year methodJon Pascoe2015-11-101-0/+19
| | |
* | | Fix instance variable not defined warning from Active Support test suiteJuanitoFatas2015-11-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before ./Users/Juan/dev/rails/activesupport/test/file_update_checker_shared_tests.rb:20: warning: instance variable @tmpdir not initialized After No warnings
* | | revises the implementation of Pathname#ascendant_of? (in refinement)Xavier Noria2015-11-111-0/+29
| | |
* | | Add days_in_year methodJon Pascoe2015-11-111-0/+19
| | |
* | | modernizes the test definitions in the file monitors suiteXavier Noria2015-11-111-16/+17
| | |
* | | applies code style guidelinesXavier Noria2015-11-113-7/+7
| | |
* | | renames the module with shared tests for file monitorsXavier Noria2015-11-103-5/+5
| | |
* | | the evented monitor filters out descendantsXavier Noria2015-11-101-0/+30
| | |
* | | better tmp file management in the monitors suiteXavier Noria2015-11-101-36/+88
| | |
* | | adds another test case in the monitors suiteXavier Noria2015-11-101-1/+17
| | |
* | | editorial pass over test method namesXavier Noria2015-11-091-5/+5
| | |
* | | improves waiting in the file monitors suiteXavier Noria2015-11-093-23/+21
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 10:17:25 +0000