aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Add `Hash#map_values` to ActiveSupportSean Griffin2014-06-291-0/+49
| |_|/ |/| | | | | | | | | | | Didn't get a chance to convert existing code, I'll skim through the code base to make use of this later this afternoon.
* | | Make the apply_inflections method case-sensitiveRobin Dupret2014-06-261-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since d3071db1, the apply_inflections method check if the downcased version of a string is contained inside the "whitelist" of uncountable words. However, if the word is composed of capital letters, it won't be matched in the list while it should. We can't simply revert to the previous behavior as there is a performance concern (benchmarked over /usr/share/dict/words): Before d3071db1 135.610000 0.290000 135.900000 (137.807081) Since d3071db1 22.170000 0.020000 22.190000 ( 22.530005) With the patch 22.060000 0.020000 22.080000 ( 22.125771) Benchmarked with http://git.io/aFnWig This way, the solution is to put the down-case version of words inside the @uncountables array.
* | | Fix a bug where NameError#name returns a qualified name in stringYuki Nishijima2014-06-241-3/+3
| | | | | | | | | | | | | | | | | | | | | Ruby's original behaviour is that : * It only returns a const name, not a qualified aname * It returns a symbol, not a string
* | | Create with_env helper for tests.Zuhao Wan2014-06-221-14/+13
| | |
* | | Merge pull request #15856 from zuhao/refactor_activesupport_decoding_testYves Senn2014-06-221-11/+19
|\ \ \ | | | | | | | | Use with_parse_json_times helper in tests.
| * | | Use with_parse_json_times helper in tests.Zuhao Wan2014-06-221-11/+19
| | | |
* | | | Avoid hardcoded magic number in test teardown.Zuhao Wan2014-06-221-14/+19
|/ / /
* | | Add regression test for NameError#nameArthur Neves2014-06-201-1/+4
| | |
* | | Merge pull request #15799 from ↵Yves Senn2014-06-1810-122/+47
|\ \ \ | | | | | | | | | | | | | | | | zuhao/refactor_activesupport_time_zone_test_helpers Extract out with_env_tz helper method.
| * | | Extract out with_env_tz helper method.Zuhao Wan2014-06-1810-122/+47
| | | | | | | | | | | | | | | | | | | | It’s used at so many places that extracting it out into a helper file is worth doing.
* | | | Move test teardown into `ensure` block.Zuhao Wan2014-06-171-1/+2
|/ / /
* | | Merge pull request #15684 from aditya-kapoor/add-tests-for-assert-valid-keysRafael Mendonça França2014-06-161-0/+15
|\ \ \ | | | | | | | | Add test cases for Hash#asset_valid_keys
| * | | Add test cases for Hash#asset_valid_keysAditya Kapoor2014-06-141-0/+15
| | | |
* | | | remove unnecessary calling of `I18n.backend.store_translations(empty, {})`Kuldeep Aggarwal2014-06-152-13/+4
| | | | | | | | | | | | | | | | | | | | Clean up I18n stored translations after test continuation with #15714
* | | | Add missing test cases for #assert_no_differenceAkshay Vishnoi2014-06-131-1/+19
|/ / /
* | | Move test for blank.rb under objectAkshay Vishnoi2014-06-111-0/+0
| | |
* | | Merge pull request #15628 from akshay-vishnoi/test-casesYves Senn2014-06-111-0/+4
|\ \ \ | | | | | | | | Add test cases for #in? and #presence_in
| * | | Add test cases for #in? and #presence_inAkshay Vishnoi2014-06-111-0/+4
| |/ /
* / / fix error with long keys in ActiveSupport::Cache::FileStoreAdam Panzer2014-06-101-0/+5
|/ /
* | Fix bug that make HashWithIndifferentAccess work differently of HashRafael Mendonça França2014-06-091-0/+8
| | | | | | | | | | Before HashWithIndifferentAccess were doing deep_dup of the inner hashes when Hash doesn't do. Now both are behaving in the same way.
* | Add Missing Test Cases for the constantizeAditya Kapoor2014-06-071-0/+11
| |
* | Merge pull request #15421 from gchan/time_with_zone_precisionMatthew Draper2014-06-051-0/+15
|\ \ | | | | | | | | | Fixed `ActiveSupport::TimeWithZone#-` so precision is not unnecessarily lost
| * | Fixed `ActiveSupport::TimeWithZone#-` so precision is not unnecessarily lostGordon Chan2014-05-301-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When working with objects with a nanosecond component, the `-` method may unnecessarily cause loss of precision. `ActiveSupport::TimeWithZone#-` should return the same result as if we were using `Time#-`: Time.now.end_of_day - Time.now.beginning_of_day #=> 86399.999999999 Before: Time.zone.now.end_of_day.nsec #=> 999999999 Time.zone.now.end_of_day - Time.zone.now.beginning_of_day #=> 86400.0 After: Time.zone.now.end_of_day - Time.zone.now.beginning_of_day #=> 86399.999999999
* | | Merge pull request #15447 from akshay-vishnoi/test-casesRafael Mendonça França2014-06-031-0/+8
|\ \ \ | | | | | | | | Test `except!` in other cases too
| * | | Test `except!` in other cases tooAkshay Vishnoi2014-05-311-0/+8
| | | |
* | | | Fix AS::NumberHelper results with rationalsJuanjo Bazán2014-05-311-0/+2
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | :precision was incorrectly being applied to Rationals before: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.3" after: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.33"
* / / :scissors: removed deprecated `Numeric#ago` and friendsGodfrey Chan2014-05-301-43/+1
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | Replacements: 5.ago => 5.seconds.ago 5.until => 5.seconds.until 5.since => 5.seconds.since 5.from_now => 5.seconds.from_now The removed tests does not affect coverage – we have equivalent test cases in the tests for `AS::Duration`. See #12389 for the history and rationale behind this.
* | Merge pull request #12080 from ShayDavidson/fix_datetime_partial_datesMatthew Draper2014-05-281-0/+6
|\ \ | | | | | | | | | Added partial days support to `DateTime`'s `advance` method.
| * | Added partial days support to `DateTime`'s `advance` method.Shay Davidson2013-08-301-0/+6
| | | | | | | | | | | | | | | You can now add partial days (e.g. 2.5.days) to `DateTime` with the advance method. This was acheived by mimicing the `advance` implementation in `Time`.
* | | Merge pull request #15316 from akshay-vishnoi/test-casesYves Senn2014-05-261-7/+8
|\ \ \ | | | | | | | | | | | | Fix test cases for inflector.rb
| * | | Fix test cases for inflector.rbAkshay Vishnoi2014-05-251-7/+8
|/ / / | | | | | | | | | | | | | | | `yield` was missing in #with_dup, due to which 57 assertions were not running in real, and all tests were passing by default. Error was introduced in commit - 31ceb5e.
* | | Merge pull request #15276 from kuldeepaggarwal/fix-array-toRafael Mendonça França2014-05-231-0/+2
|\ \ \ | | | | | | | | Array#to now accept negative position also.
| * | | revert 96525d63Kuldeep Aggarwal2014-05-231-0/+2
| | | | | | | | | | | | | | | | `Array#to` is working for negative position
* | | | Merge pull request #15275 from kuldeepaggarwal/add-testRafael Mendonça França2014-05-231-0/+2
|\ \ \ \ | |/ / / |/| | | add test cases for negative position in Array#from
| * | | add test cases for negative position in Array#fromKuldeep Aggarwal2014-05-231-0/+2
| | | |
* | | | Remove warning remeving the method before redefiningRafael Mendonça França2014-05-231-0/+1
|/ / / | | | | | | | | | | | | | | | | | | We need to test if the same method defined more than once only register one subscriber for it. We can safelly remove because the method body is the same and Subscriber use method_added hook for register the subscriber.
* | | Merge pull request #10887 from sakuro/deep_transform_keys_in_nested_arraysRafael Mendonça França2014-05-201-0/+22
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Hash#deep_*_keys(!) recurse into nested arrays. Conflicts: activesupport/CHANGELOG.md
| * | | Hash#deep_*_keys(!) recurse into nested arrays.OZAWA Sakuro2013-06-081-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Following methods now recursively transform nested arrays, too. * Hash#deep_transform_keys * Hash#deep_transform_keys! * Hash#deep_stringify_keys * Hash#deep_stringify_keys! * Hash#deep_symbolize_keys * Hash#deep_symbolize_keys!
* | | | Fix confusing exception in ActiveSupport delegationVladimir Yarotsky2014-05-201-1/+1
| | | |
* | | | Merge pull request #15037 from ↵Rafael Mendonça França2014-05-161-6/+19
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | roccoblues/fix_duplicate_activesupport_subscribers Fixed duplicate subscribers in ActiveSupport::Subscriber Conflicts: activesupport/CHANGELOG.md
| * | | | Fixed duplicate subscribers in ActiveSupport::SubscriberDennis Schoen2014-05-091-6/+19
| | | | | | | | | | | | | | | | | | | | | | | | | ActiveSupport::Subscriber no longer creates multiple subscribers when you redefine a method.
* | | | | Merge pull request #15072 from mjtko/fix/issue-15064Rafael Mendonça França2014-05-131-0/+2
|\ \ \ \ \ | | | | | | | | | | | | [Fixes #15064] Calling number_to_delimited on a ActiveSupport::SafeBuffer results in mangled output
| * | | | | Require active_support/core_ext/string/output_safety and use html_safe ↵Mark J. Titorenko2014-05-121-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | rather than use non-public SafeBuffer API.
| * | | | | Use block parameter rather than `$1` during `gsub!` so ↵Mark J. Titorenko2014-05-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `ActiveSupport::SafeBuffer` values aren't mangled. Fixes #15064
* | | | | | Update require in `array_ext_test.rb`wendi2014-05-131-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | Removed `FIMXE` tag to require necessary file but not the whole core_ext
* | | | | | Update and add tests in array_ext_test.rbwendi2014-05-131-2/+30
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Fix `test_to_with_instruct` typo to `test_to_xml_with_instruct` - Rename `test_to_xml` to `test_to_xml_with_hash_elements` to make test name more specific. - Add `test_to_xml_with_non_hash_elements` and `test_to_xml_with_non_hash_different_type_elements` `to_xml` behaves different when containing elements are same and different types. - Add `test_to_xml_with_indent_set`
* | | | | Tidy up implementation of #15010Andrew White2014-05-111-4/+6
| | | | |
* | | | | Make TimeZone#parse behave more like Time#parse.Ulysse Carion2014-05-111-0/+7
|/ / / / | | | | | | | | | | | | | | | | Namely, if the mday is omitted but any other upper components are, then instead of supplying the mday from the current time, it defaults to 1.
* | | | Merge pull request #12746 from coreyward/masterRafael Mendonça França2014-05-071-4/+14
|\ \ \ \ | | | | | | | | | | | | | | | Fix Hash#deep_merge bug and improve documentation — resolves #12738
| * | | | Fix Hash#deep_merge bug and improve documentation — resolves #12738Corey Ward2013-12-091-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously merging into a hash with a falsy value would not result in the merge-block being called. The fix is simply to check for presence of the key in the hash. The documentation example for `deep_merge` now appropriately demonstrates what a deep merge does.