Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Extend documentation of `ActiveSupport::Notifications.subscribe` (#34721) | Bogdan | 2018-12-17 | 1 | -1/+1 |
| | | | | | | | | | | | * Extend documentation of `ActiveSupport::Notifications.subscribe` Add mention that a block with only one argument passed to the method will yield an event object. Related to #33451 * Emphasize that `SubscribeEventObjects` is a test class by adding suffix `Test` | ||||
* | Change the empty block style to have space inside of the block | Rafael Mendonça França | 2018-09-25 | 1 | -1/+1 |
| | |||||
* | Always subscribe to event objects via `AS::Notifications.subscribe` | Aaron Patterson | 2018-07-26 | 1 | -9/+16 |
| | | | | | | | We don't need to have a special subscribe method for objects. The regular `subscribe` method is more expensive than a specialized method, but `subscribe` should not be called frequently. If that turns out to be a hotspot, we can introduce a specialized method. :) | ||||
* | Subscribe to event objects via `subscribe` | Aaron Patterson | 2018-07-26 | 1 | -0/+12 |
| | |||||
* | Subscribe to event objects via `subscribe_event` | Aaron Patterson | 2018-07-26 | 1 | -0/+17 |
| | | | | | | Fanout notifier can send event objects to subscribers now. Also moved `end` lower in the `finish!` method to guarantee that CPU time is shorter than real time. | ||||
* | Replace `assert !` with `assert_not` | Daniel Colson | 2018-04-19 | 1 | -3/+3 |
| | | | | | This autocorrects the violations after adding a custom cop in 3305c78dcd. | ||||
* | Remove extra whitespace | Daniel Colson | 2018-01-25 | 1 | -2/+2 |
| | |||||
* | [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 1 | -0/+1 |
| | |||||
* | Use frozen-string-literal in ActiveSupport | Kir Shatrov | 2017-07-09 | 1 | -0/+1 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Privatize unneededly protected methods in Active Support tests | Akira Matsuda | 2016-12-24 | 1 | -1/+1 |
| | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -1/+1 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | modernizes hash syntax in activesupport | Xavier Noria | 2016-08-06 | 1 | -13/+13 |
| | |||||
* | applies new string literal convention in activesupport/test | Xavier Noria | 2016-08-06 | 1 | -14/+14 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Adds exception object to instrumenter's payload | Ryan T. Hosford | 2015-12-31 | 1 | -1/+1 |
| | | | | | | | - Adds new key/value pair to payload when an exception is raised e.g. `:exception_object=> #<RuntimeError: FAIL>` - Updates relevant test - Adds CHANGELOG entry | ||||
* | Subscribing to notifications while inside the said instrumented section. | thedarkone | 2015-11-28 | 1 | -0/+15 |
| | | | | | | | | | | | | | The issue is that on the exit from Instrumenter#instrument section, an Evented listener will run into an error because its thread local (Thread.current[:_timestack]) has not been set up by the #start method (this obviously happens because the Evented listeners didn't exist at the time, since no subscribtion to that section was made yet). Note: support for subscribing to instrumented sections, while being inside those instrumented sections, might be removed in the future. Maybe fixes #21873. | ||||
* | Bug fix: Evented notification subscribers can handle published events | Carl Lerche | 2013-05-17 | 1 | -0/+22 |
| | |||||
* | Fix Typo existant -> existent [ci skip] | Prathamesh Sonpatki | 2013-05-08 | 1 | -1/+1 |
| | |||||
* | ActiveSupport::Notifications::Instrumenter#instrument should yield | stopdropandrew | 2013-03-02 | 1 | -1/+1 |
| | | | | its payload the same way that ActiveSupport::Notifications does. Fix spelling in test name. | ||||
* | make events not use date and time to determine parent_of. fixes #5932 | タコ焼き仮面 | 2012-06-18 | 1 | -1/+3 |
| | |||||
* | implements AS::Notifications.subscribed, which provides subscriptions to ↵ | Xavier Noria | 2011-11-05 | 1 | -0/+20 |
| | | | | events while a block runs | ||||
* | Requiring delegate. | Arun Agrawal | 2011-08-16 | 1 | -0/+1 |
| | |||||
* | Replace references to ActiveSupport::SecureRandom with just SecureRandom, ↵ | Jon Leighton | 2011-05-23 | 1 | -1/+1 |
| | | | | and require 'securerandom' from the stdlib when active support is required. | ||||
* | just use an attr_accessor so we do not pay ||= on every notification call | Aaron Patterson | 2011-02-09 | 1 | -2/+7 |
| | |||||
* | Revert the previous three commits. | José Valim | 2010-07-25 | 1 | -9/+0 |
| | | | | | | * AS::Notifications#instrument should not measure anything, it is not its responsibility; * Adding another argument to AS::Notifications#instrument API needs to be properly discussed; | ||||
* | use a hash to collect optional statistics about the instrumentation | Aaron Patterson | 2010-07-25 | 1 | -0/+9 |
| | |||||
* | Get rid of instrumenter.elapsed. | José Valim | 2010-07-24 | 1 | -9/+0 |
| | |||||
* | Add a test for elapsed and require missing benchmark file. | José Valim | 2010-07-20 | 1 | -17/+13 |
| | |||||
* | Float comparison adjustment | Santiago Pastorino | 2010-07-18 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | We shouldn't rely on float comparison, delta added just in case float ↵ | Santiago Pastorino | 2010-07-12 | 1 | -3/+3 |
| | | | | representation of this values aren't equal | ||||
* | Event should be aware if yielded block failed or not. | José Valim | 2010-05-02 | 1 | -0/+2 |
| | |||||
* | Make notifications go off even when an error is raised, so that we capture ↵ | Justin George | 2010-05-02 | 1 | -2/+2 |
| | | | | | | | | | | | | | | the underlying performance data [#4505 state:resolved] This is important when trying to keep track of many layers of interrelated calls i.e.: ActiveRecord::Base.transaction do MyModel.find(1) #ActiveRecord::NotFound end # should capture the full time until the error propagation Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | allow unsubscribe by name or subscription [#4433 state:resolved] | David Chelimsky | 2010-04-24 | 1 | -0/+22 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Mark bang instrumentations as something that you shuold not be listening to. | José Valim | 2010-03-17 | 1 | -3/+3 |
| | |||||
* | Optimize AS::Notifications to remember which subscribers don't match and not ↵ | Carlhuda | 2010-03-01 | 1 | -2/+29 |
| | | | | run them. This will allow notifications that are only useful in dev or testing to run efficiently in production. | ||||
* | You can unsubscribe a subscriber | Carlhuda | 2010-03-01 | 1 | -1/+13 |
| | |||||
* | Rename Rails::Subscriber to Rails::LogSubscriber | Prem Sichanugrist | 2010-02-16 | 1 | -3/+3 |
| | |||||
* | Remove instrument! and require thread from AS::Notifications. | José Valim | 2010-02-04 | 1 | -17/+1 |
| | |||||
* | deOMGifying Railties, Active Support, and Action Pack | Mikel Lindsaar | 2010-01-31 | 1 | -3/+3 |
| | |||||
* | Default to sync instrumentation. | José Valim | 2010-01-21 | 1 | -17/+1 |
| | |||||
* | Add ActionDispatch::Notifications middleware. | José Valim | 2010-01-17 | 1 | -0/+16 |
| | |||||
* | Yield the payload notifications for further modification (like adding the ↵ | José Valim | 2010-01-15 | 1 | -2/+2 |
| | | | | result). | ||||
* | Add instrument! to notifications which adds the result to the payload. | José Valim | 2010-01-14 | 1 | -1/+11 |
| | |||||
* | Do not send notifications when instrumentation raise an error. | José Valim | 2010-01-13 | 1 | -7/+4 |
| | |||||
* | instrumenter should be accessible from ActiveSupport::Notifications. | José Valim | 2010-01-06 | 1 | -7/+10 |
| | |||||
* | Expose Instrumenter id in Notifications. | José Valim | 2010-01-04 | 1 | -0/+4 |
| | |||||
* | Remove ActionView inline logging to ActiveSupport::Notifications and create ↵ | José Valim | 2009-12-26 | 1 | -12/+10 |
| | | | | ActionController::Base#log_event, so everything can be logged within one listener. Also expose log_process_action as a hook for different modules to include their own information during the action processing. This allow ActiveRecord to hook and any other ORM. Finally, this commit changes 'Processing' and 'Rendering' in logs to 'Processed' and 'Rendered' because at the point it's logged, everying already happened. | ||||
* | Notifications: synchronous fanout queue pushes events to subscribers rather ↵ | Jeremy Kemper | 2009-11-29 | 1 | -0/+10 |
| | | | | than having them concurrently pull | ||||
* | Notifications: extract central Notifier, cordon off the internal Fanout ↵ | Jeremy Kemper | 2009-11-28 | 1 | -158/+112 |
| | | | | implementation, and segregate instrumentation concerns |