aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test/multibyte_chars_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-131-1/+0
| | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* Add test for normalizing non-unicode stringFumiaki MATSUSHIMA2018-11-151-0/+10
| | | | Closes #34062
* Use String#truncate_bytes inside Multibyte::Chars#limitFrancesco Rodríguez2018-10-201-18/+0
|
* Deprecate ActiveSupport::Multibyte::Chars.consumes?Francesco Rodríguez2018-10-151-3/+9
| | | | | | In favor of String#is_utf8?. I think this method was made for internal use only, and its usage was removed here: https://github.com/rails/rails/pull/8261/files#diff-ce956ebe93786930e40f18db1da5fd46L39.
* Deprecate Unicode#normalize and Chars#normalize (#34202)Francesco Rodríguez2018-10-121-16/+57
|
* Use native String#capitalizeFrancesco Rodríguez2018-10-121-1/+1
|
* Deprecate Unicode#downcase/upcase/swapcase.Francesco Rodríguez2018-10-121-0/+6
| | | | Use String methods directly instead.
* Enable `Performance/UnfreezeString` copyuuji.yaginuma2018-09-231-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Ruby 2.3 or later, `String#+@` is available and `+@` is faster than `dup`. ```ruby # frozen_string_literal: true require "bundler/inline" gemfile(true) do source "https://rubygems.org" gem "benchmark-ips" end Benchmark.ips do |x| x.report('+@') { +"" } x.report('dup') { "".dup } x.compare! end ``` ``` $ ruby -v benchmark.rb ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux] Warming up -------------------------------------- +@ 282.289k i/100ms dup 187.638k i/100ms Calculating ------------------------------------- +@ 6.775M (± 3.6%) i/s - 33.875M in 5.006253s dup 3.320M (± 2.2%) i/s - 16.700M in 5.032125s Comparison: +@: 6775299.3 i/s dup: 3320400.7 i/s - 2.04x slower ```
* Replace `assert !` with `assert_not`Daniel Colson2018-04-191-2/+2
| | | | | This autocorrects the violations after adding a custom cop in 3305c78dcd.
* Use assert_predicate and assert_not_predicateDaniel Colson2018-01-251-1/+1
|
* Use respond_to test helpersDaniel Colson2018-01-251-4/+4
|
* [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment`Koichi ITO2017-07-111-0/+1
|
* Use frozen-string-literal in ActiveSupportKir Shatrov2017-07-091-0/+1
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-021-0/+1
|\ | | | | | | Enforce frozen string in Rubocop
| * Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
| |
* | Make ActiveSupport frozen string literal friendly.Pat Allan2017-06-201-14/+14
|/ | | | | | | The ActiveSupport test suite only passes currently if it uses the latest unreleased commits for dalli, and a patch for Builder: https://github.com/tenderlove/builder/pull/6 Beyond that, all external dependencies (at least, to the extent they’re used by ActiveSupport) are happy, including Nokogiri as of 1.8.0.
* Add `Style/EmptyLinesAroundMethodBody` in `.rubocop.yml` and remove extra ↵Ryuta Kamizono2017-02-121-1/+0
| | | | empty lines
* Correct spellingBenjamin Fleischer2017-02-051-1/+1
| | | | | | | ``` go get -u github.com/client9/misspell/cmd/misspell misspell -w -error -source=text . ```
* "Use assert_nil if expecting nil. This will fail in minitest 6."Akira Matsuda2016-12-251-8/+8
|
* Add more rubocop rules about whitespacesRafael Mendonça França2016-10-291-6/+6
|
* improve error message when include assertions failMichael Grosser2016-09-161-5/+5
| | | | | | assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
* Add three new rubocop rulesRafael Mendonça França2016-08-161-2/+2
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-11/+11
|
* modernizes hash syntax in activesupportXavier Noria2016-08-061-2/+2
|
* applies new string literal convention in activesupport/testXavier Noria2016-08-061-183/+183
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Merge pull request #12877 from aroben/extended-graphemesRafael França2015-12-311-3/+29
|\ | | | | Support extended grapheme clusters and UAX 29
| * Beef up #grapheme_length testsAdam Roben2013-11-131-3/+29
| | | | | | | | We how have tests for every rule in UAX 29.
* | Update #20737 to address feedbackSean Griffin2015-10-201-0/+8
| | | | | | | | | | | | | | Given that this pull request affects a mutable value, we need to test for and document the affects on the receiver in this case. Additionally, this pull request was missing a CHANGELOG entry.
* | Fixed slice! behavior: return nil for out-of-bound parametersGourav Tiwari2015-10-201-0/+4
| |
* | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵Vipul A M2015-02-031-1/+0
| | | | | | | | onwards.
* | Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-291-1/+1
| |
* | "warning: assigned but unused variable"Akira Matsuda2014-08-191-1/+0
| |
* | Avoid mutating the constants in a test caseAkira Matsuda2014-08-161-3/+1
| |
* | Avoid polluting String class globally in a test caseAkira Matsuda2014-08-161-8/+13
| |
* | Unused ivar in a test suiteAkira Matsuda2014-08-161-1/+0
| |
* | Prefer assert_raise instead of flunk + rescue to test for exceptionsCarlos Antonio da Silva2013-12-191-3/+3
|/ | | | | | Change most tests to make use of assert_raise returning the raised exception rather than relying on a combination of flunk + rescue to check for exception types/messages.
* ensure original encoding doesnt changeFrancesco Rodriguez2012-12-011-0/+3
|
* Simplify String#mb_chars and stop proxying #classSteve Klabnik2012-11-281-1/+4
| | | | | | | | This behavior mattered under Ruby 1.8, but that doesn't matter now that we don't support it. In addition, we don't want to proxy the #class method. A test was added to prevent against regressions.
* Fix class_eval without __FILE__ and __LINE__.kennyj2012-07-181-1/+1
|
* Use respond_to_missing? for CharsMarc-Andre Lafortune2012-05-051-0/+9
|
* Added as_json method for multibyte stringsDmitriy Vorotilin2012-02-011-0/+3
|
* Implement Chars#swapcase.Norman Clarke2012-01-061-2/+13
|
* use AS::TestCase as the base classAaron Patterson2012-01-051-3/+3
|
* Use friendlier method nameNorman Clarke2012-01-051-1/+1
|
* Replace Unicode.u_unpack with String#codepointsNorman Clarke2012-01-051-11/+0
|
* Just use Ruby's String#[]=Norman Clarke2012-01-051-5/+0
|
* Merge branch 'refactor-multibyte-chars' of https://github.com/lest/rails ↵Norman Clarke2012-01-051-1/+1
|\ | | | | | | | | | | | | into multibyte Conflicts: activesupport/lib/active_support/multibyte/chars.rb
| * refactor AS::Multibyte::CharsSergey Nartimov2012-01-051-1/+1
| |
* | Make return value from bang methods match Ruby docsNorman Clarke2012-01-051-4/+10
| | | | | | | | | | The docs for the String class indicate that methods like `rstrip!` and others should return nil when they do not have an effect on the string.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 05:16:52 +0000