aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test/core_ext
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Added method `#eql?` to `ActiveSupport::Duration`, in addition to `#==`.Joost Lubach2013-08-071-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the following returns `false`, contrary to expectation: 1.minute.eql?(1.minute) Adding method `#eql?` will make this behave like expected. Method `#eql?` is just a bit stricter than `#==`, as it checks whether the argument is also a uration. Their parts may be different though. 1.minute.eql?(60.seconds) # => true 1.minute.eql?(60) # => false
* | | | As of Unicode 6.3, Mongolian Vowel Separator is not whitespaceMatthew Draper2014-09-151-3/+3
| | | | | | | | | | | | | | | | | | | | Ruby 2.2 knows this, and no longer matches it with [[:space:]], so it's not a good candidate for testing String#squish.
* | | | add implementation of respond_to? for ActiveSupport::Durationlsylvester2014-09-152-1/+10
| | | |
* | | | Time#change can now change nanoseconds (:nsec)Agis-2014-09-141-0/+7
| | | | | | | | | | | | | | | | Closes #16392.
* | | | Time#change throws exception with an out-of-range :usecAgis-2014-09-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/98b46bf5e201307cae56ee14bf41363a539779c5 did not properly handled out-of-range `:usec`s. Passing a `:usec` that's out of range now throws an `ArgumentError` as it should. Fixes #16759.
* | | | Methods are not duplicable.Peter Jaros2014-09-031-1/+1
| | | |
* | | | Bring back the test cases for `presence`Godfrey Chan2014-08-291-0/+5
| | | | | | | | | | | | | | | | This was removed by mistake in 5e51bdd
* | | | We tenderized the wrong method! Object#try already had the yield option, ↵David Heinemeier Hansson2014-08-292-10/+4
| | | | | | | | | | | | | | | | just needed some tenderloving instance_eval to fit the bill
* | | | Clarify the origin of this great addition to Rails :trollface: :trollface ↵David Heinemeier Hansson2014-08-291-1/+1
| | | | | | | | | | | | | | | | :trollface:
* | | | Use instance_eval on @tenderlove's suggestion :trollface:David Heinemeier Hansson2014-08-291-2/+2
| | | |
* | | | Added yield to Object#presenceDavid Heinemeier Hansson2014-08-291-0/+5
| |/ / |/| |
* | | Skip #eql? tests on Rubinius for AS::DurationRobin Dupret2014-08-241-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | Since Rubinius is relying on #instance_of? for its definition of #eql? (http://git.io/MtmbbA) but ActiveSupport::Duration should behave like is_a? it returns true with `Fixnum`. Thus, for the moment, the last assertion is failing so we have to skip this test.
* | | Follow-up to #16560Robin Dupret2014-08-241-5/+6
| | | | | | | | | | | | | | | | | | | | | For the sake of backward-compatibility, we need to make #instance_of? return true for Fixnum. On the other hand, the method should still give true for ActiveSupport::Duration itself which was not the case before.
* | | Define the Duration#instance_of? methodRobin Dupret2014-08-181-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Duration is extending from ProxyObject which extends itself from BasicObject, the Duration object doesn't respond to the #instance_of? method. Thus, the #method_missing hook get triggered, delegating the method to its `value` attribute. However, Rubinius' #eql? definition relies on #instance_of?, thus this will equal to true with a Fixnum (since its `value` attribute is a Fixnum) while it should not. The previous behavior was wrong anyway, no matter the implementation.
* | | Expectations firstAkira Matsuda2014-08-181-4/+4
| | |
* | | Fix DateTime comparison with DateTime::Infinity objectRafael Mendonça França2014-08-061-0/+1
| | | | | | | | | | | | Fixes #16406
* | | Rename tests tooRafael Mendonça França2014-08-011-2/+2
| | |
* | | Rename Object#self to Object#itself to have parity with matz sanctioned ↵David Heinemeier Hansson2014-08-011-1/+1
| | | | | | | | | | | | method name for Ruby 2.2
* | | Added Object#self which returns the object itselfDavid Heinemeier Hansson2014-08-011-0/+9
| | |
* | | Merge pull request #16356 from gchan/add-hwia-testsYves Senn2014-07-311-0/+12
|\ \ \ | | | | | | | | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is initialized with a block
| * | | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is ↵Gordon Chan2014-07-311-0/+12
| | | | | | | | | | | | | | | | initialized with a block
* | | | Raise a descriptive error if non-positive integer passed to in_groups_of.Xavier Shay2014-07-301-0/+6
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | This is more consistent than the current behaviour of raising a `ZeroDivisionError: divided by 0` error when 0 is given, which can be non-obvious especially if `in_groups_of` is part of a longer chain of methods. The negative case was ok - "ArgumentError: invalid slice size" - but this error is clearer still.
* | | Add missing test case for Array#to_sentence, collect all test cases for ↵Akshay Vishnoi2014-07-292-24/+16
| | | | | | | | | | | | Object#to_param at one place and avoid repitition
* | | Merge pull request #16334 from akshay-vishnoi/array-testsRafael Mendonça França2014-07-297-482/+495
|\ \ \ | | | | | | | | Move array test files under array
| * | | Move array test files under arrayAkshay Vishnoi2014-07-297-482/+495
| | | |
* | | | Added failing test case for #16131Godfrey Chan2014-07-291-0/+42
| | | |
* | | | Merge pull request #15629 from akshay-vishnoi/test-to_paramRafael Mendonça França2014-07-282-0/+22
|\ \ \ \ | |/ / / |/| | | Define Hash#to_query and set Hash#to_param as alias to it; with test cases
| * | | Move to_param to to_query, also Improve testsAkshay Vishnoi2014-06-202-0/+22
| | | |
* | | | Move object test files under objectAkshay Vishnoi2014-07-293-65/+65
| | | |
* | | | Make HWIA copy the default proc too.Arthur Neves2014-07-241-0/+11
| | | | | | | | | | | | | | | | [fixes #16279]
* | | | Merge pull request #16232 from egilburg/activesupport_coverageRafael Mendonça França2014-07-218-4/+45
|\ \ \ \ | | | | | | | | | | Added some missing activesupport test coverage
| * | | | missing activesupport test coverageEugene Gilburg2014-07-198-4/+45
| | | | |
* | | | | Remove not-required file class/subclassesAkshay Vishnoi2014-07-211-1/+0
|/ / / /
* | | | Fix typos in string_ext_test.rb [ci skip]Jon Atack2014-07-161-4/+4
| | | |
* | | | Merge pull request #16190 from oss92/word_truncationMatthew Draper2014-07-171-0/+21
|\ \ \ \ | | | | | | | | | | | | | | | Word truncation
| * | | | Added truncate_words method to activesupport stringsroot2014-07-161-0/+20
|/ / / /
* | | | Move uuid_v5 and uuid_v3 to Digest::UUIDRafael Mendonça França2014-07-152-28/+24
| | | | | | | | | | | | | | | | | | | | These methods are not random so they should not belings to SecureRandom module.
* | | | Keep quietly and capture undeprecated on your suiteRafael Mendonça França2014-07-151-19/+17
| | | |
* | | | Fix tests broken in https://github.com/rails/rails/pull/16149Erik Michaels-Ober2014-07-121-1/+1
| | | |
* | | | Return an Enumerator if no block is givenErik Michaels-Ober2014-07-122-0/+44
| | | |
* | | | `DateTime#to_f` now preserves fractional seconds.John Paul Ashenfelter2014-07-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously this method always returns `.0` in the fractional part. This commit changes it to preserve the fractional seconds instead. Fixes #15994.
* | | | Add `Hash#map_values` to ActiveSupportSean Griffin2014-06-291-0/+49
| | | | | | | | | | | | | | | | | | | | Didn't get a chance to convert existing code, I'll skim through the code base to make use of this later this afternoon.
* | | | Merge pull request #15799 from ↵Yves Senn2014-06-187-107/+25
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | zuhao/refactor_activesupport_time_zone_test_helpers Extract out with_env_tz helper method.
| * | | | Extract out with_env_tz helper method.Zuhao Wan2014-06-187-107/+25
| | | | | | | | | | | | | | | | | | | | | | | | | It’s used at so many places that extracting it out into a helper file is worth doing.
* | | | | Move test teardown into `ensure` block.Zuhao Wan2014-06-171-1/+2
|/ / / /
* | | | Add test cases for Hash#asset_valid_keysAditya Kapoor2014-06-141-0/+15
| | | |
* | | | Move test for blank.rb under objectAkshay Vishnoi2014-06-111-0/+0
| | | |
* | | | Add test cases for #in? and #presence_inAkshay Vishnoi2014-06-111-0/+4
|/ / /
* | | Fix bug that make HashWithIndifferentAccess work differently of HashRafael Mendonça França2014-06-091-0/+8
| | | | | | | | | | | | | | | Before HashWithIndifferentAccess were doing deep_dup of the inner hashes when Hash doesn't do. Now both are behaving in the same way.
* | | Merge pull request #15421 from gchan/time_with_zone_precisionMatthew Draper2014-06-051-0/+15
|\ \ \ | | | | | | | | | | | | Fixed `ActiveSupport::TimeWithZone#-` so precision is not unnecessarily lost