Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 4 | -11/+7 |
| | |||||
* | Merge pull request #17493 from petewest/duration-comparable | Aaron Patterson | 2014-11-07 | 1 | -0/+12 |
|\ | | | | | Delegate comparison operator to value | ||||
| * | Delegate comparison operator to value | Peter West | 2014-11-03 | 1 | -0/+12 |
| | | |||||
* | | Fix grouped expression warning - `warning: (...) interpreted as grouped ↵ | Vipul A M | 2014-11-06 | 1 | -2/+2 |
| | | | | | | | | expression` | ||||
* | | added example of squish!, remove, test case for multiple occurrence of | Rishi Jain | 2014-11-06 | 1 | -0/+6 |
| | | | | | | | | | | | | | | | | pattern removal added example for string#remove and test case for remove of multiple occurence of pattern removed extra whitespaces | ||||
* | | tests, add note about the usage of a specific timezone. Closes #17448. | Yves Senn | 2014-11-05 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #17515 from prathamesh-sonpatki/rm-require | Yves Senn | 2014-11-05 | 1 | -1/+0 |
|\ \ | | | | | | | Removed the unused require of proxy_object | ||||
| * | | Removed the unused require of proxy_object and test related to it | Prathamesh Sonpatki | 2014-11-05 | 1 | -1/+0 |
| |/ | | | | | | | | | - Reference : https://github.com/rails/rails/pull/17493#issuecomment-61739359 - Duration stopped inheriting from ProxyObject in https://github.com/rails/rails/pull/16574 | ||||
* / | Fix broken string_ext_test due to change in timezone | Prathamesh Sonpatki | 2014-11-05 | 1 | -1/+1 |
|/ | | | | | - Russian time was changed to UTC+3 from UTC+4 recently. This broke the string_to_ext test. | ||||
* | Merge pull request #17383 from rwz/string-remove | Rafael Mendonça França | 2014-11-03 | 1 | -2/+12 |
|\ | | | | | | | | | | | | | Make `String#remove` and `String#remove!` accept multiple arguments Conflicts: activesupport/CHANGELOG.md | ||||
| * | Make `String#remove` and `String#remove!` accept multiple arguments | Pavel Pravosud | 2014-10-25 | 1 | -2/+12 |
| | | |||||
* | | Optimize TimeWithZoneTest#strftime | Pablo Herrero | 2014-10-27 | 1 | -0/+5 |
|/ | |||||
* | Bring try! into parity with try. | Ari Pollak | 2014-10-22 | 1 | -4/+8 |
| | | | | Based on commit 5e51bdda. | ||||
* | define hash on duration | lsylvester | 2014-10-03 | 1 | -0/+4 |
| | |||||
* | Fix another false assertions | Yuki Nishijima | 2014-09-21 | 1 | -2/+2 |
| | | | | | | | | | | | | * The assertions in AS::Duration don't actually assert. * The assertion in Railtie will pass even when `eager_load_namespaces` doesn't include `AppTemplate::Application` if `Rails.application` is truthy. For more details, see here: * https://github.com/rails/rails/pull/16998 * https://github.com/rails/rails/pull/17000 | ||||
* | Delegation works with reserved words passed to `:to` | Agis- | 2014-09-19 | 1 | -0/+11 |
| | | | | Fixes #16956. | ||||
* | Merge pull request #11794 from yoazt/duration-eql | Rafael Mendonça França | 2014-09-17 | 1 | -0/+4 |
|\ | | | | | | | | | | | | | | | | | Added method `#eql?` to `ActiveSupport::Duration`, in addition to `#==`. Conflicts: activesupport/CHANGELOG.md activesupport/lib/active_support/duration.rb activesupport/test/core_ext/duration_test.rb | ||||
| * | Added method `#eql?` to `ActiveSupport::Duration`, in addition to `#==`. | Joost Lubach | 2013-08-07 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the following returns `false`, contrary to expectation: 1.minute.eql?(1.minute) Adding method `#eql?` will make this behave like expected. Method `#eql?` is just a bit stricter than `#==`, as it checks whether the argument is also a uration. Their parts may be different though. 1.minute.eql?(60.seconds) # => true 1.minute.eql?(60) # => false | ||||
* | | As of Unicode 6.3, Mongolian Vowel Separator is not whitespace | Matthew Draper | 2014-09-15 | 1 | -3/+3 |
| | | | | | | | | | | Ruby 2.2 knows this, and no longer matches it with [[:space:]], so it's not a good candidate for testing String#squish. | ||||
* | | add implementation of respond_to? for ActiveSupport::Duration | lsylvester | 2014-09-15 | 2 | -1/+10 |
| | | |||||
* | | Time#change can now change nanoseconds (:nsec) | Agis- | 2014-09-14 | 1 | -0/+7 |
| | | | | | | | | Closes #16392. | ||||
* | | Time#change throws exception with an out-of-range :usec | Agis- | 2014-09-04 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/98b46bf5e201307cae56ee14bf41363a539779c5 did not properly handled out-of-range `:usec`s. Passing a `:usec` that's out of range now throws an `ArgumentError` as it should. Fixes #16759. | ||||
* | | Methods are not duplicable. | Peter Jaros | 2014-09-03 | 1 | -1/+1 |
| | | |||||
* | | Bring back the test cases for `presence` | Godfrey Chan | 2014-08-29 | 1 | -0/+5 |
| | | | | | | | | This was removed by mistake in 5e51bdd | ||||
* | | We tenderized the wrong method! Object#try already had the yield option, ↵ | David Heinemeier Hansson | 2014-08-29 | 2 | -10/+4 |
| | | | | | | | | just needed some tenderloving instance_eval to fit the bill | ||||
* | | Clarify the origin of this great addition to Rails :trollface: :trollface ↵ | David Heinemeier Hansson | 2014-08-29 | 1 | -1/+1 |
| | | | | | | | | :trollface: | ||||
* | | Use instance_eval on @tenderlove's suggestion :trollface: | David Heinemeier Hansson | 2014-08-29 | 1 | -2/+2 |
| | | |||||
* | | Added yield to Object#presence | David Heinemeier Hansson | 2014-08-29 | 1 | -0/+5 |
| | | |||||
* | | Skip #eql? tests on Rubinius for AS::Duration | Robin Dupret | 2014-08-24 | 1 | -0/+3 |
| | | | | | | | | | | | | | | | | | | Since Rubinius is relying on #instance_of? for its definition of #eql? (http://git.io/MtmbbA) but ActiveSupport::Duration should behave like is_a? it returns true with `Fixnum`. Thus, for the moment, the last assertion is failing so we have to skip this test. | ||||
* | | Follow-up to #16560 | Robin Dupret | 2014-08-24 | 1 | -5/+6 |
| | | | | | | | | | | | | | | For the sake of backward-compatibility, we need to make #instance_of? return true for Fixnum. On the other hand, the method should still give true for ActiveSupport::Duration itself which was not the case before. | ||||
* | | Define the Duration#instance_of? method | Robin Dupret | 2014-08-18 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | Since Duration is extending from ProxyObject which extends itself from BasicObject, the Duration object doesn't respond to the #instance_of? method. Thus, the #method_missing hook get triggered, delegating the method to its `value` attribute. However, Rubinius' #eql? definition relies on #instance_of?, thus this will equal to true with a Fixnum (since its `value` attribute is a Fixnum) while it should not. The previous behavior was wrong anyway, no matter the implementation. | ||||
* | | Expectations first | Akira Matsuda | 2014-08-18 | 1 | -4/+4 |
| | | |||||
* | | Fix DateTime comparison with DateTime::Infinity object | Rafael Mendonça França | 2014-08-06 | 1 | -0/+1 |
| | | | | | | | | Fixes #16406 | ||||
* | | Rename tests too | Rafael Mendonça França | 2014-08-01 | 1 | -2/+2 |
| | | |||||
* | | Rename Object#self to Object#itself to have parity with matz sanctioned ↵ | David Heinemeier Hansson | 2014-08-01 | 1 | -1/+1 |
| | | | | | | | | method name for Ruby 2.2 | ||||
* | | Added Object#self which returns the object itself | David Heinemeier Hansson | 2014-08-01 | 1 | -0/+9 |
| | | |||||
* | | Merge pull request #16356 from gchan/add-hwia-tests | Yves Senn | 2014-07-31 | 1 | -0/+12 |
|\ \ | | | | | | | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is initialized with a block | ||||
| * | | Add tests to ensure default proc is used when `HashWithIndifferentAccess' is ↵ | Gordon Chan | 2014-07-31 | 1 | -0/+12 |
| | | | | | | | | | | | | initialized with a block | ||||
* | | | Raise a descriptive error if non-positive integer passed to in_groups_of. | Xavier Shay | 2014-07-30 | 1 | -0/+6 |
|/ / | | | | | | | | | | | | | | | | | | | This is more consistent than the current behaviour of raising a `ZeroDivisionError: divided by 0` error when 0 is given, which can be non-obvious especially if `in_groups_of` is part of a longer chain of methods. The negative case was ok - "ArgumentError: invalid slice size" - but this error is clearer still. | ||||
* | | Add missing test case for Array#to_sentence, collect all test cases for ↵ | Akshay Vishnoi | 2014-07-29 | 2 | -24/+16 |
| | | | | | | | | Object#to_param at one place and avoid repitition | ||||
* | | Merge pull request #16334 from akshay-vishnoi/array-tests | Rafael Mendonça França | 2014-07-29 | 7 | -482/+495 |
|\ \ | | | | | | | Move array test files under array | ||||
| * | | Move array test files under array | Akshay Vishnoi | 2014-07-29 | 7 | -482/+495 |
| | | | |||||
* | | | Added failing test case for #16131 | Godfrey Chan | 2014-07-29 | 1 | -0/+42 |
| | | | |||||
* | | | Merge pull request #15629 from akshay-vishnoi/test-to_param | Rafael Mendonça França | 2014-07-28 | 2 | -0/+22 |
|\ \ \ | |/ / |/| | | Define Hash#to_query and set Hash#to_param as alias to it; with test cases | ||||
| * | | Move to_param to to_query, also Improve tests | Akshay Vishnoi | 2014-06-20 | 2 | -0/+22 |
| | | | |||||
* | | | Move object test files under object | Akshay Vishnoi | 2014-07-29 | 3 | -65/+65 |
| | | | |||||
* | | | Make HWIA copy the default proc too. | Arthur Neves | 2014-07-24 | 1 | -0/+11 |
| | | | | | | | | | | | | [fixes #16279] | ||||
* | | | Merge pull request #16232 from egilburg/activesupport_coverage | Rafael Mendonça França | 2014-07-21 | 8 | -4/+45 |
|\ \ \ | | | | | | | | | Added some missing activesupport test coverage | ||||
| * | | | missing activesupport test coverage | Eugene Gilburg | 2014-07-19 | 8 | -4/+45 |
| | | | | |||||
* | | | | Remove not-required file class/subclasses | Akshay Vishnoi | 2014-07-21 | 1 | -1/+0 |
|/ / / |